Re: [PATCH] Added warning about redefinition of listen socket protocol options

2023-01-12 Thread Maxim Dounin
Hello! On Sat, Dec 31, 2022 at 05:35:59PM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1672497248 -10800 > # Sat Dec 31 17:34:08 2022 +0300 > # Node ID c215d5cf25732ece1819cf1cd48ebb480bb642c7 > # Parent 07b0bee87f32be91a33210bc06973e07c4c1dac9 > Added w

Re: [PATCH 1 of 4] Win32: removed unneeded wildcard in NGX_CC_NAME test for msvc

2023-01-12 Thread Maxim Dounin
Hello! On Tue, Dec 20, 2022 at 04:30:15PM +0300, Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1671541071 -10800 > # Tue Dec 20 15:57:51 2022 +0300 > # Node ID f5d9c24fb4ac2a6b82b9d842b88978a329690138 > # Parent 2af1287d2da744335932f6dca345618f7b80d1c1 > Win32:

[PATCH 11 of 12] Win32: fixed ngx_fs_bsize() for symlinks

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673549010 -10800 # Thu Jan 12 21:43:30 2023 +0300 # Node ID be7eb9ec28dcbfdfd2e850befc8d051c0e4d46fd # Parent e62c8e9724ba68a698a2c3613edca73fe4e1c4ae Win32: fixed ngx_fs_bsize() for symlinks. Just a drive letter might not correctly represent

[PATCH 12 of 12] Win32: non-ASCII names in ngx_fs_bsize(), ngx_fs_available()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673549053 -10800 # Thu Jan 12 21:44:13 2023 +0300 # Node ID c63770d2ae19a5a84f3521e336ca2092879dd855 # Parent be7eb9ec28dcbfdfd2e850befc8d051c0e4d46fd Win32: non-ASCII names in ngx_fs_bsize(), ngx_fs_available(). This fixes potentially incorr

[PATCH 10 of 12] Win32: non-ASCII names support in ngx_open_tempfile()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548994 -10800 # Thu Jan 12 21:43:14 2023 +0300 # Node ID e62c8e9724ba68a698a2c3613edca73fe4e1c4ae # Parent 718bf1f036e6e00f09bb4569b124540ed3153392 Win32: non-ASCII names support in ngx_open_tempfile(). This makes it possible to use tempor

[PATCH 08 of 12] Win32: non-ASCII names support in ngx_delete_file()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548978 -10800 # Thu Jan 12 21:42:58 2023 +0300 # Node ID d680dedf87fb861f6265218b5d53b49e951947e0 # Parent c86a1405cba4d5c1be6d1bbf3160ba567b3c6f50 Win32: non-ASCII names support in ngx_delete_file(). This makes it possible to delete files

[PATCH 09 of 12] Win32: non-ASCII names support in ngx_rename_file()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548982 -10800 # Thu Jan 12 21:43:02 2023 +0300 # Node ID 718bf1f036e6e00f09bb4569b124540ed3153392 # Parent d680dedf87fb861f6265218b5d53b49e951947e0 Win32: non-ASCII names support in ngx_rename_file(). This makes it possible to upload files

[PATCH 07 of 12] Win32: reworked ngx_win32_rename_file() to use nginx wrappers

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548972 -10800 # Thu Jan 12 21:42:52 2023 +0300 # Node ID c86a1405cba4d5c1be6d1bbf3160ba567b3c6f50 # Parent bed2302585d8647df3f8185085588395b1ce7b74 Win32: reworked ngx_win32_rename_file() to use nginx wrappers. This ensures that ngx_win32_

[PATCH 06 of 12] Win32: reworked ngx_win32_rename_file() to check errors

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548968 -10800 # Thu Jan 12 21:42:48 2023 +0300 # Node ID bed2302585d8647df3f8185085588395b1ce7b74 # Parent fbe7d76fe0398ca674b5d62b4849cd524e35bf89 Win32: reworked ngx_win32_rename_file() to check errors. Previously, ngx_win32_rename_file(

[PATCH 04 of 12] Win32: non-ASCII directory names support in ngx_create_dir()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548958 -10800 # Thu Jan 12 21:42:38 2023 +0300 # Node ID 331e40f73047c03455e10212b2b8701ec5ec35d0 # Parent 7cf820c46860796cff91f53a5d2db669bb5b5a6c Win32: non-ASCII directory names support in ngx_create_dir(). This makes it possible to cre

[PATCH 05 of 12] Win32: non-ASCII directory names support in ngx_delete_dir()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548963 -10800 # Thu Jan 12 21:42:43 2023 +0300 # Node ID fbe7d76fe0398ca674b5d62b4849cd524e35bf89 # Parent 331e40f73047c03455e10212b2b8701ec5ec35d0 Win32: non-ASCII directory names support in ngx_delete_dir(). This makes it possible to del

[PATCH 02 of 12] Win32: non-ASCII names support in "include" with wildcards

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548899 -10800 # Thu Jan 12 21:41:39 2023 +0300 # Node ID d05c0adf5890aecc68ce8906ef19ca07502ed071 # Parent 60d845f9505fe1b97c1e04b680523b790e29fdb1 Win32: non-ASCII names support in "include" with wildcards. Notably, ngx_open_glob() now su

[PATCH 01 of 12] Win32: non-ASCII names support in autoindex (ticket #458)

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548890 -10800 # Thu Jan 12 21:41:30 2023 +0300 # Node ID 60d845f9505fe1b97c1e04b680523b790e29fdb1 # Parent 07b0bee87f32be91a33210bc06973e07c4c1dac9 Win32: non-ASCII names support in autoindex (ticket #458). Notably, ngx_open_dir() now supp

[PATCH 03 of 12] Win32: non-ASCII directory names support in ngx_getcwd()

2023-01-12 Thread Maxim Dounin
# HG changeset patch # User Maxim Dounin # Date 1673548916 -10800 # Thu Jan 12 21:41:56 2023 +0300 # Node ID 7cf820c46860796cff91f53a5d2db669bb5b5a6c # Parent d05c0adf5890aecc68ce8906ef19ca07502ed071 Win32: non-ASCII directory names support in ngx_getcwd(). This makes it possible to start n

[PATCH 00 of 12] win32 non-ASCII names support fixes

2023-01-12 Thread Maxim Dounin
Hello! The following patch series fixes various issues with non-ASCII names on Windows. Notably, the following Trac tickets are addressed: "Win32: autoindex module doesn't support Unicode names" https://trac.nginx.org/nginx/ticket/458 "WebDAV module didn't convert UTF8 encode url into GBK on Wi

Re: [PATCH] limit_req_status: allow status response to be as low as 200

2023-01-12 Thread J Carter
It's trivial to do with error page OP as mentioned - an example:     limit_req_status 598;     limit_req_zone $binary_remote_addr zone=a:1m rate=1r/m;     server {     limit_req zone=a nodelay;     error_page 598 = @send-204;     location / {    ...     }     .

Re: [PATCH] limit_req_status: allow status response to be as low as 200

2023-01-12 Thread Maxim Dounin
Hello! On Thu, Jan 12, 2023 at 05:16:21AM -0800, Christopher Liebman wrote: > Not with 204. > This works quite well with a partner that has an aversion to errors when > they run over the limit: > limit_req_status 204; Indeed, 204 happens to be one of the two 2xx codes which can be returned dire

Re: [PATCH] limit_req_status: allow status response to be as low as 200

2023-01-12 Thread Christopher Liebman
Not with 204. This works quite well with a partner that has an aversion to errors when they run over the limit: limit_req_status 204; On Wed, Jan 11, 2023 at 12:22 PM Maxim Dounin wrote: > Hello! > > On Mon, Jan 09, 2023 at 09:44:52AM -0800, Christopher Liebman wrote: > > > # HG changeset patch