Re: [PATCH] Introduced worker_shutdown_idle_delay

2024-01-25 Thread Roman Arutyunyan
Hi Artem, On Wed, Nov 08, 2023 at 07:51:39AM +0300, Artem Pogartsev via nginx-devel wrote: > # HG changeset patch > # User Artem Pogartsev > # Date 1699416491 -10800 > # Wed Nov 08 07:08:11 2023 +0300 > # Node ID eb0dd3d903431f4dd7a62d629db457ecddeadd96 > # Parent

Re: Nginx-tests stream_ssl_conf_command.t test hanging indefinitely

2024-01-25 Thread Mayerhofer, Austin via nginx-devel
Hey Maxim, Thanks, I installed homebrew’s Perl and all these tests are passing now, woohoo! However a few others are failing now including ssl_ocsp.t and ssl_verify_depth.t, failing 13/17 and 3/11 tests respectively with the same error: ``` # Failed test 'verify depth 2 - end' # at

Re: [PATCH] Enforce that CR precede LF in chunk lines

2024-01-25 Thread Maxim Dounin
Hello! On Thu, Jan 25, 2024 at 08:32:17PM +, Ben Kallus wrote: > > Still, there is a robustness principle which allows applications > > to parse requests with various deviations from the grammar. > > Whether this is principle is good is a matter of opinion. I tend to > lean toward thinking

Re: nginx-tests SSL tests failing out of the box?

2024-01-25 Thread Mayerhofer, Austin via nginx-devel
Hey Andrey, Thanks for the help. I rebuilt NGINX with OpenSSL 3.0.8 sources, but the same tests still fail. Here is the output of nginx configuration: nginx version: nginx/1.24.0 built by clang 14.0.0 (clang-1400.0.29.202) built with OpenSSL 3.0.8 7 Feb 2023 TLS SNI support enabled configure

[njs] Fixed fuzzer build after 9b3dac56fd8a.

2024-01-25 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/6770c015efdc branches: changeset: 2273:6770c015efdc user: Dmitry Volyntsev date: Thu Jan 25 14:48:05 2024 -0800 description: Fixed fuzzer build after 9b3dac56fd8a. diffstat: external/njs_shell.c | 60

Re: nginx-tests SSL tests failing out of the box?

2024-01-25 Thread Maxim Dounin
Hello! On Thu, Jan 25, 2024 at 06:59:36PM +, Mayerhofer, Austin via nginx-devel wrote: > Hi all, > > I have not made any changes to NGINX. Vanilla NGINX (./configure with no > flags) passes all tests that run, but when compiling with SSL, not all SSL > tests are passing. Is this

Re: [PATCH] Enforce that CR precede LF in chunk lines

2024-01-25 Thread Ben Kallus
> Still, there is a robustness principle which allows applications > to parse requests with various deviations from the grammar. Whether this is principle is good is a matter of opinion. I tend to lean toward thinking that it is not (as you can probably tell) but reasonable minds will differ on

Re: nginx-tests SSL tests failing out of the box?

2024-01-25 Thread Andrey Kulikov
Hello, Don't think your issue is specific to OpenSSL 3.2.0 or ARM64 arch. If you specify just --with-http_ssl_module flag, nginx will be compiled with system OpenSSL. What might be not what you expect (OpenSSL: 3.2.0) on MacOS. Try to specify --with-openssl= on nginx configure stage. Like

nginx-tests SSL tests failing out of the box?

2024-01-25 Thread Mayerhofer, Austin via nginx-devel
Hi all, I have not made any changes to NGINX. Vanilla NGINX (./configure with no flags) passes all tests that run, but when compiling with SSL, not all SSL tests are passing. Is this expected, or do I need to configure nginx further aside from adding the --with-http_ssl_module flag? Do each of

Re: [EXTERNAL] Re: Nginx-tests stream_ssl_conf_command.t test hanging indefinitely

2024-01-25 Thread Mayerhofer, Austin via nginx-devel
Hey Sergey, Thanks for the help. I tried installing perl via homebrew but I ran into some dependency issues setting it up, and by the time I did set it up, it was skipping due to “# SKIP no http_ssl available”. Is there a set of instructions or documentation for setting up a Mac environment

Re: [PATCH] Enforce that CR precede LF in chunk lines

2024-01-25 Thread Maxim Dounin
Hello! On Thu, Jan 25, 2024 at 03:21:16AM +, Ben Kallus wrote: > The HTTP/1.1 standards allow the recognition of bare LF as a line > terminator in some contexts. > > From RFC 9112 Section 2.2: > > Although the line terminator for the start-line and fields is the sequence > > CRLF, a