Re: Core: Avoid memcpy from NULL

2024-01-24 Thread
Hi, Here's a similar ticket in another OSS. https://github.com/bellard/quickjs/issues/225#issuecomment-1908279228 > QuickJS may pass NULL pointers to memcpy with zero size. The C spec tells it is an undefined behavior but most C code do it, so the spec should be fixed instead. On Wed, Jan 24, 202

Is ngx_http_headers_out dead code?

2023-06-25 Thread
Hi, I wonder if the `ngx_http_headers_out` variable is being used? If yes, what is it for? ``` /* src/http/ngx_http_header_filter_module.c */ ngx_http_header_out_t ngx_http_headers_out[] = { { ngx_string("Server"), offsetof(ngx_http_headers_out_t, server) }, { ngx_string("Date"), offs

Re: cache: move open to thread pool

2019-08-16 Thread
Great job, the patch works well. On Fri, Aug 16, 2019 at 10:24 PM Roman Arutyunyan wrote: > Hi, > > On Wed, Jul 24, 2019 at 11:47:19AM +0800, 洪志道 wrote: > > Hi, I found an issue with the patch. > > > > 1. Reproduce > > (/usr/local/nginx/html/5M.txt, Just m

Re: cache: move open to thread pool

2019-07-23 Thread
ginx core with all > > > associated costs of maintaining the code virtually forever. In the > > > same time at this point it brings no measurable value to the > > > community. At least, we haven't seen any proofs that it does. > > > > > > The patch w

Re: cache: move open to thread pool

2019-07-22 Thread
Thanks again. On Mon, Jul 22, 2019 at 10:05 PM Roman Arutyunyan wrote: > Hi, > > On Sat, Jul 20, 2019 at 09:44:25AM +0800, 洪志道 wrote: > > > The patch wasn't updated since that but I suspect it could be still > > applied to nginx, maybe with some minor tweaks. >

Re: cache: move open to thread pool

2019-07-19 Thread
atch wasn't updated since that but I suspect it could be still > applied to nginx, maybe with some minor tweaks. > > Maxim > > On 19/07/2019 18:26, 洪志道 wrote: > > Hi. > > Will this patch be merged into the main branch? > > What is the latest patch? We can help wi

Re: cache: move open to thread pool

2019-07-19 Thread
Hi. Will this patch be merged into the main branch? What is the latest patch? We can help with the test. Thanks. On Sat, Feb 9, 2019 at 6:40 AM Ka-Hing Cheung via nginx-devel < nginx-devel@nginx.org> wrote: > Unfortunately our test colo is not setup to do performance testing > (the traffic it rec

Re: The reason of ignoring subrequest in access phase hander.

2018-12-24 Thread
ss_by_lua_block { ... } } It's ok for us to replace it with rewrite. Anyway, do you still think it's better to restrict subrequests in access phase handler? On Mon, Dec 24, 2018 at 10:06 PM Maxim Dounin wrote: > Hello! > > On Mon, Dec 24, 2018 at 03:38:00AM +0800, 洪志道 wrote: &

The reason of ignoring subrequest in access phase hander.

2018-12-23 Thread
Hi. I'm wondering the reason of ignoring subrequests in access phase hander. Can anyone explain it to me? 1069 ngx_int_t 1070 ngx_http_core_access_phase(ngx_http_request_t *r, ngx_http_phase_handler_t *ph) 1071 { 1072 ngx_int_t rc; 1073 ngx_http_core_loc_conf_t *clcf; 10

How to checking nginx service is running?

2018-07-27 Thread
Hi. There are three ways we used. 1. Checking nginx processes. ps -Af | grep nginx 2. Checking pid file. /usr/local/nginx/logs/nginx.pid 3. service nginx status | grep running. I'm wondering which is the best way? Or any other suggestion? Thanks.

Re: http2 broken

2018-07-11 Thread
Get it, I'll try it, thank you again. On Thu, Jul 12, 2018 at 1:02 AM Maxim Dounin wrote: > Hello! > > On Wed, Jul 11, 2018 at 08:56:56PM +0800, 洪志道 wrote: > > > But there are still some clients use the old version. > > Is it a way to be compatible with it? > &g

Re: http2 broken

2018-07-11 Thread
Thank you. But there are still some clients use the old version. Is it a way to be compatible with it? Or other suggestions? @Maxim Dounin On Wed, Jul 11, 2018 at 5:43 PM tokers wrote: > Hello! > > There is a known issue caused by some obsolete client like old version > okhttp (incomplete pro

Re: http2 broken

2018-07-11 Thread
X_LOG_DEBUG_HTTP, fc->log, 0, "http2 table size update: 0"); -*pos++ = (1 << 5) | 0; h2c->table_update = 0; } On Wed, Jul 11, 2018 at 5:28 PM 洪志道 wrote: > Hi. > > The client can't load the image served by nginx-1.13.6+. >

http2 broken

2018-07-11 Thread
Hi. The client can't load the image served by nginx-1.13.6+. [App with Android 7.1.2 4.4.4 4.12 series] It works well in nginx-1.13.5, but go wrong in ngnx-1.13.6+. The change is http://hg.nginx.org/nginx/rev/12cadc4669a7. I found the similar problem. https://github.com/cloudflare/sslconfig/is

Re: [nginx] How to check node has been deleted from rbtree?

2018-07-09 Thread
Get it now, thank you. On Mon, Jul 9, 2018 at 8:24 PM Maxim Dounin wrote: > Hello! > > On Mon, Jul 09, 2018 at 07:51:47PM +0800, 洪志道 wrote: > > > As shown the subject, I wonder how to check some node has been deleted > from > > the red-black tree? > > No such

[nginx] How to check node has been deleted from rbtree?

2018-07-09 Thread
Hi. As shown the subject, I wonder how to check some node has been deleted from the red-black tree? The case is like the following: Step 1: node1 = ngx_rbtree_insert(...); node2 = ngx_rbtree_insert(...); node3 = ngx_rbtree_insert(...); Step 2: node = find_node_from_rbtree(...); remove_expired_n

Re: [nginx] Added r->schema.

2018-06-07 Thread
Hi. diff -r 8e6bb4e6045f src/http/ngx_http_variables.c --- a/src/http/ngx_http_variables.c Thu Jun 07 20:04:22 2018 +0300 +++ b/src/http/ngx_http_variables.c Thu Jun 07 12:20:05 2018 -0400 @@ -1420,25 +1420,11 @@ ngx_http_variable_scheme(ngx_http_request_t *r, ngx_http_variable_value_t *v, u

[nginx] enhance options

2018-02-04 Thread
Hi! Maybe it's better to keep the options more complete, and consider the follow operation as a mistake. /usr/local/nginx/sbin/nginx - hg diff diff -r cbf59d483c9c src/core/nginx.c --- a/src/core/nginx.c Tue Jan 16 13:52:03 2018 +0300 +++ b/src/core/nginx.c Sun Feb 04 07:41:36 2018 -0500 @@ -753

Re: [upstream] consistent hash support backup?

2017-11-08 Thread
ign. Thanks again. On Wed, Nov 8, 2017 at 9:11 PM, Ruslan Ermilov wrote: > On Mon, Nov 06, 2017 at 09:35:14PM +0800, 洪志道 wrote: > >Hi! > >We know that consistent hash upstream improve its selection in the > latest > >version. > > > > -if (hp

[upstream] consistent hash support backup?

2017-11-06 Thread
Hi! We know that consistent hash upstream improve its selection in the latest version. -if (hp->tries >= points->number) { - pc->name = hp->rrp.peers->name; +if (hp->tries > 20) { <

[nginx] support request id in error log

2017-06-28 Thread
Hi! Does nginx plan support request id in error log? In the real case, it's really helpful to position question by the unique id of request. And it will become better if support in error log also. For example showed in our error log: 2017/06/26 23:56:09 [info] 52590#52590: *1 client prematurely

Re: [nginx] slice module issue

2017-06-20 Thread
} > } > > > Note that at request level the slice module is enabled by evaluating the > $slice_range variable. > > > On Wed, Jun 21, 2017 at 12:45:07AM +0800, 洪志道 wrote: > > Well, it's a good idea, but it's not satisfied yet. > > > > Now we

Re: [nginx] slice module issue

2017-06-20 Thread
I hope slice module can satisfy customer requirements. Now the key point is users want to control the behavior of slice. And this is common. Here's the patch, take a look please! diff -r 5e05118678af src/http/modules/ngx_http_slice_filter_module.c --- a/src/http/modules/ngx_http_slice_filter_mod

Re: [nginx] slice module issue

2017-06-20 Thread
er you want for multi-range requests. > > On Tue, Jun 20, 2017 at 03:47:02PM +, 洪志道 wrote: > > If we wan't to slice in the case of multi-page, how to achieve it? > > > > 洪志道 于2017年6月20日 周二23:21写道: > > > > > You said the module doesn't supp

Re: [nginx] slice module issue

2017-06-20 Thread
If we wan't to slice in the case of multi-page, how to achieve it? 洪志道 于2017年6月20日 周二23:21写道: > You said the module doesn't support multi-range, it means nothing to > support slice feature through $slice_range. > Anyway we can avoid it by access handle, but it's still

Re: [nginx] slice module issue

2017-06-20 Thread
n 20, 2017 at 12:42:30PM +, 洪志道 wrote: > > Do you think it's better to set $slice_range not found as if multi-range > > request? > > > > Roman Arutyunyan 于2017年6月20日 周二20:09写道: > > > > > Hi, > > > > > > On Tue, Jun 20, 2017 at 02:2

Re: [nginx] slice module issue

2017-06-20 Thread
Do you think it's better to set $slice_range not found as if multi-range request? Roman Arutyunyan 于2017年6月20日 周二20:09写道: > Hi, > > On Tue, Jun 20, 2017 at 02:25:14AM +0800, 洪志道 wrote: > > Hi! > > > > Have a look at the following example first. >

[nginx] slice module issue

2017-06-19 Thread
Hi! Have a look at the following example first. server { listen 80; location / { slice 10; proxy_set_header Range $slice_range; proxy_pass http://127.0.0.1:81; } } server { listen 81; root html; } Then we start a request with cu

Re: [nginx] support http2 per server

2017-06-09 Thread
Hi, Valentin. Please confirm again, thanks. diff -r 5e05118678af src/http/modules/ngx_http_ssl_module.c --- a/src/http/modules/ngx_http_ssl_module.c Mon May 29 23:33:38 2017 +0300 +++ b/src/http/modules/ngx_http_ssl_module.c Fri Jun 09 07:15:50 2017 -0400 @@ -234,6 +234,13 @@ offsetof(ngx_

Re: [nginx] support http2 per server

2017-06-09 Thread
Get it, thanks. On Fri, Jun 9, 2017 at 7:45 PM, Valentin V. Bartenev wrote: > On Friday 09 June 2017 13:40:23 洪志道 wrote: > > Hi, Valentin. > > > > " > > Also please note that with your patch clients are still able to > > negotiate HTTP/2 even if nginx

Re: [nginx] support http2 per server

2017-06-08 Thread
h the patch, clients are still able to negotiate HTTP/2" 2. "even if nginx doesn't announce it" Is it related to nginx? On Fri, Jun 9, 2017 at 1:09 AM, Valentin V. Bartenev wrote: > On Friday 09 June 2017 00:08:06 洪志道 wrote: > > " > > > >

Re: [nginx] support http2 per server

2017-06-08 Thread
Thanks. On Fri, Jun 9, 2017 at 1:09 AM, Valentin V. Bartenev wrote: > On Friday 09 June 2017 00:08:06 洪志道 wrote: > > " > > > >For "https" resources, connection reuse additionally depends on > >having a certificate that is valid for the host in

Re: [nginx] support http2 per server

2017-06-08 Thread
to check the patch whether contains serious problem? Maybe it's helpful for other guys. Thanks again. On Thu, Jun 8, 2017 at 11:25 PM, Valentin V. Bartenev wrote: > On Thursday 08 June 2017 23:19:23 洪志道 wrote: > > It sounds right. > > > > According to the same situatio

Re: [nginx] support http2 per server

2017-06-08 Thread
'a.com', then the connection contains different requests with different domains. That b.com will escape from ssl handshake. In fact, we need it to do the ssl handshake. Thanks. On Thu, Jun 8, 2017 at 10:17 PM, Valentin V. Bartenev wrote: > On Thursday 08 June 2017 12:07:29 洪志道

Re: [nginx] support http2 per server

2017-06-07 Thread
af src/http/modules/ngx_http_ssl_module.h --- a/src/http/modules/ngx_http_ssl_module.h Mon May 29 23:33:38 2017 +0300 +++ b/src/http/modules/ngx_http_ssl_module.h Wed Jun 07 12:17:34 2017 -0400 @@ -57,6 +57,8 @@ u_char *file; ngx_uint_t line

[nginx] support http2 per server

2017-06-07 Thread
Hi! Now, http2 is enabled globally for 'listen' directive with ip:port. It seems it's possible to enable by server with sni, alpn, npn. Take a look, please. diff -r 5e05118678af src/http/modules/ngx_http_ssl_module.c --- a/src/http/modules/ngx_http_ssl_module.c Mon May 29 23:33:38 2017 +0300 +++ b

[nginx] Macro ngx_max/ngx_min improved

2017-05-01 Thread
Hi! Both 'greater' and 'less' are not the lowest priority operations, we may make a litter improvement as following. diff -r 29ba1d6a2da9 src/core/ngx_core.h --- a/src/core/ngx_core.h Tue Apr 04 18:01:57 2017 +0300 +++ b/src/core/ngx_core.h Fri Apr 28 11:27:41 2017 -0400 @@ -97,8 +97,8 @@ #def

Re: [nginx] unnormal pid file

2017-03-18 Thread
(cycle, sig, pid); - } 2017-03-19 5:22 GMT+08:00 Maxim Dounin : > Hello! > > On Sat, Mar 18, 2017 at 03:43:36PM +0800, 洪志道 wrote: > > > Hi. > > > > It's easy to reproduce such problem that > > the master/worker process are running without the pid file. >

Re: [nginx] unnormal pid file

2017-03-18 Thread
pid; +ngx_core_conf_t *ccf; + +ngx_log_error(NGX_LOG_NOTICE, cycle->log, 0, "signal process started"); + +ccf = (ngx_core_conf_t *) ngx_get_conf(cycle->conf_ctx, ngx_core_module); + +pid = ngx_get_filepid(cycle, &ccf->pid); + +if (pid == -1) {

[nginx] unnormal pid file

2017-03-18 Thread
Hi. It's easy to reproduce such problem that the master/worker process are running without the pid file. Step by step: 1. Start master process. > ./objs/nginx nginx.pid successfully create with content (23234) 2. Create an active connection, purpose for prevent previous master exit.

Re: [nginx] style

2017-03-16 Thread
seems nginx dose guarantee that pid file and master/worker processes are always exist together. What causes this phenomenon? ``` kill -USR2 pid; sleep n; kill -QUIT oldpid; ``` Thanks so much. B.R. 2017-03-17 0:05 GMT+08:00 Ruslan Ermilov : > On Thu, Mar 16, 2017 at 05:40:46PM +0800, 洪志道 wrote

[nginx] style

2017-03-16 Thread
Hi! diff -r d45072375572 src/os/unix/ngx_process.c --- a/src/os/unix/ngx_process.c Tue Mar 07 18:51:17 2017 +0300 +++ b/src/os/unix/ngx_process.c Thu Mar 16 06:44:25 2017 -0400 @@ -306,7 +306,7 @@ } -void +static void ngx_signal_handler(int signo) { char*action; Thanks. B.R

[nginx] nginx.pid doesn't exist

2017-03-15 Thread
Hi! What causes the nginx.pid file doesn't exist but the master and worker process are still running? This situation happens when we upgrade nginx. kill -USR2 pid; sleep n; kill -QUIT oldpid; I check the code in ngx_pross_cycle.c and ngx_process.c, it seems nginx dose perfectly guarantee that p

[http/2] stream id ascending

2017-03-10 Thread
Hi! http://stackoverflow.com/questions/42719939/why-http-2-stream-id-must-be-ascending Dose anyone know why http/2 stream id must be ascending? Thanks. B.R. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/ng

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread
We can close the topic. I review the previous infos, and I have already got the answer. Thanks! 2017-03-09 20:53 GMT+08:00 洪志道 : > "First of all, we can set timeout zero if need to exit immediately." > > It's not a good idea. > > 2017-03-09 20:52 GMT+08:00 洪志道 : &g

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread
"First of all, we can set timeout zero if need to exit immediately." It's not a good idea. 2017-03-09 20:52 GMT+08:00 洪志道 : > I get it. > > Yep, we can do the cleanup work in exit process or pool cleanup when > expired time happened. > > I keep my opinion that

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread
.* Thanks again. 2017-03-09 20:29 GMT+08:00 Maxim Dounin : > Hello! > > On Thu, Mar 09, 2017 at 02:39:26PM +0800, 洪志道 wrote: > > [...] > > > "Cancelable timers are now preserved if there are other timers. There is > no > > need to cancel timers early if the

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-08 Thread
_timeout when > there is already no active connection left makes little sense. > > Thanks, > Datong > > On Tue, Mar 7, 2017 at 11:52 PM, 洪志道 wrote: > >> Hi! >> >> It's a good design. >> It seems the worker process is not killed until expired, th

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-07 Thread
Hi! It's a good design. It seems the worker process is not killed until expired, the time is set by 'worker_shutdown_timeout'. But I think ngx_shutdown_timer_handler will never be called, because of the following deal. if (ngx_exiting) { if (ngx_event_no_timers_left() == NGX_OK

[nginx] two masters exist

2017-03-02 Thread
Hi! It's possible that two masters exist at the same time. kill -USR2 pid; sleep(2); if [ -f ${oldbinpidfile} -a -f ${pidfile} ]; # New master doesn't success in two seconds kill -QUIT oldpid; fi We assume that the previous exist master is old, I want to know which master process the request

Re: [nginx] setting variable cause core when used by lua

2017-02-16 Thread
It works well now, thank you! 2017-02-16 22:14 GMT+08:00 Maxim Dounin : > Hello! > > On Thu, Feb 16, 2017 at 03:51:24PM +0800, 洪志道 wrote: > > > Hi. > > > > diff -r da46bfc484ef src/http/ngx_http_variables.c > > --- a/src/http/ngx_http_variables.c Mon Feb 13 21

Re: [nginx] setting variable cause core when used by lua

2017-02-16 Thread
Sorry, sent too much. 2017-02-16 16:00 GMT+08:00 洪志道 : > Hi! > > diff -r da46bfc484ef src/http/ngx_http_variables.c > --- a/src/http/ngx_http_variables.c Mon Feb 13 21:45:01 2017 +0300 > +++ b/src/http/ngx_http_variables.c Wed Feb 08 10:31:53 2017 +0800 > @@ -783,6 +783,10 @@ &

[nginx] setting variable cause core when used by lua

2017-02-16 Thread
Hi! diff -r da46bfc484ef src/http/ngx_http_variables.c --- a/src/http/ngx_http_variables.c Mon Feb 13 21:45:01 2017 +0300 +++ b/src/http/ngx_http_variables.c Wed Feb 08 10:31:53 2017 +0800 @@ -783,6 +783,10 @@ ssize_ts, *sp; ngx_str_t val; +if (v->data == NULL) { +retur

[nginx] setting variable cause core when used by lua

2017-02-15 Thread
Hi. diff -r da46bfc484ef src/http/ngx_http_variables.c --- a/src/http/ngx_http_variables.c Mon Feb 13 21:45:01 2017 +0300 +++ b/src/http/ngx_http_variables.c Wed Feb 08 10:31:53 2017 +0800 @@ -783,6 +783,10 @@ ssize_ts, *sp; ngx_str_t val; +if (v->data == NULL) { +retur

[nginx] setting variable cause core when used by lua

2017-02-15 Thread
Hi. diff -r da46bfc484ef src/http/ngx_http_variables.c --- a/src/http/ngx_http_variables.c Mon Feb 13 21:45:01 2017 +0300 +++ b/src/http/ngx_http_variables.c Wed Feb 08 10:31:53 2017 +0800 @@ -783,6 +783,10 @@ ssize_ts, *sp; ngx_str_t val; +if (v->data == NULL) { +retur

Re: [nginx] limit_rate_after

2017-02-14 Thread
02-14 21:11 GMT+08:00 Maxim Dounin : > Hello! > > On Tue, Feb 14, 2017 at 03:54:35PM +0800, 洪志道 wrote: > > > Dose nginx consider support setting variable about limit_rate_after? > > We can limit rate after $n bytes received from upstream. > > No. A patch to intr

[nginx] limit_rate_after

2017-02-13 Thread
Hi! Dose nginx consider support setting variable about limit_rate_after? We can limit rate after $n bytes received from upstream. --- a/src/http/ngx_http_variables.c Mon Feb 13 21:45:01 2017 +0300 +++ b/src/http/ngx_http_variables.c Tue Feb 07 05:15:51 2017 +0800 @@ -321,6 +321,11 @@ offse

Re: [nginx] Map: the "volatile" parameter.

2016-12-08 Thread
Hi! It's still a problem when the variable generated by map and including itself. For example: map $host $abc { default $abc; } server { listen 80; location / { return 200 $abc; } } Thanks. B.R~ 2016-12-09 2:46 GMT+08:00 Ruslan Ermilov : > details: http://hg.nginx

[nginx] tiny style

2016-10-26 Thread
Hi! static ngx_int_t ngx_http_limit_req_init_zone(ngx_shm_zone_t *shm_zone, void *data) { ngx_http_limit_req_ctx_t *octx = data; size_t len; ngx_http_limit_req_ctx_t *ctx; ctx = shm_zone->data; if (octx) { if (ctx->key.value.len != octx->key.val

Re: [nginx-test] tempdir permission

2016-10-21 Thread
Ok, thanks. 2016-10-21 21:04 GMT+08:00 Maxim Dounin : > Hello! > > On Fri, Oct 21, 2016 at 11:44:01AM +0800, 洪志道 wrote: > > > Hi! > > > > I run the following test. > > > > > cat test.t > > #!/usr/bin/perl > > > > use warnings; > &

[nginx-test] tempdir permission

2016-10-20 Thread
Hi! I run the following test. > cat test.t #!/usr/bin/perl use warnings; use strict; use File::Temp qw/ tempdir /; tempdir( 'nginx-test-XX', TMPDIR => 1 ) or die "Can't create temp directory: $!\n"; > prove test.t > ll -d /tmp/nginx-test* drwx-- 2 ro

Re: [PATCH] Remove duplicate implementation of njs_parser_token()

2016-10-17 Thread
Hello! It seems the file njs/njs_nonrecursive_parser.c is unused. 2016-10-17 15:29 GMT+08:00 Piotr Sikora : > # HG changeset patch > # User Piotr Sikora > # Date 1476689340 25200 > # Mon Oct 17 00:29:00 2016 -0700 > # Node ID 11abc80a5a442b56ee0618834b88510369a765d6 > # Parent 8046b999aaa

Re: path purpose//Re:[patch]fork: subprocess quit when parent died

2016-10-12 Thread
Hello! It's a common case that all the worker processes are still live while the master process isn't exist. So I think nginx should continue to work as Maxim said. Btw, we noticed that nginx.pid is deleted when we do the upgrade command. kill -USR2 nginx.pid; sleep(2); kill -HUP nginx.oldpid; W

Re: nginx timer in log module

2016-09-16 Thread
Thank you for your reply, I get it now. In other case such as I showed above, it seems we needn't do like the following ? if (ev->timer_set) { ngx_del_timer(ev); } 2016-09-17 10:48 GMT+08:00 Maxim Dounin : > Hello! > > On Sat, Sep 17, 2016 at 08:25:54AM

Re: nginx timer in log module

2016-09-16 Thread
the event timer */ #if 0 if (ev->timer_set) { ngx_del_timer(ev); } #endif } Thanks again. B.R.~ 2016-09-17 8:25 GMT+08:00 洪志道 : > Hi > > As the following codes. > > > buffer->event->handler = ngx_http_log_flush_handler; > > > stat

nginx timer in log module

2016-09-16 Thread
Hi As the following codes. buffer->event->handler = ngx_http_log_flush_handler; static void ngx_http_log_flush_handler(ngx_event_t *ev) { ... if (ev->timedout) { ngx_http_log_flush(ev->data, ev->log); return; } ... } static void ngx_http_log_flush(ngx_open_fil

Re: nginx dso coredump

2016-08-31 Thread
Thanks 2016-09-01 0:50 GMT+08:00 Maxim Dounin : > Hello! > > On Wed, Aug 31, 2016 at 01:19:14AM +0800, 洪志道 wrote: > > > Hi. > > > > It’s do really a funny experience. Now I use in the following way. > > > > [ngx_http_hello_module] > > > &g

Re: nginx dso coredump

2016-08-30 Thread
Hi. It’s do really a funny experience. Now I use in the following way. [ngx_http_hello_module] 1. development: ngx_http_hello_module.c => ngx_http_hello_module.so 2. production mv modules/ngx_http_hello_module.so modules/ngx_http_hello_module.so.2 upload ngx_http_hello_module.so to modu

Re: nginx dso coredump

2016-08-30 Thread
gmentation fault if some other guy run a reload command at that time. B.R. 2016-08-30 21:05 GMT+08:00 Maxim Dounin : > Hello! > > On Tue, Aug 30, 2016 at 08:46:42PM +0800, 洪志道 wrote: > > > Thanks a lot for your reply. > > > > First, we want to manage the module versio

Re: nginx dso coredump

2016-08-30 Thread
abc_module_3.so] Then change config load_module modules/ngx_http_abc_module_3.so; Finally we upgrade nginx: -USR2 && sleep && -QUIT old B.R.~ 2016-08-30 19:22 GMT+08:00 Maxim Dounin : > Hello! > > On Tue, Aug 30, 2016 at 06:33:36PM +0800, 洪志道 wrote: > > >

Re: nginx dso coredump

2016-08-30 Thread
Plus: kill -USR2 pid; sleep(2); kill -QUIT oldpid; 2016-08-30 18:33 GMT+08:00 洪志道 : > Hi, guys > > I found a coredump file generated on production. > > > (gdb) print ngx_http_abc_module > $7 = {ctx_index = 18446744073709551615, index = 18446744073709551615, name > = 0x0

nginx dso coredump

2016-08-30 Thread
Hi, guys I found a coredump file generated on production. (gdb) print ngx_http_abc_module $7 = {ctx_index = 18446744073709551615, index = 18446744073709551615, name = 0x0, spare0 = 0, spare1 = 0, version = 1010001, signature = 0x3520 , ctx = 0x204800, commands = 0x204840, type = 1347703880, in

nginx dso version

2016-08-30 Thread
Hi What's the best way manage the version with dynamic module? For example: ngx_http_same_module.so (1) ngx_http_same_module.so (2) ... Thanks. B.R. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-de

unused ngx_http_headers_out

2016-07-06 Thread
Hi, It seems the global variable 'ngx_http_headers_out' in src/http/ngx_http_header_filter_module.c isn't used at any where. B.R. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

http 2 status

2016-07-06 Thread
Hi, Could anybody tell me the http 2 status, and what's level of support by nginx? Thanks so much! B.R. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Headers filter: style

2016-06-23 Thread
I think the name is more meaning in the *context*. So as like Maxim said, "It's just a convenient short name". 2016-06-24 3:45 GMT+08:00 Piotr Sikora : > Hey Maxim, > > > The "h" is used for variables of various types, including > > ngx_http_file_cache_header_t, ngx_str_t, ngx_keyval_t, > > ngx_t

top n url

2016-06-22 Thread
Hi, Is it possible to find the top 100 urls by visits in real time? You know I dose not want to find the infos from the log file. B.R. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [nginx] dso

2016-06-15 Thread
Hi, Assume Now it runs well, then I change nginx source code, should I compile the module files again? It seems It will get wrong when new nginx rpm run together with old so files. Thanks! B.R. 2016-04-28 3:02 GMT+08:00 Igor Sysoev : > On 27 Apr 2016, at 19:32, 洪志道 wrote: > >

upstream keepalive variable

2016-06-12 Thread
Hi, It seems to we can't check a request whether used upstream keepalive, so I add the following code with an additional variable named $upstream_keepalive. static ngx_int_t ngx_http_upstream_keepalive_variable(ngx_http_request_t *r, ngx_http_variable_value_t *v, uintptr_t data) { if

[nginx] map module cause core dump

2016-05-18 Thread
Hi, It seems the following configure will cause core dump file. map $uri $s { default $s; # same var name as the var generated by map directive above } server { listen 80; location / { return 200 $s; } } [root@localhost nginx-1.10.0]# ./objs/nginx -V nginx version:

Re: upstream/302

2016-05-18 Thread
a > module, at it’s exactly what I did, you can find it here: > https://github.com/whatvn/nginx_redirect_balancer > > *I**t works with help of following awesome module by agentzh: > *lua-nginx-module > and lua-updstream-module > > > - > Hung > > > From: nginx-de

upstream/302

2016-05-17 Thread
Hi Is there a way to get selected peer in upstream without sending request to backend server? upstream backend { hash $url consistent; server 192.168.1.101; server 192.168.1.102; # Assume this is selected server 192.168.1.103; } location /302 { proxy_pass http://backend;

[no subject]

2016-05-17 Thread
Hi Is there a way to get selected peer in upstream without sending request to backend server? upstream backend { hash $url consistent; server 192.168.1.101; server 192.168.1.102; # Assume this is selected server 192.168.1.103; } location /302 { proxy_pass http://backend;

Monitoring nginx metrics

2016-05-05 Thread
Hi, Recently I upgrade nginx and wrote a module for monitoring response metrics. It’s simple but handy and useful. Maybe the nginx can support more informations like stub status module. https://github.com/hongzhidao/nginx-http-metric-module Regards. ___

Re: [nginx] dso

2016-04-27 Thread
-QUIT `cat nginx.pid.oldbin`] And how to deal with? 2016-04-28 0:08 GMT+08:00 Igor Sysoev : > On 27 Apr 2016, at 18:51, 洪志道 wrote: > > Thanks for your reply. > > Is it the only way to solve the problem? > > > This is a way to reload a module in production without >

Re: [nginx] dso

2016-04-27 Thread
x27;s a great design, thanks again. 2016-04-27 19:22 GMT+08:00 Igor Sysoev : > On 27 Apr 2016, at 12:10, 洪志道 wrote: > > Hi, > > for example following config: > > daemon on; > ... > load_module modules/ngx_http_test_module.so; > ... > > > start nginx > &

[nginx] dso

2016-04-27 Thread
Hi, for example following config: daemon on; ... load_module modules/ngx_http_test_module.so; ... > start nginx > change ngx_http_test_module.c, then regenerate so file > kill -HUP pid I found nginx still run the old so file (load first time), and how to work with new so file? I tried .../sb

Re: njs isuse -- ext->set is null

2016-01-02 Thread
but the last statement is empty such simicolon, the body->right node is also null. 2016-01-03 1:34 GMT+08:00 Igor Sysoev : > On 02 Jan 2016, at 17:17, 洪志道 wrote: > > js_set $bar " > $r.error = "this will cause coredump file since ext->set is null"; > “; >

njs isuse -- ext->set is null

2016-01-02 Thread
js_set $bar " $r.error = "this will cause coredump file since ext->set is null"; "; ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel