Re: [PATCH 1 of 2] Rewritten host header validation to follow generic parsing rules

:53:46PM +0100, J Carter wrote: > > Hello Sergey, > > > > On Mon, 27 May 2024 14:21:43 +0400 > > Sergey Kandaurov wrote: > > > > > # HG changeset patch > > > # User Sergey Kandaurov > > > # Date 1716805272 -14400

Re: [PATCH] Slice filter: proxy_cache_background_update support (ticket #1348)

On Tue, 11 Jun 2024 02:46:13 +0100 J Carter wrote: > Style cleanup of previous patch. > > Also removed 'status already > returned' guard in slice range variable handler, as it is no longer > needed given other changes in patch. > Additional fixes. # HG changeset p

Re: [PATCH] Slice filter: proxy_cache_background_update support (ticket #1348)

Style cleanup of previous patch. Also removed 'status already returned' guard in slice range variable handler, as it is no longer needed given other changes in patch. # HG changeset patch # User J Carter # Date 1718069043 -3600 # Tue Jun 11 02:24:03 2024 +0100

[PATCH] Slice filter: proxy_cache_background_update support (ticket #1348)

# HG changeset patch # User J Carter # Date 1717886685 -3600 # Sat Jun 08 23:44:45 2024 +0100 # Node ID 1b8a60f7640be4a900ac77d8022b7d8cc6944186 # Parent 02e9411009b987f408214ab4a8b6b6093f843bcd Slice filter: proxy_cache_background_update support (ticket #1348). Previously, subrequests of

Re: [PATCH 1 of 2] Rewritten host header validation to follow generic parsing rules

Hello Sergey, On Mon, 27 May 2024 14:21:43 +0400 Sergey Kandaurov wrote: > # HG changeset patch > # User Sergey Kandaurov > # Date 1716805272 -14400 > # Mon May 27 14:21:12 2024 +0400 > # Node ID e82a7318ed48fdbc1273771bc96357e9dc232975 > # Parent f58b6f6362387eeace46043a6fc0bceb56a6786a

Re: [PATCH] Memcached: memcached_flags_set directive

Fixed a typo in patch description, and overlooked buffer overflow... # HG changeset patch # User J Carter # Date 1716779649 -3600 # Mon May 27 04:14:09 2024 +0100 # Node ID e2ebeb2b05062369626e2de1ba753f318f821d9c # Parent f58b6f6362387eeace46043a6fc0bceb56a6786a Memcached

[PATCH] Memcached: memcached_flags_set directive

# HG changeset patch # User J Carter # Date 1716779649 -3600 # Mon May 27 04:14:09 2024 +0100 # Node ID e90301dd1516b6dfa5b2b0beec05cfe2b567ea1e # Parent f58b6f6362387eeace46043a6fc0bceb56a6786a Memcached: memcached_flags_set directive. This directive creates a variable that returns the

Re: [PATCH] Configure: add support for Homebrew on Apple Silicon

On Wed, 6 Mar 2024 19:36:32 +0400 Sergey Kandaurov wrote: > > On 28 Feb 2024, at 05:24, Piotr Sikora via nginx-devel > > wrote: > > > > # HG changeset patch > > # User Piotr Sikora > > # Date 1708977643 0 > > # Mon Feb 26 20:00:43 2024 + > > # Branch patch017 > > # Node ID dd95daa55c

Re: [PATCH] Avoiding mixed socket families in PROXY protocol v1 (ticket #2594)

Hello Roman, On Wed, 21 Feb 2024 17:29:52 +0400 Roman Arutyunyan wrote: > Hi, > [...] > Checking whether the address used in PROXY writer is in fact the address > that was passed in the PROXY header, is complicated. This will either require > setting a flag when PROXY address is set by reali

Re: [nginx] Update mime-types

Hello, On Fri, 16 Feb 2024 14:19:57 +0300 izor...@gmail.com wrote: > Hello. > > Patch to update current MIME types. > Most of information is taken from IANA and Wikipedia. > > It might be a good idea to provide a reason for each of these mime type changes, such as what real problem this solve

Re: nginx-tests: Some SSL tests are failing with openssl 3.2.0

Hello, On Fri, 26 Jan 2024 16:28:15 -0300 Renato Botelho wrote: > Hello! > > I'm building nginx on an environment with openssl 3.2.0 and some SSL > tests are failing. I suspect it's related to openssl version because it > works on another env with older openssl. But maybe I'm wrong. > > He

Re: [PATCH] SSL: Added SSLKEYLOGFILE key material to debug logging

Hello, Thanks for the feedback. On Wed, 24 Jan 2024 12:20:59 +0300 Maxim Dounin wrote: > Hello! > > On Sun, Jan 21, 2024 at 10:37:24AM +, J Carter wrote: > > > # HG changeset patch > > # User J Carter > > # Date 1705832811 0 > > # Sun Jan

[PATCH] SSL: Added SSLKEYLOGFILE key material to debug logging

# HG changeset patch # User J Carter # Date 1705832811 0 # Sun Jan 21 10:26:51 2024 + # Node ID b00332a5253eefb53bacc024c72f55876c2eac6e # Parent ee40e2b1d0833b46128a357fbc84c6e23be9be07 SSL: Added SSLKEYLOGFILE key material to debug logging. This patch also introduces the debug_keylog

Re: [PATCH 4 of 4] AIO operations now add timers (ticket #2162)

Hello, On Tue, 9 Jan 2024 08:59:14 +0300 Maxim Dounin wrote: > Hello! > > On Mon, Jan 08, 2024 at 01:31:11PM +, J Carter wrote: > > > On Mon, 8 Jan 2024 11:25:55 + > > J Carter wrote: > > > > > Hello, > > > > > > On

Re: [PATCH 4 of 4] AIO operations now add timers (ticket #2162)

On Mon, 8 Jan 2024 11:25:55 + J Carter wrote: > Hello, > > On Mon, 27 Nov 2023 05:50:27 +0300 > Maxim Dounin wrote: > > > # HG changeset patch > > # User Maxim Dounin > > # Date 1701050170 -10800 > > # Mon N

Re: [PATCH 4 of 4] AIO operations now add timers (ticket #2162)

Hello, On Mon, 27 Nov 2023 05:50:27 +0300 Maxim Dounin wrote: > # HG changeset patch > # User Maxim Dounin > # Date 1701050170 -10800 > # Mon Nov 27 04:56:10 2023 +0300 > # Node ID 00c3e7333145ddb5ea0eeaaa66b3d9c26973c9c2 > # Parent 61d08e4cf97cc073200ec32fc6ada9a2d48ffe51 > AIO operation

[PATCH] Image filter: fixed sharpen parsing

# HG changeset patch # User J Carter # Date 1703993644 0 # Sun Dec 31 03:34:04 2023 + # Node ID 1eaf9f76184f849fb21c5d2d543f2aa2df3be40c # Parent ee40e2b1d0833b46128a357fbc84c6e23be9be07 Image filter: fixed sharpen parsing. Previously non numeric values were read as 0. This patch makes

Re: [PATCH 00 of 12] HTTP/3 proxying to upstreams

On Thu, 28 Dec 2023 17:23:38 +0300 Vladimir Homutov via nginx-devel wrote: > On Thu, Dec 28, 2023 at 04:31:41PM +0300, Maxim Dounin wrote: > > Hello! > > > > On Wed, Dec 27, 2023 at 04:17:38PM +0300, Vladimir Homutov via nginx-devel > > wrote: > > > > > On Wed, Dec 27, 2023 at 02:48:04PM +0300

Re: [PATCH] Proxy: altered limit_rate to support variables

Hello, Thanks for the review and feedback. On Tue, 26 Dec 2023 19:07:37 +0400 Sergey Kandaurov wrote: > > On 26 Nov 2023, at 03:37, J Carter wrote: > > > > # HG changeset patch > > # User J Carter > > # Date 1700949429 0 > > # Sat Nov

Re: [PATCH 2 of 2] Win32: extended ngx_random range to 0x7fffffff

Hello, Thanks the review and feedback. On Sat, 16 Dec 2023 05:57:28 +0300 Maxim Dounin wrote: > Hello! > > On Sat, Dec 09, 2023 at 08:42:11AM +, J Carter wrote: > > > On Sat, 09 Dec 2023 07:46:10 + > > J Carter wrote: > > > > > # H

Re: [PATCH 2 of 2] Win32: extended ngx_random range to 0x7fffffff

On Sat, 09 Dec 2023 07:46:10 + J Carter wrote: > # HG changeset patch > # User J Carter > # Date 1702101635 0 > # Sat Dec 09 06:00:35 2023 + > # Node ID 1a77698f82d2580aa8b8f62ce89b4dbb6d678c5d > # Parent d9275e982a7188a1ea7855295ffa93362ea9830f > Win32: exte

[PATCH 1 of 2] Events: debug_random directive

# HG changeset patch # User J Carter # Date 1702098547 0 # Sat Dec 09 05:09:07 2023 + # Node ID d9275e982a7188a1ea7855295ffa93362ea9830f # Parent f366007dd23a6ce8e8427c1b3042781b618a2ade Events: debug_random directive This directive enables debug logging for only a percentage of

[PATCH 2 of 2] Win32: extended ngx_random range to 0x7fffffff

# HG changeset patch # User J Carter # Date 1702101635 0 # Sat Dec 09 06:00:35 2023 + # Node ID 1a77698f82d2580aa8b8f62ce89b4dbb6d678c5d # Parent d9275e982a7188a1ea7855295ffa93362ea9830f Win32: extended ngx_random range to 0x7fff rand() is used on win32. RAND_MAX is implementation

[PATCH 0 of 2] Debug_random directive & win32 ngx_random fix

This patch series reworks previous proposal for debug_random directive, with (re)consideration for advice on unessecary complexity. (see mailing list, August 2nd 2023) https://mailman.nginx.org/pipermail/nginx-devel/2023-August/BQNBXJFIIHFLHRE2ASU4QHPTMWPJUP5D.html Resubmitting as a series due to

Re: [PATCH] Added merge inheritance to proxy_set_header

Hello Roman, Thank you for the review and feedback. On Mon, 27 Nov 2023 16:18:21 +0400 Roman Arutyunyan wrote: > Hi Jordan, > > On Thu, Nov 23, 2023 at 02:52:55PM +, J Carter wrote: > > # HG changeset patch > > # User J Carter > > # Date 1700751016 0 > >

[PATCH] Proxy: altered limit_rate to support variables

# HG changeset patch # User J Carter # Date 1700949429 0 # Sat Nov 25 21:57:09 2023 + # Node ID 98306e705015758eab0a05103d90e6bdb1da2819 # Parent f366007dd23a6ce8e8427c1b3042781b618a2ade Proxy: altered limit_rate to support variables diff -r f366007dd23a -r 98306e705015 src/http

[PATCH] Added merge inheritance to proxy_set_header

# HG changeset patch # User J Carter # Date 1700751016 0 # Thu Nov 23 14:50:16 2023 + # Node ID cc79903ca02eff8aa87238a0f801f8070425d9ab # Parent 7ec761f0365f418511e30b82e9adf80bc56681df Added merge inheritance to proxy_set_header This patch introduces 'inherit' a

Re: [PATCH] Added debug_random directive

Hello, Thanks for the review. > On Mon, Jul 24, 2023 at 05:24:04AM +0100, J Carter wrote: > > [..] > > > # HG changeset patch > > # User J Carter > > # Date 1690171706 -3600 > > # Mon Jul 24 05:08:26 2023 +0100 > > # Node ID ea91b9aa69d

Re: [PATCH] Added debug_random directive

On Tue, 18 Jul 2023 03:36:02 + J Carter wrote: > On Sat, 15 Jul 2023 03:48:25 + > J Carter wrote: > > > # HG changeset patch > > # User J Carter > > # Date 1689391559 -3600 > > # Sat Jul 15 04:25:59 2023 +0100 > > # Node ID b1ea0a60417e54

Re: [PATCH] Added debug_random directive

On Sat, 15 Jul 2023 03:48:25 + J Carter wrote: > # HG changeset patch > # User J Carter > # Date 1689391559 -3600 > # Sat Jul 15 04:25:59 2023 +0100 > # Node ID b1ea0a60417e547513654bf9d6bb79714865c780 > # Parent 77c1418916f7817a0d020f28d8a08f278a12fe43 > Added d

[PATCH] Added debug_random directive

# HG changeset patch # User J Carter # Date 1689391559 -3600 # Sat Jul 15 04:25:59 2023 +0100 # Node ID b1ea0a60417e547513654bf9d6bb79714865c780 # Parent 77c1418916f7817a0d020f28d8a08f278a12fe43 Added debug_random directive This directive enforces for EITHER a percentage of total

Re: [PATCH] Added $http2_stream_id

Hello, On Mon, 22 May 2023 00:40:08 +0300 Maxim Dounin wrote: > Hello! > > On Sun, May 14, 2023 at 11:59:35PM +0100, J Carter wrote: > > > Hello, > > > > >On Sun, 14 May 2023 18:48:06 +0100 > > >J Carter wrote: > > > > > Hello, &g

Re: [PATCH] Added $realip_add_x_forwarded_for

Hello, Thanks for the reply. On Mon, 22 May 2023 15:48:23 +0300 Maxim Dounin wrote: > Hello! > > On Sun, May 14, 2023 at 04:51:58AM +0100, J Carter wrote: > > > # HG changeset patch > > # User jordanc.car...@outlook.com > > # Date 1684035158 -3600 > > #

Re: [PATCH] Added $http2_stream_id

Hello, >On Sun, 14 May 2023 18:48:06 +0100 >J Carter wrote: > Hello, > > On Sun, 14 May 2023 17:40:43 +0300 > Maxim Dounin wrote: > > > Hello! > > > > On Fri, May 12, 2023 at 03:37:52AM +0100, J Carter wrote: > > > > > # HG c

Re: [PATCH] Added $http2_stream_id

Hello, On Sun, 14 May 2023 17:40:43 +0300 Maxim Dounin wrote: > Hello! > > On Fri, May 12, 2023 at 03:37:52AM +0100, J Carter wrote: > > > # HG changeset patch > > # User jordanc.car...@outlook.com > > # Date 1683858766 -3600 > > # Fri May

Re: [PATCH] Added $realip_add_x_forwarded_for

Re-sending with non-malformed patch... # HG changeset patch # User jordanc.car...@outlook.com # Date 1684035158 -3600 # Sun May 14 04:32:38 2023 +0100 # Node ID dad6e472ee0d97a738b117f6480987ef135c9e7f # Parent b71e69247483631bd8fc79a47cc32b762625b1fb Added $realip_add_x_forwarded_for Resol

[PATCH] Added $realip_add_x_forwarded_for

# HG changeset patch # User jordanc.car...@outlook.com # Date 1684035158 -3600 # Sun May 14 04:32:38 2023 +0100 # Node ID dad6e472ee0d97a738b117f6480987ef135c9e7f # Parent b71e69247483631bd8fc79a47cc32b762625b1fb Added $realip_add_x_forwarded_for Resolves Ticket #2127. Duplicates the functi

[PATCH] Added $http2_stream_id

# HG changeset patch # User jordanc.car...@outlook.com # Date 1683858766 -3600 # Fri May 12 03:32:46 2023 +0100 # Node ID de1a1b4141e827984cbd0d2feb97f870c32ff289 # Parent b71e69247483631bd8fc79a47cc32b762625b1fb Added $http2_stream_id Useful for tracing multiplexed requests from client logs

Re: [PATCH] Asynchronous close event handling for single peer upstreams

On Sun, 7 May 2023 21:55:19 +0100 J Carter wrote: > # HG changeset patch > # User jordanc.car...@outlook.com > # Date 1683491710 -3600 > # Sun May 07 21:35:10 2023 +0100 > # Node ID e1ec9971da677b763c7576c729576d6f906631ae > # Parent b71e69247483631bd8fc79a47cc32b762625b

[PATCH] Asynchronous close event handling for single peer upstreams

# HG changeset patch # User jordanc.car...@outlook.com # Date 1683491710 -3600 # Sun May 07 21:35:10 2023 +0100 # Node ID e1ec9971da677b763c7576c729576d6f906631ae # Parent b71e69247483631bd8fc79a47cc32b762625b1fb Asynchronous close event handling for single peer upstreams Prevents additional

[PATCH] Asynchronous close event handling for single peer upstreams

Hello, resubmitting with the changes suggested. # HG changeset patch # User jordanc.car...@outlook.com # Date 1681067934 -3600 # Sun Apr 09 20:18:54 2023 +0100 # Node ID c8dcf584b36505e42bd2ea2965c1020069adb677 # Parent 5f1d05a21287ba0290dd3a17ad501595b442a194 Asynchronous close event handl

Re: [PATCH] Added keepalive_async_fails command

Maxim Dounin wrote: Hello! On Sun, Apr 02, 2023 at 06:57:03PM +0100, J Carter wrote: I've also attached an example nginx.conf and test script that simulates the asynchronous close events. Two different test cases can be found within that, one with path /1 for single peer upstream and /2 fo

Re: [PATCH] Added keepalive_async_fails command

re-sending the patch as an attachment as the formatting is still weird, and fixed typo I spotted.. On 02/04/2023 18:57, J Carter wrote: Hello, I've also attached an example nginx.conf and test script that simulates the asynchronous close events. Two different test cases can be found w

[PATCH] Added keepalive_async_fails command

Hello, I've also attached an example nginx.conf and test script that simulates the asynchronous close events. Two different test cases can be found within that, one with path /1 for single peer upstream and /2 for multi-peer. You should see 2 upstream addresses repeated in a row per-upstream-s

Re: [PATCH 5 of 6] Upstream: allow any worker to resolve upstream servers

On 09/02/2023 16:45, Aleksei Bavshin wrote: On 2/5/2023 7:01 PM, J Carter wrote: Hi Aleksei, Why not permanently assign the task of resolving a given upstream server group (all servers/peers within it) to a single worker? It seems that this approach would resolve the SRV issues, and remove

Re: [PATCH 5 of 6] Upstream: allow any worker to resolve upstream servers

Hi Aleksei, Why not permanently assign the task of resolving a given upstream server group (all servers/peers within it) to a single worker? It seems that this approach would resolve the SRV issues, and remove the need for the shared queue of tasks. The load would still be spread evenly for

Re: [PATCH] Added dark mode support to error pages - request in ticket #2434

Adding the patch file, as something is messing with the formatting of the patches in email body.. On 28/01/2023 23:15, J Carter wrote: Hello, An example of the dark mode and light mode pages is here https://imgur.com/a/n9QJpp4 # HG changeset patch # User jordanc.car...@outlook.com # Date

[PATCH] Added dark mode support to error pages - request in ticket #2434

Hello, An example of the dark mode and light mode pages is here https://imgur.com/a/n9QJpp4 # HG changeset patch # User jordanc.car...@outlook.com # Date 1674945436 0 # Sat Jan 28 22:37:16 2023 + # Branch dark-error # Node ID 0dcba21038765f6f03098cbdf23f401e89e3648f # Parent 07b0bee87f32be

Re: [PATCH] limit_req_status: allow status response to be as low as 200

It's trivial to do with error page OP as mentioned - an example:     limit_req_status 598;     limit_req_zone $binary_remote_addr zone=a:1m rate=1r/m;     server {     limit_req zone=a nodelay;     error_page 598 = @send-204;     location / {    ...     }     .

Re: [PATCH] Dynamic rate limiting for limit_req module

gx_http_compile_complex_value_t)); + +    ccv.cf = cf; +    ccv.value = &value[i]; +    ccv.complex_value = &ctx->cvr; + +    if (ngx_http_compile_complex_value(&ccv) != NGX_OK) { +    return NGX_CONF_ERROR; +    } + +    if (ctx-&g

Re: [PATCH] Dynamic rate limiting for limit_req module

Hello, Please find below my revised patch with style and code bug fixes included. The only change in behavior of note is that invalid rate values are now simply ignored in the same fashion an empty key is, and the use of the parsing of complex value being disabled if a non variable is used as

Re: [PATCH] Dynamic rate limiting for limit_req module

Hello, Thanks again for your reply and thoughts. On 02/01/2023 23:47, Maxim Dounin wrote: Hello! On Mon, Jan 02, 2023 at 06:21:03AM +, J Carter wrote: "The fundamental problem with dynamic rates in limit_req, which is a leaky bucket limiter, is that the rate is a property which ap

Re: [PATCH] Dynamic rate limiting for limit_req module

he shared memory, reducing the number of states which can be stored there? A persistent record of the rate that was last assigned to a given node/state is needed exclusively for expiring records (in the expire function). I don't believe this can be avoided, as the rate of the curren

[PATCH] Dynamic rate limiting for limit_req module

Hello, Please find below a patch to enable dynamic rate limiting for limit_req module. /* EXAMPLE-*/ geo $traffic_tier { defaultfree; 127.0.1.0/24 basic; 127.0.2.0/24 premium; } map $traffi