Re: Re: Http: protect prefix variable when add variable

2021-01-23 Thread Jim T
mdounin.ru> > Content-Type: text/plain; charset=us-ascii > > Hello! > > On Wed, Jan 20, 2021 at 07:59:50PM +0800, Jim T wrote: > > > Hello! > > > > There is a incident occur in our team, when we use auth_request_set like > > this in many server, and

Http: protect prefix variable when add variable

2021-01-20 Thread Jim T
Hello! There is a incident occur in our team, when we use auth_request_set like this in many server, and print $upstream_http_x_auth_request_email in log: server { listen 8080 reuseport; server_name test.io; location / { auth_request/oauth2/auth; aut

Re: Core: close pid file while writing it failed

2020-06-02 Thread Jim T
Hello, Maxim Dounin. How about below patch, could you help me review it? And I found the problem still exists in release-1.19.0, or do I miss anything? --- Hello! As far as I understand it, `ngx_create_pidfile` is a function that works independently. There is no action to close the pid file ex

Core: close pid file while writing it failed.

2020-05-21 Thread Jim T
Hello! As far as I understand it, `ngx_create_pidfile` is a function that works independently. There is no action to close the pid file externally, so we need to close the pid file when the writing it failed. There are also reports here https://github.com/nginx/nginx/pull/52. # HG changeset patch

Style(http/modules): fix the incorrect front spaces to unite style.

2020-05-19 Thread Jim T
Hello! Nginx is famous for code readability and neat code format. I use the tool( https://github.com/openresty/openresty-devel-utils) to try to unify the incorrect front spaces, Here is my attempt at http/modules. # HG changeset patch # User Jinhua Tan <312841...@qq.com> # Date 1589948645 -28800

Style(core): fix the incorrect front spaces to unite style.

2020-05-19 Thread Jim T
Hello! Nginx is famous for code readability and neat code format. I use the tool( https://github.com/openresty/openresty-devel-utils) to try to unify the incorrect front spaces, Here is my attempt at core. # HG changeset patch # User Jinhua Tan <312841...@qq.com> # Date 1589948492 -28800 # W

Upstream: jump out of unnecessary loop after matching the status code.

2020-05-13 Thread Jim T
Hi: In ngx_http_upstream_test_next, the loop will continue when the status is matched, and the ngx_http_upstream_next_errors is non-repeating. I think we can jump out of for the unnecessary loop, and here is my patch: # HG changeset patch # User Jinhua Tan <312841...@qq.com> # Date 1589378567 -28