Re: nginx tempfiles

2014-09-01 Thread Nick Kew
e to do > it properly, will likely result in your module being broken during > further nginx development. That's a risk with any patch, and surely applies even to your own uncommitted input-filtering patch? -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

nginx tempfiles

2014-08-28 Thread Nick Kew
f preparation required to set up a path and file before calling it. Will Bad Things happen if I simplify by using a system call like mkstemp and then just substitute file->fd in nginx's temp_file struct? Or is this approach completely barking up

Re: API inconsistencies

2013-11-25 Thread Nick Kew
arbitrary versions will have to deal with it case-by-case (in this instance, either API could apply to version 1005003)? -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

API inconsistencies

2013-11-25 Thread Nick Kew
//hg.nginx.org/nginx/rev/05ba5bce31e0 ). -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: 100-continue and 401

2013-03-19 Thread Nick Kew
s it sends the (chunked) response promised. > * HTTP error before end of send, stop sending > < > * Closing connection 0 … but the client thinks it didn't. Whoops! How much of those responses are being generated by your app? I'd expect the server to take care of protocol issues like the intermediate response and chunked encoding - unless your app disables it! -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

No handler of last resort?

2013-01-20 Thread Nick Kew
lter "/50x.html?" 2013/01/20 11:28:13 [debug] 11635#0: *7 http copy filter: "/50x.html?" 2013/01/20 11:28:13 [debug] 11635#0: *7 http copy filter: -5 "/50x.html?" 2013/01/20 11:28:13 [debug] 11635#0: *7 http finalize request: -5, "/50x.html?" a:1, c:3 2013/01/20 11:28:13 [debug] 11635#0: *7 content phase: 13 I expect I can deal with this in my module, but how come there's no handler of last resort that would prevent this happening? -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [feature] Add skip_location directive to ngx_http_rewrite

2013-01-17 Thread Nick Kew
ouldn't you prefer IF/ELSE/ENDIF with a similar structure to a Location block? -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: Filter insertion and ordering

2013-01-15 Thread Nick Kew
p for trouble that has just yet to bite? -- Nick Kew ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Filter insertion and ordering

2013-01-08 Thread Nick Kew
e its order in the chain? Its body filter needs to come before anything that might encode it (like compression or chunking), but the header filter should ideally come after those operations to see exactly what will be sent to the Client! How do I tak