Re: [PATCH] Contrib: vim syntax, support block region

2017-04-21 Thread OOO
/73d27510c0d7022384a611269af22ff01634c6d0/contrib/vim/syntax/nginx.vim#L19-L20 [2]:https://github.com/nginx/nginx/blob/73d27510c0d7022384a611269af22ff01634c6d0/contrib/vim/syntax/nginx.vim#L416 2017-04-19 23:10 GMT+08:00 Maxim Dounin : > Hello! > > On Wed, Apr 19, 2017 at 05:52:36PM +0800, OOO wrote: > >> Hi Dounin &

Re: [PATCH] Contrib: vim syntax, support block region

2017-04-19 Thread OOO
Hi Dounin I have looked into your POC. I use this approach in yajs.vim too. The major problem of this approach is: It creates (sort of) redundant syntax group. For the listen directive: > syn keyword ngxDirectiveImportantListen listen > \ nextgroup=@ngxListenParams skipwhite skipempty > syn m

Re: [PATCH] Contrib: vim syntax, support block region

2017-03-10 Thread OOO
No problem Just let me know when you reviewed. I can prepare some test case first. 2017-03-11 0:53 GMT+08:00 Maxim Dounin : > Hello! > > On Sat, Mar 11, 2017 at 12:43:54AM +0800, OOO wrote: > >> Do you have any idea about this implementation for ngxBlock. >> If you t

Re: [PATCH] Contrib: vim syntax, support block region

2017-03-10 Thread OOO
> hi link ngxVariableString PreProc > -hi link ngxBlock Normal > hi link ngxString String > +hi link ngxLocationOperator Operator > +hi link ngxLocationPath String > +hi link ngxLocationNamedLoc Identifier > > hi link ngxBoolean Boolean > hi link ngxDirectiveBlock Statement > hi link ngxDirectiveImportant Type > +hi link ngxDirectiveServer ngxDirectiveImportant > hi link ngxDirectiveControl Keyword > hi link ngxDirectiveError Constant > hi link ngxDirectiveDeprecated Error > hi link ngxDirective Identifier > hi link ngxDirectiveThirdParty Special > > hi link ngxListenOptions Keyword > hi link ngxMailProtocol Keyword -- OOO ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

2017-03-04 Thread OOO
r 03, 2017 at 11:37:36PM +0800, OOO wrote: > >> I made a sample and take screenshot[1]. >> This one (remove current ngxBlock) is a blocker for some other changes. >> >> [1]:https://www.flickr.com/photos/othree/32843758310/ > > Ah, ok, I see. The problem only happ

Re: [PATCH 4 of 4] Contrib: vim syntax, remove unecessary ngxBlock

2017-03-03 Thread OOO
nstead of focusing on the ad-hoc > solutions for some particular directives. And removing ngxBlock > looks like a step in the wrong direction to me, as it is a basic > concept of the configuration syntax. > > -- > Maxim Dounin > http://nginx.org/ > _

Re: [PATCH] Contrib: vim syntax, allow multiline config by skipempty

2017-03-02 Thread OOO
-syn keyword ngxDirective uwsgi_ssl_protocols nextgroup=ngxSSLProtocol > skipwhite > +syn keyword ngxDirective uwsgi_ssl_protocols nextgroup=ngxSSLProtocol > skipwhite skipempty > syn keyword ngxDirective uwsgi_ssl_server_name > syn keyword ngxDirective uwsgi_ssl_session_reuse > syn keyword n

Re: [PATCH] Contrib: vim syntax, update 3rd party module directives

2017-03-01 Thread OOO
_ssl_protocols nextgroup=ngxSSLProtocol >> skipwhite skipempty >> syn keyword ngxDirective uwsgi_ssl_server_name >> syn keyword ngxDirective uwsgi_ssl_session_reuse >> syn keyword ngxDirective uwsgi_ssl_trusted_certificate >> syn keyword ngxDirective uwsgi_ssl_verify >> syn keyword ngxDirective uwsgi_ssl_verify_depth >> syn keyword ngxDirective uwsgi_store >> syn keyword ngxDirective uwsgi_store_access >> syn keyword ngxDirective uwsgi_string > > These changes look unrelated. > > [...] > > -- > Maxim Dounin > http://nginx.org/ > ___ > nginx-devel mailing list > nginx-devel@nginx.org > http://mailman.nginx.org/mailman/listinfo/nginx-devel -- OOO ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Contrib: vim syntax, update core module directives

2017-02-23 Thread OOO
xDirective uwsgi_send_timeout > +syn keyword ngxDirective uwsgi_ssl_certificate > +syn keyword ngxDirective uwsgi_ssl_certificate_key > syn keyword ngxDirective uwsgi_ssl_ciphers > syn keyword ngxDirective uwsgi_ssl_crl > syn keyword ngxDirective uwsgi_ssl_name > +syn keyword ngxDirective uwsgi_ssl_password_file > syn keyword ngxDirective uwsgi_ssl_protocols nextgroup=ngxSSLProtocol > skipwhite > syn keyword ngxDirective uwsgi_ssl_server_name > syn keyword ngxDirective uwsgi_ssl_session_reuse > syn keyword ngxDirective uwsgi_ssl_trusted_certificate > syn keyword ngxDirective uwsgi_ssl_verify > syn keyword ngxDirective uwsgi_ssl_verify_depth > syn keyword ngxDirective uwsgi_store > syn keyword ngxDirective uwsgi_store_access > @@ -547,16 +636,17 @@ syn keyword ngxDirective worker_threads > syn keyword ngxDirective working_directory > syn keyword ngxDirective xclient > syn keyword ngxDirective xml_entities > syn keyword ngxDirective xslt_last_modified > syn keyword ngxDirective xslt_param > syn keyword ngxDirective xslt_string_param > syn keyword ngxDirective xslt_stylesheet > syn keyword ngxDirective xslt_types > +syn keyword ngxDirective zone > > " 3rd party module list: > " http://wiki.nginx.org/Nginx3rdPartyModules > > " Accept Language Module <http://wiki.nginx.org/NginxAcceptLanguageModule> > " Parses the Accept-Language header and gives the most suitable locale from > a list of supported locales. > syn keyword ngxDirectiveThirdParty set_from_accept_language > -- OOO ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Contrib: vim syntax, listen option and SSL/Mail protocol keywords

2017-02-21 Thread OOO
t; listen unix:/tmp/foo'bar http2; > > It's probably minor enough to don't care, and existing string > matching can't handle this as well, but if you know a simple way > to fix it - it might worth fixing. > > -- > Maxim Dounin > http://nginx.org/ &g

Re: [PATCH] Contrib: update vim syntax script

2017-02-20 Thread OOO
from being highlighted, and there is > likely a better way to accomplish this. > > -- > Maxim Dounin > http://nginx.org/ > ___ > nginx-devel mailing list > nginx-devel@nginx.org > http://mailman.nginx.org/mailman/listinfo/nginx-devel -- OOO ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] Contrib: update vim syntax script

2017-02-20 Thread OOO
Hi 2017-02-20 22:39 GMT+08:00 Maxim Dounin : > Hello! > > On Mon, Feb 20, 2017 at 12:26:52PM +0800, OOO wrote: > >> The reason I send all changes in one patch is that >> I thought Vim syntax is very minor part of the entire repository. >> So I want to reduce commi

Re: [PATCH] Contrib: update vim syntax script

2017-02-19 Thread OOO
e more modules seems not active now. But I can't confirm which is not really deprecated. Or I can just modify syntax when I know what is deprecated by user report. 2017-02-17 23:24 GMT+08:00 Maxim Dounin : > Hello! > > On Thu, Feb 16, 2017 at 11:57:35PM +0800, OOO wrote: > >> H

[PATCH] Contrib: update vim syntax script

2017-02-16 Thread OOO
Hi This patch improves vim syntax file for nginx conf. Major changes: * Fix regexp in string might breaks location ngxBlock * Use syntax iskeyword instead of modify real Vim iskeyword (new Vim feature, can avoid change user behavior) * Update keywords, based on document[1][2] * Add/Update all 3r

Re: [PATCH] Contrib: update vim syntax script

2016-03-07 Thread OOO
://www.flickr.com/photos/othree/25580381505/ https://www.flickr.com/photos/othree/25461861942/ 2016-03-07 17:30 GMT+08:00 OOO : > # HG changeset patch > # User Kao, Wei-Ko(othree) > # Date 1457339778 -28800 > # Mon Mar 07 16:36:18 2016 +0800

[PATCH] Contrib: update vim syntax script

2016-03-07 Thread OOO
# HG changeset patch # User Kao, Wei-Ko(othree) # Date 1457339778 -28800 # Mon Mar 07 16:36:18 2016 +0800 # Node ID e0cfa435fe182f1533ae8c7a4eb5ee398dc83c4e # Parent c5f81dcf97a79576138917501c9a6cc6f53ee930 Update vim syntax file Updates including: * Fix regexp in string might breaks locati

Re: [PATCH] Contrib: removed ngxBlock syntax group

2016-03-03 Thread OOO
llo! > > On Fri, Mar 04, 2016 at 11:23:40AM +0800, OOO wrote: > > > My change made `location` and other `ngxDirectiveBlock` are same as other > > directive. > > So the issue appear on `ngxDirectiveBlock` groups also. > > So the problem started to manifest itself

Re: [PATCH] Contrib: removed ngxBlock syntax group

2016-03-03 Thread OOO
brotli and maybe njs module. So I will send another patch. [1]:https://github.com/nginx/nginx/blob/master/conf/uwsgi_params 2016-03-04 1:48 GMT+08:00 Maxim Dounin : > Hello! > > On Thu, Mar 03, 2016 at 11:21:51PM +0800, OOO wrote: > > > More info about this patch. > &

Re: [PATCH] Contrib: removed ngxBlock syntax group

2016-03-03 Thread OOO
have both correct syntax and debug feature. Will lead to more complete syntax definition. And will be slower. 2016-03-03 23:11 GMT+08:00 OOO : > # HG changeset patch > # User Kao, Wei-Ko(othree) > # Date 1457016287 -28800 > # Thu Mar 03 22:44:47 2016

[PATCH] Contrib: removed ngxBlock syntax group

2016-03-03 Thread OOO
iveImportant include syn keyword ngxDirectiveImportant root @@ -819,9 +817,7 @@ hi link ngxComment Comment hi link ngxVariable Identifier -hi link ngxVariableBlock Identifier hi link ngxVariableString PreProc -hi link ngxBlock Normal hi link ngxString String hi link ngxBoolean Boolean -- OO