[PATCH] Core: Added comment for ngx_create_pool

2016-03-08 Thread tolga ceylan
# HG changeset patch # User Tolga Ceylan # Date 1457487679 28800 # Tue Mar 08 17:41:19 2016 -0800 # Node ID 5b9659f40da1e685c5b78f04a1c031ef597b410d # Parent c5f81dcf97a79576138917501c9a6cc6f53ee930 Core: Added comment for ngx_create_pool Pool size must be at least 16-bytes aligned (the

[PATCH] Core: ngx_palloc after alignment boundary check

2016-03-08 Thread tolga ceylan
# HG changeset patch # User Tolga Ceylan # Date 1457477267 28800 # Tue Mar 08 14:47:47 2016 -0800 # Node ID 44c90f64f3eec25cdf2e5bee13419cb71e9cdf93 # Parent c5f81dcf97a79576138917501c9a6cc6f53ee930 Core: ngx_palloc after alignment boundary check Alignment macro can move the current

Re: [PATCH] Upstream: Add "before_send" option to the 'proxy_next_upstream'.

2016-02-22 Thread Tolga Ceylan
ot;request_body_no_buffering" seems to be flag to manage early/buffered reads and I can't determine why it's relevant at all here. In other words, instead of this patch, shouldn't we modify that line as below? > || u->request_sent Regards, Tolga Ceylan ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: proxy_next_upstream default

2015-12-23 Thread Tolga Ceylan
eam.c#l3811 > > (note that the value of the directive isn't checked in this code path) > > Thanks Valentin, I see it now. Regards, Tolga Ceylan ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

proxy_next_upstream default

2015-12-22 Thread Tolga Ceylan
merged/set: https://github.com/nginx/nginx/blob/master/src/http/modules/ngx_http_proxy_module.c#L3065 This means documentation is incorrect, so if "invalid_header" is not specified, nginx will not consider such cases as "unsuccessful" attempts, right? R

Re: [nginx] upstream keepalive recv MSG_PEEK check

2015-09-28 Thread Tolga Ceylan
On Mon, Sep 28, 2015 at 1:13 PM, Maxim Dounin wrote: > > Detailed explanation and a test case can be found here: > > http://mdounin.ru/hg/ngx_http_upstream_keepalive/rev/9a4ee6fe1c6d > Thank you for the quick response. Regards, Tolga Ceylan __

[nginx] upstream keepalive recv MSG_PEEK check

2015-09-28 Thread Tolga Ceylan
ther words, in ngx_http_upstream_keepalive_close_handler, can't we skip the recv() check and proceed to close? Or do these spurious wake ups occur in non-epoll platforms? Regards, Tolga Ceylan ___ nginx-devel mailing list nginx-devel

Re: ngx_execute_proc

2015-08-24 Thread Tolga Ceylan
On Sun, Aug 23, 2015 at 11:38 AM, Ricardo Iramar dos Santos wrote: > Hi Tolga, thanks a lot for your replay! :) > > Searching on the source code I found that ngx_execute_proc() has been > declared and invoked inside src/os/unix/ngx_process.c. > > ricardo@matrix:~/Documents/nginx-1.9.3$ grep -ri ng

Re: ngx_execute_proc

2015-08-22 Thread Tolga Ceylan
On Sat, Aug 22, 2015 at 8:38 AM, Ricardo Iramar dos Santos wrote: > Hi All, > > This is my first post so take easy on me. :) > I'm doing a security research about HTTP(S) web servers and I'm trying > to understand a little bit of nginx source code. > In my research I need to understand how the fun