Re: [PATCH] Add io_uring support in AIO(async io) module

2021-08-25 Thread Mathew Heard
PM > To: nginx-devel@nginx.org > Subject: Re: [PATCH] Add io_uring support in AIO(async io) module > > Hello! > > On Sat, Feb 27, 2021 at 12:48:04PM +, Zhao, Ping wrote: > > > Yes, io_uring can help Nginx achieve same performance with lower > > resource cost. Th

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-08-25 Thread Zhao, Ping
ounin Sent: March 22, 2021 12:18PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hello! On Sat, Feb 27, 2021 at 12:48:04PM +, Zhao, Ping wrote: > Yes, io_uring can help Nginx achieve same performance with lower > resource cost. This is the key

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-03-22 Thread Maxim Dounin
Hello! On Sat, Feb 27, 2021 at 12:48:04PM +, Zhao, Ping wrote: > Yes, io_uring can help Nginx achieve same performance with lower > resource cost. This is the key improvement of io_uring I think. > It can't break through the HW limitation. Thanks for the patch and testing. Potentially thi

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-27 Thread Zhao, Ping
ruary 26, 2021 4:41 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, I created i3en.6xlarge instance, 2 SSDs with 250k iops each (in raid0) and reproduced your results. Please find dstat output below. 1 worker, io_uring: usr sys id

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-26 Thread Mikhail Isachenkov
62k, BW=2196MiB/s (2303MB/s)(10.0GiB/4663msec) BR, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Thursday, February 25, 2021 7:01 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, Looks like gene

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-25 Thread Zhao, Ping
PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, Looks like general-purpose AWS EC2 instances does not optimized to high random I/O even with NVMe SSD; I'll try to test it again on bare-metal, storage-optimized instance. How ma

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-25 Thread Mikhail Isachenkov
Regards, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Tuesday, February 9, 2021 9:31 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, Unfortunately, I still couldn't reproduce these

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-24 Thread Zhao, Ping
that disk read keeps at 250M/s, is there anything locked the disk io bw? Regards, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Tuesday, February 9, 2021 9:31 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io)

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-22 Thread Zhao, Ping
devel mailto:nginx-devel-boun...@nginx.org>> On Behalf Of Zhao, Ping Sent: Thursday, January 21, 2021 9:44 AM To: nginx-devel@nginx.org<mailto:nginx-devel@nginx.org> Subject: RE: [PATCH] Add io_uring support in AIO(async io) module Hi Vladimir, No special/extra configuration nee

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-21 Thread Zhao, Ping
g -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Monday, February 15, 2021 4:12 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, First of all, happy Chinese New Year! Yes, I've checked this fi

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-21 Thread Vadim Fedorenko
&& !ctx->directio; > > -----Original Message----- > From: nginx-devel On Behalf Of Zhao, Ping > Sent: Thursday, January 21, 2021 9:44 AM > To: nginx-devel@nginx.org > Subject: RE: [PATCH] Add io_uring support in AIO(async io) module > > Hi Vladimir, > > No sp

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-15 Thread Vadim Fedorenko
391#53391: io_uring_peek_cqe: START > > > > BR, > > Ping > > > > -Original Message- > > From: nginx-devel On Behalf Of Mikhail > Isachenkov > > Sent: Tuesday, February 9, 2021 9:31 PM > > To: nginx-devel@nginx.org > > Subject: Re: [PATCH]

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-15 Thread Mikhail Isachenkov
to see if any 'io_uring_peek_cqe' in the log: [debug] 53391#53391: io_uring_peek_cqe: START BR, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Tuesday, February 9, 2021 9:31 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-14 Thread Zhao, Ping
any 'io_uring_peek_cqe' in the log: [debug] 53391#53391: io_uring_peek_cqe: START BR, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Tuesday, February 9, 2021 9:31 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(asy

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-09 Thread Mikhail Isachenkov
his patch. BR, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Tuesday, February 9, 2021 1:17 AM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, First of all, thank you for pointing me to AWS patc

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-09 Thread Zhao, Ping
his patch. BR, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Tuesday, February 9, 2021 1:17 AM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, First of all, thank you for pointing me to AWS patch

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-08 Thread Mikhail Isachenkov
rom: Zhao, Ping Sent: Friday, February 5, 2021 2:43 PM To: nginx-devel@nginx.org Subject: RE: [PATCH] Add io_uring support in AIO(async io) module Hi Mikhail, Added 'sendfile on' & 'aio off' test result with previous table: Following is the test result with 100KB and 1MB: (4KB

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-06 Thread Zhao, Ping
: Friday, February 5, 2021 2:43 PM To: nginx-devel@nginx.org Subject: RE: [PATCH] Add io_uring support in AIO(async io) module Hi Mikhail, Added 'sendfile on' & 'aio off' test result with previous table: Following is the test result with 100KB and 1MB: (4KB to

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-04 Thread Zhao, Ping
250MB/s 900MB/s 2.0GB/s sendfile tbt900MB/s 1.6GB/s Regards, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Thursday, February 4, 2021 4:55 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-04 Thread Zhao, Ping
hursday, February 4, 2021 4:55 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi Zhao Ping, My test is much simpler than yours. I created /usr/local/html/(1...9) files on SSD (100 kb size) and wrote small lua script for wrk that adds 5 rando

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-04 Thread Mikhail Isachenkov
er possible cause is that "/usr/local/html/64746" was changed/removed when other user tried to read it. -Original Message- From: Zhao, Ping Sent: Thursday, February 4, 2021 10:33 AM To: nginx-devel@nginx.org Subject: RE: [PATCH] Add io_uring support in AIO(async io) module Hi Mikh

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-03 Thread Zhao, Ping
Another possible cause is that "/usr/local/html/64746" was changed/removed when other user tried to read it. -Original Message- From: Zhao, Ping Sent: Thursday, February 4, 2021 10:33 AM To: nginx-devel@nginx.org Subject: RE: [PATCH] Add io_uring support in AIO(async io)

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-02-03 Thread Zhao, Ping
11.11.11.1:8080" Which is fixed by my 2nd patch(Jan 25) already. BR, Ping -Original Message- From: nginx-devel On Behalf Of Mikhail Isachenkov Sent: Wednesday, February 3, 2021 10:11 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module Hi

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-02-03 Thread Mikhail Isachenkov
x->directio; -Original Message- From: nginx-devel On Behalf Of Zhao, Ping Sent: Thursday, January 21, 2021 9:44 AM To: nginx-devel@nginx.org Subject: RE: [PATCH] Add io_uring support in AIO(async io) module Hi Vladimir, No special/extra configuration needed, but need check if 'aio o

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-01-25 Thread Zhao, Ping
, January 21, 2021 9:44 AM To: nginx-devel@nginx.org Subject: RE: [PATCH] Add io_uring support in AIO(async io) module Hi Vladimir, No special/extra configuration needed, but need check if 'aio on' and 'sendfile off' is correctly set. This is my Nginx config for reference: u

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-01-20 Thread Zhao, Ping
l Message- From: nginx-devel On Behalf Of Vladimir Homutov Sent: Wednesday, January 20, 2021 12:43 AM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module On Tue, Jan 19, 2021 at 03:32:30AM +, Zhao, Ping wrote: > It depends on if disk io is the perfo

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-01-19 Thread Vladimir Homutov
On Tue, Jan 19, 2021 at 03:32:30AM +, Zhao, Ping wrote: > It depends on if disk io is the performance hot spot or not. If yes, > io_uring shows improvement than libaio. With 4KB/100KB length 1 Nginx > thread it's hard to see performance difference because iostat is only > around ~10MB/100MB per

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-01-18 Thread Zhao, Ping
devel On Behalf Of Vladimir Homutov Sent: Monday, January 18, 2021 10:11 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module 18.01.2021 11:24, Zhao, Ping пишет: > Hi Vladimir, > > I tested with response from 4KB to 1MB length which are ok. Th

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-01-18 Thread Vladimir Homutov
-Original Message- From: nginx-devel On Behalf Of Vladimir Homutov Sent: Monday, January 18, 2021 3:28 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module On Thu, Jan 14, 2021 at 05:53:17AM +, Zhao, Ping wrote: # HG changeset patch # User Ping Zha

RE: [PATCH] Add io_uring support in AIO(async io) module

2021-01-18 Thread Zhao, Ping
sendfile procedure, it provides another implementation of legacy libaio. Regards, Ping -Original Message- From: nginx-devel On Behalf Of Vladimir Homutov Sent: Monday, January 18, 2021 3:28 PM To: nginx-devel@nginx.org Subject: Re: [PATCH] Add io_uring support in AIO(async io) module On

Re: [PATCH] Add io_uring support in AIO(async io) module

2021-01-17 Thread Vladimir Homutov
On Thu, Jan 14, 2021 at 05:53:17AM +, Zhao, Ping wrote: > # HG changeset patch > # User Ping Zhao > # Date 1610554205 18000 > # Wed Jan 13 11:10:05 2021 -0500 > # Node ID 95886c3353dc80a3da215027c1e0f2141e47e911 > # Parent b055bb6ef87e49232a7fcb4e5334b8efda3b6499 > Add io_uring support i

[PATCH] Add io_uring support in AIO(async io) module

2021-01-13 Thread Zhao, Ping
# HG changeset patch # User Ping Zhao # Date 1610554205 18000 # Wed Jan 13 11:10:05 2021 -0500 # Node ID 95886c3353dc80a3da215027c1e0f2141e47e911 # Parent b055bb6ef87e49232a7fcb4e5334b8efda3b6499 Add io_uring support in AIO(async io) module. Hello, This is a patch to support io_uring in AIO