Re: [PATCH] Adds $orig_remote_addr in realip module

2015-06-26 Thread Valentin V. Bartenev
On Thursday 25 June 2015 14:51:15 Jon Nalley wrote: # HG changeset patch # User Jon Nalley c...@bluebot.org # Date 1435261685 18000 # Thu Jun 25 14:48:05 2015 -0500 # Node ID 894a268769bf9b3c806a9506ea1e8daf2dac3841 # Parent 6345822f0abb70807f635989b6c2df7852a55bd9 Adds

[PATCH] Adds $orig_remote_addr in realip module

2015-06-25 Thread Jon Nalley
# HG changeset patch # User Jon Nalley c...@bluebot.org # Date 1435261685 18000 # Thu Jun 25 14:48:05 2015 -0500 # Node ID 894a268769bf9b3c806a9506ea1e8daf2dac3841 # Parent 6345822f0abb70807f635989b6c2df7852a55bd9 Adds $orig_remote_addr in realip module When the realip module sets

Re: [PATCH] Adds $orig_remote_addr in realip module

2015-06-07 Thread Maxim Dounin
Hello! On Sat, Jun 06, 2015 at 08:46:07AM -0500, Jon Nalley wrote: Hi, I saw Ruslan's comments and responded (hoping to get a better understanding of the problem). http://mailman.nginx.org/pipermail/nginx-devel/2015-May/006974.html I had assumed that the issue with my prior patch was

Re: [PATCH] Adds $orig_remote_addr in realip module

2015-06-06 Thread Maxim Dounin
Hello! On Fri, Jun 05, 2015 at 10:18:52PM -0500, Jon Nalley wrote: # HG changeset patch # User Jon Nalley c...@bluebot.org # Date 1433560679 18000 # Fri Jun 05 22:17:59 2015 -0500 # Node ID b7c07ccca1f9be7038379cfd1077fb5885b3f388 # Parent 62869a9b2e7d1b2b698cb1ca67ad664b37171113

Re: [PATCH] Adds $orig_remote_addr in realip module

2015-06-06 Thread Jon Nalley
Hi, I saw Ruslan's comments and responded (hoping to get a better understanding of the problem). http://mailman.nginx.org/pipermail/nginx-devel/2015-May/006974.html I had assumed that the issue with my prior patch was assigning the pointer from the context rather than copying the data.

[PATCH] Adds $orig_remote_addr in realip module

2015-06-05 Thread Jon Nalley
# HG changeset patch # User Jon Nalley c...@bluebot.org # Date 1433560679 18000 # Fri Jun 05 22:17:59 2015 -0500 # Node ID b7c07ccca1f9be7038379cfd1077fb5885b3f388 # Parent 62869a9b2e7d1b2b698cb1ca67ad664b37171113 Adds $orig_remote_addr in realip module. When the realip module sets

Re: [PATCH] Adds $orig_remote_addr in realip module

2015-05-30 Thread Jon Nalley
Thanks, I didn't realize the contexts were cleared. It should be ok to copy the context data correct? e.g. v-data = ngx_pnalloc(r-pool, ctx-addr_text.len); ngx_memcpy(v-data, ctx-addr_text.data, ctx-addr_text.len); Or is it unsafe to reference the context at all in the handler?

[PATCH] Adds $orig_remote_addr in realip module

2015-05-28 Thread Jon Nalley
# HG changeset patch # User Jon Nalley c...@bluebot.org # Date 1432848566 18000 # Thu May 28 16:29:26 2015 -0500 # Node ID 4e59c130d468ee6757b5ba97f912b6c72c3f7c0d # Parent 0a096e2e51fcbb536007d94bf3edfc308e214f56 Adds $orig_remote_addr in realip module. When the realip module sets

Re: [PATCH] Adds $orig_remote_addr in realip module

2015-05-28 Thread Ruslan Ermilov
On Thu, May 28, 2015 at 04:39:08PM -0500, Jon Nalley wrote: # HG changeset patch # User Jon Nalley c...@bluebot.org # Date 1432848566 18000 # Thu May 28 16:29:26 2015 -0500 # Node ID 4e59c130d468ee6757b5ba97f912b6c72c3f7c0d # Parent 0a096e2e51fcbb536007d94bf3edfc308e214f56 Adds