Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hey Maxim, On Thu, Jun 30, 2016 at 12:52 PM, Piotr Sikora wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1467064812 25200 > # Mon Jun 27 15:00:12 2016 -0700 > # Node ID 33d0b463aa3484428a30d838f6c58d8fe717746b > # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 > Configure: d

[PATCH] Configure: don't test alternatives if preferred feature is found

# HG changeset patch # User Piotr Sikora # Date 1467064812 25200 # Mon Jun 27 15:00:12 2016 -0700 # Node ID 33d0b463aa3484428a30d838f6c58d8fe717746b # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 Configure: don't test alternatives if preferred feature is found. Signed-off-by: Piotr Sikor

[PATCH] Configure: don't test alternatives if preferred feature is found

# HG changeset patch # User Piotr Sikora # Date 1467064812 25200 # Mon Jun 27 15:00:12 2016 -0700 # Node ID 4dd0a17ea347f936d81236168bd33288e15fa782 # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 Configure: don't test alternatives if preferred feature is found. Signed-off-by: Piotr Sikor

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hey Maxim, > This looks like a mismerge, as previous tests is about > IP_BIND_ADDRESS_NO_PORT (it is probably misplaced though). Yeah, IP_BIND_ADDRESS_NO_PORT was added in the middle of NGX_HAVE_TRANSPARENT_PROXY checks after I already wrote those changes and I didn't catch the mis-merge. Good c

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hello! On Tue, Jun 28, 2016 at 03:28:31PM -0700, Piotr Sikora wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1467064812 25200 > # Mon Jun 27 15:00:12 2016 -0700 > # Node ID 9e0d65eda7fa016c0aebddf898d6f3f5834351f1 > # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 > Configur

[PATCH] Configure: don't test alternatives if preferred feature is found

# HG changeset patch # User Piotr Sikora # Date 1467064812 25200 # Mon Jun 27 15:00:12 2016 -0700 # Node ID 9e0d65eda7fa016c0aebddf898d6f3f5834351f1 # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 Configure: don't test alternatives if preferred feature is found. Signed-off-by: Piotr Sikor

[PATCH] Configure: don't test alternatives if preferred feature is found

# HG changeset patch # User Piotr Sikora # Date 1467064812 25200 # Mon Jun 27 15:00:12 2016 -0700 # Node ID d1974e5bf34e45539bd2a4b3d08924fd3ed01639 # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 Configure: don't test alternatives if preferred feature is found. While there, remove unused

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hey Maxim, > There was at least one attempt to introduce a code using both > fcntl(F_READAHEAD) and posix_fadvise() depending on a > configuration. And I don't think this should be prevented at > configure stage. This code isn't part of current NGINX codebase, so it's a moot point. Once fallbac

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hey Ruslan, > So far I have mixed feelings about this patch, but if it gets > accepted then the compile-time condition for ngx_read_ahead() > in src/os/unix/ngx_files.c can be simplified to only test > NGX_HAVE_POSIX_FADVISE. Also, there is the currently unused > macro NGX_HAVE_READ_AHEAD. Good

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hello! On Tue, Jun 28, 2016 at 03:54:34PM +0300, Ruslan Ermilov wrote: > Hi Piotr, > > On Mon, Jun 27, 2016 at 07:55:17PM -0700, Piotr Sikora wrote: > > # HG changeset patch > > # User Piotr Sikora > > # Date 1467064812 25200 > > # Mon Jun 27 15:00:12 2016 -0700 > > # Node ID e4375e338d9ac

Re: [PATCH] Configure: don't test alternatives if preferred feature is found

Hi Piotr, On Mon, Jun 27, 2016 at 07:55:17PM -0700, Piotr Sikora wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1467064812 25200 > # Mon Jun 27 15:00:12 2016 -0700 > # Node ID e4375e338d9acf927ffdc4cd18c704bb7ea1fd4e > # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 > Config

[PATCH] Configure: don't test alternatives if preferred feature is found

# HG changeset patch # User Piotr Sikora # Date 1467064812 25200 # Mon Jun 27 15:00:12 2016 -0700 # Node ID e4375e338d9acf927ffdc4cd18c704bb7ea1fd4e # Parent d452cb27639f714bc43b7f3ede417e3e7f8efdd6 Configure: don't test alternatives if preferred feature is found. Signed-off-by: Piotr Sikor