Re: [PATCH] Contrib: vim syntax, support block region

2017-04-21 Thread Maxim Dounin
Hello! On Fri, Apr 21, 2017 at 04:39:03PM +0800, OOO wrote: > Actually nginx.vim supports on and off[1] before. > And some option also been highlighted because there are directives > with the same name, ex: ssl. > So if we complete remove this. > It will looks like the function is missing. Yes,

Re: [PATCH] Contrib: vim syntax, support block region

2017-04-21 Thread OOO
Actually nginx.vim supports on and off[1] before. And some option also been highlighted because there are directives with the same name, ex: ssl. So if we complete remove this. It will looks like the function is missing. [1]:https://github.com/nginx/nginx/blob/73d27510c0d7022384a611269af22ff01634c

Re: [PATCH] Contrib: vim syntax, support block region

2017-04-19 Thread Maxim Dounin
Hello! On Wed, Apr 19, 2017 at 05:52:36PM +0800, OOO wrote: > Hi Dounin > > I have looked into your POC. > I use this approach in yajs.vim too. > The major problem of this approach is: It creates (sort of) redundant > syntax group. > For the listen directive: > > > syn keyword ngxDirectiveImpor

Re: [PATCH] Contrib: vim syntax, support block region

2017-04-19 Thread OOO
Hi Dounin I have looked into your POC. I use this approach in yajs.vim too. The major problem of this approach is: It creates (sort of) redundant syntax group. For the listen directive: > syn keyword ngxDirectiveImportantListen listen > \ nextgroup=@ngxListenParams skipwhite skipempty > syn m

Re: [PATCH] Contrib: vim syntax, support block region

2017-03-10 Thread OOO
No problem Just let me know when you reviewed. I can prepare some test case first. 2017-03-11 0:53 GMT+08:00 Maxim Dounin : > Hello! > > On Sat, Mar 11, 2017 at 12:43:54AM +0800, OOO wrote: > >> Do you have any idea about this implementation for ngxBlock. >> If you think this approach is ok. >> I

Re: [PATCH] Contrib: vim syntax, support block region

2017-03-10 Thread Maxim Dounin
Hello! On Sat, Mar 11, 2017 at 12:43:54AM +0800, OOO wrote: > Do you have any idea about this implementation for ngxBlock. > If you think this approach is ok. > I will keep going in this direction. > And send more robust(maybe) patch later. Sorry, I wasn't able to look into it yet. It is marked

Re: [PATCH] Contrib: vim syntax, support block region

2017-03-10 Thread OOO
Hi Dounin Do you have any idea about this implementation for ngxBlock. If you think this approach is ok. I will keep going in this direction. And send more robust(maybe) patch later. 2017-03-04 19:59 GMT+08:00 othree : > # HG changeset patch > # User othree > # Date 1488628696 -28800 > #

[PATCH] Contrib: vim syntax, support block region

2017-03-04 Thread othree
# HG changeset patch # User othree # Date 1488628696 -28800 # Sat Mar 04 19:58:16 2017 +0800 # Node ID a244d5f635ebf90cd30c42f826810b9bf5d53f3c # Parent 7fca6f60d5cafa0127b5bc4d6b74fcd06ab532a3 Contrib: vim syntax, support block region. diff --git a/contrib/vim/syntax/nginx.vim b/contrib/vi