Re: [PATCH] Core: remove unused FIOASYNC.

2018-07-11 Thread Ruslan Ermilov
On Sun, Jul 08, 2018 at 11:36:45PM -0700, Ian Gudger wrote: > Any update on this? The original idea with SIGIO is to wake up master process from sigsuspend() when the message channel is ready for I/O. This feature is currently de-facto unused because if message writing fails, the message is lost

Re: [PATCH] Core: remove unused FIOASYNC.

2018-07-09 Thread Ian Gudger via nginx-devel
Any update on this? On Thu, Jun 28, 2018 at 4:47 AM Ruslan Ermilov wrote: > > On Thu, Jun 28, 2018 at 12:27:40PM +0300, Ruslan Ermilov wrote: > > On Wed, Jun 27, 2018 at 01:40:26PM -0700, Ian Gudger wrote: > > > Sorry, I understand now. > > > > > > Here is a new patch which removes that too: > >

Re: [PATCH] Core: remove unused FIOASYNC.

2018-06-28 Thread Ruslan Ermilov
On Thu, Jun 28, 2018 at 12:27:40PM +0300, Ruslan Ermilov wrote: > On Wed, Jun 27, 2018 at 01:40:26PM -0700, Ian Gudger wrote: > > Sorry, I understand now. > > > > Here is a new patch which removes that too: > > > > # HG changeset patch > > # User Ian Gudger > > # Date 1529449008 25200 > > #

Re: [PATCH] Core: remove unused FIOASYNC.

2018-06-28 Thread Ruslan Ermilov
On Wed, Jun 27, 2018 at 01:40:26PM -0700, Ian Gudger wrote: > Sorry, I understand now. > > Here is a new patch which removes that too: > > # HG changeset patch > # User Ian Gudger > # Date 1529449008 25200 > # Tue Jun 19 15:56:48 2018 -0700 > # Node ID

Re: [PATCH] Core: remove unused FIOASYNC.

2018-06-27 Thread Ian Gudger via nginx-devel
Sorry, I understand now. Here is a new patch which removes that too: # HG changeset patch # User Ian Gudger # Date 1529449008 25200 # Tue Jun 19 15:56:48 2018 -0700 # Node ID 8fd0b85081a1cb91fa4495258bb5f9d3a6ef5785 # Parent 118885f7a5774962f1145693d9c26a4c199ca6ea Core: remove FIOASYNC

Re: [PATCH] Core: remove unused FIOASYNC.

2018-06-27 Thread Ruslan Ermilov
On Wed, Jun 27, 2018 at 10:09:47AM -0700, Ian Gudger wrote: > Actually, as far as I can tell, it never did anything other than cause > signals to be delivered that were promptly ignored. It appears to have > been added in eaf1f651cf86. I came to the same conclusion, but I'll double check with

Re: [PATCH] Core: remove unused FIOASYNC.

2018-06-27 Thread Ian Gudger via nginx-devel
Actually, as far as I can tell, it never did anything other than cause signals to be delivered that were promptly ignored. It appears to have been added in eaf1f651cf86. There are two things in ngx_master_process_cycle() with names related to SIGIO. One is adding SIGIO to the set. That is removed

Re: [PATCH] Core: remove unused FIOASYNC.

2018-06-27 Thread Ruslan Ermilov
On Mon, Jun 25, 2018 at 11:16:12AM -0700, Ian Gudger via nginx-devel wrote: > # HG changeset patch > # User Ian Gudger > # Date 1529449008 25200 > # Tue Jun 19 15:56:48 2018 -0700 > # Node ID 9427538acbc50142afbe91a11a1d4f907a00d257 > # Parent 118885f7a5774962f1145693d9c26a4c199ca6ea >

[PATCH] Core: remove unused FIOASYNC.

2018-06-25 Thread Ian Gudger via nginx-devel
# HG changeset patch # User Ian Gudger # Date 1529449008 25200 # Tue Jun 19 15:56:48 2018 -0700 # Node ID 9427538acbc50142afbe91a11a1d4f907a00d257 # Parent 118885f7a5774962f1145693d9c26a4c199ca6ea Core: remove unused FIOASYNC. FIOASYNC, F_SETOWN and SIGIO seem to no longer serve any