Re: [PATCH] HTTP/2: add debug logging of pseudo-headers and cookies

On Monday 29 May 2017 20:26:50 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > +h = ngx_list_push(>headers_in.headers); > > +if (h == NULL) { > > +return ngx_http_v2_connection_error(h2c, > > NGX_HTTP_V2_INTERNAL_ERROR); > > This needs to wrap, since the

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers and cookies

Hey Valentin, > +h = ngx_list_push(>headers_in.headers); > +if (h == NULL) { > +return ngx_http_v2_connection_error(h2c, > NGX_HTTP_V2_INTERNAL_ERROR); This needs to wrap, since the line is too long. Otherwise, looks good, thanks! Best regards, Piotr Sikora

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers and cookies

On Monday 24 April 2017 15:58:46 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516711 25200 > # Sun Mar 26 01:25:11 2017 -0700 > # Node ID 164b95f24f414359c5b8045415da3de82653c4db > # Parent

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers

Hey Valentin, > I think that pseudo-headers have different processing and shouldn't be > a part of the same block as normal http headers. That's why I prefer > the second variant: > > http2 pseudo-header: ":method: GET" Fair enough, patch updated. Best regards, Piotr Sikora

[PATCH] HTTP/2: add debug logging of pseudo-headers and cookies

# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 164b95f24f414359c5b8045415da3de82653c4db # Parent 2c4dbcd6f2e4c9c2a1eb8dc1f0d39c99975ae208 HTTP/2: add debug logging of pseudo-headers and cookies.

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers

On Friday 07 April 2017 14:40:18 Piotr Sikora via nginx-devel wrote: > Hey Valentin, > > > Maybe "http2 pseudo-header: \":%V: %V\""? > > Because it doesn't look like a valid "http header". > > I was going back and forth between different versions, but I ended up > using "http header", which

[PATCH] HTTP/2: add debug logging of pseudo-headers and cookies

# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 7e98d1dbb9ffc83a4ae621e05f8ebdc23fdf3b70 # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add debug logging of pseudo-headers and cookies.

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers

Hey Valentin, > Maybe "http2 pseudo-header: \":%V: %V\""? > Because it doesn't look like a valid "http header". I was going back and forth between different versions, but I ended up using "http header", which matches rest of the headers and has the same alignment, because then pseudo-headers

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers

On Monday 03 April 2017 20:13:34 Piotr Sikora via nginx-devel wrote: > # HG changeset patch > # User Piotr Sikora > # Date 1490516711 25200 > # Sun Mar 26 01:25:11 2017 -0700 > # Node ID 3d72ae17c41990774721a678c50b8307ecb684c8 > # Parent

Re: [PATCH] HTTP/2: add debug logging of pseudo-headers and control frames

Hey, > # HG changeset patch > # User Piotr Sikora > # Date 1490516711 25200 > # Sun Mar 26 01:25:11 2017 -0700 > # Node ID 6990fb6463ce47705e06ff6d0fbd9ae6696aeb37 > # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 > HTTP/2: add debug logging of pseudo-headers and

[PATCH] HTTP/2: add debug logging of pseudo-headers

# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 3d72ae17c41990774721a678c50b8307ecb684c8 # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add debug logging of pseudo-headers. Signed-off-by: Piotr

[PATCH] HTTP/2: add debug logging of pseudo-headers and control frames

# HG changeset patch # User Piotr Sikora # Date 1490516711 25200 # Sun Mar 26 01:25:11 2017 -0700 # Node ID 6990fb6463ce47705e06ff6d0fbd9ae6696aeb37 # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061 HTTP/2: add debug logging of pseudo-headers and control frames.