Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-11-10 Thread Maxim Dounin
Hello! On Thu, Nov 10, 2016 at 01:06:54AM +0100, Bjørnar Ness wrote: [...] > > Current question is: > > > > What "listen ... proxy_protocol" should mean in case of mail. In > > other modules, it just means that PROXY protocol header is parsed > > and appropriate variables are available for use.

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-11-09 Thread Bjørnar Ness
2016-11-10 0:52 GMT+01:00 Maxim Dounin : > Hello! > > On Wed, Nov 09, 2016 at 08:52:14PM +0100, Bjørnar Ness wrote: > >> On Nov 9, 2016 19:20, "Maxim Dounin" wrote: > > The implementation of PROXY protocol in nginx basically mimics > what is available via X-Forwarded-For in http. > > Extending it

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-11-09 Thread Maxim Dounin
Hello! On Wed, Nov 09, 2016 at 08:52:14PM +0100, Bjørnar Ness wrote: > On Nov 9, 2016 19:20, "Maxim Dounin" wrote: > > > > Hello! > > > > On Thu, Nov 03, 2016 at 08:37:04PM +0100, Bjørnar Ness wrote: > > > > > Maxim: what needs change to get this merged? Followup will be mail pp > > > support, w

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-11-09 Thread Bjørnar Ness
On Nov 9, 2016 19:20, "Maxim Dounin" wrote: > > Hello! > > On Thu, Nov 03, 2016 at 08:37:04PM +0100, Bjørnar Ness wrote: > > > Maxim: what needs change to get this merged? Followup will be mail pp > > support, which I saw a patch for today from somone else. > > If this was a question to me, then t

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-11-09 Thread Maxim Dounin
Hello! On Thu, Nov 03, 2016 at 08:37:04PM +0100, Bjørnar Ness wrote: > Maxim: what needs change to get this merged? Followup will be mail pp > support, which I saw a patch for today from somone else. If this was a question to me, then the answer is: I'm not convinced this should be merged. For

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-11-03 Thread Bjørnar Ness
Maxim: what needs change to get this merged? Followup will be mail pp support, which I saw a patch for today from somone else. ___ nginx-devel mailing list nginx-devel@nginx.org http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-09-20 Thread Bjørnar Ness
2016-09-20 17:18 GMT+02:00 Dmitry Volyntsev : > On 20.09.2016 15:50, Bjørnar Ness wrote: >> [ ... ] >> Also, I want access to the _dst part of the proxy protocol to make >> decisions based on the original destination address, which is >> currently unavailable. > > Why do you need to know the destin

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-09-20 Thread Dmitry Volyntsev
On 20.09.2016 15:50, Bjørnar Ness wrote: 2016-09-20 13:16 GMT+02:00 Dmitry Volyntsev : Could you please clarify what a problem are you trying to solve? Any real world scenario? Hello, Dmitry, thanks for responding. The first problem I am trying to solve is the case where we have: LB -> ngin

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-09-20 Thread Bjørnar Ness
2016-09-20 13:16 GMT+02:00 Dmitry Volyntsev : > Could you please clarify what a problem are you trying to solve? Any real > world scenario? Hello, Dmitry, thanks for responding. The first problem I am trying to solve is the case where we have: LB -> nginx_proxy -> (something_with_proxy_protocol_

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-09-20 Thread Dmitry Volyntsev
Could you please clarify what a problem are you trying to solve? Any real world scenario? http://nginx.org/en/docs/contributing_changes.html > Try to make it clear why the suggested change is needed, and provide a use case, if possible. On 18.09.2016 15:11, Bjørnar Ness wrote: Introduce prox

Re: [PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-09-19 Thread Bjørnar Ness
Came to my attention that i can be used uninitialized ((thanks, Johnny), so: diff --git a/src/core/ngx_proxy_protocol.c b/src/core/ngx_proxy_protocol.c index 04dae8b..21c710a 100644 --- a/src/core/ngx_proxy_protocol.c +++ b/src/core/ngx_proxy_protocol.c @@ -13,7 +13,7 @@ u_char * ngx_proxy_proto

[PATCH] proxy-protocol dst variables and proxy-proxy-protocol

2016-09-18 Thread Bjørnar Ness
Introduce proxy_protocol_src/dst_addr/port and store proxy_protocol header in ngx_connection struct. This enables proxy-proxy-protocol in stream module if proxy_protocol is enabled on both listen and outgoing, which should be the logical default. Work in progress if/when this patch is accepted is