Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread 洪志道
We can close the topic. I review the previous infos, and I have already got the answer. Thanks! 2017-03-09 20:53 GMT+08:00 洪志道 : > "First of all, we can set timeout zero if need to exit immediately." > > It's not a good idea. > > 2017-03-09 20:52 GMT+08:00 洪志道 : > >> I get it. >> >> Yep, we can

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread 洪志道
"First of all, we can set timeout zero if need to exit immediately." It's not a good idea. 2017-03-09 20:52 GMT+08:00 洪志道 : > I get it. > > Yep, we can do the cleanup work in exit process or pool cleanup when > expired time happened. > > I keep my opinion that it's useful and helpful if we set

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread 洪志道
I get it. Yep, we can do the cleanup work in exit process or pool cleanup when expired time happened. I keep my opinion that it's useful and helpful if we set *ngx_shutdown_event.cancelable = 0.* First of all, we can set timeout zero if need to exit immediately. The key point is whether we need

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread Maxim Dounin
Hello! On Thu, Mar 09, 2017 at 02:39:26PM +0800, 洪志道 wrote: [...] > "Cancelable timers are now preserved if there are other timers. There is no > need to cancel timers early if there are other timers blocking shutdown > anyway. Preserving such timers allows nginx to continue some periodic work >

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-09 Thread Maxim Dounin
Hello! On Wed, Mar 08, 2017 at 03:52:15PM +0800, 洪志道 wrote: > It's a good design. > It seems the worker process is not killed until expired, the time is set by > 'worker_shutdown_timeout'. > But I think ngx_shutdown_timer_handler will never be called, because of the > following deal. > >

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-08 Thread 洪志道
Hi, glad to see you here. "The directive configures a timeout to be used when gracefully shutting down worker processes. When the timer expires, nginx will try to close all the connections currently open to facilitate shutdown." Well, if the only purpose is to close all the connections those fiel

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-08 Thread Datong Sun via nginx-devel
Hello! Looks like to me that the original patch does what it's supposed to do (when combined with http://hg.nginx.org/nginx/rev/3069dd358ba2). Here is my understanding: Before this patch, an active connection could potentially delay shutdown indefinitely due to the presence of connection related

Re: [nginx] Introduced worker_shutdown_timeout.

2017-03-07 Thread 洪志道
Hi! It's a good design. It seems the worker process is not killed until expired, the time is set by 'worker_shutdown_timeout'. But I think ngx_shutdown_timer_handler will never be called, because of the following deal. if (ngx_exiting) { if (ngx_event_no_timers_left() == NGX_OK

[nginx] Introduced worker_shutdown_timeout.

2017-03-07 Thread Maxim Dounin
details: http://hg.nginx.org/nginx/rev/97c99bb43737 branches: changeset: 6930:97c99bb43737 user: Maxim Dounin date: Tue Mar 07 18:51:16 2017 +0300 description: Introduced worker_shutdown_timeout. The directive configures a timeout to be used when gracefully shutting down worker proc