Re: Error handling from filter modules

2015-10-19 Thread Steven Hartland
On 19/10/2015 17:59, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 06:15:30PM +0100, Steven Hartland wrote: On 16/10/2015 13:20, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 02:36:13AM +0100, Steven Hartland wrote: I'm making changes to a filter module and when it detected an

Re: Error handling from filter modules

2015-10-16 Thread Maxim Dounin
Hello! On Fri, Oct 16, 2015 at 03:16:23PM +0300, Roman Arutyunyan wrote: > > So the question is do filters have to manually call > > ngx_http_finalize_request(r, NGX_HTTP_INTERNAL_SERVER_ERROR); or is it > > expected that the upper layers should actually do the right thing and > > ensure the

Re: Error handling from filter modules

2015-10-16 Thread Roman Arutyunyan
Hello Steve, > On 16 Oct 2015, at 04:36, Steven Hartland > wrote: > > I'm making changes to a filter module Header filter or body filter? > and when it detected an error it > returned NGX_ERROR however the response generated to the client isn't > the expected

Error handling from filter modules

2015-10-15 Thread Steven Hartland
I'm making changes to a filter module and when it detected an error it returned NGX_ERROR however the response generated to the client isn't the expected 500 internal server error I would have expected given said return. So the question is do filters have to manually call