Re: [PATCH] Fix "$upstream_response_length" for upstream requests with buffering off

2013-04-11 Thread Maxim Dounin
Hello! On Wed, Apr 10, 2013 at 09:38:35PM -0700, Piotr Sikora wrote: > Hey, > the value of "$upstream_response_length" variable is being incorrectly > reported as "0" for upstream requests with buffering off. Looks like valid problem, thanks for reporting this. > diff -r 482fda984556 src/http/n

[nginx] svn commit: r5170 - trunk/src/http

2013-04-11 Thread pluknet
Author: pluknet Date: 2013-04-11 13:49:13 + (Thu, 11 Apr 2013) New Revision: 5170 URL: http://trac.nginx.org/nginx/changeset/5170/nginx Log: Upstream: fixed $upstream_response_length without buffering. Reported by Piotr Sikora. Modified: trunk/src/http/ngx_http_upstream.c Modified: trun

Re: [PATCH] Fix "$upstream_response_length" for upstream requests with buffering off

2013-04-11 Thread Piotr Sikora
Hey Maxim, > The patch is wrong as u->pipe might not exists at all, and the > code will result in null pointer dereference. Argh, I was actually looking yesterday whether this might be the case, but I didn't find a code path that would result in u->pipe not being allocated... It seems that I tota