API inconsistencies

2013-11-25 Thread Nick Kew
Is there a prescribed way for a module to deal with API changes to support both older and newer versions? I can use constructs like: /* Get the remote address */ #if OLDVERSION len = ngx_sock_ntop(conn->sockaddr, ... #else len = ngx_sock_ntop(conn->sockaddr, conn->socklen, … #endif B

Re: API inconsistencies

2013-11-25 Thread Ruslan Ermilov
On Mon, Nov 25, 2013 at 04:36:33PM +, Nick Kew wrote: > Is there a prescribed way for a module to deal with API changes > to support both older and newer versions? > > I can use constructs like: > > /* Get the remote address */ > #if OLDVERSION > len = ngx_sock_ntop(conn->sockaddr, ..

Re: API inconsistencies

2013-11-25 Thread Nick Kew
On 25 Nov 2013, at 16:46, Ruslan Ermilov wrote: > nginx_version in src/core/nginx.h. Thanks. Seems to be 1.5.3 at the time of that commit, so I guess the test I need is < 1005003 vs >= 1005003? But that presumably only works with release versions, so anyone compiling against arbitrary versions