Re: [Nmh-workers] Missing `/' in the result of m_mktemp2()

2010-12-14 Thread markus schnalke
[2010-12-14 22:41] markus schnalke > > A trivial hack to fix the problem is `126s/-1//' in sbr/m_mktemp.c. > But I have not clue if this solves the problem right, it just made > things work again for me. The hack fixes only part of the problem. Now ~/Mail fills with `mhbuildX' files and the

[Nmh-workers] Missing `/' in the result of m_mktemp2()

2010-12-14 Thread markus schnalke
Hoi, I was moving my newest, and personally modified, version of nmh to a different system. Now I encountered an error: mhbuild: unable to rename output /home/meillo/Mail/sendwvJV2J to /home/meillo/Mailmhbuild29ELnc: Invalid cross-device link The cross-device link error comes fr

Re: [Nmh-workers] git tree - 'inc -help' and 'inc -version' broken..

2010-12-14 Thread Oliver Kiddle
valdis.kletni...@vt.edu wrote: > Current -git tree: > % inc -help > inc: no mail to incorporate > % inc -version > inc: no mail to incorporate I've just checked in a fix for this. Problem was introduced with c0521048; that removed a pile of switches to inc and msgchk by removing lines such as the

Re: [Nmh-workers] about mhparam

2010-12-14 Thread Valdis . Kletnieks
On Tue, 14 Dec 2010 16:31:09 +0100, markus schnalke said: > I improved the man page in some ways; see attached patch. > > > I also spotted code that appears to be badly formated: > --- a/uip/mhparam.c > +++ b/uip/mhparam.c Something that has proven to be very useful over in the Linux kernel wor

[Nmh-workers] about folder_addmsg.c

2010-12-14 Thread markus schnalke
Hoi, Peter told me to test his changes to sbr/folder_addmsg.c some weeks ago. I had a look at the code and came to the conclusion that everything is fine with it. I also tested some corner-cases. I wanted to write an automated test but unfortunately it never came to happen. While digging through

Re: [Nmh-workers] about mhpath

2010-12-14 Thread markus schnalke
I also found some comments I added to the code because I was puzzled. It would be nice to have it explained by someone who knows the code. --- a/uip/mhpath.c Tue Nov 30 15:30:45 2010 -0300 +++ b/uip/mhpath.c Tue Dec 14 12:43:31 2010 -0300 @@ -97,6 +97,7 @@ * for all the message nu

[Nmh-workers] about mhpath

2010-12-14 Thread markus schnalke
Hoi, I'm not quite sure if I already told you about it; I hope not. Attached is a patch for man/mhpath.man which: - fixes a typo - makes two sentences more clear Then there is this sentence: Message numbers greater than the highest existing message in a folder as part of a range designa

[Nmh-workers] about mhparam

2010-12-14 Thread markus schnalke
Hoi, when I had a look at mhparam weeks ago I came about some stuff which I like to share. It's minor but better mentioned than forgotten. I improved the man page in some ways; see attached patch. I also spotted code that appears to be badly formated: --- a/uip/mhparam.c +++ b/uip/mhparam.c @@

[Nmh-workers] Will be offline soon

2010-12-14 Thread markus schnalke
Hoi, it's time to say goodbye. I will leave on Friday for three more month traveling. Now through Patagonia. :-) I will enjoy being far away from technology, at the end of the world. Hence you will hardly hear from me before April. My work on nmh in the last months had been some kind of internshi

Re: [Nmh-workers] unapplied patches

2010-12-14 Thread Jon Steinhart
> I've had a look through for any pending patches since the last release. > Mostly, this is Meillo's recent patches. Does anyone know of any further > patches that we might apply or rework. > > Eric Gillespie: scan message numbers from stdin > It looks like people were generally in favour in

[Nmh-workers] git tree - 'inc -help' and 'inc -version' broken..

2010-12-14 Thread Valdis . Kletnieks
Current -git tree: % inc -help inc: no mail to incorporate % inc -version inc: no mail to incorporate This used to work: % ~/src/nmh.hold/uip/inc -version inc -- nmh-1.2 [compiled on turing-police.cc.vt.edu at Tue Feb 19 18:35:11 EST 2008] % ~/src/nmh.hold/uip/inc -help Usage: inc [+folder] [sw

Re: [Nmh-workers] unapplied patches

2010-12-14 Thread Peter Maydell
markus schnalke wrote: >[2010-12-14 12:29] Oliver Kiddle >> Any objections if I apply those? Doesn't git have some ways to preserve >> details of the actual author of a patch? Or better still, could someone >> give Meillo permissions on the git repository. > >I don't need permissions now as I will

Re: [Nmh-workers] unapplied patches

2010-12-14 Thread markus schnalke
[2010-12-14 12:29] Oliver Kiddle > I've had a look through for any pending patches since the last release. > Mostly, this is Meillo's recent patches. Does anyone know of any further > patches that we might apply or rework. > undo of install-mh > Nobody would ever run an uninstall-mh script

Re: [Nmh-workers] unapplied patches

2010-12-14 Thread Oliver Kiddle
Peter Maydell wrote: > >undo of install-mh > What did you think of my proposed patch to the manpage? Telling people to do echo "${MH:-$HOME/.mh-profile}" Is not going to work for users of non-Bourne based shells. May be easier to just say that .mh_profile is in the home directory unless the MH e

Re: [Nmh-workers] unapplied patches

2010-12-14 Thread Peter Maydell
Oliver Kiddle wrote: >undo of install-mh > Nobody would ever run an uninstall-mh script and I doubt that the > person raising the bug was a user looking for it. Most software > creates a pile of dot files without even asking these days. If > any fix is necessary, I'd vote fo

[Nmh-workers] unapplied patches

2010-12-14 Thread Oliver Kiddle
I've had a look through for any pending patches since the last release. Mostly, this is Meillo's recent patches. Does anyone know of any further patches that we might apply or rework. Eric Gillespie: scan message numbers from stdin It looks like people were generally in favour in principle