Philipp wrote:
> [2023-08-27 09:29] David Levine
> >
> > My only comment on the code itself is that I prefer functions that
> > just do one thing. So I would implement a fold function that just
> > modifies a string, and leave the fprintf/fwrite to output_headers().
>
> I have thought about this
[2023-08-27 09:29] David Levine
> Philipp wrote:
>
> > Do you only test the patch or have you looked at the code? It would
> > be nice to get some feedback on the implementation.
>
> My only comment on the code itself is that I prefer functions that
> just do one thing. So I would implement a fol
I wrote:
> There is a bigger issue, however. output_headers() gets called by
> other code, such as mhfixmsg via output_message_fp(). So the change
> as-is interferes badly with it. I haven't looked for a better place
> to fold the header fiels, but we'll have to find one.
Alternatively, maybe
Philipp wrote:
> [2023-08-26 17:39] David Levine
> > Philipp wrote:
> >
> > > [2023-08-26 15:28] David Levine
> > > >
> > > > The NUL byte is output as \x00:
> > >
> > > I found the problem: The build in printf of dash don't write a NUL.
> > > Using printf from path to generate the test and expe
Philipp wrote:
> Do you only test the patch or have you looked at the code? It would
> be nice to get some feedback on the implementation.
My only comment on the code itself is that I prefer functions that
just do one thing. So I would implement a fold function that just
modifies a string, and l
[2023-08-26 17:42] David Levine
> Philipp wrote:
> I agree. I'm sending this message using your patch. I'd like to
> exercise it for a few days before committing.
No problem, take your time.
Do you only test the patch or have you looked at the code? It would
be nice to get some feedback on the
[2023-08-26 17:39] David Levine
> Philipp wrote:
>
> > [2023-08-26 15:28] David Levine
> > >
> > > The NUL byte is output as \x00:
> >
> > I found the problem: The build in printf of dash don't write a NUL.
> > Using printf from path to generate the test and expected file works as
> > expected.
>
