Re: [Nmh-workers] O_CLOEXEC

2014-11-12 Thread Lyndon Nerenberg
On Nov 12, 2014, at 6:29 AM, David Levine wrote: > As part of the audit, it would be really nice to wrap all open() > calls so we can take care of this in one place. We could then > easily autoconf check for O_CLOEXEC if desired. We wrap the > alloc family and that's been very helpful. POSIX

Re: [Nmh-workers] O_CLOEXEC

2014-11-12 Thread Earl Hood
On Wed, Nov 12, 2014 at 11:49 AM, David Levine wrote: > Good points. All the more reason to wrap the opens + fcntl(). Popping in real quick here, but if we are voting on this, I prefer the fcntl() route. I have a fairly old linux box that I still use nmh on. It is running a v2.4.20 linux kernel

Re: [Nmh-workers] O_CLOEXEC

2014-11-12 Thread David Levine
Ken wrote: > You know, if I had my druthers I'd rather just write the code to use > the older but more widely supported fcntl() call to set FD_CLOEXEC; > that would avoid an autoconf test and make Lyndon happier :-) Also, > it looks like O_CLOEXEC is not actually part of POSIX? There are > also a

Re: [Nmh-workers] O_CLOEXEC

2014-11-12 Thread Ken Hornstein
>As part of the audit, it would be really nice to wrap all open() >calls so we can take care of this in one place. We could then >easily autoconf check for O_CLOEXEC if desired. We wrap the >alloc family and that's been very helpful. You know, if I had my druthers I'd rather just write the code

[Nmh-workers] O_CLOEXEC

2014-11-12 Thread David Levine
Ken wrote: > ... yeah, I have to agree with you there. I think by now all library > calls that create file descriptors should be setting the close-on-exec > flag, right? That's been around forever. Although I'm not sure > O_CLOEXEC has been around forever, has it? I know the fcntl() > equivale