[Nmh-workers] hooks interface issues

2014-02-23 Thread belg4mit
I cannot get the hooks to work: inc: external hook ((null)) did not work properly. refile: external hook ((null)) did not work properly. Configured via .mh_profile: add-hook: /usr/local/bin/hook-test ref-hook: /usr/local/bin/hook-test /usr/local/bin/hook-test: #!/bin/sh echo "Hooked($

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Ken Hornstein
>Some other thoughts on the interface: > * The requirement that the hook handler be specified by > an absolute path is rather odd. The post-1.5 hook code has been converted over to the argsplit interface. So that shouldn't be necessary anymore. If you are using post-1.5 code ... well, I'll be h

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Jerrad Pierce
I am using 1.3, and the triggers only invoke with absolute paths. I have a master branch checkout of 1.5 from last March I've been trying, I did not check this particular issue but will take your word about it now accepting bare command names. The bigger problem of course is that nmh reports a fai

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread David Levine
> >Some other thoughts on the interface: > > * The requirement that the hook handler be specified by > > an absolute path is rather odd. > > The post-1.5 hook code has been converted over to the argsplit interface. > So that shouldn't be necessary anymore. Could the requirement be due to the ch

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Jerrad Pierce
>I cannot get the hooks to work: > inc: external hook ((null)) did not work properly. > refile: external hook ((null)) did not work properly. Although add-hook does not work for inc, nor does ref-hook for refile, I just noticed that add-hook successfully fires on Fcc*. I've also found add-hook w

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Ken Hornstein
>The bigger problem of course is that nmh reports a failure to >invoke the hook. It does not function in either version I have, >and so it would not seem to be a recent breakage, unless my >simple test is not doing something the hooks expect e.g; a >specific return value, although there don't seem

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Jerrad Pierce
>And, I have to ask ... 1.3? You're not the only person still using that, >so I'm wondering if I did something wrong, or you just haven't seen a reason >to upgrade yet. I'm running CentOS 5.9, so no package support. I downloaded master for mhfixmsg this past spring, one of the more compelling fea

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Ken Hornstein
>I cannot get the hooks to work: > inc: external hook ((null)) did not work properly. > refile: external hook ((null)) did not work properly. Alright, stupid question time. Did you not make hook-test executable? Because I did the exact same thing, and once I made the script executable it worked

Re: [Nmh-workers] hooks interface issues

2014-02-23 Thread Jerrad Pierce
Yes, executability was one of the first things I checked ;-) Note the most recent message where it does work correctly for Fcc and refile -link though... very odd ___ Nmh-workers mailing list Nmh-workers@nongnu.org https://lists.nongnu.org/mailman/listi

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Ken Hornstein
>Yes, executability was one of the first things I checked ;-) > >Note the most recent message where it does work correctly >for Fcc and refile -link though... very odd If you're willing to pull from master, I committed a change that will give you a useful error message. I will note that there is

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Jon Steinhart
Sorry to take so long to respond to stuff; had some important skiing to do. This code is 12 or 13 years old now so my memory probably has some holes. 1. I had thought that I had added the hook stuff to the documentation for mh_profile but I don't see it there. I'd be happy to add it. I have

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Jerrad Pierce
>1. I had thought that I had added the hook stuff to the documentation for >mh_profile but I don't see it there. I'd be happy to add it. I have mh_profile seems like a good place for this. There coudl also potentially be a cookbook somewhere on extending nmh, with references to this, Jerry'

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Ken Hornstein
>mh_profile seems like a good place for this. There coudl also >potentially be a cookbook somewhere on extending nmh, with references to >this, Jerry's book, contribs, GUIs, etc. Jerry's book is open source, and can be modified. Sigh .. so much documentation to do, so little time. >There's a non

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Jerrad Pierce
>>mh_profile seems like a good place for this. There coudl also >>potentially be a cookbook somewhere on extending nmh, with references to >>this, Jerry's book, contribs, GUIs, etc. >Jerry's book is open source, and can be modified. Indeed. >Sigh .. so much documentation to do, so little time. I

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Robert Elz
Date:Mon, 24 Feb 2014 11:07:24 -0500 From:Jerrad Pierce Message-ID: <20140224160724.b25344c...@db.pthbb.org> | I did not do anything in particular, I simply opened the file in emacs | and ammended it emacs is a sack of horse sh*t from another universe... There a

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Jerrad Pierce
del-hook is not called if rmmproc is set. This prevents the user from doing a number of useful things e.g; restoration of original message in MIME-hooks (see forthcoming message to list) I would expect the hook to be called before rmmproc is invoked, and not wrapped into the non-rmmproc fallback co

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Jerrad Pierce
FYI, it runs out slocal is handled (the + action uses rcsvstore). I missed this in preliminary testing because slocal is headless :-P ___ Nmh-workers mailing list Nmh-workers@nongnu.org https://lists.nongnu.org/mailman/listinfo/nmh-workers

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread David Levine
> When you say "the file was not new-line terminated", which file? If > it was your .mh_profile ... I guess that's the fault of m_getfld(). Good catch. Fixed. David ___ Nmh-workers mailing list Nmh-workers@nongnu.org https://lists.nongnu.org/mailman/

Re: [Nmh-workers] hooks interface issues

2014-02-24 Thread Bill Wohler
Ken Hornstein writes: >>mh_profile seems like a good place for this. There coudl also >>potentially be a cookbook somewhere on extending nmh, with references to >>this, Jerry's book, contribs, GUIs, etc. > > Jerry's book is open source, and can be modified. Sigh .. so much > documentation to do,

Re: [Nmh-workers] hooks interface issues

2014-02-25 Thread Ralph Corderoy
Hi David, > > When you say "the file was not new-line terminated", which file? If > > it was your .mh_profile ... I guess that's the fault of m_getfld(). > > Good catch. Fixed. My quick skim of http://git.savannah.gnu.org/cgit/nmh.git/commit/?id=a0514c9a6f41ea1b0d60553ca578312a9f3bd9ab&context

Re: [Nmh-workers] hooks interface issues

2014-02-25 Thread Christer Boräng
In message <20140225120259.d11791f...@orac.inputplus.co.uk>, Ralph Corderoy wri tes: >Any Emacs user that doesn't use `(setq require-final-newline t)' in >their .emacs or similar and has to suffer because of it has made their >bed... :-) The number of wasted hours I've seen over the years due to

Re: [Nmh-workers] hooks interface issues

2014-02-25 Thread David Levine
Ralph wrote: > My quick skim of > http://git.savannah.gnu.org/cgit/nmh.git/commit/?id=a0514c9a6f41ea1b0d60553ca > 578312a9f3bd9ab&context=12 > with the whole source at > http://git.savannah.gnu.org/cgit/nmh.git/tree/sbr/m_getfld.c?id=a0514c9a6f41e > a1b0d60553ca578312a9f3bd9ab#n620 > suggests that