Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-18 Thread Ben Noordhuis
On Thu, Oct 18, 2012 at 7:28 AM, Nathan Rajlich nat...@tootallnate.net wrote: Seriously I'm lost. Can somebody show me some sample code to demonstrate the problem? Here's the issue on the tracker btw: https://github.com/joyent/node/issues/4160 The bug is in the documentation, there's a

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-18 Thread Isaac Schlueter
Here's a proof that it works as intended: https://gist.github.com/3911308 On Thu, Oct 18, 2012 at 11:04 AM, Ben Noordhuis i...@bnoordhuis.nl wrote: On Thu, Oct 18, 2012 at 7:28 AM, Nathan Rajlich nat...@tootallnate.net wrote: Seriously I'm lost. Can somebody show me some sample code to

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-18 Thread Vitaly Puzrin
https://gist.github.com/3910923 Seems to work. Sorry for noise. четверг, 18 октября 2012 г., 9:34:23 UTC+4 пользователь Vitaly Puzrin написал: Yes, i can't quickly reproduce bug in my current enviroment. That's a bit strange. Need some time to ask people, who confirmed problem, and

[nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread mscdex
On Oct 17, 3:35 pm, Vitaly Puzrin vit...@rcdesign.ru wrote: But that can cause broken 2-bytes unicode chars. Calling setEncoding() does not helps. IMHO, that's not correct - if function returns string, that string should be valid. Why not use Buffers directly and either create a single buffer

[nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Vitaly Puzrin
This question is not about buffers. It's about strings. If official API says, that handler can operate with strings, i expect, those strings are always valid. среда, 17 октября 2012 г., 23:49:59 UTC+4 пользователь mscdex написал: On Oct 17, 3:35 pm, Vitaly Puzrin vit...@rcdesign.ru wrote:

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Matt
On Wed, Oct 17, 2012 at 4:01 PM, Vitaly Puzrin vit...@rcdesign.ru wrote: This question is not about buffers. It's about strings. If official API says, that handler can operate with strings, i expect, those strings are always valid. Then your expectations are too high. Internally it deals

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Vitaly Puzrin
Do you really think, that eхpectiotion to get correct strings instead of crap from official API is too high :) ? Returning strings is officially documented feature. It sould work correctly, or should be removed, to not confuse people. As i said, 99% examples in internet about joining node

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Ben Noordhuis
On Wed, Oct 17, 2012 at 11:04 PM, Vitaly Puzrin vit...@rcdesign.ru wrote: Do you really think, that eхpectiotion to get correct strings instead of crap from official API is too high :) ? Returning strings is officially documented feature. It sould work correctly, or should be removed, to not

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Nathan Rajlich
I don't get it. This is what string_decoder was designed for. What is the problem? On Wed, Oct 17, 2012 at 2:09 PM, Ben Noordhuis i...@bnoordhuis.nl wrote: On Wed, Oct 17, 2012 at 11:04 PM, Vitaly Puzrin vit...@rcdesign.ru wrote: Do you really think, that eхpectiotion to get correct strings

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Matt
On Wed, Oct 17, 2012 at 5:04 PM, Vitaly Puzrin vit...@rcdesign.ru wrote: Do you really think, that eхpectiotion to get correct strings instead of crap from official API is too high :) ? Well sort of. Unicode is hard. I'm glad you get it, but most people don't, including the original people

[nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Marco Rogers
I tend to agree with the OP. If node supports strings, they should be valid strings. The name setEncoding implies that we plan to respect that encoding. Anything else is surprising. I think we're all sympathetic to the perf arguments. But that's something that can be worked on. I'd like to see

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Nathan Rajlich
Seriously I'm lost. Can somebody show me some sample code to demonstrate the problem? Here's the issue on the tracker btw: https://github.com/joyent/node/issues/4160 On Wed, Oct 17, 2012 at 9:19 PM, Marco Rogers marco.rog...@gmail.com wrote: I tend to agree with the OP. If node supports

Re: [nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Vitaly Puzrin
Yes, i can't quickly reproduce bug in my current enviroment. That's a bit strange. Need some time to ask people, who confirmed problem, and comfirmed, that they didn't missed setEncoding(). четверг, 18 октября 2012 г., 9:29:12 UTC+4 пользователь Nathan Rajlich написал: Seriously I'm lost.

[nodejs] Re: Broken string data chunks in http ?

2012-10-17 Thread Marco Rogers
Turns out I was full of shit here. Sorry for helping stir things up without doing my homework. https://github.com/joyent/node/issues/4160#issuecomment-9553750 :Marco On Wednesday, October 17, 2012 9:19:34 PM UTC-7, Marco Rogers wrote: I tend to agree with the OP. If node supports strings,