Re: [nodejs] Using MakeCallback for domain-based error propagation and setting recv

2015-07-16 Thread Ben Noordhuis
On Thu, Jul 16, 2015 at 12:44 AM, Jeff Waller wrote: >> Then args.This() equals |addon|, the native module object, and won't >> normally have the .domain property that MakeCallback() looks for. > > > Much thanks, that clarifies. > > I have a followup question. There are multiple functions my > add

Re: [nodejs] Using MakeCallback for domain-based error propagation and setting recv

2015-07-15 Thread Jeff Waller
> > Then args.This() equals |addon|, the native module object, and won't > normally have the .domain property that MakeCallback() looks for. > Much thanks, that clarifies. I have a followup question. There are multiple functions my addon exposes that are of this form, and I think I can change

Re: [nodejs] Using MakeCallback for domain-based error propagation and setting recv

2015-07-15 Thread Ben Noordhuis
On Wed, Jul 15, 2015 at 2:17 AM, Jeff Waller wrote: > When dispatching from an asynchronous operation using C++, the function > node::MakeCallback is > supposed to automatically set the domain of the callback. So if method > throws, then an event will > be sent to the domain. At least that's the

[nodejs] Using MakeCallback for domain-based error propagation and setting recv

2015-07-14 Thread Jeff Waller
When dispatching from an asynchronous operation using C++, the function node::MakeCallback is supposed to automatically set the domain of the callback. So if method throws, then an event will be sent to the dom