Re: [nodejs] buffer: stability improvements feedback

2013-01-04 Thread Trevor Norris
On Friday, January 4, 2013 3:39:10 PM UTC-8, Ben Noordhuis wrote: > > I'm okay with that, with the caveat that there should be no > performance or behavior regressions whatsoever. That means writing a > lot of tests and benchmarks. :-) > Awesome. Thanks. -- Job Board: http://jobs.nodejs.o

Re: [nodejs] buffer: stability improvements feedback

2013-01-04 Thread Ben Noordhuis
On Fri, Jan 4, 2013 at 9:23 PM, Trevor Norris wrote: > This is for all the committers out there. > > While working on my latest Buffers PR, noticed there are > undocumented/unenforced ways things can go wrong. Say, for example, a user > wants to extend Buffer with their own set of methods/properti

[nodejs] buffer: stability improvements feedback

2013-01-04 Thread Trevor Norris
This is for all the committers out there. While working on my latest Buffers PR, noticed there are undocumented/unenforced ways things can go wrong. Say, for example, a user wants to extend Buffer with their own set of methods/properties and just happen to name one of them 'parent' or 'offset'.