[nodejs] child_process.spawn issue in 0.8.x

2012-07-10 Thread wavded
The following code worked fine in 0.6.19, but fails in 0.8.x: https://github.com/applieddataconsultants/pdfsnag/blob/master/pdfsnag.js#L108-110 I know spawn changed a bit in how it handles stdio in 0.8.x. The issue is that wkhtmltopdf is either failing because of write permissions issue (its t

Re: [nodejs] child_process.spawn issue in 0.8.x

2012-07-10 Thread Ben Noordhuis
On Tue, Jul 10, 2012 at 3:58 PM, wavded wrote: > The following code worked fine in 0.6.19, but fails in 0.8.x: > > https://github.com/applieddataconsultants/pdfsnag/blob/master/pdfsnag.js#L108-110 > > I know spawn changed a bit in how it handles stdio in 0.8.x. The issue is > that wkhtmltopdf is

Re: [nodejs] child_process.spawn issue in 0.8.x

2012-07-10 Thread wavded
Thanks Ben for your response: Your cat example fixed the problem with wkhtmltopdf but .pipe() doesn't close properly so the response never finishes. ``` wkhtmltopdf.stdout.pipe(res) ``` This starts a download in the browser but never completes (however if I kill the server it completes :) I h

Re: [nodejs] child_process.spawn issue in 0.8.x

2012-07-10 Thread Ben Noordhuis
On Tue, Jul 10, 2012 at 10:37 PM, wavded wrote: > Thanks Ben for your response: > > Your cat example fixed the problem with wkhtmltopdf but .pipe() doesn't > close properly so the response never finishes. > > ``` > wkhtmltopdf.stdout.pipe(res) > ``` > > This starts a download in the browser but ne

Re: [nodejs] child_process.spawn issue in 0.8.x

2012-07-10 Thread wavded
Ahh, found out that I the first `cat |` was causing the issue for whatever reason, this commit fixed the issue for me: https://github.com/applieddataconsultants/pdfsnag/commit/27b3b078651260328274b46c852100caba177b29 On Tuesday, July 10, 2012 3:48:20 PM UTC-5, Ben Noordhuis wrote: > > On Tue, Ju