Re: [node-dev] Adding missing Uint8ClampedArray

2012-03-27 Thread m1k3l
Exactly. I added the code and tests. See pull request: https://github.com/joyent/node/pull/3021. On Tuesday, March 27, 2012 4:19:22 PM UTC-7, Ben Noordhuis wrote: > > On Wed, Mar 28, 2012 at 00:04, m1k3l wrote: > > No way to override that? or to add a hook before or after this v8 code? > > Not t

Re: [node-dev] Adding missing Uint8ClampedArray

2012-03-27 Thread m1k3l
OK I found the solution. Indeed, it's quite some asm for that... In fact, Uint8ClampedArray is what v8 calls PixelArray. Please merge the updated code and tests. See https://github.com/joyent/node/pull/3021 Thanks On Tuesday, March 27, 2012 3:04:29 PM UTC-7, m1k3l wrote: > > No way to overrid

Re: [node-dev] Adding missing Uint8ClampedArray

2012-03-27 Thread Ben Noordhuis
On Wed, Mar 28, 2012 at 00:04, m1k3l wrote: > No way to override that? or to add a hook before or after this v8 code? Not that I know of. But maybe the kExternalPixelArray array type does what you want, it clamps values to the 0-255 range.

Re: [node-dev] Adding missing Uint8ClampedArray

2012-03-27 Thread m1k3l
No way to override that? or to add a hook before or after this v8 code? On Tuesday, March 27, 2012 2:55:24 PM UTC-7, Ben Noordhuis wrote: > > On Tue, Mar 27, 2012 at 23:41, m1k3l wrote: > > I'm adding a missing typed array, the Uint8ClampedArray. You can see the > > changes > > at > https://gith

Re: [node-dev] Adding missing Uint8ClampedArray

2012-03-27 Thread Ben Noordhuis
On Tue, Mar 27, 2012 at 23:41, m1k3l wrote: > I'm adding a missing typed array, the Uint8ClampedArray. You can see the > changes > at https://github.com/mikeseven/node/commit/27ad75f882a6c7ad06a878f3eaab292a045ffc4c > I didn't put this in the pull requests yet because I have an issue with the > sy

[node-dev] Adding missing Uint8ClampedArray

2012-03-27 Thread m1k3l
I'm adding a missing typed array, the Uint8ClampedArray. You can see the changes at https://github.com/mikeseven/node/commit/27ad75f882a6c7ad06a878f3eaab292a045ffc4c I didn't put this in the pull requests yet because I have an issue with the syntax: buf[idx]=value, which should do the same thin