[GitHub] [accumulo] cradal commented on issue #1618: Investigate TODO in exception message in new Bulk Import

2020-06-15 Thread GitBox
cradal commented on issue #1618: URL: https://github.com/apache/accumulo/issues/1618#issuecomment-644151827 @millerruntime I traced through the logic for mergeOverlappinh() in BulkImport. It appears that the only scenario in which a merge will occur is if the overlapping KeyExtent (oke) fi

[GitHub] [accumulo] milleruntime commented on pull request #1616: Update Last Location. Fix #1169

2020-06-15 Thread GitBox
milleruntime commented on pull request #1616: URL: https://github.com/apache/accumulo/pull/1616#issuecomment-644158569 > Shouldn't this include a revert of the previous revert? I don't think so. He pulled out this one line from the previous change (which included too many other chan

[GitHub] [accumulo] Manno15 commented on pull request #1616: Update Last Location. Fix #1169

2020-06-15 Thread GitBox
Manno15 commented on pull request #1616: URL: https://github.com/apache/accumulo/pull/1616#issuecomment-644159700 I am currently working on getting those other changes to build but this one should be good to go. This is an a

[GitHub] [accumulo] keith-turner merged pull request #1623: Added unit test for too many tablets in bulk import

2020-06-15 Thread GitBox
keith-turner merged pull request #1623: URL: https://github.com/apache/accumulo/pull/1623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Accumulo-Master - Build # 3112 - Fixed

2020-06-15 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Master (build #3112) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Master/3112/ to view the results.

[GitHub] [accumulo] keith-turner commented on a change in pull request #1487: Fixes: #1323 Implement a write thread limit

2020-06-15 Thread GitBox
keith-turner commented on a change in pull request #1487: URL: https://github.com/apache/accumulo/pull/1487#discussion_r440275644 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -381,6 +381,9 @@ TSERV_MEM_MGMT("tserver.memory.manager",

[GitHub] [accumulo] milleruntime commented on issue #1618: Investigate TODO in exception message in new Bulk Import

2020-06-15 Thread GitBox
milleruntime commented on issue #1618: URL: https://github.com/apache/accumulo/issues/1618#issuecomment-644255992 @cradal thanks for looking into this message. Please open a PR with an idea of what the message should say.

[jira] [Issue Comment Deleted] (ACCUMULO-2844) Remove master/slave terminology

2020-06-15 Thread Marc Parisi (Jira)
[ https://issues.apache.org/jira/browse/ACCUMULO-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc Parisi updated ACCUMULO-2844: -- Comment: was deleted (was: Slacum, that is a masterful response. Can't agree more. ) > Remo

[jira] [Comment Edited] (ACCUMULO-2844) Remove master/slave terminology

2020-06-15 Thread Marc Parisi (Jira)
[ https://issues.apache.org/jira/browse/ACCUMULO-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136024#comment-17136024 ] Marc Parisi edited comment on ACCUMULO-2844 at 6/15/20, 5:06 PM: ---

[jira] [Commented] (ACCUMULO-2844) Remove master/slave terminology

2020-06-15 Thread Marc Parisi (Jira)
[ https://issues.apache.org/jira/browse/ACCUMULO-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136024#comment-17136024 ] Marc Parisi commented on ACCUMULO-2844: --- I think as situations evolve so do our

[jira] [Comment Edited] (ACCUMULO-2844) Remove master/slave terminology

2020-06-15 Thread Marc Parisi (Jira)
[ https://issues.apache.org/jira/browse/ACCUMULO-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136024#comment-17136024 ] Marc Parisi edited comment on ACCUMULO-2844 at 6/15/20, 5:09 PM: ---

[GitHub] [accumulo] milleruntime opened a new pull request #1626: Add javadoc explaining parameter behavior. Closes #1619

2020-06-15 Thread GitBox
milleruntime opened a new pull request #1626: URL: https://github.com/apache/accumulo/pull/1626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [accumulo] milleruntime commented on a change in pull request #1605: Fixes #564 adds support multiple compaction executors

2020-06-15 Thread GitBox
milleruntime commented on a change in pull request #1605: URL: https://github.com/apache/accumulo/pull/1605#discussion_r440381804 ## File path: core/src/main/java/org/apache/accumulo/core/client/admin/compaction/TooManyDeletesSelector.java ## @@ -0,0 +1,157 @@ +/* + * Licensed

[GitHub] [accumulo] keith-turner opened a new issue #1627: Add method to get properties with prefix to PluginEnvironment.Configuration

2020-06-15 Thread GitBox
keith-turner opened a new issue #1627: URL: https://github.com/apache/accumulo/issues/1627 [PluginEnvironment.Configuration](https://github.com/apache/accumulo/blob/db9c2b975f2db1b3903402dea69e32a014d122da/core/src/main/java/org/apache/accumulo/core/client/PluginEnvironment.java#L39) is a

[GitHub] [accumulo] keith-turner opened a new issue #1628: Add test where compaction selector sporadically throws an exception.

2020-06-15 Thread GitBox
keith-turner opened a new issue #1628: URL: https://github.com/apache/accumulo/issues/1628 Add test that does the following to org.apache.accumulo.test.CompactionIT * Create a compaction selector that only compacts file names that match a pattern and throws an exception randomly 50%

[GitHub] [accumulo] keith-turner opened a new issue #1629: Look into parallelizing file selection and planning for compaction services

2020-06-15 Thread GitBox
keith-turner opened a new issue #1629: URL: https://github.com/apache/accumulo/issues/1629 The changes in #1605 introduced a compaction manager and multiple compaction services. Currently the compaction manager has a single thread that goes through all tablets and does the following.

[GitHub] [accumulo] keith-turner opened a new issue #1630: Looking into marking tablet as chopped in compaction mutation

2020-06-15 Thread GitBox
keith-turner opened a new issue #1630: URL: https://github.com/apache/accumulo/issues/1630 While working on #1605 I noticed that chop compactions write out two mutations to the metadata table. One mutation changes the tablets set of files. The second mutation marks the tablet as chopped

[GitHub] [accumulo] keith-turner opened a new issue #1631: Tablet in memory compaction ID is updated before metadata write

2020-06-15 Thread GitBox
keith-turner opened a new issue #1631: URL: https://github.com/apache/accumulo/issues/1631 While working on #1605 I noticed that the tablets in memory tracking of the compaction ID (via `Tablet.setLastCompactionID()`) was updated before updating the metadata table. If the metadata table u

[GitHub] [accumulo] keith-turner commented on pull request #1605: Fixes #564 adds support multiple compaction executors

2020-06-15 Thread GitBox
keith-turner commented on pull request #1605: URL: https://github.com/apache/accumulo/pull/1605#issuecomment-644416350 @milleruntime I found all the TODOs and addressed/removed them. This is an automated message from the Apac