ctubbsii commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729320071
> Adding a change to the upgrade code is not that big of deal anymore, since
it is now done in one spot. There is already a method for upgrading data in ZK
going from 2.0 to 2
ctubbsii commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729319342
> Given unlimited volunteer effort I agree that such an implementation would
be nice.
I was operating on the assumption that there was already an interested
volunteer w
joshelser commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729290491
> would an approach where the algorithm is configurable but defaults to the
current SHA-256 be acceptable?
This seems super reasonable to me.
milleruntime commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729267575
Adding a change to the upgrade code is not that big of deal anymore, since
it is now done in one spot. There is already a method for upgrading data in ZK
going from 2.0 t
busbey commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729258281
Given unlimited volunteer effort I agree that such an implementation would
be nice.
Can you think of a technical justification for a veto for the simpler
incremental chan
ctubbsii commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729251958
> @ctubbsii is your request specifically that the PR be changed to allow for
upgrades that maintain user credentials?
I didn't necessarily have a request. Just an observ
busbey commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729246882
e.g. would an approach where the algorithm is configurable but defaults to
the current SHA-256 be acceptable? that would allow existing users to continue
to work as-is while all
busbey commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729245895
@ctubbsii is your request specifically that the PR be changed to allow for
upgrades that maintain user credentials?
ctubbsii commented on a change in pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#discussion_r525525497
##
File path:
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java
##
@@ -140,8 +140,8 @@ public Buildable withOverrides(Map
overri
dlmarion commented on pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#issuecomment-729190890
I ran the commands you gave me on the main branch (after removing the lines
in the log4j properties file) and I saw the log statements you were talking
about. Then I switched
ctubbsii commented on pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#issuecomment-729151190
> To be clear, you are saying that the spam is showing up in the master or
tserver logs when starting Accumulo, and the entries in `
test/src/main/resources/log4j2-test.proper
EdColeman commented on pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787#issuecomment-729146670
Thanks for the contributions. Just wanted to point out that the accumulo
dev mailing list or the Accumulo slack channel
(https://the-asf.slack.com/messages/CERNB8NDC) can be
ctubbsii commented on a change in pull request #1765:
URL: https://github.com/apache/accumulo/pull/1765#discussion_r525422499
##
File path:
core/src/test/java/org/apache/accumulo/core/clientImpl/ScannerBaseTest.java
##
@@ -20,71 +20,121 @@
import static org.easymock.EasyMoc
milleruntime merged pull request #1774:
URL: https://github.com/apache/accumulo/pull/1774
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ctubbsii commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-729140450
I did see a test failure with
`org.apache.accumulo.test.ShellIT.insertIntoSpecifiedTableTest`
This is an auto
dlmarion commented on pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#issuecomment-729120125
To be clear, you are saying that the spam is showing up in the master or
tserver logs when starting Accumulo, and the entries in `
test/src/main/resources/log4j2-test.properti
ctubbsii commented on pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#issuecomment-729113404
> Just realized I looked at the wrong files. Ran the following and didn't
get any matches either:
>
> ```
> find */target/surefire-reports -name *-output.txt -exec gr
BukrosSzabolcs opened a new pull request #1787:
URL: https://github.com/apache/accumulo/pull/1787
The use of less robust hashes would prevent a system deploying Accumulo
from meeting FIPS requirements so by updating it we avoid forcing
downstream users seeking FIPS certification from g
dlmarion commented on pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#issuecomment-729093118
Just realized I looked at the wrong files. Ran the following and didn't get
any matches either:
```
find */target/surefire-reports -name *-output.txt -exec grep -H beanut
dlmarion commented on pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#issuecomment-729091982
Made the changes you requested. I'm not sure what spam you were getting
previously, but I did the following and did not get any results:
```
mvn clean verify -Psunny
ctubbsii commented on a change in pull request #1774:
URL: https://github.com/apache/accumulo/pull/1774#discussion_r525315192
##
File path:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
##
@@ -79,21 +79,13 @@ public GroupBalancer(Table
dlmarion commented on pull request #3:
URL:
https://github.com/apache/accumulo-classloaders/pull/3#issuecomment-729053476
Agreed. I'll check it tomorrow. Thanks.
This is an automated message from the Apache Git Service.
To r
ctubbsii commented on pull request #3:
URL:
https://github.com/apache/accumulo-classloaders/pull/3#issuecomment-729047724
> What's the frequency of that?
I think daily. We can manually trigger it, but I don't think that it's
necessary.
-
ctubbsii commented on a change in pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786#discussion_r525298718
##
File path:
core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java
##
@@ -203,15 +204,18 @@ private SiteConfiguration(Map config) {
dlmarion commented on pull request #3:
URL:
https://github.com/apache/accumulo-classloaders/pull/3#issuecomment-729040260
What's the frequency of that?
This is an automated message from the Apache Git Service.
To respond to
ctubbsii commented on pull request #3:
URL:
https://github.com/apache/accumulo-classloaders/pull/3#issuecomment-729039531
> [apache/accumulo#1715](https://github.com/apache/accumulo/pull/1715) is
merged. The checks are still not passing.
We'll have to wait until after ASF Jenkins pu
dlmarion commented on pull request #3:
URL:
https://github.com/apache/accumulo-classloaders/pull/3#issuecomment-729032655
apache/accumulo#1715 is merged. The checks are still not passing.
This is an automated message fro
ctubbsii commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-729038488
It looks like #1715 introduced a bunch of new build warnings, so they kind
of dominate any that this might produce. I saw your change to use `close()`,
and it probably fixes t
dlmarion opened a new pull request #1786:
URL: https://github.com/apache/accumulo/pull/1786
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
jmark99 merged pull request #1785:
URL: https://github.com/apache/accumulo/pull/1785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ctubbsii commented on a change in pull request #1774:
URL: https://github.com/apache/accumulo/pull/1774#discussion_r525273855
##
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java
##
@@ -1301,7 +1301,7 @@ private void waitForTableStateTr
ctubbsii edited a comment on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-729006135
> Interesting, I was just following the
[test](https://github.com/apache/accumulo/blob/main/TESTING.md) instructions.
Even my IDE was unhappy and the tests failed in the sam
Manno15 commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-729010094
> [WARNING]
/home/runner/work/accumulo/accumulo/shell/src/main/java/org/apache/accumulo/shell/Shell.java:[623,13]
shutdown() in jline.console.ConsoleReader has been deprecated
Manno15 edited a comment on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-729010094
> [WARNING]
/home/runner/work/accumulo/accumulo/shell/src/main/java/org/apache/accumulo/shell/Shell.java:[623,13]
shutdown() in jline.console.ConsoleReader has been depr
ctubbsii commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-729006135
> Interesting, I was just following the
[test](https://github.com/apache/accumulo/blob/main/TESTING.md) instructions.
Even my IDE was unhappy and the tests failed in the same manne
dlmarion commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-729005324
Interesting, I was just following the
[test](https://github.com/apache/accumulo/blob/main/TESTING.md) instructions.
Even my IDE was unhappy and the tests failed in the same manner
ctubbsii commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-729002994
@dlmarion So, it seems like you might be using Maven a bit wrong, and it may
be the reason you're seeing inconsistent results. `mvn test` generally only
works in a multi-module pro
milleruntime commented on a change in pull request #1774:
URL: https://github.com/apache/accumulo/pull/1774#discussion_r525240571
##
File path:
server/manager/src/main/java/org/apache/accumulo/master/MasterClientServiceHandler.java
##
@@ -278,7 +278,9 @@ public void shutdownTa
Manno15 commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-728996067
Yeah, I am running the full test suite currently. I got past the issue you
had and so far only one IT has failed. `IteratorEnvIT`. Not sure why as of yet.
dlmarion commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-728995265
So, I ran `mvn clean install -DskipTests -DskipITs -Dspotbugs.skip` to
install the snapshot jars without the dependency into my local Maven repo. `mvn
clean test -Dspotbugs.skip -D
ctubbsii commented on a change in pull request #1783:
URL: https://github.com/apache/accumulo/pull/1783#discussion_r525234705
##
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/ActiveCompactionHelper.java
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache So
ctubbsii commented on a change in pull request #1783:
URL: https://github.com/apache/accumulo/pull/1783#discussion_r525234123
##
File path:
shell/src/main/java/org/apache/accumulo/shell/commands/ActiveCompactionHelper.java
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache So
Manno15 commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728994937
Yeah, I am not sure why it previously worked either. I couldn't find any
details on what changed in Jline that would cause such a thing.
--
ctubbsii commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728993817
> @ctubbsii I did not see that warning but I will take a look.
Thanks.
> I suppose it is also possible to just strip out the `\t` when we print to
the shell. Mayb
jmark99 commented on a change in pull request #1785:
URL: https://github.com/apache/accumulo/pull/1785#discussion_r525229381
##
File path: pom.xml
##
@@ -124,7 +124,7 @@
1
-3.2.1
+3.3.0
Review comment:
Interesting! I'll revert back to 3.3.0 :)
ctubbsii commented on a change in pull request #1785:
URL: https://github.com/apache/accumulo/pull/1785#discussion_r525228593
##
File path: pom.xml
##
@@ -124,7 +124,7 @@
1
-3.2.1
+3.3.0
Review comment:
I don't even see 3.2.2 listed on their web
ctubbsii commented on a change in pull request #1715:
URL: https://github.com/apache/accumulo/pull/1715#discussion_r525226297
##
File path:
core/src/main/java/org/apache/accumulo/core/spi/common/ContextClassLoaderFactory.java
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache
jmark99 commented on a change in pull request #1785:
URL: https://github.com/apache/accumulo/pull/1785#discussion_r525225176
##
File path: pom.xml
##
@@ -124,7 +124,7 @@
1
-3.2.1
+3.3.0
Review comment:
We can go with 3.2.2 just to take a more ca
ctubbsii commented on a change in pull request #1785:
URL: https://github.com/apache/accumulo/pull/1785#discussion_r525221464
##
File path: pom.xml
##
@@ -124,7 +124,7 @@
1
-3.2.1
+3.3.0
Review comment:
I'd be okay with bumping to 3.2.2, because
dlmarion closed issue #1747:
URL: https://github.com/apache/accumulo/issues/1747
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dlmarion merged pull request #1715:
URL: https://github.com/apache/accumulo/pull/1715
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Manno15 edited a comment on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728971938
@ctubbsii I did not see that warning but I will take a look.
Thank you for taking another look at it for me. I did some checks on the
shell myself and I noticed no
ctubbsii edited a comment on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728968941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Manno15 edited a comment on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728971938
@ctubbsii I did not see that warning but I will take a look.
Thank you for taking another look at it for me. I did some checks on the
shell myself and I noticed no
Manno15 commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728971938
@ctubbsii I did not see that warning but I will take a look.
Thank you for taking another look at it for me. I did some checks on the
shell myself and I noticed no issue.
ctubbsii commented on pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784#issuecomment-728968941
@Manno15 Thanks for this. I saw a new build warning:
```
[WARNING]
/home/runner/work/accumulo/accumulo/shell/src/main/java/org/apache/accumulo/shell/Shell.java:[623,1
jmark99 opened a new pull request #1785:
URL: https://github.com/apache/accumulo/pull/1785
Update version of hadoop to 3.3.0 in order to remove warnings. With 3.3.0
version the "An illegal reflective access operaion has occurred" errors no
longer appear as the issue has been corrected in t
[
https://issues.apache.org/jira/browse/ACCUMULO-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Tubbs resolved ACCUMULO-4320.
-
Resolution: Duplicate
Duplicated by PR https://github.com/apache/accumulo/pull
Manno15 commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-728944114
I'll help investigate.
This is an automated message from the Apache Git Service.
To respond to the message, please
dlmarion commented on issue #1463:
URL: https://github.com/apache/accumulo/issues/1463#issuecomment-728941910
I was able to remove the beanutils references and compile the code. Some
tests are failing and I'm a little confused as to why. The tests in `start` run
just fine, but some of the
BukrosSzabolcs commented on pull request #1780:
URL: https://github.com/apache/accumulo/pull/1780#issuecomment-728931878
@ctubbsii I fully understand. Thank you for the explanation.
This is an automated message from the Apach
Manno15 opened a new pull request #1784:
URL: https://github.com/apache/accumulo/pull/1784
Based on the Jira ticket
[4320](https://issues.apache.org/jira/browse/ACCUMULO-4320). I upgraded Jline
to the newest version of Jline2 and fixed several errors that came from
upgrading. Most were ju
62 matches
Mail list logo
