[GitHub] [accumulo] keith-turner commented on pull request #2900: Add a new "dumeta" command to compute table disk usage

2022-09-02 Thread GitBox
keith-turner commented on PR #2900: URL: https://github.com/apache/accumulo/pull/2900#issuecomment-1235954025 > The existing DU command works by computing the storage used exclusively by each table provided, as well as computing the storage used by any combination of tables. A bit of

[GitHub] [accumulo] ctubbsii commented on pull request #2912: Updates to ScanAttempts

2022-09-02 Thread GitBox
ctubbsii commented on PR #2912: URL: https://github.com/apache/accumulo/pull/2912#issuecomment-1235938552 I'll need to rebase this on the changes done in #2896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [accumulo] ctubbsii commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
ctubbsii commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235936071 > > But we should deprecate the fate stuff in the shell. > > What about the new cancel operation? I seem to remember making the point when that was added, that FaTE wasn't

[GitHub] [accumulo-testing] DomGarguilo commented on issue #213: IllegalArgumentException: Rwalk Simpl.xml and Basic.xml module

2022-09-02 Thread GitBox
DomGarguilo commented on issue #213: URL: https://github.com/apache/accumulo-testing/issues/213#issuecomment-1235833497 > Yes, but they still show up as options for the user to choose if you enter the rwalk command without any module. Oh yea good point. I didn't see that until now. M

[GitHub] [accumulo-testing] Manno15 commented on issue #213: IllegalArgumentException: Rwalk Simpl.xml and Basic.xml module

2022-09-02 Thread GitBox
Manno15 commented on issue #213: URL: https://github.com/apache/accumulo-testing/issues/213#issuecomment-1235832026 Yes, but they still show up as options for the user to choose if you enter the rwalk command without any module. -- This is an automated message from the Apache Git Servic

[GitHub] [accumulo-testing] DomGarguilo commented on issue #213: IllegalArgumentException: Rwalk Simpl.xml and Basic.xml module

2022-09-02 Thread GitBox
DomGarguilo commented on issue #213: URL: https://github.com/apache/accumulo-testing/issues/213#issuecomment-1235830792 I'm not certain of the intentions behind these files in the `unit` directory (`Basic` and `Simple`), but it doesn't seem to me that these are necessarily supposed to be r

[GitHub] [accumulo] milleruntime commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
milleruntime commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235793511 I started work to move the new FateCommand options (cancel and summary) added in 2.1 to the Admin command in https://github.com/apache/accumulo/pull/2914 -- This is an automated

[GitHub] [accumulo] milleruntime commented on pull request #2913: Fix FateCommand cancel message

2022-09-02 Thread GitBox
milleruntime commented on PR #2913: URL: https://github.com/apache/accumulo/pull/2913#issuecomment-1235792391 This will be obsolete if #2914 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [accumulo] milleruntime opened a new pull request, #2914: Move new FateCommand options to Admin

2022-09-02 Thread GitBox
milleruntime opened a new pull request, #2914: URL: https://github.com/apache/accumulo/pull/2914 * See discussion on #2780 about problems trying to complete #2215 * Move new cancel and summary options to Admin and deprecate FateCommand. -- This is an automated message from the Apache

[GitHub] [accumulo] DomGarguilo closed issue #2855: Simplify ScanServerSelector

2022-09-02 Thread GitBox
DomGarguilo closed issue #2855: Simplify ScanServerSelector URL: https://github.com/apache/accumulo/issues/2855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [accumulo] DomGarguilo merged pull request #2896: ScanServerSelector - Break nested interfaces into their own files

2022-09-02 Thread GitBox
DomGarguilo merged PR #2896: URL: https://github.com/apache/accumulo/pull/2896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [accumulo] milleruntime commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
milleruntime commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235708505 > But we should deprecate the fate stuff in the shell. What about the new cancel operation? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [accumulo] ctubbsii commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
ctubbsii commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235693602 > I like that idea. It looks like FateAdmin has been deprecated for a few versions. Do you think we could drop it for 2.1? No. We can drop it in 3, along with the fate stuff in th

[GitHub] [accumulo] milleruntime commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
milleruntime commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235686797 > Overall, I'm inclined to scrap the idea of adding a FaTE RPC and API so we can access it from the shell. That's the whole basis for these changes... and it's become bloated with a

[GitHub] [accumulo] ctubbsii commented on pull request #2887: Print exceptions that cause the server process to exit to stderr

2022-09-02 Thread GitBox
ctubbsii commented on PR #2887: URL: https://github.com/apache/accumulo/pull/2887#issuecomment-1235685953 Ideally, instead of explicitly printing, we should just make sure the exception gets thrown out of the main method... let the JVM do its own printing to STDERR, as this is the expected

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2910: Add ability to retrieve TimeType for a table

2022-09-02 Thread GitBox
ctubbsii commented on code in PR #2910: URL: https://github.com/apache/accumulo/pull/2910#discussion_r961829449 ## core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java: ## @@ -2011,6 +2013,16 @@ public ImportDestinationArguments importDirectory(String

[GitHub] [accumulo] ctubbsii commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
ctubbsii commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235669111 The Manager is supposed to be off in order to prevent FaTE concurrency issues during a delicate manual failure-handling situation. If we're directly manipulating FaTE by executing these

[GitHub] [accumulo] ctubbsii commented on pull request #2882: Add JVM flag UnlockDiagnosticVMOptions to default JVM options

2022-09-02 Thread GitBox
ctubbsii commented on PR #2882: URL: https://github.com/apache/accumulo/pull/2882#issuecomment-1235631302 I cannot find any documentation that says that setting this flag automatically enables some diagnostic options. Everything I can find seems to suggest that you need to set this flag in

[GitHub] [accumulo] milleruntime commented on pull request #2780: New FateOperations API

2022-09-02 Thread GitBox
milleruntime commented on PR #2780: URL: https://github.com/apache/accumulo/pull/2780#issuecomment-1235471469 @ctubbsii what do you think the special methods, `fail()` and `delete()` being called on a `FateTransaction`? These currently require the Manager to be down to free the lock, which

[GitHub] [accumulo] cshannon commented on pull request #2900: Add a new "dumeta" command to compute table disk usage

2022-09-02 Thread GitBox
cshannon commented on PR #2900: URL: https://github.com/apache/accumulo/pull/2900#issuecomment-1235418223 @ctubbsii - Thanks for the detailed feedback, that's very helpful to get some more background. My comments are below to address each of your points. 1. I agree that we should just

[GitHub] [accumulo] keith-turner commented on a diff in pull request #2910: Add ability to retrieve TimeType for a table

2022-09-02 Thread GitBox
keith-turner commented on code in PR #2910: URL: https://github.com/apache/accumulo/pull/2910#discussion_r961507295 ## core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java: ## @@ -2011,6 +2013,20 @@ public ImportDestinationArguments importDirectory(Str