[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2016-06-23 Thread Dylan Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347012#comment-15347012 ] Dylan Hutchison commented on ACCUMULO-2817: --- Sure, see ACCUMULO-4352 > Add offset and limit

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2016-06-23 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346983#comment-15346983 ] Josh Elser commented on ACCUMULO-2817: -- bq. Hi folks, I'm interested in calling

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2016-06-23 Thread Dylan Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346824#comment-15346824 ] Dylan Hutchison commented on ACCUMULO-2817: --- Hi folks, I'm interested in calling

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-25 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337296#comment-14337296 ] Keith Turner commented on ACCUMULO-2817: [~matthew-dailey] the patch looks

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337304#comment-14337304 ] Josh Elser commented on ACCUMULO-2817: -- bq. The coverage is really high.

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-23 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333696#comment-14333696 ] Josh Elser commented on ACCUMULO-2817: -- Also, in the future, if you can squash

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-23 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333683#comment-14333683 ] Josh Elser commented on ACCUMULO-2817: -- {code} diff --git

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-23 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333733#comment-14333733 ] Keith Turner commented on ACCUMULO-2817: When doing code reviews, its nice to

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-23 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334380#comment-14334380 ] Josh Elser commented on ACCUMULO-2817: -- LGTM. Thanks, Matt! I'll give Keith a

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-19 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14327669#comment-14327669 ] Keith Turner commented on ACCUMULO-2817: Re {{public T decodeUnchecked(byte[]

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Matt Dailey (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326621#comment-14326621 ] Matt Dailey commented on ACCUMULO-2817: --- That sounds like a good plan to me. For

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326997#comment-14326997 ] Josh Elser commented on ACCUMULO-2817: -- 1. I think some simple Guava

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326116#comment-14326116 ] Keith Turner commented on ACCUMULO-2817: [~elserj] I missed that {{ V

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326130#comment-14326130 ] Josh Elser commented on ACCUMULO-2817: -- Oh bugger, you're right. I think I opened

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326073#comment-14326073 ] Josh Elser commented on ACCUMULO-2817: -- Added you as a contributor and assigned

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326091#comment-14326091 ] Josh Elser commented on ACCUMULO-2817: -- bq. Ideally the new decode(byte[] b, int

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326109#comment-14326109 ] Keith Turner commented on ACCUMULO-2817: bq. A default method would be nice

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326070#comment-14326070 ] Keith Turner commented on ACCUMULO-2817: All of the new methods should have

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326152#comment-14326152 ] Keith Turner commented on ACCUMULO-2817: As for creating new issues, I wanted

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326156#comment-14326156 ] Josh Elser commented on ACCUMULO-2817: -- That's not a bad compromise IMO. It forces

[jira] [Commented] (ACCUMULO-2817) Add offset and limit arguments to byte array Encoder.decode method

2015-02-18 Thread Matt Dailey (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326880#comment-14326880 ] Matt Dailey commented on ACCUMULO-2817: --- Realized I need to add in bounds