[ 
https://issues.apache.org/jira/browse/ACCUMULO-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Corey J. Nolet updated ACCUMULO-1393:
-------------------------------------

    Comment: was deleted

(was: Just to be clear, are we referring to the this method in the 
ServerServices? 

{code}
    // not necessary: everything should be advertizing ports in zookeeper
    int getDefaultPort() {
      switch (this) {
        case TSERV_CLIENT:
          return 
AccumuloConfiguration.getDefaultConfiguration().getPort(Property.TSERV_CLIENTPORT);
        case MASTER_CLIENT:
          return 
AccumuloConfiguration.getDefaultConfiguration().getPort(Property.MASTER_CLIENTPORT);
        case GC_CLIENT:
          return 
AccumuloConfiguration.getDefaultConfiguration().getPort(Property.GC_PORT);
        default:
          throw new IllegalArgumentException();
      }
    }
{code}

As well as the corresponding code in Property that is setting a default port 
for the TSERVER_CLIENTPORT and MASTER_CLIENTPORT?


)
    
> Removed code related to default ports in client code
> ----------------------------------------------------
>
>                 Key: ACCUMULO-1393
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1393
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Keith Turner
>            Assignee: Corey J. Nolet
>             Fix For: 1.6.0
>
>
> The Accumulo client code has code for dealing with default master and tserver 
> ports.  This code is old and unused.  Its always expected that locations 
> listed in zookeeper and the metadata table will have a ip+port now.  If this 
> expectation is not met, it should be treated as an error instead of falling 
> back to a default.  Removing this code would clean up the client and logging 
> produced by the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to