Re: [PR] Handles RPC errors when requesting tablet unload [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on PR #4497: URL: https://github.com/apache/accumulo/pull/4497#issuecomment-2089263532 Why was the logging left at warn? If that's appropriate, it's fine, just wanted to check that reducing the severity level was not overlooked. -- This is an automated message from

Re: [PR] Handles RPC errors when requesting tablet unload [accumulo]

2024-05-01 Thread via GitHub
keith-turner merged PR #4497: URL: https://github.com/apache/accumulo/pull/4497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] Last contact for tablet server on monitor seemed incorrect [accumulo]

2024-05-01 Thread via GitHub
keith-turner opened a new issue, #4516: URL: https://github.com/apache/accumulo/issues/4516 **Describe the bug** Working with a handful of half dead tablet sever that were holding their locks in zookeeper but not accepting RPC request it seems the last contact times for these tablet

Re: [I] Resolve ASF web-checker issues. [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii commented on issue #420: URL: https://github.com/apache/accumulo-website/issues/420#issuecomment-2089239280 Just checked again, and we're all green now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Update minimum Ruby version and gems [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii commented on PR #424: URL: https://github.com/apache/accumulo-website/pull/424#issuecomment-2089235867 @clambertus confirmed in Slack that the builder is running Ruby 2.7 (I think it's safe to rely on it not going backwards). These updated gems work fine on Ruby 3.3.0 on my Fedora

Re: [I] Unhosted user tablets prevent balancing of metadata table [accumulo]

2024-05-01 Thread via GitHub
keith-turner commented on issue #4515: URL: https://github.com/apache/accumulo/issues/4515#issuecomment-2089235594 > Is there any chance that you started the manager before the tservers (or at least most of them)? Started all tablet servers first. -- This is an automated message

[PR] Update minimum Ruby version and gems [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii opened a new pull request, #424: URL: https://github.com/apache/accumulo-website/pull/424 * Update minimum Ruby version to at least the version run by ASF infra team on Jekyll builders, so that way we can reduce compatibility surprises when trying to build on stuff substantially

Re: [I] Unhosted user tablets prevent balancing of metadata table [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4515: URL: https://github.com/apache/accumulo/issues/4515#issuecomment-2089230387 Is there any chance that you started the manager before the tservers (or at least most of them)? If you start the tservers first, they will sit there waiting for assignments.

Re: [I] Resolve ASF web-checker issues. [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii commented on issue #420: URL: https://github.com/apache/accumulo-website/issues/420#issuecomment-2089193655 This won't show up as fixed right away, but can check back in a couple days to see if all is green on the Whimsy dashboard again. -- This is an automated message from the

Re: [PR] Update site to comply with ASF privacy site checks [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii merged PR #423: URL: https://github.com/apache/accumulo-website/pull/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Resolve ASF web-checker issues. [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii closed issue #420: Resolve ASF web-checker issues. URL: https://github.com/apache/accumulo-website/issues/420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update site to comply with ASF privacy site checks [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii commented on PR #423: URL: https://github.com/apache/accumulo-website/pull/423#issuecomment-2089162456 @EdColeman I had to include the fonts from fontawesome also, so I've pushed an update after your review. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Update site to comply with ASF privacy site checks [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii commented on PR #423: URL: https://github.com/apache/accumulo-website/pull/423#issuecomment-2089123761 I don't think we should do this, as explained above, but if one really wanted to add the integrity checks back in, it would be something like: ```bash shopt -s globstar

[PR] Update site to comply with ASF privacy site checks [accumulo-website]

2024-05-01 Thread via GitHub
ctubbsii opened a new pull request, #423: URL: https://github.com/apache/accumulo-website/pull/423 See https://whimsy.apache.org/site/project/accumulo * Add link to ASF privacy policy in ASF links section of navigation * Stop linking to external CDNs for our default page layout.

Re: [PR] lowers logging level for first seen dead compaction [accumulo]

2024-05-01 Thread via GitHub
keith-turner merged PR #4490: URL: https://github.com/apache/accumulo/pull/4490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] sets compaction coordinator status update log to trace [accumulo]

2024-05-01 Thread via GitHub
keith-turner merged PR #4489: URL: https://github.com/apache/accumulo/pull/4489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Changed default value of TSERV_PORTSEARCH from false to true [accumulo]

2024-05-01 Thread via GitHub
dlmarion opened a new pull request, #4514: URL: https://github.com/apache/accumulo/pull/4514 Changed the default value of TSERV_PORTSEARCH from false to true to provide some consistency in the PORTSEARCH properties. The default values for the Compactors and ScanServers is already set to

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-201202 Yeah, I get that total cardinality is an issue for most of the TSDBs, but I think limitations are different for each. My point was that we should not take the numbers from

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088876727 While those are specific to Prometheus - my understanding is that they apply generally across various metric systems. There are similar limitations for things like InfluxDB and

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088870320 > For example guidance, [Prometheus label guidelines](https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels%5D) provides the following:, > > ``` >

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088865261 For example guidance, [Prometheus label guidelines](https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels]) provides the following:, ``` As a

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088862188 > Yeah, I think for this to be workable would need a user provided list of tables to tag. This could be a metric property with a value of a list of table names or it could be a

Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

2024-05-01 Thread via GitHub
EdColeman closed issue #4262: MeterRegistryFactory lacks mechanism for configuration. URL: https://github.com/apache/accumulo/issues/4262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4262: URL: https://github.com/apache/accumulo/issues/4262#issuecomment-2088855397 Completed with #4459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
keith-turner commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088853125 > One way to think of it is that each tag will create a unique time-series in some (most?) back ends. So, in addition to the number of metrics that are reported each interval,

Re: [I] MeterRegistryFactory lacks mechanism for configuration. [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4262: URL: https://github.com/apache/accumulo/issues/4262#issuecomment-2088850317 @EdColeman - was this implemented in #4459 as part of the new MeterRegistryFactory SPI class? If so, can this be closed? -- This is an automated message from the Apache Git

Re: [I] Emit metrics for block caches [accumulo]

2024-05-01 Thread via GitHub
DomGarguilo commented on issue #4492: URL: https://github.com/apache/accumulo/issues/4492#issuecomment-2088827307 > It should be possible to compute the hit ratio over time of each block cache using the metrics data. @keith-turner Is this something that you think should be done

Re: [PR] Add integration test that ensures that server process does not start against newer version of accumulo. [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on PR #4513: URL: https://github.com/apache/accumulo/pull/4513#issuecomment-2088824429 MiniAccumuloClusterImpl.verifyUp (called from start) should throw an IllegalStateException if the expected processes are not running. -- This is an automated message from the Apache

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088813510 > Would something like tracing work? If tracing provided the level of information needed, then it could be enabled on a subset of the scan servers / tablet servers via

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088665774 Would something like tracing work? If we could activate / de-activate tracing on-demand, then it seems that maybe would could collect the needed values for profiling and then

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088643490 One way to think of it is that each tag will create a unique time-series in some (most?) back ends. So, in addition to the number of metrics that are reported each interval,

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
keith-turner commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088638548 It may be more useful to tag the metrics with a table name instead of a table id. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088636865 > https://docs.micrometer.io/micrometer/reference/concepts/meter-provider.html I saw this as well. Additionally, there is a `MultiGauge`. If we are going to do

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
keith-turner commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088632646 > Other than well defined Accumulo system tables (root, metadata,...) it is probably not a good idea to add unbounded tags. Systems that have large numbers of dynamic tables

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
keith-turner commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088626298 The following may be relevant if something is done for this issue. https://docs.micrometer.io/micrometer/reference/concepts/meter-provider.html -- This is an automated

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2088595290 Other than well defined Accumulo system tables (root, metadata,...) it is probably not a good idea to add unbounded tags. Systems that have large numbers of dynamic tables will

[PR] Add integration test that ensures that server process does not start against newer version of accumulo. [accumulo]

2024-05-01 Thread via GitHub
ArbaazKhan1 opened a new pull request, #4513: URL: https://github.com/apache/accumulo/pull/4513 At the current moment, checking for errors while each server type starts up fails. We should be expecting them to throw errors during start up since it should detect that there is a

[PR] Removed duplicate call to Ample.deleteScanServerFileReferences in ScanServer [accumulo]

2024-05-01 Thread via GitHub
dlmarion opened a new pull request, #4512: URL: https://github.com/apache/accumulo/pull/4512 Closes #4508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
keith-turner opened a new issue, #4511: URL: https://github.com/apache/accumulo/issues/4511 **Is your feature request related to a problem? Please describe.** The monitor currently has a custom metrics system. This custom system in the monitor tracks certain metrics per tablet

Re: [PR] scan server metrics from #4458 based on #4459 [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on code in PR #4461: URL: https://github.com/apache/accumulo/pull/4461#discussion_r1586320791 ## server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServerMetrics.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] scan server metrics from #4458 based on #4459 [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on code in PR #4461: URL: https://github.com/apache/accumulo/pull/4461#discussion_r1586273849 ## server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServerMetrics.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] scan server metrics from #4458 based on #4459 [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on code in PR #4461: URL: https://github.com/apache/accumulo/pull/4461#discussion_r1586273481 ## core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java: ## @@ -638,6 +660,11 @@ public interface MetricsProducer { String

Re: [PR] scan server metrics from #4458 based on #4459 [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on code in PR #4461: URL: https://github.com/apache/accumulo/pull/4461#discussion_r1586271767 ## core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java: ## @@ -367,6 +367,28 @@ * Gauge * * + * + * + * N/A + * N/A + * {@value

Re: [PR] scan server metrics from #4458 based on #4459 [accumulo]

2024-05-01 Thread via GitHub
EdColeman commented on PR #4461: URL: https://github.com/apache/accumulo/pull/4461#issuecomment-2088434657 Changes in 5dd3c2d311 - Renames String METRICS_SCAN_PREFIX from `accumulo.tserver.scans.` to `accumulo.scan.` Service type (tserver, sserver) is available in the tags -

Re: [PR] Include hash in sserver metadata ref [accumulo]

2024-05-01 Thread via GitHub
ddanielr commented on PR #4510: URL: https://github.com/apache/accumulo/pull/4510#issuecomment-2088424700 Old Ref: `~sservfile:/data/workspace/accumulo/test/target/mini-tests/` New Ref: `~sserv5e6087acfile:/data/workspace/accumulo/test/target/` -- This is an automated message

[PR] Include hash in sserver metadata ref [accumulo]

2024-05-01 Thread via GitHub
ddanielr opened a new pull request, #4510: URL: https://github.com/apache/accumulo/pull/4510 Include a hash in the scan server metadata ref to reduce splits in the metadata table. This is the same logic that is currently used in the ~del ref markers -- This is an automated message