[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #62: fix: add new features and function enhance

2019-11-03 Thread GitBox
juzhiyuan commented on issue #62: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/62#issuecomment-549250971 Tests will be in action when the APISIX demo instance is deployed with the latest codes. --

[GitHub] [incubator-apisix] membphis commented on issue #790: new plugin: data-validator

2019-11-03 Thread GitBox
membphis commented on issue #790: new plugin: data-validator URL: https://github.com/apache/incubator-apisix/issues/790#issuecomment-549250285 > Is it support json schema v4 or v5? support draft4, draft6 and draft7. Th

[GitHub] [incubator-apisix] membphis commented on issue #792: Feature: Update prometheus plugin

2019-11-03 Thread GitBox
membphis commented on issue #792: Feature: Update prometheus plugin URL: https://github.com/apache/incubator-apisix/issues/792#issuecomment-549249946 @lyyoung Can we close this PR now? This is an automated message from the A

[GitHub] [incubator-apisix] wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil

2019-11-03 Thread GitBox
wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil URL: https://github.com/apache/incubator-apisix/issues/776#issuecomment-549240002 > @wangxiaochuang so is it a bug? If this variable is useful, then it must be a bug. @

[GitHub] [incubator-apisix] wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil

2019-11-03 Thread GitBox
wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil URL: https://github.com/apache/incubator-apisix/issues/776#issuecomment-549239830 I don't know what the role of this variable "changed" is. so I can not remove it --

[incubator-apisix] branch master updated: test: reformatted by `reindex` tools. (#798)

2019-11-03 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new ecd4a57 test: reformatted by `rein

[GitHub] [incubator-apisix] nic-chen merged pull request #798: test: reformatted by `reindex` tools.

2019-11-03 Thread GitBox
nic-chen merged pull request #798: test: reformatted by `reindex` tools. URL: https://github.com/apache/incubator-apisix/pull/798 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-apisix] branch master updated: Fix: allow set multiple URI in one route config (#797)

2019-11-03 Thread shuaijinchao
This is an automated email from the ASF dual-hosted git repository. shuaijinchao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new b91d2d3 Fix: allow set multiple

[GitHub] [incubator-apisix] shuaijinchao merged pull request #797: Fix: allow set multiple URI in one route config

2019-11-03 Thread GitBox
shuaijinchao merged pull request #797: Fix: allow set multiple URI in one route config URL: https://github.com/apache/incubator-apisix/pull/797 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix] shuaijinchao closed issue #796: bug: unable to set multiple URI into uris field when config route

2019-11-03 Thread GitBox
shuaijinchao closed issue #796: bug: unable to set multiple URI into uris field when config route URL: https://github.com/apache/incubator-apisix/issues/796 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #56: license: moved License information to LICENSE.

2019-11-03 Thread GitBox
juzhiyuan merged pull request #56: license: moved License information to LICENSE. URL: https://github.com/apache/incubator-apisix-dashboard/pull/56 This is an automated message from the Apache Git Service. To respond to the

[incubator-apisix-dashboard] branch master updated (140eedc -> ac82cd4)

2019-11-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. from 140eedc feat: remove useless files (#63) add ac82cd4 license: moved License informati

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #54: License information goes in LICENSE not NOTICE

2019-11-03 Thread GitBox
juzhiyuan closed issue #54: License information goes in LICENSE not NOTICE URL: https://github.com/apache/incubator-apisix-dashboard/issues/54 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #63: feat: remove useless files

2019-11-03 Thread GitBox
juzhiyuan merged pull request #63: feat: remove useless files URL: https://github.com/apache/incubator-apisix-dashboard/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log o

[incubator-apisix-dashboard] branch master updated (31cac84 -> 140eedc)

2019-11-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. from 31cac84 license: add apache copyright in NOTICE. add 140eedc feat: remove useless file

[incubator-apisix-dashboard] branch feature-remove-useless-files updated (c967967 -> d96e2e5)

2019-11-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feature-remove-useless-files in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. from c967967 update proxy path add d96e2e5 remove tests/ No new revi

[GitHub] [incubator-apisix] membphis commented on issue #795: Changed wording for clarity in README.md

2019-11-03 Thread GitBox
membphis commented on issue #795: Changed wording for clarity in README.md URL: https://github.com/apache/incubator-apisix/pull/795#issuecomment-549207183 Many thanks, merged. This is an automated message from the Apache Git S

[GitHub] [incubator-apisix] membphis merged pull request #795: Changed wording for clarity in README.md

2019-11-03 Thread GitBox
membphis merged pull request #795: Changed wording for clarity in README.md URL: https://github.com/apache/incubator-apisix/pull/795 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-apisix] branch master updated: doc: changed wording for clarity in README.md (#795)

2019-11-03 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 5ac22b5 doc: changed wording for cl

[GitHub] [incubator-apisix] membphis commented on a change in pull request #797: Fix: Allow set multi uris in one route config

2019-11-03 Thread GitBox
membphis commented on a change in pull request #797: Fix: Allow set multi uris in one route config URL: https://github.com/apache/incubator-apisix/pull/797#discussion_r341890108 ## File path: t/node/route-host.t ## @@ -42,7 +42,7 @@ __DATA__ "t

[GitHub] [incubator-apisix] membphis commented on a change in pull request #797: Fix: Allow set multi uris in one route config

2019-11-03 Thread GitBox
membphis commented on a change in pull request #797: Fix: Allow set multi uris in one route config URL: https://github.com/apache/incubator-apisix/pull/797#discussion_r341889993 ## File path: t/admin/routes.t ## @@ -1330,3 +1330,34 @@ GET /t {"error_msg":"failed to load '

[GitHub] [incubator-apisix] membphis commented on a change in pull request #797: Fix: Allow set multi uris in one route config

2019-11-03 Thread GitBox
membphis commented on a change in pull request #797: Fix: Allow set multi uris in one route config URL: https://github.com/apache/incubator-apisix/pull/797#discussion_r341889932 ## File path: lua/apisix/schema_def.lua ## @@ -267,6 +267,14 @@ _M.route = { type = "objec

[GitHub] [incubator-apisix] membphis opened a new pull request #798: test: reformatted by `reindex` tools.

2019-11-03 Thread GitBox
membphis opened a new pull request #798: test: reformatted by `reindex` tools. URL: https://github.com/apache/incubator-apisix/pull/798 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-apisix-dashboard] lilien1010 edited a comment on issue #62: fix: add new features and function enhance

2019-11-03 Thread GitBox
lilien1010 edited a comment on issue #62: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/62#issuecomment-549204748 https://github.com/apache/incubator-apisix/pull/797 this PR need to be merged after this PR is merged, since the

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on issue #62: fix: add new features and function enhance

2019-11-03 Thread GitBox
lilien1010 commented on issue #62: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/62#issuecomment-549204748 https://github.com/apache/incubator-apisix/pull/797 this PR need to be merged after this PR is merged, since the code in

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #797: Fix:

2019-11-03 Thread GitBox
lilien1010 opened a new pull request #797: Fix: URL: https://github.com/apache/incubator-apisix/pull/797 Allow set multi uris in one route config, this PR work with my last PR in apisix-dashboard so I think yous need to merge this PR first then merge the one below https://git

[GitHub] [incubator-apisix] lilien1010 opened a new issue #796: bug: set uris to

2019-11-03 Thread GitBox
lilien1010 opened a new issue #796: bug: set uris to URL: https://github.com/apache/incubator-apisix/issues/796 ### Issue description ### Environment * apisix version (cmd: `apisix version`): * OS: ### Minimal test code / Steps to reproduce the issue 1. 2.

[GitHub] [incubator-apisix] soulsoul commented on issue #472: [WIP] doc: added comment for code.

2019-11-03 Thread GitBox
soulsoul commented on issue #472: [WIP] doc: added comment for code. URL: https://github.com/apache/incubator-apisix/pull/472#issuecomment-549199557 ok This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-apisix] BradyBromley opened a new pull request #795: Changed wording for clarity in README.md

2019-11-03 Thread GitBox
BradyBromley opened a new pull request #795: Changed wording for clarity in README.md URL: https://github.com/apache/incubator-apisix/pull/795 NOTE: Please read the Contributing.md guidelines before submitting your patch: https://github.com/apache/incubator-apisix/blob/master/Contr

[incubator-apisix-dashboard] branch feature-remove-useless-files updated (0bda9b3 -> c967967)

2019-11-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feature-remove-useless-files in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. from 0bda9b3 remove i18n add c967967 update proxy path No new revisi

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #62: fix: add new features and function enhance

2019-11-03 Thread GitBox
juzhiyuan commented on issue #62: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/62#issuecomment-549154803 Thanks for your contribution, PR will be merged once I build & test the codes successfully today. -

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new pull request #63: feat: remove useless files

2019-11-03 Thread GitBox
juzhiyuan opened a new pull request #63: feat: remove useless files URL: https://github.com/apache/incubator-apisix-dashboard/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-apisix-dashboard] branch feature-remove-useless-files created (now 0bda9b3)

2019-11-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feature-remove-useless-files in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. at 0bda9b3 remove i18n This branch includes the following new commits:

[incubator-apisix-dashboard] 02/02: remove i18n

2019-11-03 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feature-remove-useless-files in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git commit 0bda9b3fbe547ba38390eb4871bade553a48bc74 Author: juzhiyuan AuthorDate: Mon

[GitHub] [incubator-apisix] membphis merged pull request #794: Feature prometheus

2019-11-03 Thread GitBox
membphis merged pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[incubator-apisix] branch master updated: plugin(prometheus): added new field `node` and new item latency. (#794)

2019-11-03 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 89688d3 plugin(prometheus): added

[incubator-apisix] branch master updated: bugfix: support more built-in parameters when set chash balancer (#775)

2019-11-03 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new b119a5c bugfix: support more built-i

[GitHub] [incubator-apisix] moonming merged pull request #775: bugfix: support more built-in parameters when set chash balancer

2019-11-03 Thread GitBox
moonming merged pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-apisix] moonming closed issue #717: bug: Can't set other Nginx built-in parameters when config chash balancer

2019-11-03 Thread GitBox
moonming closed issue #717: bug: Can't set other Nginx built-in parameters when config chash balancer URL: https://github.com/apache/incubator-apisix/issues/717 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-apisix] membphis commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
membphis commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341841144 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +48,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix] lyyoung commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
lyyoung commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341840808 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +47,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix] membphis commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
membphis commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341840766 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +48,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix] membphis commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
membphis commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341840534 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +47,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new pull request #62: fix: add new features and function enhance

2019-11-03 Thread GitBox
lilien1010 opened a new pull request #62: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/62 1、when enter the router list ,the Action column fixed to the right and always inside view. 2、keep router upstream service list ordered b

[GitHub] [incubator-apisix] lyyoung commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
lyyoung commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341842059 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +48,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix-dashboard] lilien1010 closed pull request #61: fix: add new features and function enhance

2019-11-03 Thread GitBox
lilien1010 closed pull request #61: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/61 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new pull request #61: Dev for multi hosts uris

2019-11-03 Thread GitBox
lilien1010 opened a new pull request #61: Dev for multi hosts uris URL: https://github.com/apache/incubator-apisix-dashboard/pull/61 1、when enter the router list ,the Action column fixed to the right and always inside view. 2、keep router upstream service list ordered by ID, which I think

[GitHub] [incubator-apisix-dashboard] lilien1010 closed pull request #60: fix: add new features and function enhance

2019-11-03 Thread GitBox
lilien1010 closed pull request #60: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/60 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new pull request #60: fix: add new features and function enhance

2019-11-03 Thread GitBox
lilien1010 opened a new pull request #60: fix: add new features and function enhance URL: https://github.com/apache/incubator-apisix-dashboard/pull/60 1、when enter the router list ,the Action column fixed to the right and always inside view. 2、keep router upstream service list ordered b

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new issue #59: bug: not support multi hosts and multi uris when create a router

2019-11-03 Thread GitBox
lilien1010 opened a new issue #59: bug: not support multi hosts and multi uris when create a router URL: https://github.com/apache/incubator-apisix-dashboard/issues/59 This is an automated message from the Apache Git Servi

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new issue #58: bug: each time I input a new upstream or router, the list is always in different order

2019-11-03 Thread GitBox
lilien1010 opened a new issue #58: bug: each time I input a new upstream or router, the list is always in different order URL: https://github.com/apache/incubator-apisix-dashboard/issues/58 each time I input a new upstream or router, the list is always in different order, which I t

[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new issue #57: bug: when enter the router list , the Action column out of views

2019-11-03 Thread GitBox
lilien1010 opened a new issue #57: bug: when enter the router list ,the Action column out of views URL: https://github.com/apache/incubator-apisix-dashboard/issues/57 when enter the router list ,the Action column out of views,we always need to scroll to the right, which is inconvenient -

[GitHub] [incubator-apisix] lyyoung commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
lyyoung commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341839612 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +47,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix] lyyoung commented on a change in pull request #794: Feature prometheus

2019-11-03 Thread GitBox
lyyoung commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341839491 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -21,6 +21,9 @@ local ngx_capture = ngx.location.capture loca