[GitHub] [incubator-apisix] agile6v opened a new pull request #1041: enhancement: using schema pattern to check if uri option starts with / in proxy-rewrite plugin.

2020-01-11 Thread GitBox
agile6v opened a new pull request #1041: enhancement: using schema pattern to check if uri option starts with / in proxy-rewrite plugin. URL: https://github.com/apache/incubator-apisix/pull/1041 This is an automated message

[GitHub] [incubator-apisix] agile6v commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

2020-01-11 Thread GitBox
agile6v commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin. URL: https://github.com/apache/incubator-apisix/pull/1039#issuecomment-573377275 I submit another PR. This is an auto

[GitHub] [incubator-apisix] membphis commented on issue #1038: feature: I want to introduce a fault-injection plugin

2020-01-11 Thread GitBox
membphis commented on issue #1038: feature: I want to introduce a fault-injection plugin URL: https://github.com/apache/incubator-apisix/issues/1038#issuecomment-573373491 Looking forward to PR ^_^ This is an automated messa

[GitHub] [incubator-apisix] membphis commented on issue #1029: feat: add basic-auth plugin

2020-01-11 Thread GitBox
membphis commented on issue #1029: feat: add basic-auth plugin URL: https://github.com/apache/incubator-apisix/pull/1029#issuecomment-573373397 travis still fail. ```shell t/debug/debug-mode.t ... 1/? # Failed test 'TEST 1: loaded plugin - grep_error_log_out (

[GitHub] [incubator-apisix] membphis edited a comment on issue #1029: feat: add basic-auth plugin

2020-01-11 Thread GitBox
membphis edited a comment on issue #1029: feat: add basic-auth plugin URL: https://github.com/apache/incubator-apisix/pull/1029#issuecomment-573373397 travis result. ```shell t/debug/debug-mode.t ... 1/? # Failed test 'TEST 1: loaded plugin - grep_error_log_ou

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1029: feat: add basic-auth plugin

2020-01-11 Thread GitBox
membphis commented on a change in pull request #1029: feat: add basic-auth plugin URL: https://github.com/apache/incubator-apisix/pull/1029#discussion_r365552293 ## File path: lua/apisix/plugins/basic-auth.lua ## @@ -0,0 +1,151 @@ +-- +-- Licensed to the Apache Software Fo

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1029: feat: add basic-auth plugin

2020-01-11 Thread GitBox
membphis commented on a change in pull request #1029: feat: add basic-auth plugin URL: https://github.com/apache/incubator-apisix/pull/1029#discussion_r365552470 ## File path: lua/apisix/plugins/basic-auth.lua ## @@ -0,0 +1,151 @@ +-- +-- Licensed to the Apache Software Fo

[GitHub] [incubator-apisix] membphis commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

2020-01-11 Thread GitBox
membphis commented on issue #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin. URL: https://github.com/apache/incubator-apisix/pull/1039#issuecomment-573370455 https://github.com/agile6v/incubator-apisix/blob/8cc4420646d958513136eb6e2b013f833b24957e/lua/apisix/

[GitHub] [incubator-apisix] membphis merged pull request #1040: Comment: add tips in the generated nginx.conf (#1003)

2020-01-11 Thread GitBox
membphis merged pull request #1040: Comment: add tips in the generated nginx.conf (#1003) URL: https://github.com/apache/incubator-apisix/pull/1040 This is an automated message from the Apache Git Service. To respond to the

[incubator-apisix] branch master updated: change: add tips in the generated nginx.conf (#1040)

2020-01-11 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 65446e8 change: add tips in the gen

[GitHub] [incubator-apisix] membphis commented on issue #1040: Comment: add tips in the generated nginx.conf (#1003)

2020-01-11 Thread GitBox
membphis commented on issue #1040: Comment: add tips in the generated nginx.conf (#1003) URL: https://github.com/apache/incubator-apisix/pull/1040#issuecomment-573370015 merged, many thx This is an automated message from the

[GitHub] [incubator-apisix] wtt20 opened a new pull request #1040: Comment: add tips in the generated nginx.conf (#1003)

2020-01-11 Thread GitBox
wtt20 opened a new pull request #1040: Comment: add tips in the generated nginx.conf (#1003) URL: https://github.com/apache/incubator-apisix/pull/1040 ### Summary add tips in the generated nginx.conf ### Full changelog * Edit file : bin/apisix to declare that the nginx

[incubator-apisix] branch master updated: bugfix: check if uri option starts with / in proxy-rewrite plugin. (#1039)

2020-01-11 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c07b8b5 bugfix: check if uri option

[GitHub] [incubator-apisix] moonming merged pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

2020-01-11 Thread GitBox
moonming merged pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin. URL: https://github.com/apache/incubator-apisix/pull/1039 This is an automated message from the Apache Git Service.

[GitHub] [incubator-apisix] agile6v opened a new pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin.

2020-01-11 Thread GitBox
agile6v opened a new pull request #1039: enhancement: check if uri option starts with "/ in proxy-rewrite plugin. URL: https://github.com/apache/incubator-apisix/pull/1039 This is an automated message from the Apache Git Ser

[GitHub] [incubator-apisix] moonming commented on issue #1029: feat: add basic-auth plugin

2020-01-11 Thread GitBox
moonming commented on issue #1029: feat: add basic-auth plugin URL: https://github.com/apache/incubator-apisix/pull/1029#issuecomment-573307607 ``` Scan detected 2 error(s) in 1 file(s): [./doc/plugins/basic-auth-cn.md]: 87: line has trailing whitespace. 115: line ha