[GitHub] [incubator-apisix] moonming opened a new issue #1668: request help: Encrypted storage of the SSL private key in etcd

2020-06-07 Thread GitBox
moonming opened a new issue #1668: URL: https://github.com/apache/incubator-apisix/issues/1668 we can use `AES` to encrypted SSL PK with [admin_key](https://github.com/apache/incubator-apisix/blob/master/conf/config.yaml#L67) as salt. -

[GitHub] [incubator-apisix-docker] moonming merged pull request #55: modify alpine build version && add readme for alpine

2020-06-07 Thread GitBox
moonming merged pull request #55: URL: https://github.com/apache/incubator-apisix-docker/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-apisix-docker] branch master updated: modify alpine build version && add readme for alpine (#55)

2020-06-07 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-docker.git The following commit(s) were added to refs/heads/master by this push: new f831a29 modify alpine build v

[GitHub] [incubator-apisix] Yiyiyimu commented on issue #1662: request help: `Key not found` error calling the Admin API

2020-06-07 Thread GitBox
Yiyiyimu commented on issue #1662: URL: https://github.com/apache/incubator-apisix/issues/1662#issuecomment-640381057 @nic-chen It works! Thank you! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] Yiyiyimu closed issue #1662: request help: `Key not found` error calling the Admin API

2020-06-07 Thread GitBox
Yiyiyimu closed issue #1662: URL: https://github.com/apache/incubator-apisix/issues/1662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-apisix] Miss-you commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

2020-06-07 Thread GitBox
Miss-you commented on pull request #1658: URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640372304 > @Miss-you please rebase your branch with `master`. This branch has conflicts that must be resolved. Okay, I'll resolve the conflict tonight.

[GitHub] [incubator-apisix] Miss-you commented on a change in pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

2020-06-07 Thread GitBox
Miss-you commented on a change in pull request #1658: URL: https://github.com/apache/incubator-apisix/pull/1658#discussion_r436460305 ## File path: bin/apisix ## @@ -21,6 +21,8 @@ local function trim(s) return (s:gsub("^%s*(.-)%s*$", "%1")) end +-- Note: The `excute_cmd

[incubator-apisix] branch master updated (c452846 -> d6cee16)

2020-06-07 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from c452846 bugfix: wildcard certificates cannot match multi-level subdomains in … (#810) add d6cee16

[GitHub] [incubator-apisix] moonming merged pull request #1437: plugin: consumer-restriction

2020-06-07 Thread GitBox
moonming merged pull request #1437: URL: https://github.com/apache/incubator-apisix/pull/1437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] griffenliu opened a new issue #1667: bug: global-rule error when enable_debug=true

2020-06-07 Thread GitBox
griffenliu opened a new issue #1667: URL: https://github.com/apache/incubator-apisix/issues/1667 ### Issue description I customized a plug-in for global rules,When I set the configuration enable_debug=true, i got the follow error: ``` 2020/06/08 11:40:56 [error] 15825#0: *330 faile

[GitHub] [incubator-apisix] dabue commented on a change in pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue commented on a change in pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665#discussion_r436441118 ## File path: bin/apisix ## @@ -781,6 +781,17 @@ local function init_etcd(show_output) local host_count = #(yaml_conf.etcd.host) +-- c

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
membphis commented on a change in pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665#discussion_r436440039 ## File path: bin/apisix ## @@ -781,6 +781,17 @@ local function init_etcd(show_output) local host_count = #(yaml_conf.etcd.host) +-

[GitHub] [incubator-apisix] dabue commented on pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue commented on pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665#issuecomment-640340120 I have updated it, please review, thx. This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-apisix] membphis commented on pull request #1524: add global name

2020-06-07 Thread GitBox
membphis commented on pull request #1524: URL: https://github.com/apache/incubator-apisix/pull/1524#issuecomment-640339320 I'm sorry to reply so late, I'm hesitant to add a similar function. Hope to hear more opinions from others. --

[GitHub] [incubator-apisix] membphis commented on pull request #962: feature: support showing apisix cluster node information

2020-06-07 Thread GitBox
membphis commented on pull request #962: URL: https://github.com/apache/incubator-apisix/pull/962#issuecomment-640333261 @agile6v do you want to continue work on this issue or we can close this PR first? This is an automated

[GitHub] [incubator-apisix] membphis merged pull request #810: bugfix: wildcard certificates cannot match multi-level subdomains in …

2020-06-07 Thread GitBox
membphis merged pull request #810: URL: https://github.com/apache/incubator-apisix/pull/810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-apisix] membphis closed issue #760: bug: wildcard certificates cannot match multi-level subdomains.

2020-06-07 Thread GitBox
membphis closed issue #760: URL: https://github.com/apache/incubator-apisix/issues/760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[incubator-apisix] branch master updated: bugfix: wildcard certificates cannot match multi-level subdomains in … (#810)

2020-06-07 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c452846 bugfix: wildcard certificat

[GitHub] [incubator-apisix] membphis commented on pull request #1655: feat: resource name

2020-06-07 Thread GitBox
membphis commented on pull request #1655: URL: https://github.com/apache/incubator-apisix/pull/1655#issuecomment-640332247 @nic-chen missing doc This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix] membphis commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

2020-06-07 Thread GitBox
membphis commented on pull request #1658: URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640330628 @Miss-you please rebase your branch with `master`. This branch has conflicts that must be resolved.

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

2020-06-07 Thread GitBox
membphis commented on a change in pull request #1658: URL: https://github.com/apache/incubator-apisix/pull/1658#discussion_r436434028 ## File path: bin/apisix ## @@ -21,6 +21,8 @@ local function trim(s) return (s:gsub("^%s*(.-)%s*$", "%1")) end +-- Note: The `excute_cmd

[GitHub] [incubator-apisix] membphis commented on pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

2020-06-07 Thread GitBox
membphis commented on pull request #1661: URL: https://github.com/apache/incubator-apisix/pull/1661#issuecomment-640329687 @Miss-you many thx This is an automated message from the Apache Git Service. To respond to the message

[incubator-apisix] branch master updated (f61b703 -> 12bfcec)

2020-06-07 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from f61b703 [log] Optimize the buffer size and flush time (#1570) add 12bfcec doc: add 'X-API-KEY' par

[GitHub] [incubator-apisix] membphis merged pull request #1661: [doc]Supplement the 'X-API-KEY' parameter for each interface that operates admin.

2020-06-07 Thread GitBox
membphis merged pull request #1661: URL: https://github.com/apache/incubator-apisix/pull/1661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix-docker] gxthrj opened a new pull request #55: modify alpine build version && add readme for alpine

2020-06-07 Thread GitBox
gxthrj opened a new pull request #55: URL: https://github.com/apache/incubator-apisix-docker/pull/55 modify alpine build version && add readme for alpine This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] Firstsawyou commented on issue #1622: bug: After the plug-in registered for global rule is deleted, all requests for access are abnormal

2020-06-07 Thread GitBox
Firstsawyou commented on issue #1622: URL: https://github.com/apache/incubator-apisix/issues/1622#issuecomment-640325868 Update to apsix version 1.3 is normal. This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-apisix] Firstsawyou edited a comment on issue #1622: bug: After the plug-in registered for global rule is deleted, all requests for access are abnormal

2020-06-07 Thread GitBox
Firstsawyou edited a comment on issue #1622: URL: https://github.com/apache/incubator-apisix/issues/1622#issuecomment-640325868 Update to apisix version 1.3 is normal. This is an automated message from the Apache Git Service

[GitHub] [incubator-apisix] Firstsawyou closed issue #1622: bug: After the plug-in registered for global rule is deleted, all requests for access are abnormal

2020-06-07 Thread GitBox
Firstsawyou closed issue #1622: URL: https://github.com/apache/incubator-apisix/issues/1622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-apisix] xxm404 commented on issue #1660: request help: APISIX can not running!

2020-06-07 Thread GitBox
xxm404 commented on issue #1660: URL: https://github.com/apache/incubator-apisix/issues/1660#issuecomment-640322594 > how did you install the apisix? luarocks? yes, install by Luarocks This is an automated message fro

[GitHub] [incubator-apisix] dabue edited a comment on pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue edited a comment on pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665#issuecomment-640322281 > @dabue I think you need to add this check in `bin/apisix` intead of travis CI. You are right. It's more reasonable to put it there,I will update it.

[GitHub] [incubator-apisix] dabue commented on pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue commented on pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665#issuecomment-640322281 > @dabue I think you need to add this check in `bin/apisix` intead of travis CI. You are right. It's more reasonable to put it there,I will update. --

[GitHub] [incubator-apisix] moonming commented on pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
moonming commented on pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665#issuecomment-640319453 @dabue I think you need to add this check in `bin/apisix` intead of travis CI. This is an automated m

[GitHub] [incubator-apisix] moonming opened a new issue #1666: add test cases in `t/` for admin api https access

2020-06-07 Thread GitBox
moonming opened a new issue #1666: URL: https://github.com/apache/incubator-apisix/issues/1666 I think the test coverage of add test case in shell is too low, e.g. I don't know what happens if I open https but send an http request, and it not test that the host is incorrect, it's basically

[GitHub] [incubator-apisix] Miss-you closed issue #1567: the buffer for access log is too large

2020-06-07 Thread GitBox
Miss-you closed issue #1567: URL: https://github.com/apache/incubator-apisix/issues/1567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-apisix] branch master updated: [log] Optimize the buffer size and flush time (#1570)

2020-06-07 Thread yousa
This is an automated email from the ASF dual-hosted git repository. yousa pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new f61b703 [log] Optimize the buffer size

[GitHub] [incubator-apisix] Miss-you merged pull request #1570: [log] Optimize the buffer size and flush time

2020-06-07 Thread GitBox
Miss-you merged pull request #1570: URL: https://github.com/apache/incubator-apisix/pull/1570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] qiukeren commented on issue #1663: bug: The 'config.yaml' update issue when reuseport is enabled

2020-06-07 Thread GitBox
qiukeren commented on issue #1663: URL: https://github.com/apache/incubator-apisix/issues/1663#issuecomment-640224764 棒 我看一下 stick. let me see see. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] dabue opened a new pull request #1665: [bugfix(CLI)]: check whether the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue opened a new pull request #1665: URL: https://github.com/apache/incubator-apisix/pull/1665 ### Summary check whether the user has enabled etcd v2 protocol. ### Full changelog update the apisix_cli_test.sh to provide a friendly error message when etvd v2 not enab

[GitHub] [incubator-apisix] dabue closed pull request #1664: [bugfix] check if the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue closed pull request #1664: URL: https://github.com/apache/incubator-apisix/pull/1664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] dabue opened a new pull request #1664: [bugfix] check if the user has enabled etcd v2 protocol.

2020-06-07 Thread GitBox
dabue opened a new pull request #1664: URL: https://github.com/apache/incubator-apisix/pull/1664 ### Summary check if the user has enabled etcd v2 protocol ### Full changelog update apisix_cli_test.sh to check whether the user enabled etcd v2 protocol. ### Issues r

[GitHub] [incubator-apisix] nic-chen commented on issue #1663: bug: The 'config.yaml' update issue when reuseport is enabled

2020-06-07 Thread GitBox
nic-chen commented on issue #1663: URL: https://github.com/apache/incubator-apisix/issues/1663#issuecomment-640217272 @qiukeren I found this issue quite suit you, you just fix a similar one. would you like to fix this one too ? ^_^ ---

[GitHub] [incubator-apisix] nic-chen opened a new issue #1663: bug: The 'config.yaml' update issue when reuseport is enabled

2020-06-07 Thread GitBox
nic-chen opened a new issue #1663: URL: https://github.com/apache/incubator-apisix/issues/1663 ### Issue description We recently encountered a bug: when reuseport is enabled by default, during the running of APISIX, modify `config.yaml` and start without stopping APISIX. This resu

[GitHub] [incubator-apisix] membphis closed issue #1647: feature: support to enable HTTPS for admin API

2020-06-07 Thread GitBox
membphis closed issue #1647: URL: https://github.com/apache/incubator-apisix/issues/1647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-apisix] branch master updated: feature: support to enable HTTPS for admin API (#1648)

2020-06-07 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 3228e16 feature: support to enable

[GitHub] [incubator-apisix] membphis merged pull request #1648: feature: support to enable HTTPS for admin API

2020-06-07 Thread GitBox
membphis merged pull request #1648: URL: https://github.com/apache/incubator-apisix/pull/1648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] nic-chen edited a comment on issue #1646: bug: limit-req in consumer is not work for grpc-proxy

2020-06-07 Thread GitBox
nic-chen edited a comment on issue #1646: URL: https://github.com/apache/incubator-apisix/issues/1646#issuecomment-640189842 > i am a fresh man of lua and openresty. > can you give me some hint(For example, which file should be mainly changed)? So i can try to support it. I'm sor

[GitHub] [incubator-apisix] nic-chen commented on issue #1662: request help: `Key not found` error calling the Admin API

2020-06-07 Thread GitBox
nic-chen commented on issue #1662: URL: https://github.com/apache/incubator-apisix/issues/1662#issuecomment-640213028 > Thank you @nic-chen ! > > The IP and port are the same for my case, and the output of `curl 127.0.0.1:2379/v2/keys` is `{"action":"get","node":{"dir":true}}`. >

[GitHub] [incubator-apisix] dabue commented on pull request #1648: feature: support to enable HTTPS for admin API

2020-06-07 Thread GitBox
dabue commented on pull request #1648: URL: https://github.com/apache/incubator-apisix/pull/1648#issuecomment-640206434 The test cases only checked whether the added field https_admin in config.yaml is in effect or not. Thi

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1648: feature: support to enable HTTPS for admin API

2020-06-07 Thread GitBox
moonming commented on a change in pull request #1648: URL: https://github.com/apache/incubator-apisix/pull/1648#discussion_r436349899 ## File path: .travis/apisix_cli_test.sh ## @@ -72,3 +72,47 @@ done sed -i '/dns_resolver:/,+4s/^#//' conf/config.yaml echo "passed: system

[GitHub] [incubator-apisix] Yiyiyimu commented on issue #1662: request help: `Key not found` error calling the Admin API

2020-06-07 Thread GitBox
Yiyiyimu commented on issue #1662: URL: https://github.com/apache/incubator-apisix/issues/1662#issuecomment-640191725 Thank you @nic-chen ! The IP and port are the same for my case, and the output of `curl 127.0.0.1:2379/v2/keys` is `{"action":"get","node":{"dir":true}}`. Bu

[GitHub] [incubator-apisix] nic-chen commented on issue #1646: bug: limit-req in consumer is not work for grpc-proxy

2020-06-07 Thread GitBox
nic-chen commented on issue #1646: URL: https://github.com/apache/incubator-apisix/issues/1646#issuecomment-640189842 > i am a fresh man of lua and openresty. > can you give me some hint(For example, which file should be mainly changed)? So i can try to support it. I'm sorry to r

[GitHub] [incubator-apisix] Miss-you edited a comment on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

2020-06-07 Thread GitBox
Miss-you edited a comment on pull request #1658: URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640173575 @membphis Please help with codereview. This is an automated message from the Apache Git Service

[GitHub] [incubator-apisix] Miss-you commented on pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

2020-06-07 Thread GitBox
Miss-you commented on pull request #1658: URL: https://github.com/apache/incubator-apisix/pull/1658#issuecomment-640173575 @membphis This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] Miss-you commented on pull request #1570: [log] Optimize the buffer size and flush time

2020-06-07 Thread GitBox
Miss-you commented on pull request #1570: URL: https://github.com/apache/incubator-apisix/pull/1570#issuecomment-640173461 > it seems blocked. @Miss-you need your help > > ![image](https://user-images.githubusercontent.com/6814606/83935476-7e38e600-a7ec-11ea-9623-dd60f3adb001.png)