[GitHub] [incubator-apisix] agile6v commented on pull request #1632: Add body filter and header filter plugin drafts.

2020-06-12 Thread GitBox
agile6v commented on pull request #1632: URL: https://github.com/apache/incubator-apisix/pull/1632#issuecomment-643546180 Hi @Akayeshmantha LGTM. Let's move on. 1. add headers to client (can be implemented in the header_filter phase) 2. implement a simple auth. i.e.

[GitHub] [incubator-apisix] agile6v commented on a change in pull request #1632: Add body filter and header filter plugin drafts.

2020-06-12 Thread GitBox
agile6v commented on a change in pull request #1632: URL: https://github.com/apache/incubator-apisix/pull/1632#discussion_r439692287 ## File path: apisix/plugins/echo.lua ## @@ -0,0 +1,68 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribu

[GitHub] [incubator-apisix-dashboard] moonming commented on pull request #257: add grafana & fix some bug

2020-06-12 Thread GitBox
moonming commented on pull request #257: URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643269935 yes, we need the asf header 琚致远 于 2020年6月12日周五 下午9:16写道: > *@juzhiyuan* requested changes on this pull request. >

[GitHub] [incubator-apisix] xxm404 opened a new issue #1706: request help: Support custom Nginx template

2020-06-12 Thread GitBox
xxm404 opened a new issue #1706: URL: https://github.com/apache/incubator-apisix/issues/1706 ### Issue description we need to support user can custom Nginx template instead of modify source code ### Environment * apisix version (cmd: `apisix version`):latest * OS:linux

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #257: add grafana & fix some bug

2020-06-12 Thread GitBox
juzhiyuan commented on a change in pull request #257: URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#discussion_r439411241 ## File path: compose/grafana_conf/provisioning/dashboards/all.yaml ## @@ -0,0 +1,11 @@ +apiVersion: 1 + +providers: +- name: 'default

[GitHub] [incubator-apisix] QuakeWang opened a new pull request #1705: Update README_CN.md

2020-06-12 Thread GitBox
QuakeWang opened a new pull request #1705: URL: https://github.com/apache/incubator-apisix/pull/1705 更改“用户”为“用于”。 NOTE: Please read the Contributing.md guidelines before submitting your patch: https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a

[GitHub] [incubator-apisix] membphis commented on pull request #1701: Authorization Plugin for Keycloak Identity Server

2020-06-12 Thread GitBox
membphis commented on pull request #1701: URL: https://github.com/apache/incubator-apisix/pull/1701#issuecomment-643217008 great PR This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1701: Authorization Plugin for Keycloak Identity Server

2020-06-12 Thread GitBox
membphis commented on a change in pull request #1701: URL: https://github.com/apache/incubator-apisix/pull/1701#discussion_r439355808 ## File path: apisix/plugins/authz-keycloak.lua ## @@ -0,0 +1,167 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1701: Authorization Plugin for Keycloak Identity Server

2020-06-12 Thread GitBox
membphis commented on a change in pull request #1701: URL: https://github.com/apache/incubator-apisix/pull/1701#discussion_r439355758 ## File path: apisix/plugins/authz-keycloak.lua ## @@ -0,0 +1,167 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1697: [batch-request]feat: cp all header to every request

2020-06-12 Thread GitBox
membphis commented on a change in pull request #1697: URL: https://github.com/apache/incubator-apisix/pull/1697#discussion_r439355217 ## File path: t/plugin/batch-requests.t ## @@ -716,24 +722,28 @@ passed { "status": 200,

[GitHub] [incubator-apisix-dashboard] membphis commented on pull request #257: add grafana & fix some bug

2020-06-12 Thread GitBox
membphis commented on pull request #257: URL: https://github.com/apache/incubator-apisix-dashboard/pull/257#issuecomment-643208421 How about rename to `apisix_http_prometheus.json'? `compose/grafana_conf/dashboards/apisix.json` --

[GitHub] [incubator-apisix-dashboard] gxthrj opened a new pull request #257: add grafana & fix some bug

2020-06-12 Thread GitBox
gxthrj opened a new pull request #257: URL: https://github.com/apache/incubator-apisix-dashboard/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[incubator-apisix-dashboard] branch master updated: feat: remove codes

2020-06-12 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 385070f feat: remove cod

[incubator-apisix-dashboard] branch master updated: feat: remove codes

2020-06-12 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 385070f feat: remove cod

[incubator-apisix-dashboard] branch master updated: feat: patch fix

2020-06-12 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new d80f6cd feat: patch fix

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1701: Authorization Plugin for Keycloak Identity Server

2020-06-12 Thread GitBox
sshniro commented on a change in pull request #1701: URL: https://github.com/apache/incubator-apisix/pull/1701#discussion_r439308187 ## File path: apisix/plugins/authz-keycloak.lua ## @@ -0,0 +1,128 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [incubator-apisix] Akayeshmantha commented on pull request #1632: Add body filter and header filter plugin drafts.

2020-06-12 Thread GitBox
Akayeshmantha commented on pull request #1632: URL: https://github.com/apache/incubator-apisix/pull/1632#issuecomment-643167367 thanks alot This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] moonming commented on pull request #1632: Add body filter and header filter plugin drafts.

2020-06-12 Thread GitBox
moonming commented on pull request #1632: URL: https://github.com/apache/incubator-apisix/pull/1632#issuecomment-643161365 sure, restarted. Thanks, Ming Wen Twitter: _WenMing Ayeshmantha Perera 于2020年6月12日周五 下午4:59写道: > *@Akayeshmantha* commented on this pull

[GitHub] [incubator-apisix] moonming commented on issue #1653: add AK/SK auth plugin

2020-06-12 Thread GitBox
moonming commented on issue #1653: URL: https://github.com/apache/incubator-apisix/issues/1653#issuecomment-643156524 yes Thanks, Ming Wen Twitter: _WenMing 琚致远 于2020年6月12日周五 下午4:42写道: > AccessKey and SecrectKey just like AWS IAM keys? > > — > You ar

[GitHub] [incubator-apisix] juzhiyuan commented on issue #1653: add AK/SK auth plugin

2020-06-12 Thread GitBox
juzhiyuan commented on issue #1653: URL: https://github.com/apache/incubator-apisix/issues/1653#issuecomment-643152285 AccessKey and SecrectKey just like AWS IAM keys? This is an automated message from the Apache Git Service