[GitHub] [incubator-apisix] membphis commented on issue #1736: request help: stream_proxy the parameters of the proxy

2020-06-19 Thread GitBox
membphis commented on issue #1736: URL: https://github.com/apache/incubator-apisix/issues/1736#issuecomment-646477523 we should support this feature, welcome PR. This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-apisix] moonming commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox
moonming commented on issue #1737: URL: https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646482232 @Donghui0 can not reproduced in my side. Can you provide reproduction steps? This is an automated mes

[GitHub] [incubator-apisix] FunnySunshine520 opened a new issue #1738: bug: Without directory /tmp/apisix_cores, the system will not work

2020-06-19 Thread GitBox
FunnySunshine520 opened a new issue #1738: URL: https://github.com/apache/incubator-apisix/issues/1738 ### Issue description if directory /tmp/apisix_cores does not exist and use "make reload" to reload the system. Then this system is not working properly ### Environment * OS

[GitHub] [incubator-apisix] shibingli commented on a change in pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox
shibingli commented on a change in pull request #1659: URL: https://github.com/apache/incubator-apisix/pull/1659#discussion_r442698816 ## File path: t/admin/services.t ## @@ -26,12 +26,12 @@ run_tests; __DATA__ -=== TEST 1: set service(id: 1) +=== TEST 1: set service(id: 5

[GitHub] [incubator-apisix-docker] lingsamuel opened a new issue #59: gcr.azk8s.cn no longer public

2020-06-19 Thread GitBox
lingsamuel opened a new issue #59: URL: https://github.com/apache/incubator-apisix-docker/issues/59 Reference: https://github.com/Azure/container-service-for-azure-china/issues/58#issuecomment-630765201 This is an automated

[incubator-apisix-website] 01/01: add translate doc.

2020-06-19 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch release-english in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git commit 7fc05fc2255a304c797ac5ab91029c301678cf9d Author: WenMing AuthorDate: Fri Jun 19 16:26:15 202

[incubator-apisix-website] branch release-english created (now 7fc05fc)

2020-06-19 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch release-english in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git. at 7fc05fc add translate doc. This branch includes the following new commits: new 7f

[GitHub] [incubator-apisix-website] moonming opened a new pull request #49: doc: add translate doc for release guide.

2020-06-19 Thread GitBox
moonming opened a new pull request #49: URL: https://github.com/apache/incubator-apisix-website/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix-website] juzhiyuan merged pull request #49: doc: add translate doc for release guide.

2020-06-19 Thread GitBox
juzhiyuan merged pull request #49: URL: https://github.com/apache/incubator-apisix-website/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-apisix-website] branch master updated: add translate doc. (#49)

2020-06-19 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 2fcfa30 add translate doc.

[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-06-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d75f531 Deploy to Git

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #35: Translate Release Guide in English

2020-06-19 Thread GitBox
juzhiyuan closed issue #35: URL: https://github.com/apache/incubator-apisix-website/issues/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix-docker] gxthrj commented on issue #59: gcr.azk8s.cn no longer public

2020-06-19 Thread GitBox
gxthrj commented on issue #59: URL: https://github.com/apache/incubator-apisix-docker/issues/59#issuecomment-646517243 the image has been changed, used `gcr.io/etcd-development/etcd:v3.3.12` now https://github.com/apache/incubator-apisix-docker/blob/f3db8c3e3f6860ef32af2d4373ab864d1b55a

[GitHub] [incubator-apisix] Donghui0 commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox
Donghui0 commented on issue #1737: URL: https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646544945 In my production env, total 117 routes. basically, each route is configured with limit-count plugin. Whether there will be conflicts ? Or the current limit rule

[GitHub] [incubator-apisix] Donghui0 commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox
Donghui0 commented on issue #1737: URL: https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646546329 If a large number of routes use this plugin, do we need to increase PLUGIN_ITEMS_COUNT in lrucache.lua ?

[incubator-apisix] branch v1.4 created (now 7307797)

2020-06-19 Thread sshniro
This is an automated email from the ASF dual-hosted git repository. sshniro pushed a change to branch v1.4 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. at 7307797 feature: support the use of independent files to implement the load a… (#1732) No new revisions w

[GitHub] [incubator-apisix-docker] lingsamuel commented on issue #59: gcr.azk8s.cn no longer public

2020-06-19 Thread GitBox
lingsamuel commented on issue #59: URL: https://github.com/apache/incubator-apisix-docker/issues/59#issuecomment-646559131 What's this? https://github.com/apache/incubator-apisix-docker/blob/f3db8c3e3f6860ef32af2d4373ab864d1b55a178/example/docker-compose.yml#L23-L24 --

[GitHub] [incubator-apisix] moonming commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox
moonming commented on issue #1737: URL: https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646559664 you can increase the size of shared dict: https://github.com/apache/incubator-apisix/blob/master/bin/apisix#L178, which is LRU.

[GitHub] [incubator-apisix] moonming commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox
moonming commented on issue #1737: URL: https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646559781 > conflicts No, it will not conflict This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-apisix] moonming edited a comment on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox
moonming edited a comment on issue #1737: URL: https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646559781 > In my production env, total 117 routes. basically, each route is configured with limit-count plugin. Whether there will be conflicts ? No, it will not co

[GitHub] [incubator-apisix] Akayeshmantha commented on pull request #1708: feature(echo): support header filter and access phases.

2020-06-19 Thread GitBox
Akayeshmantha commented on pull request #1708: URL: https://github.com/apache/incubator-apisix/pull/1708#issuecomment-646626547 @agile6v @membphis I think we can merge this right and will start on working the other phases

[GitHub] [incubator-apisix] membphis opened a new pull request #1739: bugfix: the id can be string object, which contains `^[a-zA-Z0-9-_]+$`.

2020-06-19 Thread GitBox
membphis opened a new pull request #1739: URL: https://github.com/apache/incubator-apisix/pull/1739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] membphis commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
membphis commented on pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646631199 > need add in the README.md https://github.com/apache/incubator-apisix/pull/1727/files#diff-e8976e35ba880b8daf3c56fa658dd2b5 DONE --

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox
membphis commented on a change in pull request #1659: URL: https://github.com/apache/incubator-apisix/pull/1659#discussion_r442839067 ## File path: apisix/admin/services.lua ## @@ -47,15 +43,15 @@ local function check_conf(id, conf, need_id) return nil, {error_msg = "w

[GitHub] [incubator-apisix] membphis commented on issue #1731: request help:

2020-06-19 Thread GitBox
membphis commented on issue #1731: URL: https://github.com/apache/incubator-apisix/issues/1731#issuecomment-646637367 I think only support DNS-based Service Discovery for `nacos` is not enough. The `nacos` call it `Dynamic Configuration Management`, Apache APISIX need to support bot

[GitHub] [incubator-apisix] membphis commented on issue #1731: request help:

2020-06-19 Thread GitBox
membphis commented on issue #1731: URL: https://github.com/apache/incubator-apisix/issues/1731#issuecomment-646637891 > nacos supports DNS-based Service Discovery, It needs to be written into the document. This is an

[GitHub] [incubator-apisix] membphis merged pull request #1708: feature(echo): support header filter and access phases.

2020-06-19 Thread GitBox
membphis merged pull request #1708: URL: https://github.com/apache/incubator-apisix/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-apisix] branch master updated: feature(echo): support header filter and access phases. (#1708)

2020-06-19 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new f8f104d feature(echo): support head

[GitHub] [incubator-apisix] membphis commented on pull request #1708: feature(echo): support header filter and access phases.

2020-06-19 Thread GitBox
membphis commented on pull request #1708: URL: https://github.com/apache/incubator-apisix/pull/1708#issuecomment-646638433 @Akayeshmantha merged, many thx This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-apisix] membphis commented on issue #1713: request help: add auth for etcd

2020-06-19 Thread GitBox
membphis commented on issue #1713: URL: https://github.com/apache/incubator-apisix/issues/1713#issuecomment-646639410 support etcd v3 is a big event. I hope we can start this step asap. This is an automated message from the

[GitHub] [incubator-apisix] membphis commented on issue #1699: request help: how to custom apisix home directory

2020-06-19 Thread GitBox
membphis commented on issue #1699: URL: https://github.com/apache/incubator-apisix/issues/1699#issuecomment-646641849 Do you want to customize the path in the production environment or the local development environment? production environment: soft link is a good way. eg: /usr/local

[GitHub] [incubator-apisix] membphis edited a comment on issue #1699: request help: how to custom apisix home directory

2020-06-19 Thread GitBox
membphis edited a comment on issue #1699: URL: https://github.com/apache/incubator-apisix/issues/1699#issuecomment-646641849 Do you want to customize the path in the production environment or the local development environment? production environment: soft link is a good way. eg: /us

[GitHub] [incubator-apisix] membphis commented on issue #1715: bug: healthcheck bug

2020-06-19 Thread GitBox
membphis commented on issue #1715: URL: https://github.com/apache/incubator-apisix/issues/1715#issuecomment-646644644 please update your version first. I remember we have fixed such a bug. This is an automated message from t

[GitHub] [incubator-apisix] membphis commented on issue #1548: Support Groups for consumers

2020-06-19 Thread GitBox
membphis commented on issue #1548: URL: https://github.com/apache/incubator-apisix/issues/1548#issuecomment-646647729 I am very interested in this feature. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
spacewander commented on a change in pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#discussion_r442850805 ## File path: apisix/plugins/uri-blocker.lua ## @@ -0,0 +1,85 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [incubator-apisix] agile6v commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
agile6v commented on pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646896513 Also, What's the differences between `doc/zh-cn/README.md` and `doc/README_CN.md`? This is an automate

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
membphis commented on a change in pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#discussion_r443085739 ## File path: doc/plugins/uri-blocker.md ## @@ -0,0 +1,96 @@ + + +[Chinese](uri-blocker.md) + +# Summary + +- [**Name**](#name) +- [**Attributes

[GitHub] [incubator-apisix] membphis commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
membphis commented on pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646921302 > Also, What's the differences between `doc/zh-cn/README.md` and `doc/README_CN.md`? fix this later. it should be one file. ---

[GitHub] [incubator-apisix] membphis commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
membphis commented on pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646922700 > We could add a test case for multiple rules and test it. added, good catch. This is an automa

[GitHub] [incubator-apisix] membphis commented on issue #1689: Use ipv4 API turn out 403 error

2020-06-19 Thread GitBox
membphis commented on issue #1689: URL: https://github.com/apache/incubator-apisix/issues/1689#issuecomment-646926148 @zheng11581 do you have fixed? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] membphis opened a new issue #1740: safe: Apache APISIX security configuration

2020-06-19 Thread GitBox
membphis opened a new issue #1740: URL: https://github.com/apache/incubator-apisix/issues/1740 check the current nginx.conf if it has any security problem. This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] membphis commented on issue #1693: request help: apisix supports running as root user

2020-06-19 Thread GitBox
membphis commented on issue #1693: URL: https://github.com/apache/incubator-apisix/issues/1693#issuecomment-646926475 > I think we need an Apache APISIX security configuration specification. that is another question. I have created a new issue: https://github.com/apache/incubator-ap

[GitHub] [incubator-apisix] membphis edited a comment on issue #1693: request help: apisix supports running as root user

2020-06-19 Thread GitBox
membphis edited a comment on issue #1693: URL: https://github.com/apache/incubator-apisix/issues/1693#issuecomment-646926475 > I think we need an Apache APISIX security configuration specification. that is another question. I have created a new issue: https://github.com/apache/incub

[GitHub] [incubator-apisix] membphis commented on issue #1686: request help: Does the protocol support custom transformations

2020-06-19 Thread GitBox
membphis commented on issue #1686: URL: https://github.com/apache/incubator-apisix/issues/1686#issuecomment-646927368 @guoziqin it needs some work to support custom transformations. if you need any help, please let me know.

[GitHub] [incubator-apisix] membphis commented on issue #1680: Is etcd configuration support v3 api

2020-06-19 Thread GitBox
membphis commented on issue #1680: URL: https://github.com/apache/incubator-apisix/issues/1680#issuecomment-646927775 lua-resty-etcd already supports etcd v3, welcome PR. This is an automated message from the Apache Git Serv

[GitHub] [incubator-apisix] membphis edited a comment on issue #1680: Is etcd configuration support v3 api

2020-06-19 Thread GitBox
membphis edited a comment on issue #1680: URL: https://github.com/apache/incubator-apisix/issues/1680#issuecomment-646927775 lua-resty-etcd already supports etcd v3, welcome PR. https://github.com/api7/lua-resty-etcd/blob/master/api_v3.md ---

[GitHub] [incubator-apisix] wangxiaolong100 opened a new issue #1741: request help: openid-connect plugin with hydra not working as expected

2020-06-19 Thread GitBox
wangxiaolong100 opened a new issue #1741: URL: https://github.com/apache/incubator-apisix/issues/1741 ### Issue description openid-connect can not block not active access token. hydra introspect endpoint return ` HTTP/1.1 200 OK Content-Type: application/json Date:

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox
spacewander commented on a change in pull request #1727: URL: https://github.com/apache/incubator-apisix/pull/1727#discussion_r443096855 ## File path: doc/plugins/uri-blocker.md ## @@ -0,0 +1,96 @@ + + +[Chinese](uri-blocker.md) + +# Summary + +- [**Name**](#name) +- [**Attribu

[GitHub] [incubator-apisix] zheng11581 commented on issue #1689: Use ipv4 API turn out 403 error

2020-06-19 Thread GitBox
zheng11581 commented on issue #1689: URL: https://github.com/apache/incubator-apisix/issues/1689#issuecomment-646938774 no i didn't. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] shibingli closed pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox
shibingli closed pull request #1659: URL: https://github.com/apache/incubator-apisix/pull/1659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-apisix] shibingli commented on pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox
shibingli commented on pull request #1659: URL: https://github.com/apache/incubator-apisix/pull/1659#issuecomment-646942517 Merger #1739 This is an automated message from the Apache Git Service. To respond to the message, p