[GitHub] [incubator-apisix] membphis commented on issue #1604: bug: stand alone mode proxy-rewrite headers has bug

2020-07-15 Thread GitBox
membphis commented on issue #1604: URL: https://github.com/apache/incubator-apisix/issues/1604#issuecomment-659190881 and we need to update this file: https://github.com/apache/incubator-apisix/blob/master/apisix/core/config_yaml.lua @nic-chen do you have time to fix this bug? ---

[GitHub] [incubator-apisix] membphis commented on issue #1604: bug: stand alone mode proxy-rewrite headers has bug

2020-07-15 Thread GitBox
membphis commented on issue #1604: URL: https://github.com/apache/incubator-apisix/issues/1604#issuecomment-659190647 we need to check schema after we got the conf, here is an example: ```lua if data_valid and self.item_schema then data_valid, err = check_schema(self.i

[GitHub] [incubator-apisix] Miss-you opened a new issue #1853: bug: The recommended value for worker_shutdown_timeout is 240 seconds.

2020-07-15 Thread GitBox
Miss-you opened a new issue #1853: URL: https://github.com/apache/incubator-apisix/issues/1853 ### Issue description current ``` worker_shutdown_timeout: 3s # timeout for a graceful shutdown of worker processes ``` https://github.com/apache/incubator-apisix/blob/mas

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1852: doc: update README.md for proxy-mirror

2020-07-15 Thread GitBox
moonming commented on a change in pull request #1852: URL: https://github.com/apache/incubator-apisix/pull/1852#discussion_r455526398 ## File path: README.md ## @@ -69,7 +69,8 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against - Hash-based

[GitHub] [incubator-apisix] UnderTreeTech commented on issue #1804: performance: spend more time on ssl handshake

2020-07-15 Thread GitBox
UnderTreeTech commented on issue #1804: URL: https://github.com/apache/incubator-apisix/issues/1804#issuecomment-659175368 Any updates? @membphis @moonming This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-apisix] scaat opened a new pull request #1852: doc: update README.md for proxy-mirror

2020-07-15 Thread GitBox
scaat opened a new pull request #1852: URL: https://github.com/apache/incubator-apisix/pull/1852 ### What this PR does / why we need it: Fix #1847 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] Beckjiang opened a new issue #1850: request help: How to grayscale update the api configuration

2020-07-15 Thread GitBox
Beckjiang opened a new issue #1850: URL: https://github.com/apache/incubator-apisix/issues/1850 ### Issue description Does it now support grayscale update API configuration? If it's not supported, what are the ideas to implement it? ---

[GitHub] [incubator-apisix] wanzhenhan opened a new issue #1851: health check can't use

2020-07-15 Thread GitBox
wanzhenhan opened a new issue #1851: URL: https://github.com/apache/incubator-apisix/issues/1851 环境: version: v1.4.0 路由和upstream配置: curl -i --connect-timeout 1 http://127.0.0.1:9080/apisix/admin/routes/ -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' { "m

[GitHub] [incubator-apisix] mtx2d commented on pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#issuecomment-659119097 Hi @membphis, Do we think this is PR good to move forward :D? This is an automated message from the

[GitHub] [incubator-apisix] ko-han commented on a change in pull request #1795: feature: expose API for dns resolving

2020-07-15 Thread GitBox
ko-han commented on a change in pull request #1795: URL: https://github.com/apache/incubator-apisix/pull/1795#discussion_r455467851 ## File path: apisix/init.lua ## @@ -630,5 +630,18 @@ function _M.stream_log_phase() run_plugin("log") end +do +local dns_resolver_cac

[GitHub] [incubator-apisix] RocFang opened a new pull request #1849: fix hyper links in readme

2020-07-15 Thread GitBox
RocFang opened a new pull request #1849: URL: https://github.com/apache/incubator-apisix/pull/1849 ### What this PR does / why we need it: Found some link errors when start reading the docs. ### Pre-submission checklist: * [ x ] Did you explain what problem does this

[GitHub] [incubator-apisix] mtx2d commented on pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#issuecomment-658897291 According to this [doc](https://github.com/travis-ci/travis-ci/issues/576#issuecomment-65317915), we can close and reopen, which will trigger a new CI run without making

[GitHub] [incubator-apisix] mtx2d closed pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d closed pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] mtx2d commented on pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#issuecomment-658895818 The CI fails due to CI server network issue: https://github.com/apache/incubator-apisix/pull/1845/checks?check_run_id=874200614#step:3:68 Will make a small change a

[GitHub] [incubator-apisix] mtx2d commented on pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#issuecomment-658885499 > @moonming @membphis , is it possible to force trigger a CI? > I made new commit to my local repo mtx2d/incubato-apisix, but the CI still looks at the old states.(my m

[GitHub] [incubator-apisix] mtx2d commented on pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#issuecomment-658874317 @moonming @membphis , is it possible to force trigger a CI? I made new commit to my local repo mtx2d/incubato-apisix, but the CI still looks at the old states.(my mast

[GitHub] [incubator-apisix] mtx2d commented on pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#issuecomment-658863570 Trying to figure out how to trigger CI. This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-apisix] mtx2d commented on a change in pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
mtx2d commented on a change in pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#discussion_r455175520 ## File path: t/lib/server.lua ## @@ -112,10 +112,6 @@ function _M.mock_skywalking_v2_instance_register() ngx.say(json_encode(ret)) end -fu

[GitHub] [incubator-apisix] Miss-you edited a comment on issue #1842: request help: log phase occurs nil pointer error log.

2020-07-15 Thread GitBox
Miss-you edited a comment on issue #1842: URL: https://github.com/apache/incubator-apisix/issues/1842#issuecomment-658845583 If you are using luarocks to install, you can try `luarocks install apisix` to upgrade the APISIX

[GitHub] [incubator-apisix] Miss-you commented on issue #1842: request help: log phase occurs nil pointer error log.

2020-07-15 Thread GitBox
Miss-you commented on issue #1842: URL: https://github.com/apache/incubator-apisix/issues/1842#issuecomment-658845583 If you are using luarocks to install, you can uninstall and reinstall. This is an automated message from t

[GitHub] [incubator-apisix] Miss-you commented on issue #1842: request help: log phase occurs nil pointer error log.

2020-07-15 Thread GitBox
Miss-you commented on issue #1842: URL: https://github.com/apache/incubator-apisix/issues/1842#issuecomment-658844948 I think you should upgrade the apache apisix . This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] Miss-you commented on issue #1846: bug: Missing the CODE_STYLE.md file

2020-07-15 Thread GitBox
Miss-you commented on issue #1846: URL: https://github.com/apache/incubator-apisix/issues/1846#issuecomment-658844218 https://github.com/apache/incubator-apisix/pull/1848 This is an automated message from the Apache Git Serv

[GitHub] [incubator-apisix] Miss-you edited a comment on issue #1846: bug: Missing the CODE_STYLE.md file

2020-07-15 Thread GitBox
Miss-you edited a comment on issue #1846: URL: https://github.com/apache/incubator-apisix/issues/1846#issuecomment-658843329 I think it would be more appropriate to use this document as a code style guide. https://github.com/luarocks/lua-style-guide ---

[GitHub] [incubator-apisix] Miss-you commented on issue #1846: bug: Missing the CODE_STYLE.md file

2020-07-15 Thread GitBox
Miss-you commented on issue #1846: URL: https://github.com/apache/incubator-apisix/issues/1846#issuecomment-658843329 I think it would be more appropriate to use this document as a code style guide. https://github.com/luarocks/lua-style-guide --

[GitHub] [incubator-apisix] Miss-you opened a new pull request #1848: [doc] remove the CODE_STYLE.md ref

2020-07-15 Thread GitBox
Miss-you opened a new pull request #1848: URL: https://github.com/apache/incubator-apisix/pull/1848 ### What this PR does / why we need it: Remove the CODE_STYLE.md ref which would cause invalid reference. ### Pre-submission checklist: * [ ] Did you explain what

[incubator-apisix-website] branch master updated: feat(graduate): remove incubating text (#52)

2020-07-15 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 61b2372 feat(graduate): re

[GitHub] [incubator-apisix-website] juzhiyuan merged pull request #52: feat(graduate): remove incubating text

2020-07-15 Thread GitBox
juzhiyuan merged pull request #52: URL: https://github.com/apache/incubator-apisix-website/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix-website] juzhiyuan opened a new pull request #52: feat(graduate): remove incubating text

2020-07-15 Thread GitBox
juzhiyuan opened a new pull request #52: URL: https://github.com/apache/incubator-apisix-website/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-07-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 87a6842 Deploy to Git

[incubator-apisix-website] 01/01: feat(graduate): remove incubating text

2020-07-15 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feat-graduate in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git commit 20a877024ba14e4fdec061146b2d4e9fda5a8157 Author: juzhiyuan AuthorDate: Wed Jul 15 21:08:01 2

[incubator-apisix-website] branch feat-graduate created (now 20a8770)

2020-07-15 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-graduate in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git. at 20a8770 feat(graduate): remove incubating text This branch includes the following new c

[GitHub] [incubator-apisix-website] juzhiyuan opened a new issue #51: Refactor Website by React or Vue.js

2020-07-15 Thread GitBox
juzhiyuan opened a new issue #51: URL: https://github.com/apache/incubator-apisix-website/issues/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
membphis commented on a change in pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#discussion_r454943520 ## File path: t/lib/server.lua ## @@ -112,10 +112,6 @@ function _M.mock_skywalking_v2_instance_register() ngx.say(json_encode(ret)) end

[incubator-apisix] branch master updated: doc: add more info for pr template. (#1840)

2020-07-15 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 9a6a86c doc: add more info for pr te

[GitHub] [incubator-apisix] moonming merged pull request #1840: doc: add more info for pr template.

2020-07-15 Thread GitBox
moonming merged pull request #1840: URL: https://github.com/apache/incubator-apisix/pull/1840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1845: remove not used plugin heartbeat.lua

2020-07-15 Thread GitBox
moonming commented on a change in pull request #1845: URL: https://github.com/apache/incubator-apisix/pull/1845#discussion_r454917841 ## File path: Makefile ## @@ -176,7 +176,7 @@ install: default ### test: Run the test case test: - prove -I../test-nginx/l

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1795: feature: expose API for dns resolving

2020-07-15 Thread GitBox
moonming commented on a change in pull request #1795: URL: https://github.com/apache/incubator-apisix/pull/1795#discussion_r454892966 ## File path: apisix/init.lua ## @@ -630,5 +630,18 @@ function _M.stream_log_phase() run_plugin("log") end +do +local dns_resolver_c

[GitHub] [incubator-apisix] nanwenbo commented on issue #1831: request help: Mac os can't start apisix

2020-07-15 Thread GitBox
nanwenbo commented on issue #1831: URL: https://github.com/apache/incubator-apisix/issues/1831#issuecomment-658608258 > BTW, is APISIX still can wroks well? I think warn level will not block start. apisix is not work, i reinstall openresty 1.15.8.3 ,apisix is working now. --

[GitHub] [incubator-apisix] mtx2d closed issue #1844: request help: Local Test for Master Barnch Failed 26% Cases

2020-07-15 Thread GitBox
mtx2d closed issue #1844: URL: https://github.com/apache/incubator-apisix/issues/1844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-apisix] mtx2d commented on issue #1844: request help: Local Test for Master Barnch Failed 26% Cases

2020-07-15 Thread GitBox
mtx2d commented on issue #1844: URL: https://github.com/apache/incubator-apisix/issues/1844#issuecomment-658596137 I will close this. The recommended way to test is to file a PR and trigger CI to run full set of tests. This