[GitHub] [incubator-apisix] Joe123-ai commented on issue #1880: request help: The port disappears after redirection

2020-07-20 Thread GitBox
Joe123-ai commented on issue #1880: URL: https://github.com/apache/incubator-apisix/issues/1880#issuecomment-661669518 我不太明白您的意思,您能说下需要我这边怎么测试下吗 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-apisix] moonming commented on issue #1880: request help: The port disappears after redirection

2020-07-20 Thread GitBox
moonming commented on issue #1880: URL: https://github.com/apache/incubator-apisix/issues/1880#issuecomment-661667858 is there has `Location:` response header? Thanks, Ming Wen Twitter: _WenMing Joe123-ai 于2020年7月21日周二 下午2:41写道: > 需要我做什么处理吗 > > — > Y

[GitHub] [incubator-apisix] Joe123-ai commented on issue #1880: request help: The port disappears after redirection

2020-07-20 Thread GitBox
Joe123-ai commented on issue #1880: URL: https://github.com/apache/incubator-apisix/issues/1880#issuecomment-661666835 需要我做什么处理吗 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] Joe123-ai commented on issue #1880: request help: The port disappears after redirection

2020-07-20 Thread GitBox
Joe123-ai commented on issue #1880: URL: https://github.com/apache/incubator-apisix/issues/1880#issuecomment-661665503 这是返回的header: Content-Type →application/json;charset=UTF-8 Transfer-Encoding →chunked Date →Tue, 21 Jul 2020 06:35:28 GMT

[GitHub] [incubator-apisix] moonming commented on issue #1880: request help: The port disappears after redirection

2020-07-20 Thread GitBox
moonming commented on issue #1880: URL: https://github.com/apache/incubator-apisix/issues/1880#issuecomment-661661500 @Joe123-ai what's the response header of the upstream java service? Apache APISIX will not change the upstream response. -

[GitHub] [incubator-apisix] Joe123-ai opened a new issue #1880: request help: The port disappears after redirection

2020-07-20 Thread GitBox
Joe123-ai opened a new issue #1880: URL: https://github.com/apache/incubator-apisix/issues/1880 ### Issue description 以下是routes配置: curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' { "uri": "/nacos-provider/provider

[GitHub] [incubator-apisix] Joe123-ai closed issue #1879: request help:

2020-07-20 Thread GitBox
Joe123-ai closed issue #1879: URL: https://github.com/apache/incubator-apisix/issues/1879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix-docker] CGerAJ commented on issue #64: error parsing HTTP 403 response body

2020-07-20 Thread GitBox
CGerAJ commented on issue #64: URL: https://github.com/apache/incubator-apisix-docker/issues/64#issuecomment-661624024 ``` curl gcr.azk8s.cn/etcd-development/etcd:v3.3.12 403 Forbidden 403 Forbidden nginx/1.14.0 (Ubuntu) ``` 我想应该是资源问题导致的

[GitHub] [incubator-apisix-docker] CGerAJ opened a new issue #64: error parsing HTTP 403 response body

2020-07-20 Thread GitBox
CGerAJ opened a new issue #64: URL: https://github.com/apache/incubator-apisix-docker/issues/64 使用的中国区镜像 ``` image: gcr.azk8s.cn/etcd-development/etcd:v3.3.12 ``` 多个版本复现 macos 10.15.6 centos7.5 error message: ![image](https://user-images.githubuserconte

[incubator-apisix] branch master updated (c1ee898 -> a5fc25c)

2020-07-20 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from c1ee898 release: released 1.4.1 version (#1872) add a5fc25c feat: Support admin API authentication

[GitHub] [incubator-apisix] gxthrj commented on pull request #1372: modify: specify pool_size and backlog for plugin

2020-07-20 Thread GitBox
gxthrj commented on pull request #1372: URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-661612531 > @gxthrj any update? still needed rebase and some test This is an automated message from the Apa

[GitHub] [incubator-apisix] moonming merged pull request #1747: feat: Support admin API authentication with SSL certificates

2020-07-20 Thread GitBox
moonming merged pull request #1747: URL: https://github.com/apache/incubator-apisix/pull/1747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming commented on pull request #1735: bugfix: failed to fetch upstream, apisix may be starting.

2020-07-20 Thread GitBox
moonming commented on pull request #1735: URL: https://github.com/apache/incubator-apisix/pull/1735#issuecomment-661611781 @membphis please rebase master and add test cases. This is an automated message from the Apache Git Se

[GitHub] [incubator-apisix] moonming commented on pull request #1709: Request validation plugin

2020-07-20 Thread GitBox
moonming commented on pull request #1709: URL: https://github.com/apache/incubator-apisix/pull/1709#issuecomment-661611556 we can merge first, then fix minor issues. This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] Joe123-ai opened a new issue #1879: request help:

2020-07-20 Thread GitBox
Joe123-ai opened a new issue #1879: URL: https://github.com/apache/incubator-apisix/issues/1879 ### Issue description 以下是routes配置: curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' { "uri": "/nacos-provider/provider

[GitHub] [incubator-apisix] moonming commented on pull request #1572: enable request stats when run with tengine

2020-07-20 Thread GitBox
moonming commented on pull request #1572: URL: https://github.com/apache/incubator-apisix/pull/1572#issuecomment-661610491 ping @ywengineer This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] moonming closed pull request #1565: [core]control the output format of access.log through the http.access_log_format field in config.yaml

2020-07-20 Thread GitBox
moonming closed pull request #1565: URL: https://github.com/apache/incubator-apisix/pull/1565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming commented on pull request #1565: [core]control the output format of access.log through the http.access_log_format field in config.yaml

2020-07-20 Thread GitBox
moonming commented on pull request #1565: URL: https://github.com/apache/incubator-apisix/pull/1565#issuecomment-661610117 this PR that hasn't been updated for a long time, close it first This is an automated message from the

[GitHub] [incubator-apisix] moonming commented on pull request #1376: Create how-k8s-deploy-cn.md

2020-07-20 Thread GitBox
moonming commented on pull request #1376: URL: https://github.com/apache/incubator-apisix/pull/1376#issuecomment-661609849 @cyxinda ping This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-apisix] moonming commented on pull request #1372: modify: specify pool_size and backlog for plugin

2020-07-20 Thread GitBox
moonming commented on pull request #1372: URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-661608572 @gxthrj any update? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-apisix] moonming closed pull request #1353: Complement Apache APISIX architecture documentation with Basic Object Relationships

2020-07-20 Thread GitBox
moonming closed pull request #1353: URL: https://github.com/apache/incubator-apisix/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming closed pull request #1000: add whiteiplist in limit count plugin

2020-07-20 Thread GitBox
moonming closed pull request #1000: URL: https://github.com/apache/incubator-apisix/pull/1000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming commented on pull request #1000: add whiteiplist in limit count plugin

2020-07-20 Thread GitBox
moonming commented on pull request #1000: URL: https://github.com/apache/incubator-apisix/pull/1000#issuecomment-661607475 this PR that hasn't been updated for a long time, close it first This is an automated message from the

[GitHub] [incubator-apisix] moonming commented on pull request #1353: Complement Apache APISIX architecture documentation with Basic Object Relationships

2020-07-20 Thread GitBox
moonming commented on pull request #1353: URL: https://github.com/apache/incubator-apisix/pull/1353#issuecomment-661607629 this PR that hasn't been updated for a long time, close it first This is an automated message from the

[GitHub] [incubator-apisix] moonming closed pull request #1848: [doc] remove the CODE_STYLE.md ref

2020-07-20 Thread GitBox
moonming closed pull request #1848: URL: https://github.com/apache/incubator-apisix/pull/1848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] moonming opened a new issue #1877: request help: add version in http response `server` header

2020-07-20 Thread GitBox
moonming opened a new issue #1877: URL: https://github.com/apache/incubator-apisix/issues/1877 Apache APISIX only return `server: APISIX`, we need to add version like `server: APISIX/1.4` This is an automated message from th

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1848: [doc] remove the CODE_STYLE.md ref

2020-07-20 Thread GitBox
moonming commented on a change in pull request #1848: URL: https://github.com/apache/incubator-apisix/pull/1848#discussion_r45781 ## File path: Contributing.md ## @@ -94,7 +94,7 @@ Once we've discussed your changes and you've got your code ready, make sure that ## Check c

[GitHub] [incubator-apisix] moonming commented on issue #1877: request help: add version in http response `server` header

2020-07-20 Thread GitBox
moonming commented on issue #1877: URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-661582219 we can remove https://github.com/apache/incubator-apisix/blob/master/bin/apisix#L241, and use lua code to add http header --

[GitHub] [incubator-apisix] moonming commented on pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

2020-07-20 Thread GitBox
moonming commented on pull request #1874: URL: https://github.com/apache/incubator-apisix/pull/1874#issuecomment-661599920 @yongboy ``` Scan detected 1 error(s) in 1 file(s): [./CODE_STYLE_CN.md]: 20: line has trailing whitespace. ``` please fix the code style, whi

[GitHub] [incubator-apisix] 0102redirects opened a new issue #1878: docker-compose.yaml中的gcr.azk8s.cn/etcd-development/etcd:v3.3.12 无法访问

2020-07-20 Thread GitBox
0102redirects opened a new issue #1878: URL: https://github.com/apache/incubator-apisix/issues/1878 ### Issue description ### Environment * apisix version (cmd: `apisix version`): * OS: ### Minimal test code / Steps to reproduce the issue 1. 2. 3.

[GitHub] [incubator-apisix] shuaijinchao commented on pull request #1871: bugfix: failed to get `host` in health check configuration.

2020-07-20 Thread GitBox
shuaijinchao commented on pull request #1871: URL: https://github.com/apache/incubator-apisix/pull/1871#issuecomment-661591039 @membphis the test case cannot get the warn log thrown by the health check, please help to check.

[GitHub] [incubator-apisix] wrl96 commented on issue #1836: bug: should not save the runtime data of plugin into etcd

2020-07-20 Thread GitBox
wrl96 commented on issue #1836: URL: https://github.com/apache/incubator-apisix/issues/1836#issuecomment-661567604 I think we should remove apisix.admin.plugins.check_schema, just check schema in sync_data This is an automa

[GitHub] [incubator-apisix] moonming edited a comment on issue #1868: request help: do you have any plan to add waf feature?

2020-07-20 Thread GitBox
moonming edited a comment on issue #1868: URL: https://github.com/apache/incubator-apisix/issues/1868#issuecomment-661558556 @UnderTreeTech yes, Apache APISIX need WAF features. Maybe we can add plugin like modsecurity? Th

[GitHub] [incubator-apisix] moonming commented on issue #1868: request help: do you have any plan to add waf feature?

2020-07-20 Thread GitBox
moonming commented on issue #1868: URL: https://github.com/apache/incubator-apisix/issues/1868#issuecomment-661558556 @UnderTreeTech yes, Apache APISIX need WAF features. Maybe we can add module like modsecurity? This is a

[GitHub] [incubator-apisix] moonming closed issue #1865: request help: How to separate apisix and user customize code?

2020-07-20 Thread GitBox
moonming closed issue #1865: URL: https://github.com/apache/incubator-apisix/issues/1865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-apisix] mtx2d opened a new issue #1876: request help: How to perform Authentication Code Grant Flow with OIDC using APISIX?

2020-07-20 Thread GitBox
mtx2d opened a new issue #1876: URL: https://github.com/apache/incubator-apisix/issues/1876 ### Issue description I want to use APISIX as the main API gateway to perform the OIDC flow for my mobile app. Do we have document showing such an similar to the follow? In the meantime

[GitHub] [incubator-apisix] wrl96 opened a new pull request #1875: [WIP] bugfix: check plugin schema when sync data

2020-07-20 Thread GitBox
wrl96 opened a new pull request #1875: URL: https://github.com/apache/incubator-apisix/pull/1875 ### What this PR does: Fix #1604 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you

[GitHub] [incubator-apisix] FourierX9 commented on issue #1791: change: enabled websocket in route

2020-07-20 Thread GitBox
FourierX9 commented on issue #1791: URL: https://github.com/apache/incubator-apisix/issues/1791#issuecomment-661067366 Hello, I am Weiqing and I want to work on this issue as my first issue. I am trying to understand the inside logic and I will work out a development plan in a few days.

[GitHub] [incubator-apisix] yongboy opened a new pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

2020-07-20 Thread GitBox
yongboy opened a new pull request #1874: URL: https://github.com/apache/incubator-apisix/pull/1874 ### What this PR does / why we need it: We missing the apisix's lua code style guide when writing a plugin, fixing the code bug. ### Pre-submission checklist: * [x] Did yo

[incubator-apisix-website] branch master updated: add download links for version 1.4.1 (#53)

2020-07-20 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new d755397 add download links

[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-07-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 929528f Deploy to Git

[GitHub] [incubator-apisix-website] juzhiyuan commented on a change in pull request #53: add download links for version 1.4.1

2020-07-20 Thread GitBox
juzhiyuan commented on a change in pull request #53: URL: https://github.com/apache/incubator-apisix-website/pull/53#discussion_r457363218 ## File path: content/downloads/index.zh.md ## @@ -89,6 +89,18 @@ include_footer: true ) + +1.4

[GitHub] [incubator-apisix-website] juzhiyuan merged pull request #53: add download links for version 1.4.1

2020-07-20 Thread GitBox
juzhiyuan merged pull request #53: URL: https://github.com/apache/incubator-apisix-website/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #325: i18n consumer

2020-07-20 Thread GitBox
juzhiyuan commented on a change in pull request #325: URL: https://github.com/apache/incubator-apisix-dashboard/pull/325#discussion_r457359851 ## File path: src/pages/Consumer/locales/zh-CN.ts ## @@ -3,4 +3,33 @@ export default { 'menu.consumer.list': '列表', 'menu.consume

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #325: i18n consumer

2020-07-20 Thread GitBox
juzhiyuan commented on a change in pull request #325: URL: https://github.com/apache/incubator-apisix-dashboard/pull/325#discussion_r457359436 ## File path: src/pages/Consumer/Create.tsx ## @@ -15,6 +16,7 @@ const Page: React.FC = (props) => { const [step, setStep] = useSta

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #326: i18n metrics

2020-07-20 Thread GitBox
juzhiyuan commented on a change in pull request #326: URL: https://github.com/apache/incubator-apisix-dashboard/pull/326#discussion_r457358819 ## File path: src/pages/Metrics/locales/zh-CN.ts ## @@ -0,0 +1,5 @@ +export default { Review comment: And you should import th

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #326: i18n metrics

2020-07-20 Thread GitBox
juzhiyuan commented on a change in pull request #326: URL: https://github.com/apache/incubator-apisix-dashboard/pull/326#discussion_r457357733 ## File path: src/pages/Metrics/Metrics.tsx ## @@ -16,15 +17,15 @@ const Metrics: React.FC = () => { }, []); return ( - +

[GitHub] [incubator-apisix] membphis commented on issue #1873: doc: The `doc/admin-api.md#consumer` & `doc/zh-cn/admin-api.md#consumer` doc, the consumer 'id' meaning confused.

2020-07-20 Thread GitBox
membphis commented on issue #1873: URL: https://github.com/apache/incubator-apisix/issues/1873#issuecomment-660949655 welcome PR This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-apisix] branch master updated: release: released 1.4.1 version (#1872)

2020-07-20 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c1ee898 release: released 1.4.1 ve

[GitHub] [incubator-apisix] nic-chen merged pull request #1872: release: released 1.4.1 version

2020-07-20 Thread GitBox
nic-chen merged pull request #1872: URL: https://github.com/apache/incubator-apisix/pull/1872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] membphis commented on pull request #1872: release: released 1.4.1 version

2020-07-20 Thread GitBox
membphis commented on pull request #1872: URL: https://github.com/apache/incubator-apisix/pull/1872#issuecomment-660933287 I have uploaded `1.4.1` to luarocks, and it works fine. https://luarocks.org/modules/apisix/apisix Th

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1863: bugfix: read the request body from the temporary file if it was cached.

2020-07-20 Thread GitBox
spacewander commented on a change in pull request #1863: URL: https://github.com/apache/incubator-apisix/pull/1863#discussion_r457186013 ## File path: apisix/admin/init.lua ## @@ -117,10 +117,13 @@ local function run() core.response.exit(404) end -ngx.req.re

[incubator-apisix] branch v1.4.1 updated (cd661a7 -> 380a8c3)

2020-07-20 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch v1.4.1 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from cd661a7 fix: remove `incubating` in download url in docs. add f8f104d feature(echo): support hea

[GitHub] [incubator-apisix] EdisonLiang opened a new issue #1873: bug: The `doc/admin-api.md#consumer` & `doc/zh-cn/admin-api.md#consumer` doc, the consumer 'id' meaning confused.

2020-07-20 Thread GitBox
EdisonLiang opened a new issue #1873: URL: https://github.com/apache/incubator-apisix/issues/1873 ### Issue description The `doc/admin-api.md#consumer` & `doc/zh-cn/admin-api.md#consumer` doc, the consumer `id` meaning confused. `id` miss leading `name` to `index` number while

[GitHub] [incubator-apisix] nic-chen opened a new pull request #1872: release: released 1.4.1 version

2020-07-20 Thread GitBox
nic-chen opened a new pull request #1872: URL: https://github.com/apache/incubator-apisix/pull/1872 ### What this PR does / why we need it: released 1.4.1 version ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features h