[GitHub] [incubator-apisix] membphis opened a new pull request #1892: change: the timeout of `healthcheck` should be number type.

2020-07-22 Thread GitBox
membphis opened a new pull request #1892: URL: https://github.com/apache/incubator-apisix/pull/1892 ### What this PR does / why we need it: as title. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [incubator-apisix] tiger333777 commented on issue #1889: bug: some site pages will be garbled

2020-07-22 Thread GitBox
tiger333777 commented on issue #1889: URL: https://github.com/apache/incubator-apisix/issues/1889#issuecomment-662842979 chareset utf-8 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-apisix] tiger333777 closed issue #1889: bug: some site pages will be garbled

2020-07-22 Thread GitBox
tiger333777 closed issue #1889: URL: https://github.com/apache/incubator-apisix/issues/1889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-apisix-dashboard] TikWind commented on pull request #325: i18n consumer

2020-07-22 Thread GitBox
TikWind commented on pull request #325: URL: https://github.com/apache/incubator-apisix-dashboard/pull/325#issuecomment-662831721 > @TikWind Could we merge this PR, if ok, please remove the WIP from title. Thanks! I have tested, maybe you can merge this PR, thanks. ---

[GitHub] [incubator-apisix-dashboard] TikWind opened a new pull request #334: I18n upstream

2020-07-22 Thread GitBox
TikWind opened a new pull request #334: URL: https://github.com/apache/incubator-apisix-dashboard/pull/334 I18n upstream This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #333: Ready to Relase

2020-07-22 Thread GitBox
juzhiyuan opened a new issue #333: URL: https://github.com/apache/incubator-apisix-dashboard/issues/333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

2020-07-22 Thread GitBox
bzp2010 commented on pull request #330: URL: https://github.com/apache/incubator-apisix-dashboard/pull/330#issuecomment-662801243 @juzhiyuan It will be built into the manager API. It's not finished yet. Working in Progress.

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #330: feat(authentication): create authentication module

2020-07-22 Thread GitBox
juzhiyuan commented on pull request #330: URL: https://github.com/apache/incubator-apisix-dashboard/pull/330#issuecomment-662797188 @bzp2010 Do we have API support currently? APISIX or manager API? This is an automated mess

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #332: Use auto load i18n

2020-07-22 Thread GitBox
juzhiyuan opened a new issue #332: URL: https://github.com/apache/incubator-apisix-dashboard/issues/332 https://umijs.org/zh-CN/plugins/plugin-locale#%E7%BA%A6%E5%AE%9A%E5%BC%8F%E5%A4%9A%E8%AF%AD%E8%A8%80%E6%94%AF%E6%8C%81 Don’t need import every locale configuration from Module any

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #331: Proposal: i18n

2020-07-22 Thread GitBox
juzhiyuan commented on issue #331: URL: https://github.com/apache/incubator-apisix-dashboard/issues/331#issuecomment-662791251 1. Please take a look at how WordPress does; 2. We need a good design on how the sub key is grouped to a key; -

[GitHub] [incubator-apisix-dashboard] juzhiyuan opened a new issue #331: Proposal: i18n

2020-07-22 Thread GitBox
juzhiyuan opened a new issue #331: URL: https://github.com/apache/incubator-apisix-dashboard/issues/331 We need a proposal to make our i18n cleaner and reasonable. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] gxthrj opened a new pull request #1891: style:modify kubernetes doc,make config.yaml from the latest version …

2020-07-22 Thread GitBox
gxthrj opened a new pull request #1891: URL: https://github.com/apache/incubator-apisix/pull/1891 ### What this PR does / why we need it: 1.make config.yaml from the latest version 2.remove some config not necessary ### Pre-submission checklist: * [x] Did you explain wha

[GitHub] [incubator-apisix] gxthrj closed pull request #1890: style:modify kubernetes doc,make config.yaml from the latest version …

2020-07-22 Thread GitBox
gxthrj closed pull request #1890: URL: https://github.com/apache/incubator-apisix/pull/1890 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-apisix] gxthrj opened a new pull request #1890: style:modify kubernetes doc,make config.yaml from the latest version …

2020-07-22 Thread GitBox
gxthrj opened a new pull request #1890: URL: https://github.com/apache/incubator-apisix/pull/1890 style:modify kubernetes doc,make config.yaml from the latest version and remove some config not necessary This is an automated

[GitHub] [incubator-apisix] tiger333777 opened a new issue #1889: bug: some site pages will be garbled

2020-07-22 Thread GitBox
tiger333777 opened a new issue #1889: URL: https://github.com/apache/incubator-apisix/issues/1889 ### Issue description Use APISIX master branch to do reverse generation, some site pages will be garbled ### Environment * apisix version (cmd: `apisix version`): master branch

[GitHub] [incubator-apisix-dashboard] bzp2010 opened a new pull request #330: feat(authentication): create authentication module

2020-07-22 Thread GitBox
bzp2010 opened a new pull request #330: URL: https://github.com/apache/incubator-apisix-dashboard/pull/330 This pull request creates an authentication module to prevent unauthorized access. # LoginMethod - It provides an extensible pluggable mechanism to extend the user-defined a

[GitHub] [incubator-apisix] nic-chen opened a new pull request #1888: change: add more prometheus metrics(hostname, etcd modify index)

2020-07-22 Thread GitBox
nic-chen opened a new pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888 ### What this PR does / why we need it: add more prometheus metrics for better understanding the situation of APISIX nodes. #1885 ### Pre-submission checklist: *

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #325: WIP: i18n consumer

2020-07-22 Thread GitBox
juzhiyuan commented on pull request #325: URL: https://github.com/apache/incubator-apisix-dashboard/pull/325#issuecomment-662764824 @TikWind Could we merge this PR, if ok, please remove the WIP from title. Thanks! This is a

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #325: WIP: i18n consumer

2020-07-22 Thread GitBox
juzhiyuan commented on a change in pull request #325: URL: https://github.com/apache/incubator-apisix-dashboard/pull/325#discussion_r459157578 ## File path: src/pages/Consumer/Create.tsx ## @@ -51,7 +53,7 @@ const Page: React.FC = (props) => { .map((item) => item[0]);

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #327: WIP: i18n route

2020-07-22 Thread GitBox
juzhiyuan commented on pull request #327: URL: https://github.com/apache/incubator-apisix-dashboard/pull/327#issuecomment-662764035 @LiteSun Please take a look at this PR. This is an automated message from the Apache Git Ser

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #327: WIP: i18n route

2020-07-22 Thread GitBox
juzhiyuan commented on a change in pull request #327: URL: https://github.com/apache/incubator-apisix-dashboard/pull/327#discussion_r459156368 ## File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx ## @@ -17,15 +18,18 @@ const style = { }; const CreateStep4:

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #326: WIP: i18n metrics

2020-07-22 Thread GitBox
juzhiyuan commented on a change in pull request #326: URL: https://github.com/apache/incubator-apisix-dashboard/pull/326#discussion_r459155006 ## File path: src/pages/Metrics/locales/zh-CN.ts ## @@ -0,0 +1,5 @@ +export default { Review comment: Not sure, please check t

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #326: WIP: i18n metrics

2020-07-22 Thread GitBox
juzhiyuan commented on pull request #326: URL: https://github.com/apache/incubator-apisix-dashboard/pull/326#issuecomment-662761718 Hi @TikWind , will there have more commits? Or we could merge it now? This is an automated m

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #328: Route cannot enabled plugin

2020-07-22 Thread GitBox
juzhiyuan commented on issue #328: URL: https://github.com/apache/incubator-apisix-dashboard/issues/328#issuecomment-662761417 @longshang Could you please provide more detail? E.g Which plugin could not be enabled? And what are your steps?

[GitHub] [incubator-apisix] XW512 commented on issue #1802: request help:

2020-07-22 Thread GitBox
XW512 commented on issue #1802: URL: https://github.com/apache/incubator-apisix/issues/1802#issuecomment-662508112 > can you provide an example? If many microservices need to be registered to the gateway, it will be very troublesome to add them manually. Is it possible to register t

[GitHub] [incubator-apisix] odidev opened a new issue #1887: Linux jobs in Travis-CI

2020-07-22 Thread GitBox
odidev opened a new issue #1887: URL: https://github.com/apache/incubator-apisix/issues/1887 Hi Team, I am interested in adding arm64 jobs to Travis-CI. I found that the linux jobs have been removed from .travis.yml recently. May I please know why the change has been done? I am in

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1863: bugfix: read the request body from the temporary file if it was cached.

2020-07-22 Thread GitBox
moonming commented on a change in pull request #1863: URL: https://github.com/apache/incubator-apisix/pull/1863#discussion_r458640687 ## File path: apisix/admin/init.lua ## @@ -117,10 +117,13 @@ local function run() core.response.exit(404) end -ngx.req.read_

[GitHub] [incubator-apisix] moonming closed issue #1846: bug: Missing the CODE_STYLE.md file

2020-07-22 Thread GitBox
moonming closed issue #1846: URL: https://github.com/apache/incubator-apisix/issues/1846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-apisix] moonming merged pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

2020-07-22 Thread GitBox
moonming merged pull request #1874: URL: https://github.com/apache/incubator-apisix/pull/1874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-apisix] branch master updated: doc: added CODE_STYLE.md and CODE_STYLE_CN.md for APISIX (#1874)

2020-07-22 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 8fbd0ac doc: added CODE_STYLE.md and

[GitHub] [incubator-apisix-dashboard] tiger333777 opened a new issue #329: about authentication of manage API

2020-07-22 Thread GitBox
tiger333777 opened a new issue #329: URL: https://github.com/apache/incubator-apisix-dashboard/issues/329 The 8080 port of the current manage API needs to be opened to the operator IP of the dashboard before it can be executed. In this way, there will be security risks. There is no restric

[GitHub] [incubator-apisix] moonming commented on issue #1886: Does the stream proxy support authentication plugins?

2020-07-22 Thread GitBox
moonming commented on issue #1886: URL: https://github.com/apache/incubator-apisix/issues/1886#issuecomment-662296019 No, all the auth plugins are wroking in L7, and stream proxy working in L4. By the way, how to do auth for tcp or udp request? TCP-AO? -