[apisix] branch v1.5 updated (aaf7b2a -> 261960b)

This is an automated email from the ASF dual-hosted git repository. shuaijinchao pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix.git. from aaf7b2a release: updated 1.5 version package download path. add 261960b release: remove trailing whitespac

[GitHub] [apisix] shuaijinchao opened a new pull request #1965: release: released 1.5.0 version.

shuaijinchao opened a new pull request #1965: URL: https://github.com/apache/apisix/pull/1965 ### What this PR does / why we need it: released 1.5.0 version. @apache/apisix-committers please do have a check. @membphis After PR merge, please upload `apisix-1.5-0.rockspec` to https:/

[apisix-dashboard] branch master updated: feat(conf): update default preview API (#353)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new b657493 feat(conf): update default

[apisix-dashboard] branch juzhiyuan-patch-1 created (now 37f5d9b)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 37f5d9b feat(conf): update default preview API No new revisions were added by this update.

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #353: feat(conf): update default preview API

juzhiyuan merged pull request #353: URL: https://github.com/apache/apisix-dashboard/pull/353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #353: feat(conf): update default preview API

juzhiyuan opened a new pull request #353: URL: https://github.com/apache/apisix-dashboard/pull/353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] shuaijinchao closed pull request #1948: release: released 1.5.0 version.

shuaijinchao closed pull request #1948: URL: https://github.com/apache/apisix/pull/1948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch v1.5 updated: release: updated 1.5 version package download path.

This is an automated email from the ASF dual-hosted git repository. shuaijinchao pushed a commit to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/v1.5 by this push: new aaf7b2a release: updated 1.5 version package

[GitHub] [apisix] shuaijinchao commented on pull request #1948: release: released 1.5.0 version.

shuaijinchao commented on pull request #1948: URL: https://github.com/apache/apisix/pull/1948#issuecomment-667456115 @moonming I will fix this issue later. Version 1.5-RC1 is voting, and the current release method of this branch is incorrect. I will close this PR.

[apisix] branch v1.5 updated: release: updated 1.5 version CHANGELOG.

This is an automated email from the ASF dual-hosted git repository. shuaijinchao pushed a commit to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/v1.5 by this push: new 48e07b0 release: updated 1.5 version CHANGELO

[GitHub] [apisix] membphis opened a new pull request #1964: doc: update main picture of APISIX.

membphis opened a new pull request #1964: URL: https://github.com/apache/apisix/pull/1964 ### What this PR does / why we need it: Apache APISIX is TPL project, update main picture. This is an automated mess

[apisix] branch v1.5 updated (921fbe2 -> 6c5b52e)

This is an automated email from the ASF dual-hosted git repository. shuaijinchao pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix.git. discard 921fbe2 release: released 1.5 version. add 1ffcc9c doc: fixed grpc transcode link (#1946) add f37a1dd

[apisix] 01/01: release: released 1.5 version.

This is an automated email from the ASF dual-hosted git repository. shuaijinchao pushed a commit to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix.git commit 6c5b52e93ea522009355643feb9d8c5a84e4baf4 Author: Janko AuthorDate: Fri Jul 31 12:04:39 2020 +0800 release: rele

[GitHub] [apisix] membphis merged pull request #1963: feat: add option for cors

membphis merged pull request #1963: URL: https://github.com/apache/apisix/pull/1963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feat: add option for cors and bugfix (#1963)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2936c7d feat: add option for cors and bugfix

[GitHub] [apisix] membphis closed issue #1915: bug: cors should be at header_filter phase

membphis closed issue #1915: URL: https://github.com/apache/apisix/issues/1915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667255004 > @Yiyiyimu etcd v3 support is an urgent need, we should hurry up and complete it as soon as possible. Sure I'll try to provide the minimum working PR ASAP -

[GitHub] [apisix] nic-chen commented on pull request #1943: feature: support etcd v3

nic-chen commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-66783 @ChelinTsien Thank you for your hard work and the understanding. ：） This is an automated message from the Apache

[GitHub] [apisix] ChelinTsien commented on pull request #1943: feature: support etcd v3

ChelinTsien commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667219088 Since the production environment uses apisix and apisix doesn't support etcd v3 at the moment so it took almost a day to deal with this issue, sorry for not seeing this assig

[GitHub] [apisix] ChelinTsien edited a comment on pull request #1943: feature: support etcd v3

ChelinTsien edited a comment on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667213575 ok！ nic-chen 于2020年8月1日 周六上午12:27写道： > Hi, @ChelinTsien , Thank you for your > contribution! > As @Yiyiyimu

[GitHub] [incubator-apisix] ChelinTsien commented on pull request #1943: feature: support etcd v3

ChelinTsien commented on pull request #1943: URL: https://github.com/apache/incubator-apisix/pull/1943#issuecomment-667213575 ok！ nic-chen 于2020年8月1日 周六上午12:27写道： > Hi, @ChelinTsien , Thank you for your > contribution! > As @Yiyiyimu

[GitHub] [incubator-apisix] nic-chen commented on pull request #1943: feature: support etcd v3

nic-chen commented on pull request #1943: URL: https://github.com/apache/incubator-apisix/pull/1943#issuecomment-667212721 Hi, @ChelinTsien, Thank you for your contribution! As @Yiyiyimu said, etcd v3 support is a task of `summer 2020`. He spent a lot of time studying and researching

[GitHub] [incubator-apisix] nic-chen closed issue #1885: request help: need more prometheus metrics

nic-chen closed issue #1885: URL: https://github.com/apache/incubator-apisix/issues/1885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-apisix] nic-chen commented on issue #1957: bug: return fail if failed to load SSL certificate by SNI

nic-chen commented on issue #1957: URL: https://github.com/apache/incubator-apisix/issues/1957#issuecomment-667191535 @membphis Ok, let me deal with this issue. This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1963: feat: add option for cors

membphis commented on a change in pull request #1963: URL: https://github.com/apache/incubator-apisix/pull/1963#discussion_r463683726 ## File path: t/plugin/cors.t ## @@ -491,3 +491,134 @@ Access-Control-Max-Age: 5 Access-Control-Allow-Credentials: --- no_error_log [error] +

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1963: feat: add option for cors

membphis commented on a change in pull request #1963: URL: https://github.com/apache/incubator-apisix/pull/1963#discussion_r463681866 ## File path: apisix/plugins/cors.lua ## @@ -146,10 +146,16 @@ function _M.rewrite(conf, ctx) ctx.cors_allow_origins = allow_origins

[GitHub] [incubator-apisix-dashboard] bzp2010 edited a comment on pull request #330: feat(authentication): create authentication module

bzp2010 edited a comment on pull request #330: URL: https://github.com/apache/incubator-apisix-dashboard/pull/330#issuecomment-667181852 > The frontend of authentication module has been basically completed. The modification to the Manager API in this pull request has been temporarily remo

[GitHub] [incubator-apisix-dashboard] bzp2010 commented on pull request #330: feat(authentication): create authentication module

bzp2010 commented on pull request #330: URL: https://github.com/apache/incubator-apisix-dashboard/pull/330#issuecomment-667181852 > The frontend of authentication module has been basically completed. The modification to the Manager API in this pull request has been temporarily removed. A

[GitHub] [incubator-apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/incubator-apisix/pull/1943#issuecomment-667155565 Hi @ChelinTsien @moonming supporting etcd v3 is a task of [ISCAS summer plan](https://cwiki.apache.org/confluence/display/APISIX/Open+Source+Promotion+Plan+-+Summer+202

[GitHub] [incubator-apisix] taotao2014 commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

taotao2014 commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463622806 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #54: update release note for TLP

juzhiyuan closed issue #54: URL: https://github.com/apache/incubator-apisix-website/issues/54 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-apisix] branch master updated (8fc2af5 -> 3d8150b)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 8fc2af5 bugfix: avoid to modify the original plugin conf. (#1958) add 3d8150b test: old test case

[incubator-apisix] branch master updated (8fc2af5 -> 3d8150b)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 8fc2af5 bugfix: avoid to modify the original plugin conf. (#1958) add 3d8150b test: old test case

[incubator-apisix] branch master updated (8fc2af5 -> 3d8150b)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 8fc2af5 bugfix: avoid to modify the original plugin conf. (#1958) add 3d8150b test: old test case

[GitHub] [incubator-apisix] membphis merged pull request #1925: test: old test case is unstable, running fail sometimes.

membphis merged pull request #1925: URL: https://github.com/apache/incubator-apisix/pull/1925 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] ShiningRush opened a new pull request #1963: feat: add option for cors

ShiningRush opened a new pull request #1963: URL: https://github.com/apache/incubator-apisix/pull/1963 fixed with #1915 #1704 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-apisix] membphis opened a new issue #1962: need test case: redirect plugin

membphis opened a new issue #1962: URL: https://github.com/apache/incubator-apisix/issues/1962 https://github.com/apache/incubator-apisix/pull/1958/files#diff-cdaf7c2893523e3e57d9b439cb5d2b23R133 This is an automated

[GitHub] [incubator-apisix] membphis closed issue #1934: bug: redirect plugin redirects all the time when https

membphis closed issue #1934: URL: https://github.com/apache/incubator-apisix/issues/1934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-apisix] membphis commented on issue #1934: bug: redirect plugin redirects all the time when https

membphis commented on issue #1934: URL: https://github.com/apache/incubator-apisix/issues/1934#issuecomment-667092308 @ACanOfGas please make a try with the master branch, we have fixed this issue. This is an automated messa

[GitHub] [incubator-apisix] membphis closed issue #1956: bug: should not modify the user `conf` in plugin

membphis closed issue #1956: URL: https://github.com/apache/incubator-apisix/issues/1956 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-apisix] branch master updated: bugfix: avoid to modify the original plugin conf. (#1958)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 8fc2af5 bugfix: avoid to modify the

[GitHub] [incubator-apisix] membphis merged pull request #1958: bugfix: avoid to modify the original plugin conf.

membphis merged pull request #1958: URL: https://github.com/apache/incubator-apisix/pull/1958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-apisix] membphis commented on issue #1952: request help: build-in etcd service discovery example

membphis commented on issue #1952: URL: https://github.com/apache/incubator-apisix/issues/1952#issuecomment-667090729 Discovery service protocol: https://etcd.io/docs/v3.4.0/dev-internal/discovery_protocol/ This is an autom

[GitHub] [incubator-apisix] membphis commented on pull request #1959: feature: accept ":" in id (#1955)

membphis commented on pull request #1959: URL: https://github.com/apache/incubator-apisix/pull/1959#issuecomment-667089765 @jackwoods That is the right way, I have helped you updated. ![image](https://user-images.githubusercontent.com/6814606/89033857-55574c00-d36a-11ea-99d5-1b6b12af

[GitHub] [incubator-apisix] membphis edited a comment on pull request #1961: add apisix-version info to headers

membphis edited a comment on pull request #1961: URL: https://github.com/apache/incubator-apisix/pull/1961#issuecomment-667084145 please take a look at this patch, @justinmclean : ```diff diff --git a/apisix/init.lua b/apisix/init.lua index 354290dc..e465a372 100644 --- a/api

[GitHub] [incubator-apisix] membphis commented on pull request #1961: add apisix-version info to headers

membphis commented on pull request #1961: URL: https://github.com/apache/incubator-apisix/pull/1961#issuecomment-667084145 please take a look at this patch: ```diff diff --git a/apisix/init.lua b/apisix/init.lua index 354290dc..e465a372 100644 --- a/apisix/init.lua +++ b/a

[GitHub] [incubator-apisix-website] membphis commented on issue #54: update release note for TLP

membphis commented on issue #54: URL: https://github.com/apache/incubator-apisix-website/issues/54#issuecomment-667082210 can we close this issue now? This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-apisix] membphis commented on pull request #1960: add AK/SK auth plugin

membphis commented on pull request #1960: URL: https://github.com/apache/incubator-apisix/pull/1960#issuecomment-667081520 > Document to be added later yes, that is important This is an automated message from the Apach

[GitHub] [incubator-apisix] ChelinTsien commented on issue #1653: add AK/SK auth plugin

ChelinTsien commented on issue #1653: URL: https://github.com/apache/incubator-apisix/issues/1653#issuecomment-667079327 @membphis this is ak/sk auth ，implemented according to aws v4, just badly named. This is an automated

[GitHub] [incubator-apisix] swayamraina opened a new pull request #1961: add apisix-version info to headers

swayamraina opened a new pull request #1961: URL: https://github.com/apache/incubator-apisix/pull/1961 ### What this PR does / why we need it: We should pass the APISIX version in the response headers fixes : https://github.com/apache/incubator-apisix/issues/1877 ### Pre-submiss

[GitHub] [incubator-apisix] membphis closed issue #1640: question: passive health check seems never provide a healthy report

membphis closed issue #1640: URL: https://github.com/apache/incubator-apisix/issues/1640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-apisix] membphis merged pull request #1918: bugfix: passive health check seems never provide a healthy report

membphis merged pull request #1918: URL: https://github.com/apache/incubator-apisix/pull/1918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-apisix] branch master updated: bugfix: passive health check seems never provide a healthy report (#1918)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 2ba0231 bugfix: passive health chec

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

membphis commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463557465 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

membphis commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463556815 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix] membphis commented on pull request #1941: etcd v3 api support

membphis commented on pull request #1941: URL: https://github.com/apache/incubator-apisix/pull/1941#issuecomment-667073783 `add aws sign` why we need this commit? This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-apisix] membphis commented on issue #1877: request help: add version in http response `server` header

membphis commented on issue #1877: URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-667072442 you can submit your code first. then I will help you where is the problem. ^_^ @swayamraina This is an a

[GitHub] [incubator-apisix] swayamraina commented on issue #1877: request help: add version in http response `server` header

swayamraina commented on issue #1877: URL: https://github.com/apache/incubator-apisix/issues/1877#issuecomment-667068368 @membphis can you please help here? This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-apisix] ChelinTsien commented on pull request #1941: etcd v3 api support

ChelinTsien commented on pull request #1941: URL: https://github.com/apache/incubator-apisix/pull/1941#issuecomment-667053701 Added before #1943, why not review my pr? This is an automated message from the Apache Git Service

[GitHub] [incubator-apisix] ChelinTsien commented on pull request #1943: feature: support etcd v3

ChelinTsien commented on pull request #1943: URL: https://github.com/apache/incubator-apisix/pull/1943#issuecomment-667051469 > the same feature as #1941? yes This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] ChelinTsien commented on pull request #1960: add AK/SK auth plugin

ChelinTsien commented on pull request #1960: URL: https://github.com/apache/incubator-apisix/pull/1960#issuecomment-667050908 Document to be added later This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] ChelinTsien opened a new pull request #1960: add AK/SK auth plugin

ChelinTsien opened a new pull request #1960: URL: https://github.com/apache/incubator-apisix/pull/1960 ### What this PR does / why we need it: add ak/sk auth plugin fix #1653. ### Pre-submission checklist: * [x ] Did you explain what problem does this PR so

[GitHub] [incubator-apisix] moonming commented on pull request #1959: feature: accept ":" in id (#1955)

moonming commented on pull request #1959: URL: https://github.com/apache/incubator-apisix/pull/1959#issuecomment-667045981 @jackwoods please add test cases This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] jackwoods commented on issue #1955: feature: accept ":" in id?

jackwoods commented on issue #1955: URL: https://github.com/apache/incubator-apisix/issues/1955#issuecomment-667026243 https://github.com/apache/incubator-apisix/pull/1959 This is an automated message from the Apache Git Ser

[GitHub] [incubator-apisix] jackwoods closed issue #1954: bug: service id does not support string

jackwoods closed issue #1954: URL: https://github.com/apache/incubator-apisix/issues/1954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] jackwoods commented on issue #1954: bug: service id does not support string

jackwoods commented on issue #1954: URL: https://github.com/apache/incubator-apisix/issues/1954#issuecomment-667025558 I saw @membphis has fixed it in branch v1.4.1 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] jackwoods opened a new pull request #1959: feature: accept ":" in id (#1955)

jackwoods opened a new pull request #1959: URL: https://github.com/apache/incubator-apisix/pull/1959 ### What this PR does / why we need it: Sometimes we might hope the id in the following format: - upstream:payment:project_a - upstream:message_system:project_b etc. --

[GitHub] [incubator-apisix] taotao2014 commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

taotao2014 commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463493811 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix] taotao2014 removed a comment on pull request #1953: add core.request.get_scheme/host/port/http_version

taotao2014 removed a comment on pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#issuecomment-667014825 > @taotao2014 please fix conflicting files: apisix/core/request.lua Only those with write access to this repository can merge pull requests. -

[GitHub] [incubator-apisix] taotao2014 commented on pull request #1953: add core.request.get_scheme/host/port/http_version

taotao2014 commented on pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#issuecomment-667015127 > @taotao2014 please fix conflicting files: apisix/core/request.lua Only those with write access to this repository can merge pull requests. -

[GitHub] [incubator-apisix] taotao2014 commented on pull request #1953: add core.request.get_scheme/host/port/http_version

taotao2014 commented on pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#issuecomment-667014825 > @taotao2014 please fix conflicting files: apisix/core/request.lua Only those with write access to this repository can merge pull requests. -

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

membphis commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463489057 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix] taotao2014 commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

taotao2014 commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463488169 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix] membphis commented on issue #1923: feature: Divide config.yaml into two files config-custom.yaml & config-default.yaml

membphis commented on issue #1923: URL: https://github.com/apache/incubator-apisix/issues/1923#issuecomment-667011347 > Is this an incompatible feature? it is a compatible feature. The user can still use his old `conf/config.yaml` as the user's own configuration. -

[incubator-apisix-website] branch master updated: doc: update release note for TLP (#55)

This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 6bb98fb doc: update releas

[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 83b090d Deploy to Git

[GitHub] [incubator-apisix-website] nic-chen merged pull request #55: doc: update release note for TLP

nic-chen merged pull request #55: URL: https://github.com/apache/incubator-apisix-website/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-apisix] membphis opened a new pull request #1958: bugfix: use local variable.

membphis opened a new pull request #1958: URL: https://github.com/apache/incubator-apisix/pull/1958 ### What this PR does / why we need it: fix https://github.com/apache/incubator-apisix/issues/1934 ### Pre-submission checklist: * [ ] Did you explain what problem

[GitHub] [incubator-apisix] membphis commented on issue #1957: bug: return fail if failed to load SSL certificate by SNI

membphis commented on issue #1957: URL: https://github.com/apache/incubator-apisix/issues/1957#issuecomment-666992337 @nic-chen do you have time to handle this bug? This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] membphis opened a new issue #1957: bug: return fail if failed to load SSL certificate by SNI

membphis opened a new issue #1957: URL: https://github.com/apache/incubator-apisix/issues/1957 https://github.com/apache/incubator-apisix/blob/master/apisix/init.lua#L162 only `warn` message is not enough. This is an a

[GitHub] [incubator-apisix] membphis opened a new issue #1956: bug: should not modify the user `conf` in plugin

membphis opened a new issue #1956: URL: https://github.com/apache/incubator-apisix/issues/1956 - [ ] openid-connect - [ ] zipkin - [ ] uri-blocker for example: https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/zipkin.lua#L87 we need another wa

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #136: Complete the License information for the next dashboard

juzhiyuan closed issue #136: URL: https://github.com/apache/incubator-apisix-dashboard/issues/136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #352: feat: prepare to release

juzhiyuan merged pull request #352: URL: https://github.com/apache/incubator-apisix-dashboard/pull/352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-apisix-dashboard] branch feat-release-asf updated (3728d89 -> 9eec3b3)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-release-asf in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. from 3728d89 feat: update LICENSE add 9eec3b3 feat: update License No new revisi

[incubator-apisix-dashboard] branch feat-release-asf updated (20adbcf -> 3728d89)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-release-asf in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git. from 20adbcf feat: revert version add 3728d89 feat: update LICENSE No new revisi

[GitHub] [incubator-apisix-dashboard] moonming commented on a change in pull request #352: feat: prepare to release

moonming commented on a change in pull request #352: URL: https://github.com/apache/incubator-apisix-dashboard/pull/352#discussion_r463446840 ## File path: src/components/HeaderDropdown/index.less ## @@ -1,3 +1,26 @@ +/* +* MIT License + +* Copyright (c) 2019 Alipay.inc Revie

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1953: add core.request.get_scheme/host/port/http_version

membphis commented on a change in pull request #1953: URL: https://github.com/apache/incubator-apisix/pull/1953#discussion_r463446572 ## File path: apisix/core/request.lua ## @@ -94,7 +94,34 @@ function _M.get_remote_client_port(ctx) ctx = ngx.ctx.api_ctx end

[GitHub] [incubator-apisix] membphis commented on issue #1942: request help: benchmark with Envoy and other gateways

membphis commented on issue #1942: URL: https://github.com/apache/incubator-apisix/issues/1942#issuecomment-666970079 ### fake-apisix https://github.com/apache/incubator-apisix/tree/master/benchmark/fake-apisix ```shell rain@benchmark:~/incubator-apisix-1.4.1/benchmark/fake

[GitHub] [incubator-apisix-website] nic-chen opened a new pull request #55: doc: update release note for TLP

nic-chen opened a new pull request #55: URL: https://github.com/apache/incubator-apisix-website/pull/55 #54 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #250: Hash mode

juzhiyuan closed issue #250: URL: https://github.com/apache/incubator-apisix-dashboard/issues/250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #322: Object(xxx) Error

juzhiyuan closed issue #322: URL: https://github.com/apache/incubator-apisix-dashboard/issues/322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a