[GitHub] [apisix] backnero commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-08-06 Thread GitBox
backnero commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-670334062 Okay, I added the SSL configuration (for example: xxx.com), and added the route of xxx.com/v1/xxx. When I set to enable cors globally, this error will appear. At this time, the r

[GitHub] [apisix] ShiningRush edited a comment on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-08-06 Thread GitBox
ShiningRush edited a comment on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-670311269 @backnero Hi, I have a try in my environment, but does not reproduce the problem, can you give more detail about the bug?such as is route bind custom plugin.

[GitHub] [apisix] ShiningRush edited a comment on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-08-06 Thread GitBox
ShiningRush edited a comment on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-670311269 @backnero Hi, I have a try in my environment, but does not reproduce the problem, can you give more detail about the bug? -

[GitHub] [apisix] ShiningRush commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-08-06 Thread GitBox
ShiningRush commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-670311269 @backnero Hi, I have a try in my environment, but does not produce the problem, can you give more detail about the bug? --

[apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-08-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new ffeb02c Deploy to GitHub pages

[apisix-website] branch master updated: feat: added description

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new b37651a feat: added description b376

[GitHub] [apisix] membphis commented on a change in pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466805513 ## File path: apisix/balancer/ewma.lua ## @@ -0,0 +1,240 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor lic

[GitHub] [apisix] membphis commented on pull request #2017: feat: allow customizing worker_processes

2020-08-06 Thread GitBox
membphis commented on pull request #2017: URL: https://github.com/apache/apisix/pull/2017#issuecomment-670305405 need to update `conf/config.yaml` and test case This is an automated message from the Apache Git Service. To res

[GitHub] [apisix] membphis commented on a change in pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466803168 ## File path: t/node/ewma.t ## @@ -0,0 +1,90 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements

[GitHub] [apisix] spacewander opened a new pull request #2017: feat: allow customizing worker_processes

2020-08-06 Thread GitBox
spacewander opened a new pull request #2017: URL: https://github.com/apache/apisix/pull/2017 Close #2016. ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix] spacewander commented on issue #2016: request help: How are worker_processes configured

2020-08-06 Thread GitBox
spacewander commented on issue #2016: URL: https://github.com/apache/apisix/issues/2016#issuecomment-670287310 Look like we could not customize worker number yet. This is an automated message from the Apache Git Service. To r

[GitHub] [apisix] qianglu1989 opened a new issue #2016: request help: How are worker_processes configured

2020-08-06 Thread GitBox
qianglu1989 opened a new issue #2016: URL: https://github.com/apache/apisix/issues/2016 ### Environment * apisix version (cmd: `apisix version`): 1.4 * OS: linux how can configured `worker_processes` my config.yml ![image](https://user-images.githubusercontent.c

[GitHub] [apisix-dashboard] gxthrj commented on issue #369: About service startup with manager_api

2020-08-06 Thread GitBox
gxthrj commented on issue #369: URL: https://github.com/apache/apisix-dashboard/issues/369#issuecomment-670280564 1. I agree that the manager-api is started by formulating a configuration file, or by rewriting certain parameters when starting. This is a good feature. 2. In k8s, `configm

[GitHub] [apisix-dashboard] membphis commented on pull request #362: feat(deploy): set gen-config-yaml.sh executable

2020-08-06 Thread GitBox
membphis commented on pull request #362: URL: https://github.com/apache/apisix-dashboard/pull/362#issuecomment-670278535 @imjoey need to rebase your branch This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] juzhiyuan commented on pull request #2015: Rename Contributing.md to CONTRIBUTING.md

2020-08-06 Thread GitBox
juzhiyuan commented on pull request #2015: URL: https://github.com/apache/apisix/pull/2015#issuecomment-670274647 > @juzhiyuan > > ![image](https://user-images.githubusercontent.com/6814606/89595050-1f442b80-d886-11ea-8a59-6100f82eda05.png) 1. Because Git is not sensitive by d

[apisix] branch juzhiyuan-patch-1 updated (8463960 -> 51afc11)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8463960 feat(Doc): update CONTRIBUTING add b4890bf doc: remove all ‘incubator’ in doc (#2014)

[apisix] branch juzhiyuan-patch-1 updated (7577275 -> 8463960)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 7577275 Rename Contributing.md to CONTRIBUTING.md add 8463960 feat(Doc): update CONTRIBUTING No

[GitHub] [apisix-docker] membphis opened a new issue #69: bug: failed to start the apisix-1.5:alpine

2020-08-06 Thread GitBox
membphis opened a new issue #69: URL: https://github.com/apache/apisix-docker/issues/69 ![image](https://user-images.githubusercontent.com/6814606/89596858-f96d5580-d88a-11ea-8319-84adada26675.png) This is an automat

[GitHub] [apisix-dashboard] Yangzcy423911 opened a new issue #369: About service startup with manager_api

2020-08-06 Thread GitBox
Yangzcy423911 opened a new issue #369: URL: https://github.com/apache/apisix-dashboard/issues/369 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirements - [ ] Feature or performa

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #364: feat: release 1.5

2020-08-06 Thread GitBox
membphis commented on a change in pull request #364: URL: https://github.com/apache/apisix-dashboard/pull/364#discussion_r466753240 ## File path: .gitignore ## @@ -40,4 +40,7 @@ build /compose/**/*.log /compose/**/nginx.pid -/compose/etcd_data \ No newline at end of file +/

[GitHub] [apisix] membphis commented on pull request #1961: add apisix-version info to headers

2020-08-06 Thread GitBox
membphis commented on pull request #1961: URL: https://github.com/apache/apisix/pull/1961#issuecomment-670253269 you can take a look at the CI install script: https://github.com/apache/apisix/blob/master/.travis/linux_openresty_runner.sh another doc: https://github.com/apache/apisix

[GitHub] [apisix] membphis closed issue #1986: bug: plugins limit-conn repeatedly leaving key

2020-08-06 Thread GitBox
membphis closed issue #1986: URL: https://github.com/apache/apisix/issues/1986 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis merged pull request #1994: bugfix: used a table array to store the `status`, allow the plugin can

2020-08-06 Thread GitBox
membphis merged pull request #1994: URL: https://github.com/apache/apisix/pull/1994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: bugfix: used a table array to store the `status`, allow the plugin can (#1994)

2020-08-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 31f7445 bugfix: used a table array to store t

[GitHub] [apisix] membphis commented on pull request #2015: Rename Contributing.md to CONTRIBUTING.md

2020-08-06 Thread GitBox
membphis commented on pull request #2015: URL: https://github.com/apache/apisix/pull/2015#issuecomment-670252636 @juzhiyuan ![image](https://user-images.githubusercontent.com/6814606/89595050-1f442b80-d886-11ea-8a59-6100f82eda05.png) ---

[GitHub] [apisix] membphis commented on pull request #2014: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
membphis commented on pull request #2014: URL: https://github.com/apache/apisix/pull/2014#issuecomment-670252464 @jie123108 many thx, merged This is an automated message from the Apache Git Service. To respond to the message,

[apisix] branch master updated: bugfix: support parameter way to match request in route. (#2012)

2020-08-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 05f30e1 bugfix: support parameter way to matc

[GitHub] [apisix] membphis merged pull request #2012: bugfix: support parameter way to match request in route.

2020-08-06 Thread GitBox
membphis merged pull request #2012: URL: https://github.com/apache/apisix/pull/2012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #2008: request help: Parameters in path don't work as expected

2020-08-06 Thread GitBox
membphis closed issue #2008: URL: https://github.com/apache/apisix/issues/2008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] moonming merged pull request #2014: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
moonming merged pull request #2014: URL: https://github.com/apache/apisix/pull/2014 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: doc: remove all ‘incubator’ in doc (#2014)

2020-08-06 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b4890bf doc: remove all ‘incubator’ in doc (#2

[GitHub] [apisix] moonming closed issue #1999: remove all `incubator` in doc and source code

2020-08-06 Thread GitBox
moonming closed issue #1999: URL: https://github.com/apache/apisix/issues/1999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[apisix-dashboard] branch v1.5 updated (9a5e643 -> 5852277)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 9a5e643 Feat release 1.5 (#358) add 873a8d8 feat(i18n): modify some i18n according to the proposal#

[apisix-dashboard] branch master updated: doc: remove all ‘incubator’ (#367)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new ecdf25e doc: remove all ‘incubator

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #367: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
juzhiyuan merged pull request #367: URL: https://github.com/apache/apisix-dashboard/pull/367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #368: Create CONTRIBUTING.md

2020-08-06 Thread GitBox
juzhiyuan merged pull request #368: URL: https://github.com/apache/apisix-dashboard/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: Create CONTRIBUTING.md (#368)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 666b2e9 Create CONTRIBUTING.md (#3

[apisix-dashboard] branch juzhiyuan-patch-1 updated (ff79835 -> c6172e6)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from ff79835 Create ISSUE_TEMPLATE add c6172e6 Create PULL_REQUEST_TEMPLATE No new revisio

[apisix-dashboard] branch juzhiyuan-patch-1 updated (a642f5b -> ff79835)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from a642f5b Create CONTRIBUTING.md add ff79835 Create ISSUE_TEMPLATE No new revisions wer

[GitHub] [apisix] juzhiyuan opened a new pull request #2015: Rename Contributing.md to CONTRIBUTING.md

2020-08-06 Thread GitBox
juzhiyuan opened a new pull request #2015: URL: https://github.com/apache/apisix/pull/2015 ### What this PR does / why we need it: Keep the same UpperCase style. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have b

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #368: Create CONTRIBUTING.md

2020-08-06 Thread GitBox
juzhiyuan opened a new pull request #368: URL: https://github.com/apache/apisix-dashboard/pull/368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-dashboard] branch juzhiyuan-patch-1 created (now a642f5b)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at a642f5b Create CONTRIBUTING.md This branch includes the following new commits: new a6

[apisix] branch juzhiyuan-patch-1 created (now 7577275)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 7577275 Rename Contributing.md to CONTRIBUTING.md This branch includes the following new commits:

[apisix] 01/01: Rename Contributing.md to CONTRIBUTING.md

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git commit 7577275c40822712d956a8b1cc4b62012cf68fa3 Author: 琚致远 AuthorDate: Fri Aug 7 07:37:47 2020 +0800 Rename

[apisix-dashboard] 01/01: Create CONTRIBUTING.md

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit a642f5baf7d03e71fdfa53d0bdc182aa6a27590e Author: 琚致远 AuthorDate: Fri Aug 7 07:37:17 2020 +0800

[GitHub] [apisix-dashboard] juzhiyuan closed issue #331: Proposal: i18n

2020-08-06 Thread GitBox
juzhiyuan closed issue #331: URL: https://github.com/apache/apisix-dashboard/issues/331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #331: Proposal: i18n

2020-08-06 Thread GitBox
juzhiyuan commented on issue #331: URL: https://github.com/apache/apisix-dashboard/issues/331#issuecomment-670240703 Agree +1 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] swayamraina commented on pull request #1961: add apisix-version info to headers

2020-08-06 Thread GitBox
swayamraina commented on pull request #1961: URL: https://github.com/apache/apisix/pull/1961#issuecomment-670079931 > Can you please help to understand how to setup/run TCs (from https://github.com/apache/apisix/issues/1877) @membphis I am unable to run TCs locally. It produces the

[GitHub] [apisix] Miss-you commented on issue #2009: request help: support custom access log format

2020-08-06 Thread GitBox
Miss-you commented on issue #2009: URL: https://github.com/apache/apisix/issues/2009#issuecomment-670007992 /accept This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-dashboard] jie123108 opened a new pull request #367: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
jie123108 opened a new pull request #367: URL: https://github.com/apache/apisix-dashboard/pull/367 ### remove all ‘incubator’ This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] jie123108 opened a new pull request #2014: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
jie123108 opened a new pull request #2014: URL: https://github.com/apache/apisix/pull/2014 ### What this PR does / why we need it: Fix: #1999 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? *

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #366: feat(i18n): modify some i18n according to the proposal#331

2020-08-06 Thread GitBox
juzhiyuan merged pull request #366: URL: https://github.com/apache/apisix-dashboard/pull/366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: feat(i18n): modify some i18n according to the proposal#331 (#366)

2020-08-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 873a8d8 feat(i18n): modify some i1

[GitHub] [apisix] jie123108 closed pull request #2013: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
jie123108 closed pull request #2013: URL: https://github.com/apache/apisix/pull/2013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #1862: bug: redirect question

2020-08-06 Thread GitBox
membphis closed issue #1862: URL: https://github.com/apache/apisix/issues/1862 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis commented on issue #1862: bug: redirect question

2020-08-06 Thread GitBox
membphis commented on issue #1862: URL: https://github.com/apache/apisix/issues/1862#issuecomment-669976778 @Joe123-ai if you still have a problem, please feel free to reopen this issue. This is an automated message from the

[GitHub] [apisix] membphis commented on issue #1851: health check can't use

2020-08-06 Thread GitBox
membphis commented on issue #1851: URL: https://github.com/apache/apisix/issues/1851#issuecomment-669976215 @wanzhenhan please make a try with this PR: https://github.com/apache/apisix/pull/1971 I think this bug has been fixed. --

[GitHub] [apisix] membphis closed issue #1990: bug: custom plugin does not work

2020-08-06 Thread GitBox
membphis closed issue #1990: URL: https://github.com/apache/apisix/issues/1990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis commented on issue #1990: bug: custom plugin does not work

2020-08-06 Thread GitBox
membphis commented on issue #1990: URL: https://github.com/apache/apisix/issues/1990#issuecomment-669971663 @spjiang close this issue. if you still have a problem, please feel free to reopen this issue. This is an automated

[GitHub] [apisix] membphis merged pull request #2011: doc: update authz-keycloak plugin docs

2020-08-06 Thread GitBox
membphis merged pull request #2011: URL: https://github.com/apache/apisix/pull/2011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #2010: doc: Chinese version

2020-08-06 Thread GitBox
membphis closed issue #2010: URL: https://github.com/apache/apisix/issues/2010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[apisix] branch master updated: doc: update authz-keycloak plugin docs (#2011)

2020-08-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b450320 doc: update authz-keycloak plugin doc

[GitHub] [apisix] membphis commented on pull request #2013: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
membphis commented on pull request #2013: URL: https://github.com/apache/apisix/pull/2013#issuecomment-669970516 According to the title, we'd better only update the doc file. But the change log file does not need to be updated. And we should keep the source code unchanged. ---

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #366: feat(i18n): modify some i18n according to the proposal#331

2020-08-06 Thread GitBox
liuxiran opened a new pull request #366: URL: https://github.com/apache/apisix-dashboard/pull/366 this pr is changing some i18n according to https://github.com/apache/apisix-dashboard/issues/331 Proposal This is an automated

[GitHub] [apisix] jie123108 opened a new pull request #2013: doc: remove all ‘incubator’

2020-08-06 Thread GitBox
jie123108 opened a new pull request #2013: URL: https://github.com/apache/apisix/pull/2013 ### What this PR does / why we need it: Fix: #1999 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? *

[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-06 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r466351129 ## File path: apisix/discovery/eureka.lua ## @@ -34,6 +35,8 @@ local log= core.log local default_weight local applications + + Review

[GitHub] [apisix] membphis opened a new pull request #2012: bugfix: support parameter way to match request in route.

2020-08-06 Thread GitBox
membphis opened a new pull request #2012: URL: https://github.com/apache/apisix/pull/2012 ### What this PR does / why we need it: fix https://github.com/apache/apisix/issues/2008 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve?

[GitHub] [apisix] membphis commented on a change in pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466334456 ## File path: t/node/ewma.t ## @@ -0,0 +1,90 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements

[GitHub] [apisix] membphis commented on a change in pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466332602 ## File path: apisix/balancer/ewma.lua ## @@ -33,31 +34,34 @@ local ewma_lock, ewma_lock_err local shm_ewma = ngx_shared.balancer_ewma local shm_last_to

[GitHub] [apisix] membphis commented on pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-669859101 @redynasc if we have fixed them, we can click the `resolve ...` button by ourselves. ![image](https://user-images.githubusercontent.com/6814606/89524034-6db9e180-d816-11e

[GitHub] [apisix] membphis commented on issue #2008: request help: Parameters in path don't work as expected

2020-08-06 Thread GitBox
membphis commented on issue #2008: URL: https://github.com/apache/apisix/issues/2008#issuecomment-669858228 we can update the `resty-radixtree` release new version This is an automated message from the Apache Git Service. To

[GitHub] [apisix] scaat opened a new pull request #2011: doc: update authz-keycloak plugin docs

2020-08-06 Thread GitBox
scaat opened a new pull request #2011: URL: https://github.com/apache/apisix/pull/2011 ### What this PR does / why we need it: fix #2010 This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] liuxiran commented on issue #331: Proposal: i18n

2020-08-06 Thread GitBox
liuxiran commented on issue #331: URL: https://github.com/apache/apisix-dashboard/issues/331#issuecomment-669849130 Hi, I have a proposal the key can be like this : [basicModule].[moduleName].[elementName].[...desc] 1. basic keys (the first tow levels) divide according to the dire

[GitHub] [apisix-dashboard] juzhiyuan closed issue #365: apikey

2020-08-06 Thread GitBox
juzhiyuan closed issue #365: URL: https://github.com/apache/apisix-dashboard/issues/365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #365: apikey

2020-08-06 Thread GitBox
juzhiyuan commented on issue #365: URL: https://github.com/apache/apisix-dashboard/issues/365#issuecomment-669829125 https://github.com/apache/apisix-dashboard/blob/master/compose/manager_conf/build.sh#L27 This is an automa

[GitHub] [apisix] membphis commented on issue #1991: request help: grpc-transcode plugin converts http/json parameters abnormally

2020-08-06 Thread GitBox
membphis commented on issue #1991: URL: https://github.com/apache/apisix/issues/1991#issuecomment-669825541 > The doc link of the grpc-transcode plugin on the APISIX project homepage is incorrect, can you supply a screen capture? I can not sure which link is wrong.

[GitHub] [apisix] membphis commented on pull request #1989: Fixed discovery weight bug

2020-08-06 Thread GitBox
membphis commented on pull request #1989: URL: https://github.com/apache/apisix/pull/1989#issuecomment-669820599 @frank0417 please take a look at the output of CI: https://github.com/apache/apisix/pull/1989/checks?check_run_id=952820522#step:6:125 you need to fix them first ---

[GitHub] [apisix-dashboard] qiuhaohui163 opened a new issue #365: apikey

2020-08-06 Thread GitBox
qiuhaohui163 opened a new issue #365: URL: https://github.com/apache/apisix-dashboard/issues/365 The new dashboard where to set the apikey? The request header don't have the X-API-KEY. This is an automated message from the A

[GitHub] [apisix] membphis commented on a change in pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466263277 ## File path: apisix/balancer/ewma.lua ## @@ -140,30 +140,30 @@ local function pick_and_score(peers, k) end --- slow_start_ewma is something we use t

[GitHub] [apisix] sshniro commented on pull request #1924: Support SSL verify option to Authz Keycloak plugin

2020-08-06 Thread GitBox
sshniro commented on pull request #1924: URL: https://github.com/apache/apisix/pull/1924#issuecomment-669810062 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix] membphis opened a new issue #2010: doc: Chinese version

2020-08-06 Thread GitBox
membphis opened a new issue #2010: URL: https://github.com/apache/apisix/issues/2010 https://github.com/apache/apisix/pull/1924/files#diff-142655bb13c688162035732e434efc7eR48 This is an automated message from the Apache

[GitHub] [apisix] membphis commented on pull request #1924: Support SSL verify option to Authz Keycloak plugin

2020-08-06 Thread GitBox
membphis commented on pull request #1924: URL: https://github.com/apache/apisix/pull/1924#issuecomment-669809532 @sshniro yes, merged already This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix] membphis closed issue #1855: Support verify ssl option parameter in Keycloak Plugin

2020-08-06 Thread GitBox
membphis closed issue #1855: URL: https://github.com/apache/apisix/issues/1855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis merged pull request #1924: Support SSL verify option to Authz Keycloak plugin

2020-08-06 Thread GitBox
membphis merged pull request #1924: URL: https://github.com/apache/apisix/pull/1924 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feat: Support SSL verify option to Authz Keycloak plugin (#1924)

2020-08-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 712a23f feat: Support SSL verify option to Au

[GitHub] [apisix] moonming commented on issue #1652: add support for Vault

2020-08-06 Thread GitBox
moonming commented on issue #1652: URL: https://github.com/apache/apisix/issues/1652#issuecomment-669802234 sure, absolutely. Thanks, Ming Wen Twitter: _WenMing Nirojan Selvanathan 于2020年8月6日周四 下午4:49写道: > @moonming @membphis >

[GitHub] [apisix] sshniro commented on issue #1652: add support for Vault

2020-08-06 Thread GitBox
sshniro commented on issue #1652: URL: https://github.com/apache/apisix/issues/1652#issuecomment-669800100 @moonming @membphis shall I attempt this task? This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix] membphis commented on pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-669799609 @redynasc please take a look at the output of CI: https://github.com/apache/apisix/pull/2001/checks?check_run_id=952937828 ```shell + luacheck -q apisix Checking api

[GitHub] [apisix] sshniro commented on pull request #1924: Support SSL verify option to Authz Keycloak plugin

2020-08-06 Thread GitBox
sshniro commented on pull request #1924: URL: https://github.com/apache/apisix/pull/1924#issuecomment-669799602 @membphis can we merge this PR? This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix] membphis commented on a change in pull request #2001: add ewma balancer

2020-08-06 Thread GitBox
membphis commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r466239262 ## File path: apisix/balancer/ewma.lua ## @@ -17,144 +17,155 @@ local resty_lock = require("resty.lock") local core = require("apisix.core") +local ng

[GitHub] [apisix] membphis commented on issue #2008: request help: Parameters in path don't work as expected

2020-08-06 Thread GitBox
membphis commented on issue #2008: URL: https://github.com/apache/apisix/issues/2008#issuecomment-669791974 I added a test case in `resty-radixtree`, it works fine with the case you provided. https://github.com/api7/lua-resty-radixtree/pull/49 We will make a try in APISIX late

[GitHub] [apisix] membphis commented on issue #2008: request help: Parameters in path don't work as expected

2020-08-06 Thread GitBox
membphis commented on issue #2008: URL: https://github.com/apache/apisix/issues/2008#issuecomment-669785296 I will make a test in `resty-radixtree` for this case. This is an automated message from the Apache Git Service. To r

[apisix] branch master updated: feat: add '**' for alllow_headers and complete docs (#2004)

2020-08-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2ac4773 feat: add '**' for alllow_headers and

[GitHub] [apisix] membphis merged pull request #2004: feat: add '**' for alllow_headers and complete docs

2020-08-06 Thread GitBox
membphis merged pull request #2004: URL: https://github.com/apache/apisix/pull/2004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #1983: bug: cors when the request is a preflight request we shouldn't set the Access-Control-Allow-Headers *

2020-08-06 Thread GitBox
membphis closed issue #1983: URL: https://github.com/apache/apisix/issues/1983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis merged pull request #2007: typo: fixed typo about function.

2020-08-06 Thread GitBox
membphis merged pull request #2007: URL: https://github.com/apache/apisix/pull/2007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated (ac69ad3 -> 23bc76b)

2020-08-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from ac69ad3 doc: removed incubator prefix and fix steps (#1998) add 23bc76b typo: fixed typo about function. (#2

[GitHub] [apisix] nic-chen opened a new issue #2009: request help: support custom access log format

2020-08-06 Thread GitBox
nic-chen opened a new issue #2009: URL: https://github.com/apache/apisix/issues/2009 ### Issue description The access log format is currently fixed, hope that the access log format can be specified through the configuration file `config.yaml`. ### Environment * apisix

[GitHub] [apisix] backnero commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-08-06 Thread GitBox
backnero commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-669773814 Yes, I try to configure the cors plug-in on Service and Route, not in the global, it can be used normally This is an

[GitHub] [apisix] ShiningRush commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

2020-08-06 Thread GitBox
ShiningRush commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-669772817 As a workaround, you can using CORS plugin append to each route instead of global rules util the bug is resolved. @backnero -

  1   2   >