[GitHub] [apisix-dashboard] juzhiyuan commented on issue #332: Use auto load i18n

juzhiyuan commented on issue #332: URL: https://github.com/apache/apisix-dashboard/issues/332#issuecomment-671189133 > > Only locales under /src/pages would work as far as I know, you could have a test :D > > test passed.👍 > > although src/pages locales will be auto load , an

[GitHub] [apisix-dashboard] liuxiran commented on issue #332: Use auto load i18n

liuxiran commented on issue #332: URL: https://github.com/apache/apisix-dashboard/issues/332#issuecomment-671187243 > Only locales under /src/pages would work as far as I know, you could have a test :D test passed.👍 although src/pages locales will be auto load , and it may be

[GitHub] [apisix-dashboard] liuxiran removed a comment on issue #332: Use auto load i18n

liuxiran removed a comment on issue #332: URL: https://github.com/apache/apisix-dashboard/issues/332#issuecomment-671160851 > Only locales under /src/pages would work as far as I know, you could have a test :D I tried to do i18n in src/helps.tsx, which is not under src/pages It w

[GitHub] [apisix-dashboard] liuxiran commented on issue #332: Use auto load i18n

liuxiran commented on issue #332: URL: https://github.com/apache/apisix-dashboard/issues/332#issuecomment-671160851 > Only locales under /src/pages would work as far as I know, you could have a test :D I tried to do i18n in src/helps.tsx, which is not under src/pages It worked by

[GitHub] [apisix] membphis opened a new issue #2034: feature: allow user to specify the `conf/config.yaml` when starting the APISIX project.

membphis opened a new issue #2034: URL: https://github.com/apache/apisix/issues/2034 Here is an example: `apisix start -c /opts/apisix/config.yaml` . This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] membphis commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…

membphis commented on pull request #2023: URL: https://github.com/apache/apisix/pull/2023#issuecomment-671145794 > How about allowing user to specify the path of `config.yaml` ? that is another feature, we can implement it in a single PR -

[GitHub] [apisix] moonming commented on a change in pull request #2001: add ewma balancer

moonming commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r467670387 ## File path: apisix/balancer/ewma.lua ## @@ -0,0 +1,240 @@ +-- Review comment: This code file is copied from https://github.com/kubernetes/ingre

[GitHub] [apisix] moonming commented on a change in pull request #2001: add ewma balancer

moonming commented on a change in pull request #2001: URL: https://github.com/apache/apisix/pull/2001#discussion_r467669361 ## File path: apisix/balancer/ewma.lua ## @@ -0,0 +1,240 @@ +-- Review comment: @redynasc Did you write this code yourself, or copied it from anot

[GitHub] [apisix] membphis merged pull request #2030: doc: update example syntax error for request-validation plugin.

membphis merged pull request #2030: URL: https://github.com/apache/apisix/pull/2030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis closed issue #2033: doc: example json syntax error for request-validation plugin.

membphis closed issue #2033: URL: https://github.com/apache/apisix/issues/2033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[apisix] branch master updated: doc: update example syntax error for request-validation plugin. (#2030)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new da08265 doc: update example syntax error for

[GitHub] [apisix] nic-chen commented on issue #2025: bug: comparing etcd key's modifiedIndex as a number may cause an error when access to prometheus exporter api

nic-chen commented on issue #2025: URL: https://github.com/apache/apisix/issues/2025#issuecomment-671132459 > @nic-chen do you have time to fix this bug? sure This is an automated message from the Apache Git Service. T

[GitHub] [apisix] moonming commented on pull request #1961: add apisix-version info to headers

moonming commented on pull request #1961: URL: https://github.com/apache/apisix/pull/1961#issuecomment-671131595 I don't think so. We need strict restrictions, which is the meaning of the test case. how about `\d\.\d+(\.\d+)?$`? Thanks, Ming Wen Twitter: _WenMing

[GitHub] [apisix] membphis commented on a change in pull request #1961: add apisix-version info to headers

membphis commented on a change in pull request #1961: URL: https://github.com/apache/apisix/pull/1961#discussion_r467653957 ## File path: t/node/remote-addr-ipv6.t ## @@ -114,7 +114,7 @@ request sent: 59 received: HTTP/1.1 200 OK received: Content-Type: text/plain received:

[GitHub] [apisix] membphis commented on pull request #2031: doc: update uri-blocker name for README.

membphis commented on pull request #2031: URL: https://github.com/apache/apisix/pull/2031#issuecomment-671128014 @shuaijinchao many thx This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix] membphis closed issue #2032: doc: `uri-blocker` misspelled for README_CN.

membphis closed issue #2032: URL: https://github.com/apache/apisix/issues/2032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[apisix] branch master updated (8304b68 -> 5607114)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8304b68 doc: rename Contributing.md to CONTRIBUTING.md (#2015) add 5607114 doc: update uri-blocker name for

[GitHub] [apisix] membphis merged pull request #2031: doc: update uri-blocker name for README.

membphis merged pull request #2031: URL: https://github.com/apache/apisix/pull/2031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] shuaijinchao opened a new issue #2033: doc: example json syntax error for request-validation plugin.

shuaijinchao opened a new issue #2033: URL: https://github.com/apache/apisix/issues/2033 ### Issues https://github.com/apache/apisix/blob/master/doc/zh-cn/plugins/request-validation.md#%E7%A4%BA%E4%BE%8B the Json structure in the example should use `:` instead of `=`. --

[GitHub] [apisix] shuaijinchao opened a new issue #2032: doc: `uri-blocker` misspelled for README_CN.

shuaijinchao opened a new issue #2032: URL: https://github.com/apache/apisix/issues/2032 ### Issues 1/ update `uri-blocker` to `URI拦截器` for README_CN.md 2/ update `uri-blocker` to `URI Blocker` for README.md This is an

[GitHub] [apisix] shuaijinchao opened a new pull request #2031: doc: update uri-blocker name for README.

shuaijinchao opened a new pull request #2031: URL: https://github.com/apache/apisix/pull/2031 ### What this PR does / why we need it: 1/ update `uri-blocker` to `URI拦截器` for README_CN.md 2/ update `uri-blocker` to `URI Blocker` for README.md ### Pre-submission checklist:

[GitHub] [apisix] shuaijinchao opened a new pull request #2030: doc: update example syntax error for request-validation plugin.

shuaijinchao opened a new pull request #2030: URL: https://github.com/apache/apisix/pull/2030 ### What this PR does / why we need it: 1/ update example syntax error for request-validation plugin. 2/ add example to request-validation plugin english document. ### Pre-submission ch

[GitHub] [apisix] nic-chen edited a comment on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…

nic-chen edited a comment on pull request #2023: URL: https://github.com/apache/apisix/pull/2023#issuecomment-671043910 LGTM. How about allowing user to specify the path of `config.yaml` ? This is an automated message

[GitHub] [apisix] nic-chen commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…

nic-chen commented on pull request #2023: URL: https://github.com/apache/apisix/pull/2023#issuecomment-671043910 LGTM. But how about allow user to specify the path of `config.yaml`? This is an automated message from the Ap

[apisix-dashboard] branch v1.5 updated (c2ce4c9 -> 5a482d3)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from c2ce4c9 Merge branch 'master' into v1.5 add 5a482d3 feat: added line No new revisions were added b

[apisix-dashboard] branch v1.5 updated (e07cefa -> c2ce4c9)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from e07cefa feat(compose): remove images add 4fd0ce7 feat(deploy): set gen-config-yaml.sh executable (#

[apisix-dashboard] branch v1.5 updated (8e77410 -> e07cefa)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 8e77410 feat: cherry-pick 4fd0ce79bb34dbe8c31b7a27884930e3b0e5437c add e07cefa feat(compose): remov

[apisix-dashboard] branch v1.5 updated (5852277 -> 8e77410)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch v1.5 in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 5852277 Merge branch 'master' into v1.5 add 8e77410 feat: cherry-pick 4fd0ce79bb34dbe8c31b7a2788493