[GitHub] [apisix] griffenliu opened a new issue #2194: bug: error when route not found

2020-09-08 Thread GitBox
griffenliu opened a new issue #2194: URL: https://github.com/apache/apisix/issues/2194 ### Issue description when route not found and `return core.response.exit(404, {error_msg = "failed to match any routes"})`, the apisix occur error. ### Environment * apisix version

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689309012 @liuxiran could add the description under that field using Form item :D This is an automated message

[GitHub] [apisix-dashboard] ShiningRush commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
ShiningRush commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-689307501 @bzp2010 @gxthrj @moonming @membphis @ShiningRush @tiannian @LiteSun `GenericStore` has already completed.I write a demo about how to use it in

[apisix-dashboard] 02/02: resolve conflict

2020-09-08 Thread vinci
This is an automated email from the ASF dual-hosted git repository. vinci pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 13d0e98a6585406b9c56b526da484973f67b2600 Merge: b2dcf5e b93388f Author: vincixu AuthorDate: Wed Sep 9

[apisix-dashboard] 01/02: feat: refactor some codes and append store core

2020-09-08 Thread vinci
This is an automated email from the ASF dual-hosted git repository. vinci pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit b2dcf5ee74a6da9119ee7e9963f96de4cc24673f Author: vincixu AuthorDate: Wed Sep 9 12:51:53 2020 +0800

[apisix-dashboard] branch refactor created (now 13d0e98)

2020-09-08 Thread vinci
This is an automated email from the ASF dual-hosted git repository. vinci pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 13d0e98 resolve conflict This branch includes the following new commits: new b2dcf5e feat:

[GitHub] [apisix] spacewander commented on issue #2191: bug zipkin Arguments

2020-09-08 Thread GitBox
spacewander commented on issue #2191: URL: https://github.com/apache/apisix/issues/2191#issuecomment-689300661 Look like the sample argument is removed since https://github.com/iresty/opentracing-openresty/pull/2/files. But the code in apisix didn't update for it. CC @moonming

[GitHub] [apisix-dashboard] moonming commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
moonming commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689293720 LGTM Thanks, Ming Wen Twitter: _WenMing liuxiran 于2020年9月9日周三 上午11:56写道: > [image: 图片] >

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran edited a comment on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689285571 > ![图片](https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png) > You may have misunderstood what I mean. I hope

[apisix-dashboard] branch master updated (316633b -> b93388f)

2020-09-08 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 316633b Feat: manage api support route group (#432) add b93388f feat: preview pluginchart

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #456: feat: preview pluginchart

2020-09-08 Thread GitBox
juzhiyuan merged pull request #456: URL: https://github.com/apache/apisix-dashboard/pull/456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] liuxiran commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689285571 > ![图片](https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png) > You may have misunderstood what I mean. I hope the

[GitHub] [apisix-dashboard] moonming commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
moonming commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689280915 ![图片](https://user-images.githubusercontent.com/26448043/92551709-403ada80-f291-11ea-90c2-44abc712fc61.png) You may have misunderstood what I mean. I hope the

[GitHub] [apisix] dickens7 opened a new pull request #2193: fixed #2191

2020-09-08 Thread GitBox
dickens7 opened a new pull request #2193: URL: https://github.com/apache/apisix/pull/2193 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you

[GitHub] [apisix] nic-chen opened a new pull request #2192: [WIP] feat: add AK/SK auth plugin

2020-09-08 Thread GitBox
nic-chen opened a new pull request #2192: URL: https://github.com/apache/apisix/pull/2192 ### What this PR does / why we need it: add AK/SK auth plugin ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix] dickens7 commented on issue #2191: bug zipkin Arguments

2020-09-08 Thread GitBox
dickens7 commented on issue #2191: URL: https://github.com/apache/apisix/issues/2191#issuecomment-689275461 when `x-b3-sampled` is 1, the BUG is triggered This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] dickens7 opened a new issue #2191: bug zipkin Arguments

2020-09-08 Thread GitBox
dickens7 opened a new issue #2191: URL: https://github.com/apache/apisix/issues/2191 - parameters passed when using the function https://github.com/apache/apisix/blob/3ece377d3ff920a3f46c0fa93312e5d7b276f63f/apisix/plugins/zipkin/codec.lua#L101-L103 - the actual

[GitHub] [apisix] membphis commented on issue #2189: bug: When creating a route, host should not be required

2020-09-08 Thread GitBox
membphis commented on issue #2189: URL: https://github.com/apache/apisix/issues/2189#issuecomment-689273956 you can copy this issue to apisix-dashboard ^_^ This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-08 Thread GitBox
membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r485311928 ## File path: FAQ.md ## @@ -80,7 +80,7 @@ An example, `foo.com/product/index.html?id=204=2`, gray release based on `i here is the way: ```shell

[GitHub] [apisix-dashboard] liuxiran commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689272799 > > choose `enable`, means to publish route(create route both in mysql and apisix), and the route can be use now; > > it will be better if we can make it more

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-08 Thread GitBox
membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r485309909 ## File path: FAQ.md ## @@ -80,7 +80,7 @@ An example, `foo.com/product/index.html?id=204=2`, gray release based on `i here is the way: ```shell

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #456: feat: preview pluginchart

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #456: URL: https://github.com/apache/apisix-dashboard/pull/456#issuecomment-689268971 cc @moonming This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-689268753 Waiting for #450 , DO NOT MERGE NOW. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] Firstsawyou commented on issue #457: request help: How to resolve the license conflict in the file header.

2020-09-08 Thread GitBox
Firstsawyou commented on issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457#issuecomment-689264874 okay, thanks. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-08 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r485304213 ## File path: api/route/route.go ## @@ -34,10 +34,10 @@ func AppendRoute(r *gin.Engine) *gin.Engine { r.GET("/apisix/admin/routes/:rid",

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485303868 ## File path: src/pages/Route/service.ts ## @@ -50,8 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => { };

[GitHub] [apisix] y934317258 opened a new issue #2190: request help: What is the current circuit breaker strategy and where is it introduced

2020-09-08 Thread GitBox
y934317258 opened a new issue #2190: URL: https://github.com/apache/apisix/issues/2190 ### Issue description What is the current circuit breaker strategy and where is it introduced? For example, if the threshold value is reached in the monitoring period, it will fuse. How long can it

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-08 Thread GitBox
juzhiyuan commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r485300682 ## File path: api/route/route.go ## @@ -34,10 +34,10 @@ func AppendRoute(r *gin.Engine) *gin.Engine { r.GET("/apisix/admin/routes/:rid",

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485298935 ## File path: src/pages/Route/transform.ts ## @@ -53,11 +53,17 @@ export const transformStepData = ({ protocols =

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
juzhiyuan commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485298486 ## File path: src/pages/Route/service.ts ## @@ -50,8 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => {

[GitHub] [apisix] tengzhinei opened a new issue #2189: bug:

2020-09-08 Thread GitBox
tengzhinei opened a new issue #2189: URL: https://github.com/apache/apisix/issues/2189 ### Issue description When creating a route, host should not be required. We are a sass project. Thousands of domain names point to the same system. Now, we are using Kong. Now we can route

[GitHub] [apisix] fankeke removed a comment on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production

2020-09-08 Thread GitBox
fankeke removed a comment on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-689251844 Every request will be handled by block plugin. This is an automated message from the Apache Git Service.

[GitHub] [apisix] fankeke opened a new issue #2188: request help:

2020-09-08 Thread GitBox
fankeke opened a new issue #2188: URL: https://github.com/apache/apisix/issues/2188 ### Issue description plugin: url_blocker.lua ``` local from = re_find(ctx.var.request_uri, conf.block_rules_concat, "jo") ``` Is there any performance bottleneck if there are many

[GitHub] [apisix] fankeke commented on issue #2188: request help:

2020-09-08 Thread GitBox
fankeke commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-689251456 @membphis This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #456: feat: preview pluginchart

2020-09-08 Thread GitBox
LiteSun commented on a change in pull request #456: URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r485291538 ## File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx ## @@ -44,7 +46,12 @@ const CreateStep4: React.FC = ({ form1, form2,

[GitHub] [apisix] ShiningRush commented on issue #2176: request help: How to configure timeout settings?

2020-09-08 Thread GitBox
ShiningRush commented on issue #2176: URL: https://github.com/apache/apisix/issues/2176#issuecomment-689249001 There is currently no way to set these values. We can record this requirement and expose it in soon. As a workaround, you can modify the configuration content in `bin/apisix`

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485289231 ## File path: src/pages/Route/typing.d.ts ## @@ -113,6 +116,8 @@ declare namespace RouteModule { // Request Body or Response Data for API

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
liuxiran commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r485288825 ## File path: src/pages/Route/service.ts ## @@ -50,6 +50,8 @@ export const fetchList = ({ current = 1, pageSize = 10 }, search: string) => { };

[GitHub] [apisix] moonming commented on issue #2156: bug: can not run apisix on ARM

2020-09-08 Thread GitBox
moonming commented on issue #2156: URL: https://github.com/apache/apisix/issues/2156#issuecomment-689240122 @DHB-liuhong got it, thanks. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] DHB-liuhong edited a comment on issue #2156: bug: can not run apisix on ARM

2020-09-08 Thread GitBox
DHB-liuhong edited a comment on issue #2156: URL: https://github.com/apache/apisix/issues/2156#issuecomment-689239308 @moonming .Apisix must be compiled on an ARM machine, ffi.load(fpath) is failed, because /usr/local/apisix/deps/lib64/lua/5.1/librestyradixtree.so's info is x86. use

[GitHub] [apisix] DHB-liuhong edited a comment on issue #2156: bug: can not run apisix on ARM

2020-09-08 Thread GitBox
DHB-liuhong edited a comment on issue #2156: URL: https://github.com/apache/apisix/issues/2156#issuecomment-689239308 @moonming .Apisix must be compiled on an ARM machine, ffi.load(fpath) is failed, because /usr/local/apisix/deps/lib64/lua/5.1/librestyradixtree.so's info is x86

[GitHub] [apisix] DHB-liuhong commented on issue #2156: bug: can not run apisix on ARM

2020-09-08 Thread GitBox
DHB-liuhong commented on issue #2156: URL: https://github.com/apache/apisix/issues/2156#issuecomment-689239308 @moonming .Apisix must be compiled on an ARM machine This is an automated message from the Apache Git Service. To

[GitHub] [apisix] juzhiyuan opened a new issue #2187: request help: remove the dashboard submodule

2020-09-08 Thread GitBox
juzhiyuan opened a new issue #2187: URL: https://github.com/apache/apisix/issues/2187 ### Issue description Please remove the dashboard submodule, because it's outdated with the Dashboard v1.5+ ### Environment * apisix version (cmd: `apisix version`): * OS:

[GitHub] [apisix-dashboard] moonming commented on issue #457: request help: How to resolve the license conflict in the file header.

2020-09-08 Thread GitBox
moonming commented on issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457#issuecomment-689227706 yes, we should keep these original headers. you can skip these files in license check tool. 琚致远 于 2020年9月9日周三 上午8:18写道: > Just keep the MIT Header,

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #457: request help: How to resolve the license conflict in the file header.

2020-09-08 Thread GitBox
juzhiyuan commented on issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457#issuecomment-689204655 Just keep the MIT Header, @moonming right? This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Yiyiyimu commented on issue #2152: request help: add Chaos Testing for Apache APISIX

2020-09-08 Thread GitBox
Yiyiyimu commented on issue #2152: URL: https://github.com/apache/apisix/issues/2152#issuecomment-689047153 Hi @zhouqiang-cl thank you for your support! This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-08 Thread GitBox
membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r485103731 ## File path: t/lib/test_admin.lua ## @@ -128,6 +128,7 @@ function _M.test(uri, method, body, pattern, headers) end if not

[GitHub] [apisix-dashboard] Firstsawyou opened a new issue #457: request help: How to resolve the license conflict in the file header.

2020-09-08 Thread GitBox
Firstsawyou opened a new issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirements - [ ] Feature or

[GitHub] [apisix] zhouqiang-cl commented on issue #2152: request help: add Chaos Testing for Apache APISIX

2020-09-08 Thread GitBox
zhouqiang-cl commented on issue #2152: URL: https://github.com/apache/apisix/issues/2152#issuecomment-688983479 @Yiyiyimu @moonming Thank you for your interest in Chaos Mesh. I am [Chaos Mesh](https://github.com/chaos-mesh/chaos-mesh) maintainer. If you have any questions, please feel

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #456: feat: preview pluginchart

2020-09-08 Thread GitBox
juzhiyuan commented on a change in pull request #456: URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r484935433 ## File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx ## @@ -44,7 +46,12 @@ const CreateStep4: React.FC = ({ form1, form2,

[GitHub] [apisix] moonming commented on issue #2151: feature: Best practice for jaeger

2020-09-08 Thread GitBox
moonming commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-688872687 I think you can add a plugin for jaeger, and welcome PR for this This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] Firstsawyou commented on pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
Firstsawyou commented on pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#issuecomment-688845587 > @Firstsawyou please check the output of CI: https://github.com/apache/apisix-dashboard/pull/454/checks?check_run_id=1085838821 > you need to fix all error

[GitHub] [apisix-dashboard] Firstsawyou commented on a change in pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
Firstsawyou commented on a change in pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r484887438 ## File path: .actions/ASF-Release.cfg ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor

[GitHub] [apisix-dashboard] imjoey commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
imjoey commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688838945 > APISIX will change to etcd v3 at the same time, there is already a pr in apisix repo. 琚致远 于 @moonming yeah, that would be really great! Thanks.

[GitHub] [apisix-dashboard] imjoey commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
imjoey commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688837846 > @imjoey `GenericStore` just depend on a storage interface, so we can also implement etcdv2storage if we need @ShiningRush OK, thanks for your point.

[GitHub] [apisix-dashboard] moonming edited a comment on pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
moonming edited a comment on pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#issuecomment-688835386 @Firstsawyou please check the output of CI: https://github.com/apache/apisix-dashboard/pull/454/checks?check_run_id=1085838821 you need to fix all error

[GitHub] [apisix-dashboard] moonming commented on pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
moonming commented on pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#issuecomment-688835386 @Firstsawyou please check the output of CI. you need to fix all error messages. This is an automated

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
moonming commented on a change in pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r484877051 ## File path: .actions/ASF-Release.cfg ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +#

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #456: feat: preview pluginchart

2020-09-08 Thread GitBox
moonming commented on a change in pull request #456: URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r484875289 ## File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx ## @@ -44,7 +46,12 @@ const CreateStep4: React.FC = ({ form1, form2,

[GitHub] [apisix-dashboard] ShiningRush commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
ShiningRush commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688830905 @imjoey `GenericStore` just depend on a storage interface, so we can also implement etcdv2storage if we need

[GitHub] [apisix-dashboard] moonming commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
moonming commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688828189 APISIX will change to etcd v3 at the same time, there is already a pr in apisix repo. 琚致远 于 2020年9月8日周二 下午7:38写道: > need @membphis

[GitHub] [apisix-dashboard] Firstsawyou commented on a change in pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
Firstsawyou commented on a change in pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r484651096 ## File path: .github/workflows/api_ci.yml ## @@ -74,3 +74,7 @@ jobs: working-directory: ./api run: | go test ./... +

[GitHub] [apisix] haifeng9414 opened a new issue #2186: bug: The log keeps printing "wait for more time, context: ngx.timer"

2020-09-08 Thread GitBox
haifeng9414 opened a new issue #2186: URL: https://github.com/apache/apisix/issues/2186 ### Issue description The http_init method starts a privileged process and the privileged process initializes the routing in the init_worker phase ``` -- radixtree_uri.lua file function

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#issuecomment-688822198 @Firstsawyou This PR is only for the manager-api? or work both for Dashboard and manager API? This is

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#issuecomment-688820433 This PR should wait for #450 This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #451: feat(route): add publish and offline to route

2020-09-08 Thread GitBox
juzhiyuan commented on a change in pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r484855909 ## File path: src/pages/Route/transform.ts ## @@ -53,11 +53,17 @@ export const transformStepData = ({ protocols =

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
juzhiyuan commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688810818 need @membphis @moonming 's help to address your question  This is an automated message from the Apache

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #455: ci: Add lint

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #455: URL: https://github.com/apache/apisix-dashboard/pull/455#issuecomment-688809950 ![image](https://user-images.githubusercontent.com/2106987/92471410-80a34580-f20a-11ea-8718-9ffb09f7bb14.png) What's this? 樂

[GitHub] [apisix-dashboard] imjoey commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
imjoey commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688807701 @ShiningRush @juzhiyuan Just as a reminder, APISIX itself is using API v2 to interactive with etcd, meanwhile this new design seems that API v3 would be adopted in Manager.

[GitHub] [apisix] maxluo1992 commented on issue #2182: bug: error in the pod when deploying apisix-gw-config-cm.yaml in kubernetes

2020-09-08 Thread GitBox
maxluo1992 commented on issue #2182: URL: https://github.com/apache/apisix/issues/2182#issuecomment-688785746 @gxthrj I found that APISIXl uses the http protocol to connect to etcd, but the etcd of the k8s cluster uses the mandatory https protocol, so it cannot connect.

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #456: feat: preview pluginchart

2020-09-08 Thread GitBox
LiteSun opened a new pull request #456: URL: https://github.com/apache/apisix-dashboard/pull/456 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #433: Feat: dashboard support route group

2020-09-08 Thread GitBox
liuxiran commented on a change in pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r484762283 ## File path: config/routes.ts ## @@ -35,6 +35,18 @@ const routes = [ path: '/routes/:rid/edit', component: './Route/Create', }, +

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #433: Feat: dashboard support route group

2020-09-08 Thread GitBox
juzhiyuan commented on pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-688720897 cc @LiteSun This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #433: Feat: dashboard support route group

2020-09-08 Thread GitBox
juzhiyuan commented on a change in pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r484752952 ## File path: config/routes.ts ## @@ -35,6 +35,18 @@ const routes = [ path: '/routes/:rid/edit', component: './Route/Create', }, +

[GitHub] [apisix] gxthrj opened a new pull request #2185: fix: change the config file when deploying apisix in k8s #2182

2020-09-08 Thread GitBox
gxthrj opened a new pull request #2185: URL: https://github.com/apache/apisix/pull/2185 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you

[GitHub] [apisix] gxthrj commented on issue #2182: bug: error in the pod when deploying apisix-gw-config-cm.yaml in kubernetes

2020-09-08 Thread GitBox
gxthrj commented on issue #2182: URL: https://github.com/apache/apisix/issues/2182#issuecomment-688720546 need to update the doc for deploying APISIX in k8s This is an automated message from the Apache Git Service. To

[apisix] 01/01: fix: change the config file when deploying apisix in k8s #2182

2020-09-08 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch kv/k8s-config in repository https://gitbox.apache.org/repos/asf/apisix.git commit 8f3e4587c2e6dda847ab8512490bee3f7709aa47 Author: kv AuthorDate: Tue Sep 8 16:43:42 2020 +0800 fix: change the

[apisix] branch kv/k8s-config created (now 8f3e458)

2020-09-08 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch kv/k8s-config in repository https://gitbox.apache.org/repos/asf/apisix.git. at 8f3e458 fix: change the config file when deploying apisix in k8s #2182 This branch includes the following new

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-08 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r483905871 ## File path: rockspec/apisix-master-0.rockspec ## @@ -52,6 +52,7 @@ dependencies = { "lua-resty-kafka = 0.07", "lua-resty-logger-socket =

[GitHub] [apisix] y934317258 opened a new issue #2184: bug: limit-conn,After limiting concurrency for the first time, all subsequent requests are blocked

2020-09-08 Thread GitBox
y934317258 opened a new issue #2184: URL: https://github.com/apache/apisix/issues/2184 ### Issue description limit-conn,After limiting concurrency for the first time, all subsequent requests are blocked ### Environment * apisix version (cmd: `apisix version`):master *

[GitHub] [apisix] gxthrj commented on issue #2182: bug: error in the pod when deploying apisix-gw-config-cm.yaml in kubernetes

2020-09-08 Thread GitBox
gxthrj commented on issue #2182: URL: https://github.com/apache/apisix/issues/2182#issuecomment-688703913 > This is config.yaml file content: > > ```yaml > apiVersion: v1 > data: > config.yaml: | > kind: ConfigMap > metadata: > name: apisix-gw-config.yaml >

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #433: Feat: dashboard support route group

2020-09-08 Thread GitBox
liuxiran edited a comment on pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-688669129 this pr will fix: https://github.com/apache/apisix-dashboard/issues/452 @juzhiyuan This is an

[GitHub] [apisix] Yiyiyimu commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-08 Thread GitBox
Yiyiyimu commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-688697918 > I added this PR to 2.0 milestone, which due by September 18, 2020 Sure. It just I need some help in the current problem, which discussed in

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-08 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r477341702 ## File path: apisix/core/etcd.lua ## @@ -44,24 +73,143 @@ end _M.new = new +local function kvs2node(kvs) +local node = {} +node.key =

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #454: add tools to check ASF headers in code files.

2020-09-08 Thread GitBox
moonming commented on a change in pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r484720845 ## File path: Makefile ## @@ -0,0 +1,8 @@ +### license-check:Check apisix-dashboard source code for Apache License +.PHONY: license-check

[GitHub] [apisix-dashboard] Rapiz1 opened a new pull request #455: ci: Add lint

2020-09-08 Thread GitBox
Rapiz1 opened a new pull request #455: URL: https://github.com/apache/apisix-dashboard/pull/455 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix] maxluo1992 commented on issue #2182: bug: error in the pod when deploying apisix-gw-config-cm.yaml in kubernetes

2020-09-08 Thread GitBox
maxluo1992 commented on issue #2182: URL: https://github.com/apache/apisix/issues/2182#issuecomment-688673638 Ok, I will have a try and give you the feedback if possible. This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] liuxiran commented on pull request #433: Feat: dashboard support route group

2020-09-08 Thread GitBox
liuxiran commented on pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-688669129 this pr will fix: https://github.com/apache/apisix-dashboard/issues/452 This is an automated message

[GitHub] [apisix-dashboard] liuxiran commented on issue #452: An error is reported when creating the second route:RouteGroup name is duplicate

2020-09-08 Thread GitBox
liuxiran commented on issue #452: URL: https://github.com/apache/apisix-dashboard/issues/452#issuecomment-688666125 @y934317258 yes this error is due to the front ends corresponding to the routeGroup are still not merged when creating a route, a group without a name is created by

[GitHub] [apisix-dashboard] y934317258 commented on issue #452: An error is reported when creating the second route:RouteGroup name is duplicate

2020-09-08 Thread GitBox
y934317258 commented on issue #452: URL: https://github.com/apache/apisix-dashboard/issues/452#issuecomment-688657124 ![J86ZQR1`7F4(VG` 085D @L](https://user-images.githubusercontent.com/68832358/92442453-7ec58c00-f1e2-11ea-903a-40281f4229fc.jpg) Maybe it's the problem here. I'm not

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-08 Thread GitBox
juzhiyuan commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-688654569 @moonming @ShiningRush Could you please set a milestone here? cc @bzp2010 This is an automated

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #452: An error is reported when creating the second route:RouteGroup name is duplicate

2020-09-08 Thread GitBox
juzhiyuan commented on issue #452: URL: https://github.com/apache/apisix-dashboard/issues/452#issuecomment-688653270 @liuxiran Please take a look, thanks! This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] moonming closed issue #2183: bug: Can't see the route created using api in dashboard

2020-09-08 Thread GitBox
moonming closed issue #2183: URL: https://github.com/apache/apisix/issues/2183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] moonming commented on issue #2183: bug: Can't see the route created using api in dashboard

2020-09-08 Thread GitBox
moonming commented on issue #2183: URL: https://github.com/apache/apisix/issues/2183#issuecomment-688648153 Thanks for your understanding This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] tokers commented on issue #2170: feature(core): implement `core.sleep`

2020-09-08 Thread GitBox
tokers commented on issue #2170: URL: https://github.com/apache/apisix/issues/2170#issuecomment-688643231 Maybe a readable name is also important to imply the difference, like `interrupted_sleep` This is an automated

[GitHub] [apisix] chenyicai commented on issue #2183: bug: Can't see the route created using api in dashboard

2020-09-08 Thread GitBox
chenyicai commented on issue #2183: URL: https://github.com/apache/apisix/issues/2183#issuecomment-688642810 ok,thank you very much, i will use English next time! This is an automated message from the Apache Git Service. To

[GitHub] [apisix] tokers commented on issue #2182: bug: error in the pod when deploying apisix-gw-config-cm.yaml in kubernetes

2020-09-08 Thread GitBox
tokers commented on issue #2182: URL: https://github.com/apache/apisix/issues/2182#issuecomment-688642285 @maxluo1992 You should put the whole configuration file data into the `data` field of ConfigMap object, rather than add some fields like `dns_resolver` in ConfigMap own's spec.