[GitHub] [apisix] liuximu opened a new issue #2198: request help: How to deploy apisix

2020-09-09 Thread GitBox
liuximu opened a new issue #2198: URL: https://github.com/apache/apisix/issues/2198 ### Issue description 求官方确认一下: apache/apisix 包括两个职责,有两种部署方式: 1 被放到线上部署成API-Gateway集群,关闭api相关的接口,作为数据面 2 被放到内网部署成管理平台,开源被 apisix-dashboard 调用完成配置的变更 是这样子吗?谢谢 -

[GitHub] [apisix] y934317258 opened a new issue #2199: request help: The parameter meaning of JWT auth plug-in. What are the functions of parameter configuration in consumer and routing

2020-09-09 Thread GitBox
y934317258 opened a new issue #2199: URL: https://github.com/apache/apisix/issues/2199 ### Issue description The parameter meaning of JWT auth plug-in. What are the functions of parameter configuration in consumer and routing ![image](https://user-images.githubusercontent.com/6883235

[GitHub] [apisix] mddmzl commented on pull request #2148: fix: serverless plugin not work in header_filter phase

2020-09-09 Thread GitBox
mddmzl commented on pull request #2148: URL: https://github.com/apache/apisix/pull/2148#issuecomment-689356311 @moonming It's OK now. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] masahills commented on issue #2165: request help: multi-tenancy/multi-workspace feature

2020-09-09 Thread GitBox
masahills commented on issue #2165: URL: https://github.com/apache/apisix/issues/2165#issuecomment-689367235 We have hundreds of internal API endpoints which go through a cluster of API gateway servers. It is a typical micro-service architecture and each API is developed and owned by diffe

[GitHub] [apisix] y934317258 commented on issue #2197: request help: How to ensure the security of token without password

2020-09-09 Thread GitBox
y934317258 commented on issue #2197: URL: https://github.com/apache/apisix/issues/2197#issuecomment-689367199 I don't understand the meaning of this plug-in. In my opinion, it is extremely unsafe. Can you introduce its usage scenarios? -

[GitHub] [apisix] y934317258 commented on issue #2197: request help: How to ensure the security of token without password

2020-09-09 Thread GitBox
y934317258 commented on issue #2197: URL: https://github.com/apache/apisix/issues/2197#issuecomment-689370108 @membphis This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] moonming merged pull request #2148: fix: serverless plugin not work in header_filter phase

2020-09-09 Thread GitBox
moonming merged pull request #2148: URL: https://github.com/apache/apisix/pull/2148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming commented on pull request #2148: fix: serverless plugin not work in header_filter phase

2020-09-09 Thread GitBox
moonming commented on pull request #2148: URL: https://github.com/apache/apisix/pull/2148#issuecomment-689404297 @mddmzl thx, merged This is an automated message from the Apache Git Service. To respond to the message, please

[apisix] branch master updated: bugfix: serverless plugin not work in header_filter phase (#2148)

2020-09-09 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 47d39e7 bugfix: serverless plugin not work in

[GitHub] [apisix-dashboard] moonming merged pull request #454: add tools to check ASF headers in code files.

2020-09-09 Thread GitBox
moonming merged pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix-dashboard] branch master updated (b93388f -> 54f7a98)

2020-09-09 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from b93388f feat: preview pluginchart (#456) add 54f7a98 add tools to check ASF headers in code files.

[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191

2020-09-09 Thread GitBox
moonming commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-689408350 ``` apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused ``` please remove `sample` variable, thx ---

[GitHub] [apisix] moonming removed a comment on pull request #2193: fixed #2191

2020-09-09 Thread GitBox
moonming removed a comment on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-689408350 ``` apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused ``` please remove `sample` variable, thx ---

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
juzhiyuan commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689432449 @liuxiran CI failed, please take a look This is an automated message from the Apache Git Service. To re

[GitHub] [apisix-dashboard] liuxiran commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
liuxiran commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689433677 > @liuxiran CI failed, please take a look fixing :) This is an automated message from the Apache

[GitHub] [apisix-dashboard] tengzhinei opened a new issue #458: bug: When creating a route, host should not be required

2020-09-09 Thread GitBox
tengzhinei opened a new issue #458: URL: https://github.com/apache/apisix-dashboard/issues/458 ### Issue description When creating a route, host should not be required. We are a sass project. Thousands of domain names point to the same system. Now, we are using Kong. kong is not r

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #458: bug: When creating a route, host should not be required

2020-09-09 Thread GitBox
juzhiyuan commented on issue #458: URL: https://github.com/apache/apisix-dashboard/issues/458#issuecomment-689436642 cc @membphis @nic-chen so it's not needed? 🤔 This is an automated message from the Apache Git Service. To

[GitHub] [apisix] dickens7 commented on pull request #2193: fixed #2191

2020-09-09 Thread GitBox
dickens7 commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-689441251 I think it’s not a good idea to remove the sample variable, I moved the sample decision logic to create_tracer function. Keep upstream decided to sample the request, we do too.

[GitHub] [apisix-dashboard] y934317258 opened a new issue #459: In the routing plug-in configuration interface, click response rewrite to display 500

2020-09-09 Thread GitBox
y934317258 opened a new issue #459: URL: https://github.com/apache/apisix-dashboard/issues/459 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirements - [ ] Feature or performance

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #460: feat: support ungroup in manager api

2020-09-09 Thread GitBox
liuxiran opened a new pull request #460: URL: https://github.com/apache/apisix-dashboard/pull/460 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] liuxiran commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
liuxiran commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689467089 the reason for ci failed is the same with https://github.com/apache/apisix-dashboard/issues/452#issuecomment-688666125 , we updated the logic of routeGroup. this pr is d

[GitHub] [apisix] spacewander commented on issue #2194: bug: error when route not found

2020-09-09 Thread GitBox
spacewander commented on issue #2194: URL: https://github.com/apache/apisix/issues/2194#issuecomment-689467983 Duplicate of #2006 ? This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
juzhiyuan commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689468983 @liuxiran ok, so just waiting for others' review :DD This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #433: Feat: dashboard support route group

2020-09-09 Thread GitBox
liuxiran commented on a change in pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r485506244 ## File path: src/pages/RouteGroup/components/Step1.tsx ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-dashboard] liuxiran commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
liuxiran commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689477596 > @liuxiran ok, so just waiting for others' review :DD thanks for your time~ This is an automated

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #433: Feat: dashboard support route group

2020-09-09 Thread GitBox
juzhiyuan commented on pull request #433: URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-689477819 cc @LiteSun This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-docker] hityc2019 opened a new issue #74: can not access the 9080 port

2020-09-09 Thread GitBox
hityc2019 opened a new issue #74: URL: https://github.com/apache/apisix-docker/issues/74 ``` # docker-compose -p docker-apisix up -d Creating network "docker-apisix_apisix" with driver "bridge" Creating docker-apisix_etcd_1 ... done Creating docker-apisix_web1_1 ... done Creat

[GitHub] [apisix] membphis commented on a change in pull request #2101: feature: customed config.yaml when apisix start

2020-09-09 Thread GitBox
membphis commented on a change in pull request #2101: URL: https://github.com/apache/apisix/pull/2101#discussion_r485675296 ## File path: bin/apisix ## @@ -940,6 +940,22 @@ function _M.start(...) end end +local argparse = require "argparse" +local parser

[GitHub] [apisix-docker] membphis commented on issue #74: can not access the 9080 port

2020-09-09 Thread GitBox
membphis commented on issue #74: URL: https://github.com/apache/apisix-docker/issues/74#issuecomment-689617716 @gxthrj ping This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] membphis commented on issue #2169: feature: how use apisix send log to aliyun sls

2020-09-09 Thread GitBox
membphis commented on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-689621640 I think we can send the log to aliyun sls is an easy way, and that is a stable way. use `lua-resty-logger-socket` is a better way. ---

[GitHub] [apisix] membphis commented on issue #2169: feature: how use apisix send log to aliyun sls

2020-09-09 Thread GitBox
membphis commented on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-689623663 another way, set `syslog` server in `conf/config.yaml` is another good method This is an automated message from the A

[apisix] branch juzhiyuan-patch-1 created (now 9e5b3b1)

2020-09-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 9e5b3b1 Update health-check.md This branch includes the following new commits: new 9e5b3b1 Upd

[apisix] 01/01: Update health-check.md

2020-09-09 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git commit 9e5b3b141ff25d1157c954c022fdc212a707b2c0 Author: 琚致远 AuthorDate: Thu Sep 10 00:07:51 2020 +0800 Updat

[GitHub] [apisix] juzhiyuan opened a new pull request #2200: fix typo Update health-check.md

2020-09-09 Thread GitBox
juzhiyuan opened a new pull request #2200: URL: https://github.com/apache/apisix/pull/2200 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have y

[GitHub] [apisix] swayamraina commented on issue #2196: feature(kafka-logger): need to read the request body data if it was cached to local file

2020-09-09 Thread GitBox
swayamraina commented on issue #2196: URL: https://github.com/apache/apisix/issues/2196#issuecomment-689745070 Hi @membphis I would like to pick this up. Can you describe what exactly is required here? This is an automate

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #454: add tools to check ASF headers in code files.

2020-09-09 Thread GitBox
moonming commented on a change in pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r485994194 ## File path: .actions/ASF-Release.cfg ## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +#

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #454: add tools to check ASF headers in code files.

2020-09-09 Thread GitBox
moonming commented on a change in pull request #454: URL: https://github.com/apache/apisix-dashboard/pull/454#discussion_r485994194 ## File path: .actions/ASF-Release.cfg ## @@ -0,0 +1,105 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +#

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
nic-chen commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r486000136 ## File path: api/route/route_test.go ## @@ -0,0 +1,51 @@ +package route + +import ( + "github.com/apisix/manager-api/conf" + "github.

[GitHub] [apisix-dashboard] nic-chen commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
nic-chen commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689904687 api ci not pass This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix-dashboard] nic-chen commented on pull request #460: feat: support ungroup in manager api

2020-09-09 Thread GitBox
nic-chen commented on pull request #460: URL: https://github.com/apache/apisix-dashboard/pull/460#issuecomment-689920798 need test cases for changes. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
juzhiyuan commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689924915 > the reason for ci failed is the same with [#452 (comment)](https://github.com/apache/apisix-dashboard/issues/452#issuecomment-688666125) , we updated the logic of rou

[GitHub] [apisix] y934317258 opened a new issue #2201: request help: use core.log Output log, output to which file

2020-09-09 Thread GitBox
y934317258 opened a new issue #2201: URL: https://github.com/apache/apisix/issues/2201 ### Issue description use core.log Output log, output to which file ### Environment * apisix version (cmd: `apisix version`): * OS: ---

[GitHub] [apisix] membphis commented on a change in pull request #2163: improve: cache parsed SSL certs and pkeys

2020-09-09 Thread GitBox
membphis commented on a change in pull request #2163: URL: https://github.com/apache/apisix/pull/2163#discussion_r486031725 ## File path: apisix/http/router/radixtree_sni.lua ## @@ -30,14 +30,53 @@ local ngx_decode_base64 = ngx.decode_base64 local ssl_certificates local radix

[GitHub] [apisix] linsir commented on issue #2201: request help: use core.log Output log, output to which file

2020-09-09 Thread GitBox
linsir commented on issue #2201: URL: https://github.com/apache/apisix/issues/2201#issuecomment-689943545 `logs/error.log` This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] tokers commented on pull request #2163: improve: cache parsed SSL certs and pkeys

2020-09-09 Thread GitBox
tokers commented on pull request #2163: URL: https://github.com/apache/apisix/pull/2163#issuecomment-689945812 @membphis It's really a problem if the number of certs is large, I will refactor it with the LRU cache. This is a

[GitHub] [apisix] membphis opened a new issue #2202: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`

2020-09-09 Thread GitBox
membphis opened a new issue #2202: URL: https://github.com/apache/apisix/issues/2202 Sometimes users create an empty service (managed through API). When needed later, add specific attributes, such as plug-ins, upstream, etc. just remove this limitation and add test case to chec

[GitHub] [apisix] y934317258 commented on issue #2201: request help: use core.log Output log, output to which file

2020-09-09 Thread GitBox
y934317258 commented on issue #2201: URL: https://github.com/apache/apisix/issues/2201#issuecomment-689950811 > `logs/error.log` No matter what level of log, is it output to error.log ? This is an automated message from th

[GitHub] [apisix-dashboard] Firstsawyou opened a new pull request #461: Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file.

2020-09-09 Thread GitBox
Firstsawyou opened a new pull request #461: URL: https://github.com/apache/apisix-dashboard/pull/461 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Rela

[GitHub] [apisix] Yiyiyimu commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-09 Thread GitBox
Yiyiyimu commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-689952623 The newly imported lib [base64](https://github.com/iskolbin/lbase64) holds MIT License and only 200 lines. So I think we could directly use it.

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-09 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r486040363 ## File path: rockspec/apisix-master-0.rockspec ## @@ -52,6 +52,7 @@ dependencies = { "lua-resty-kafka = 0.07", "lua-resty-logger-socket = 2.0-0

[GitHub] [apisix] Yiyiyimu edited a comment on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-09 Thread GitBox
Yiyiyimu edited a comment on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-689952623 The newly imported lib [base64](https://github.com/iskolbin/lbase64) is used in `init_etcd` step to encode k/v send to etcd. Lib `base64` holds MIT License and only 200 l

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2101: feature: customed config.yaml when apisix start

2020-09-09 Thread GitBox
Yiyiyimu commented on a change in pull request #2101: URL: https://github.com/apache/apisix/pull/2101#discussion_r484328359 ## File path: bin/apisix ## @@ -940,6 +940,22 @@ function _M.start(...) end end +local argparse = require "argparse" +local parser

[GitHub] [apisix] dickens7 opened a new issue #2203: Is there a version release plan?

2020-09-09 Thread GitBox
dickens7 opened a new issue #2203: URL: https://github.com/apache/apisix/issues/2203 Is there a detailed version plan and release plan? This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix] idbeta opened a new issue #2204: bug: “prevNode” should not return after setting a route

2020-09-09 Thread GitBox
idbeta opened a new issue #2204: URL: https://github.com/apache/apisix/issues/2204 ### Issue description set twice route in the same uri,the second response should not include “preNode” curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #462: chore: remove unnecessary license file

2020-09-09 Thread GitBox
nic-chen opened a new pull request #462: URL: https://github.com/apache/apisix-dashboard/pull/462 Please answer these questions before submitting a pull request - Why submit this pull request? remove unnecessary license file for lib `dag-to-lua` which just is a dependency not

[GitHub] [apisix] Yiyiyimu opened a new pull request #2205: doc: add option `include_req_body`

2020-09-09 Thread GitBox
Yiyiyimu opened a new pull request #2205: URL: https://github.com/apache/apisix/pull/2205 ### What this PR does / why we need it: fix #2195 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] H

[GitHub] [apisix-dashboard] moonming commented on a change in pull request #462: chore: remove unnecessary license file

2020-09-09 Thread GitBox
moonming commented on a change in pull request #462: URL: https://github.com/apache/apisix-dashboard/pull/462#discussion_r486059913 ## File path: LICENSE ## @@ -224,5 +224,5 @@ Apache 2.0 licenses The following components are provided under the Apache 2.0 License. See project

[GitHub] [apisix] Yiyiyimu commented on pull request #2205: doc: add option `include_req_body`

2020-09-09 Thread GitBox
Yiyiyimu commented on pull request #2205: URL: https://github.com/apache/apisix/pull/2205#issuecomment-689978415 Chinese doc of plugins format needs to be unified。 This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] nic-chen commented on pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
nic-chen commented on pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#issuecomment-689980972 > > the reason for ci failed is the same with [#452 (comment)](https://github.com/apache/apisix-dashboard/issues/452#issuecomment-688666125) , we updated the logic of ro

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r486072028 ## File path: api/route/route.go ## @@ -34,11 +34,100 @@ func AppendRoute(r *gin.Engine) *gin.Engine { r.GET("/apisix/admin/routes/:rid",

[GitHub] [apisix] Firstsawyou commented on issue #2202: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`

2020-09-09 Thread GitBox
Firstsawyou commented on issue #2202: URL: https://github.com/apache/apisix/issues/2202#issuecomment-689991034 Assigned to me. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-09 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r486077100 ## File path: api/script/db/schema.sql ## @@ -18,7 +18,7 @@ CREATE TABLE `routes` ( `update_time` bigint(20), `route_group_id` varchar(64) N

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #462: chore: remove unnecessary license file

2020-09-09 Thread GitBox
nic-chen commented on a change in pull request #462: URL: https://github.com/apache/apisix-dashboard/pull/462#discussion_r486080122 ## File path: LICENSE ## @@ -224,5 +224,5 @@ Apache 2.0 licenses The following components are provided under the Apache 2.0 License. See project

[GitHub] [apisix] tokers edited a comment on pull request #2163: improve: cache parsed SSL certs and pkeys

2020-09-09 Thread GitBox
tokers edited a comment on pull request #2163: URL: https://github.com/apache/apisix/pull/2163#issuecomment-690011030 @membphis changed. This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] tokers commented on pull request #2163: improve: cache parsed SSL certs and pkeys

2020-09-09 Thread GitBox
tokers commented on pull request #2163: URL: https://github.com/apache/apisix/pull/2163#issuecomment-690011030 @membphis way changed. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] ChelinTsien closed pull request #1960: add AK/SK auth plugin

2020-09-09 Thread GitBox
ChelinTsien closed pull request #1960: URL: https://github.com/apache/apisix/pull/1960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] membphis commented on a change in pull request #2205: doc: add option `include_req_body`

2020-09-09 Thread GitBox
membphis commented on a change in pull request #2205: URL: https://github.com/apache/apisix/pull/2205#discussion_r486103749 ## File path: doc/plugins/syslog.md ## @@ -47,6 +47,7 @@ This will provide the ability to send Log data requests as JSON objects. |max_retry_times|optio

[GitHub] [apisix] membphis commented on a change in pull request #2205: doc: add option `include_req_body`

2020-09-09 Thread GitBox
membphis commented on a change in pull request #2205: URL: https://github.com/apache/apisix/pull/2205#discussion_r486104143 ## File path: doc/zh-cn/plugins/http-logger.md ## @@ -46,6 +46,7 @@ | buffer_duration |可选的|必须先处理批次中最旧条目的最长期限(以秒为单位),默认值为 5| | max_retry_count |可选的|从处理管道