[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 The nginx timer is out of request life cycle , you can get it in the log event of plugin, and other way the log plugin is already support get request body, you can just

[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 The nginx timer is out of request life cycle , you can get it in the log event of plugin, and other way the log plugin is already support get request body, you can just

[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 The nginx timer is out of request life cycle , you can get it in the log event of plugin, and other way the log plugin is already support get request body, you can just

[GitHub] [apisix] gy09535 commented on issue #2220: How to get the parameters of the post request in the log plugins

gy09535 commented on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 The nginx timer is out of request life cycle , you can get it in the log event of plugin, and other way the log plugin is already support get request body, you can just send an

[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 The nginx timer is out of request life cycle , you can get it in the log event of plugin, and other way the log plugin is already support get request body, you can just

[GitHub] [apisix] haifeng9414 commented on pull request #2218: bugfix: load yaml config in privileged agent

haifeng9414 commented on pull request #2218: URL: https://github.com/apache/apisix/pull/2218#issuecomment-691407782 Privileged processes do not process user requests, I think there is no need to create a timer in init_worker phase.

[GitHub] [apisix] dickens7 commented on a change in pull request #2174: optimize set nginx conf env

dickens7 commented on a change in pull request #2174: URL: https://github.com/apache/apisix/pull/2174#discussion_r487361859 ## File path: conf/config-default.yaml ## @@ -115,6 +115,8 @@ nginx_config: # config for render the template to genarate n

[GitHub] [apisix] dickens7 commented on a change in pull request #2174: optimize set nginx conf env

dickens7 commented on a change in pull request #2174: URL: https://github.com/apache/apisix/pull/2174#discussion_r487361283 ## File path: conf/config-default.yaml ## @@ -115,6 +115,8 @@ nginx_config: # config for render the template to genarate n

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream

juzhiyuan edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691363046 Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does. So

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691363046 Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does.

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691341782 Good catch, @membphis, could you please describe this logic? This is an automated message from the Apache

[GitHub] [apisix] swayamraina opened a new pull request #2221: send file contents and not file name

swayamraina opened a new pull request #2221: URL: https://github.com/apache/apisix/pull/2221 ### What this PR does / why we need it: implements https://github.com/apache/apisix/issues/2196 This is an automated

[GitHub] [apisix] swayamraina commented on issue #2196: feature(kafka-logger): need to read the request body data if it was cached to local file

swayamraina commented on issue #2196: URL: https://github.com/apache/apisix/issues/2196#issuecomment-691269807 @membphis I got what exactly is required here and will raise a PR. I had one question though, why would request body data get cached to a local file and be absent in the

[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream

liuxiran edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 > How about this design? Agree with ui design  , I have a question about interaction logic： refer to the [upstream health-check

[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream

liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828 > How about this design? Agree with ui design  , I have a question about interaction logic： refer to the [upstream health-check

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691042697 

[GitHub] [apisix-dashboard] juzhiyuan closed issue #212: Feature: Service module

juzhiyuan closed issue #212: URL: https://github.com/apache/apisix-dashboard/issues/212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #212: Feature: Service module

juzhiyuan commented on issue #212: URL: https://github.com/apache/apisix-dashboard/issues/212#issuecomment-691029074 related issue #471 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #471: Proposal: Service

juzhiyuan commented on issue #471: URL: https://github.com/apache/apisix-dashboard/issues/471#issuecomment-691028684 @membphis Please take a look once more, thanks! This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #471: Proposal: Service

juzhiyuan opened a new issue #471: URL: https://github.com/apache/apisix-dashboard/issues/471  # Why Service is aimed to pre config the upstream and plugins and would be

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r486966337 ## File path: bin/apisix ## @@ -637,6 +637,45 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r486965508 ## File path: bin/apisix ## @@ -637,6 +637,45 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check

[GitHub] [apisix] membphis commented on pull request #2209: draft: allow empty `service` object, it does not contain any `upstream` and `plugin`.

membphis commented on pull request #2209: URL: https://github.com/apache/apisix/pull/2209#issuecomment-691020500 test case: success to create an empty service This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream

juzhiyuan edited a comment on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 How about this design? ping @membphis @liuxiran This is an automated message from the

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #194: bug: dashboard does not support healcheck config

juzhiyuan commented on issue #194: URL: https://github.com/apache/apisix-dashboard/issues/194#issuecomment-691016672 related #470 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] juzhiyuan closed issue #194: bug: dashboard does not support healcheck config

juzhiyuan closed issue #194: URL: https://github.com/apache/apisix-dashboard/issues/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431 ping @membphis @liuxiran This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #470: Proposal: Health Checks for Upstream

juzhiyuan opened a new issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470  ## Why Doc: https://github.com/apache/apisix/blob/master/doc/health-check.md

[GitHub] [apisix] zwwhub commented on issue #2220: How to get the parameters of the post request in the log plugins

zwwhub commented on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-690996936 When I tried to modify the plugin source code to get the parameters through method ngx.req.get_post_args(), an error was reported: API disabled in the context of ngx.timer

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #469: Feature: debug a route online

juzhiyuan commented on issue #469: URL: https://github.com/apache/apisix-dashboard/issues/469#issuecomment-690996064 ping @membphis @moonming This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #448: Proposal: improve the PluginModule

juzhiyuan edited a comment on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-690994976 @bzp2010 @LiteSun @liuxiran @moonming @membphis Any ideas about this proposal? This is an

[GitHub] [apisix-dashboard] juzhiyuan closed issue #463: Custom plug-in profiles and links

juzhiyuan closed issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #463: Custom plug-in profiles and links

juzhiyuan commented on issue #463: URL: https://github.com/apache/apisix-dashboard/issues/463#issuecomment-690995547 related issue #448 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #448: Proposal: improve the PluginModule

juzhiyuan commented on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-690994976 @bzp2010 @LiteSun @liuxiran Any ideas about this proposal? This is an automated message from the Apache

[GitHub] [apisix] zwwhub opened a new issue #2220: How to get the parameters of the post request in the log plugins

zwwhub opened a new issue #2220: URL: https://github.com/apache/apisix/issues/2220 It seems that the input parameters of the post request are not recorded in tcp-logger and http-logger This is an automated message from the

[GitHub] [apisix] moonming commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

moonming commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486902889 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key

[GitHub] [apisix] membphis closed pull request #2219: ONLY FOR TEST, DO NOT MERGE ME

membphis closed pull request #2219: URL: https://github.com/apache/apisix/pull/2219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

membphis commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486898710 ## File path: t/node/route-delete.t ## @@ -0,0 +1,93 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis opened a new pull request #2219: ONLY FOR TEST, DO NOT MERGE ME

membphis opened a new pull request #2219: URL: https://github.com/apache/apisix/pull/2219 ### What this PR does / why we need it: V1.2 bug config etcd sync 100 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new

[GitHub] [apisix] membphis commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

membphis commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486880701 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key

[GitHub] [apisix] membphis commented on a change in pull request #2168: bugfix: clear all cached object when got `delete` action, and removing stale boolean data in table `self.values` with a safer wa

membphis commented on a change in pull request #2168: URL: https://github.com/apache/apisix/pull/2168#discussion_r486876889 ## File path: apisix/core/config_etcd.lua ## @@ -314,36 +316,44 @@ local function sync_data(self) res.value.id = key

[GitHub] [apisix-dashboard] liuxiran opened a new issue #469: Feature: debug a route online

liuxiran opened a new issue #469: URL: https://github.com/apache/apisix-dashboard/issues/469 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirements - [ ] Feature or performance

[GitHub] [apisix] spacewander opened a new pull request #2218: bugfix: load yaml config in privileged agent

spacewander opened a new pull request #2218: URL: https://github.com/apache/apisix/pull/2218 Fix #2186. ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feature: how use apisix send log to aliyun sls

gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 > welcome PR，then the community can share this feature. ^_^ I use cosocket and processor to send logs to sls , users can define different routes or services plugins to

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feature: how use apisix send log to aliyun sls

gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 > welcome PR，then the community can share this feature. ^_^ I use cosocket and processor to send logs to sls , users can define different routes or services plugins to

[GitHub] [apisix] juzhiyuan closed issue #997: doc(FAQ): Why is the ID displayed on the dashboard not the original value of etcd?

juzhiyuan closed issue #997: URL: https://github.com/apache/apisix/issues/997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] moonming commented on issue #434: Requirements for refactoring the Dashboard with Manager API

moonming commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690929281 LGTM Thanks, Ming Wen Twitter: _WenMing 琚致远 于2020年9月11日周五 下午3:24写道： > got it ping @moonming > > — > You

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #434: Requirements for refactoring the Dashboard with Manager API

juzhiyuan commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-690924953 got it ping @moonming This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] spacewander commented on issue #2186: bug: The log keeps printing "wait for more time, context: ngx.timer"

spacewander commented on issue #2186: URL: https://github.com/apache/apisix/issues/2186#issuecomment-690923235 @membphis This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] spacewander opened a new issue #2217: bug: kubernetes/config.sh is broken?

spacewander opened a new issue #2217: URL: https://github.com/apache/apisix/issues/2217 ### Issue description It seems that `kubernetes/config.sh` doesn't work anymore as config.yaml is empty now. ### Environment * apisix version (cmd: `apisix version`): * OS:

[GitHub] [apisix] spacewander commented on pull request #1979: bugfix: empty `allow_admin` means that any IP is allowed to access Ad…

spacewander commented on pull request #1979: URL: https://github.com/apache/apisix/pull/1979#issuecomment-690913327 Need to update apisix_cli_test.sh before merge. This is an automated message from the Apache Git Service.

[GitHub] [apisix] tokers opened a new pull request #2216: improve: use optimistic locking to avoid concurrency problem in admin…

tokers opened a new pull request #2216: URL: https://github.com/apache/apisix/pull/2216 #1750 # What this PR does / why we need it: There is a potential concurrency problem in all admin PATCH APIs when two patch requests come in simultaneously, in such case, the patched

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feature: how use apisix send log to aliyun sls

gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 > welcome PR，then the community can share this feature. ^_^ I use cosocket and processor to send logs to sls , you can define different routes or services plugins to