[GitHub] [apisix] membphis commented on issue #2215: Used TscanCode scan the lua code,it report two code defects

2020-09-13 Thread GitBox
membphis commented on issue #2215: URL: https://github.com/apache/apisix/issues/2215#issuecomment-691855653 > .../t/lib/test_admin.lua: Code line 223,undeclared Variable [core] is used. https://github.com/apache/apisix/blob/master/t/lib/test_admin.lua#L222-L225 it should be def

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #448: Proposal: improve the PluginModule

2020-09-13 Thread GitBox
juzhiyuan commented on issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448#issuecomment-691853052 close #459 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] powermanlc commented on issue #2213: can router support uri+params style

2020-09-13 Thread GitBox
powermanlc commented on issue #2213: URL: https://github.com/apache/apisix/issues/2213#issuecomment-691851163 > You can route via Nginx builtin variable: https://github.com/apache/apisix/blob/master/doc/router-radixtree.md#how-to-filter-route-by-nginx-builtin-variable thank you. --

[GitHub] [apisix] moonming closed issue #2203: Is there a version release plan?

2020-09-13 Thread GitBox
moonming closed issue #2203: URL: https://github.com/apache/apisix/issues/2203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] moonming closed issue #2213: can router support uri+params style

2020-09-13 Thread GitBox
moonming closed issue #2213: URL: https://github.com/apache/apisix/issues/2213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] moonming commented on issue #2223: chore: the title of the `basic-auth` JSONSchema is wrong.

2020-09-13 Thread GitBox
moonming commented on issue #2223: URL: https://github.com/apache/apisix/issues/2223#issuecomment-691849755 here is the link: https://github.com/apache/apisix/blob/master/apisix/plugins/basic-auth.lua#L31 This is an automate

[GitHub] [apisix] membphis opened a new issue #2223: chore: the title of the `basic-auth` JSONSchema is wrong.

2020-09-13 Thread GitBox
membphis opened a new issue #2223: URL: https://github.com/apache/apisix/issues/2223 That is the correct one: ```lua local schema = { type = "object", oneOf = { { title = "work with consumer object", properties = {

[apisix] branch master updated (98da870 -> 4b756ec)

2020-09-13 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 98da870 doc: fixed typo in `health-check.md` (#2200) add 4b756ec doc: fix formatting (#2210) No new revisio

[apisix] branch master updated (98da870 -> 4b756ec)

2020-09-13 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 98da870 doc: fixed typo in `health-check.md` (#2200) add 4b756ec doc: fix formatting (#2210) No new revisio

[GitHub] [apisix] membphis merged pull request #2210: doc: fix format

2020-09-13 Thread GitBox
membphis merged pull request #2210: URL: https://github.com/apache/apisix/pull/2210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-control-plane] Firstsawyou commented on issue #25: CI: add tools to check ASF headers in code files

2020-09-13 Thread GitBox
Firstsawyou commented on issue #25: URL: https://github.com/apache/apisix-control-plane/issues/25#issuecomment-691842127 Let me do it. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix-control-plane] Firstsawyou opened a new issue #25: CI: add tools to check ASF headers in code files

2020-09-13 Thread GitBox
Firstsawyou opened a new issue #25: URL: https://github.com/apache/apisix-control-plane/issues/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-dashboard] Firstsawyou closed pull request #467: draft: License CI test

2020-09-13 Thread GitBox
Firstsawyou closed pull request #467: URL: https://github.com/apache/apisix-dashboard/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-13 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487669728 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,286 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] dickens7 commented on pull request #2193: fixed #2191

2020-09-13 Thread GitBox
dickens7 commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-691832972 > thx, it will be better if you can add test cases. I'm sorry to be a little busy these few days, maybe a few days later -

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-13 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487665633 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,291 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191

2020-09-13 Thread GitBox
moonming commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-691795888 > thx, it will be better if you can add test cases. ping @dickens7 This is an automated message from the

[GitHub] [apisix] spacewander commented on issue #2215: Used TscanCode scan the lua code,it report two code defects

2020-09-13 Thread GitBox
spacewander commented on issue #2215: URL: https://github.com/apache/apisix/issues/2215#issuecomment-691781542 Which version of apisix the TscanCode works on? The lines don't match the master branch of apisix. This is an aut

[GitHub] [apisix] spacewander commented on issue #2217: bug: kubernetes/config.sh is broken?

2020-09-13 Thread GitBox
spacewander commented on issue #2217: URL: https://github.com/apache/apisix/issues/2217#issuecomment-691781059 Dup: #2182 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feat: how use apisix send log to aliyun sls

2020-09-13 Thread GitBox
gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 > welcome PR,then the community can share this feature. ^_^ I use cosocket and processor to send logs to sls , users can define different routes or services plugins to

[GitHub] [apisix] spacewander closed issue #2217: bug: kubernetes/config.sh is broken?

2020-09-13 Thread GitBox
spacewander closed issue #2217: URL: https://github.com/apache/apisix/issues/2217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander commented on a change in pull request #2185: fix: change the config file when deploying apisix in k8s #2182

2020-09-13 Thread GitBox
spacewander commented on a change in pull request #2185: URL: https://github.com/apache/apisix/pull/2185#discussion_r487623501 ## File path: kubernetes/README.md ## @@ -57,11 +48,15 @@ etcd: Create configmap for apache apisix +you will change some config by use `apisi

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-13 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691772846 It's not a hurry :D because we could use Active Health Check and Passive Health Check independent, but we recommend enabling active health check when enabling passive healt

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-13 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487616802 ## File path: t/admin/services.t ## @@ -1085,3 +1085,50 @@ GET /t --- error_code: 400 --- no_error_log [error] + + + +=== TEST 31: set service(id: 1

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-13 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487616083 ## File path: t/admin/schema.t ## @@ -40,7 +40,7 @@ qr/"plugins":\{"type":"object"}/ --- request GET /apisix/admin/schema/service --- response_body

[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream

2020-09-13 Thread GitBox
liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691770513 > Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does. > > So we c

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feat: how use apisix send log to aliyun sls

2020-09-13 Thread GitBox
gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 > welcome PR,then the community can share this feature. ^_^ I use cosocket and processor to send logs to sls , users can define different routes or services plugins to

[GitHub] [apisix] gy09535 edited a comment on issue #2169: feat: how use apisix send log to aliyun sls

2020-09-13 Thread GitBox
gy09535 edited a comment on issue #2169: URL: https://github.com/apache/apisix/issues/2169#issuecomment-690824661 > welcome PR,then the community can share this feature. ^_^ I use cosocket and processor to send logs to sls , users can define different routes or services plugins to

[GitHub] [apisix] zwwhub closed issue #2220: How to get the parameters of the post request in the log plugins

2020-09-13 Thread GitBox
zwwhub closed issue #2220: URL: https://github.com/apache/apisix/issues/2220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix] zwwhub commented on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-13 Thread GitBox
zwwhub commented on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691768345 i get it,thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] moonming commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-13 Thread GitBox
moonming commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487604738 ## File path: t/admin/schema.t ## @@ -40,7 +40,7 @@ qr/"plugins":\{"type":"object"}/ --- request GET /apisix/admin/schema/service --- response_body eva

[GitHub] [apisix] dotSlashLu opened a new pull request #2222: fix: return ok in kafka-logger

2020-09-13 Thread GitBox
dotSlashLu opened a new pull request #: URL: https://github.com/apache/apisix/pull/ ### What this PR does / why we need it: https://github.com/apache/apisix/blob/98da870976a4893a87b31300276c8c548dac14c0/apisix/utils/batch-processor.lua#L59 needs `ok` and `err`, but `func` in

[GitHub] [apisix] gy09535 edited a comment on issue #2220: How to get the parameters of the post request in the log plugins

2020-09-13 Thread GitBox
gy09535 edited a comment on issue #2220: URL: https://github.com/apache/apisix/issues/2220#issuecomment-691413887 The nginx timer is out of request life cycle , you can get it in the log event of plugin, and other way the log plugin is already support get request body, you can just set