[GitHub] [apisix] moonming commented on a change in pull request #2230: bug: removed default access token for Admin API

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2230: URL: https://github.com/apache/apisix/pull/2230#discussion_r488430805 ## File path: FAQ.md ## @@ -80,7 +80,7 @@ An example, `foo.com/product/index.html?id=204&page=2`, gray release based on `i here is the way: ```shell

[apisix-dashboard] branch feat-plugin updated (2329b1d -> b469b8b)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 2329b1d feat: added new plugin dependency add a253fd8 feat: omit shadow var add b469b8b

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream

2020-09-14 Thread GitBox
juzhiyuan commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-692505266 hi @liuxiran, would you like to implement this feature (if you have free time)? This is an automated messa

[GitHub] [apisix] membphis commented on pull request #2092: bug: removed default access token for Admin API.

2020-09-14 Thread GitBox
membphis commented on pull request #2092: URL: https://github.com/apache/apisix/pull/2092#issuecomment-692503939 @moonming I created a new PR https://github.com/apache/apisix/pull/2230, with the right git commit log. welcome to review the new PR. ---

[GitHub] [apisix-dashboard] juzhiyuan closed issue #162: Allow set filter_func in router configuration page

2020-09-14 Thread GitBox
juzhiyuan closed issue #162: URL: https://github.com/apache/apisix-dashboard/issues/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] membphis opened a new pull request #2230: bug: removed default access token for Admin API

2020-09-14 Thread GitBox
membphis opened a new pull request #2230: URL: https://github.com/apache/apisix/pull/2230 ### What this PR does / why we need it: related PR: #2092 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have be

[GitHub] [apisix-dashboard] juzhiyuan closed issue #437: Feature:route publish management

2020-09-14 Thread GitBox
juzhiyuan closed issue #437: URL: https://github.com/apache/apisix-dashboard/issues/437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #437: Feature:route publish management

2020-09-14 Thread GitBox
juzhiyuan commented on issue #437: URL: https://github.com/apache/apisix-dashboard/issues/437#issuecomment-692502969 > @juzhiyuan > I don't know what progress has been made in the replacement of database. At present, the pr #450 related to this is use mysql. Is this only regarded as a

[GitHub] [apisix-dashboard] moonming commented on issue #449: CI: add tools to check ASF headers in code files

2020-09-14 Thread GitBox
moonming commented on issue #449: URL: https://github.com/apache/apisix-dashboard/issues/449#issuecomment-692502897 yes, fixed by https://github.com/apache/apisix-dashboard/pull/465 This is an automated message from the Apac

[GitHub] [apisix-dashboard] moonming closed issue #449: CI: add tools to check ASF headers in code files

2020-09-14 Thread GitBox
moonming closed issue #449: URL: https://github.com/apache/apisix-dashboard/issues/449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #431: Feature: route group

2020-09-14 Thread GitBox
juzhiyuan closed issue #431: URL: https://github.com/apache/apisix-dashboard/issues/431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #431: Feature: route group

2020-09-14 Thread GitBox
juzhiyuan commented on issue #431: URL: https://github.com/apache/apisix-dashboard/issues/431#issuecomment-692503187 merged and closed. This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #434: Requirements for refactoring the Dashboard with Manager API

2020-09-14 Thread GitBox
juzhiyuan commented on issue #434: URL: https://github.com/apache/apisix-dashboard/issues/434#issuecomment-692502807 Any update? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #444: Proposal: Improve the Route module

2020-09-14 Thread GitBox
juzhiyuan commented on issue #444: URL: https://github.com/apache/apisix-dashboard/issues/444#issuecomment-692502572 cc @LiteSun Need some time to work on this, I just added the latest plugin. This is an automated message f

[GitHub] [apisix-dashboard] juzhiyuan closed issue #452: An error is reported when creating the second route:RouteGroup name is duplicate

2020-09-14 Thread GitBox
juzhiyuan closed issue #452: URL: https://github.com/apache/apisix-dashboard/issues/452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #449: CI: add tools to check ASF headers in code files

2020-09-14 Thread GitBox
juzhiyuan commented on issue #449: URL: https://github.com/apache/apisix-dashboard/issues/449#issuecomment-692502318 Done? This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #452: An error is reported when creating the second route:RouteGroup name is duplicate

2020-09-14 Thread GitBox
juzhiyuan commented on issue #452: URL: https://github.com/apache/apisix-dashboard/issues/452#issuecomment-692502242 merged, feel free to reopen this one. This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] juzhiyuan closed issue #464: request help: 401 when using apisix in k8s

2020-09-14 Thread GitBox
juzhiyuan closed issue #464: URL: https://github.com/apache/apisix-dashboard/issues/464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #458: bug: When creating a route, host should not be required

2020-09-14 Thread GitBox
juzhiyuan commented on issue #458: URL: https://github.com/apache/apisix-dashboard/issues/458#issuecomment-692502040 assigned to @LiteSun This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #466: bug: a related to route basic-auth consumer should not be deleted

2020-09-14 Thread GitBox
juzhiyuan commented on issue #466: URL: https://github.com/apache/apisix-dashboard/issues/466#issuecomment-692501456 ping @membphis @nic-chen This is an automated message from the Apache Git Service. To respond to the messa

[apisix-dashboard] branch feat-plugin created (now 2329b1d)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 2329b1d feat: added new plugin dependency This branch includes the following new commits: n

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #475: feat: added new plugin dependency

2020-09-14 Thread GitBox
juzhiyuan opened a new pull request #475: URL: https://github.com/apache/apisix-dashboard/pull/475 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improve performance - Relate

[apisix-dashboard] 01/01: feat: added new plugin dependency

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 2329b1dbe4267a2e38d71fb978701ed0d609311f Author: juzhiyuan AuthorDate: Tue Sep 15 14:38:36 2020 +0800

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #474: Publish route failed

2020-09-14 Thread GitBox
juzhiyuan opened a new issue #474: URL: https://github.com/apache/apisix-dashboard/issues/474 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance

[GitHub] [apisix] membphis closed pull request #2092: bug: removed default access token for Admin API.

2020-09-14 Thread GitBox
membphis closed pull request #2092: URL: https://github.com/apache/apisix/pull/2092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on pull request #2092: bug: removed default access token for Admin API.

2020-09-14 Thread GitBox
membphis commented on pull request #2092: URL: https://github.com/apache/apisix/pull/2092#issuecomment-692493280 I have to close this PR, this PR contains other people's commit logs. This is an automated message from the Apac

[GitHub] [apisix] membphis commented on a change in pull request #2092: bug: removed default access token for Admin API.

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2092: URL: https://github.com/apache/apisix/pull/2092#discussion_r488413639 ## File path: bin/apisix ## @@ -637,6 +637,45 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check the

[apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-09-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 885dadd Deploy to GitHub pages

[GitHub] [apisix-website] juzhiyuan merged pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan merged pull request #73: URL: https://github.com/apache/apisix-website/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix-website] juzhiyuan closed issue #72: add reference to "Apache APISIX software"

2020-09-14 Thread GitBox
juzhiyuan closed issue #72: URL: https://github.com/apache/apisix-website/issues/72 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix-website] branch master updated: feat: added desc (#73)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new fe9bd58 feat: added desc (#73) fe9bd

[GitHub] [apisix-website] juzhiyuan commented on pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on pull request #73: URL: https://github.com/apache/apisix-website/pull/73#issuecomment-692485620 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488403217 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The Cloud-N

[apisix-website] branch feat-trademarks updated (46dc0ec -> 69a1a4f)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-trademarks in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 46dc0ec feat: added desc add 69a1a4f feat: added tagline2 No new revisions were added by

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488400764 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The Cloud-N

[apisix-dashboard] branch master updated: feat: remove netlify (#472)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 361392f feat: remove netlify (#472

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #472: feat: remove netlify

2020-09-14 Thread GitBox
juzhiyuan merged pull request #472: URL: https://github.com/apache/apisix-dashboard/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692476896 please take a look at kong's ACL plugin too: https://docs.konghq.com/hub/kong-inc/acl/ Thanks, Ming Wen Twitter: _WenMing Firstsawyou 于2020年9月15日周二 下午1:29写道

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692473633 > the same as #385 Ok,let me take a look. This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692472362 > How do you plan to implement this feature? It is planned to create a whitelisted plug-in through "service_id", which is bound to "consumer".

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692470173 How do you plan to implement this feature? This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692469543 Assigned to me. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692469486 the same as https://github.com/apache/apisix/issues/385 This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692468901 > This is what identity authentication needs to do, such as ACL, right? Yes. This is an automated message f

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692468240 This is what identity authentication needs to do, such as ACL, right? This is an automated message from the Apache Gi

[GitHub] [apisix] Firstsawyou opened a new issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou opened a new issue #2229: URL: https://github.com/apache/apisix/issues/2229 ### Issue description Configure multiple "service" objects. I want to restrict the "service" on the "consumer". What should I do? For example: "service" has: serv1, serv2 and serv3. In "consumer",

[apisix] branch master updated (2999541 -> 12a0b13)

2020-09-14 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 2999541 fix: change the config file when deploying apisix in k8s #2182 (#2185) add 12a0b13 bugfix: use the r

[GitHub] [apisix] moonming merged pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object

2020-09-14 Thread GitBox
moonming merged pull request #2211: URL: https://github.com/apache/apisix/pull/2211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-website] moonming commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
moonming commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488364826 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The Cloud-Na

[GitHub] [apisix] Caelebs closed issue #2224: request help: k8s部署日志提示failed to read `apisix` field from yaml file

2020-09-14 Thread GitBox
Caelebs closed issue #2224: URL: https://github.com/apache/apisix/issues/2224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [apisix] Miss-you commented on pull request #2226: doc: added channel at slack and added new qq group.

2020-09-14 Thread GitBox
Miss-you commented on pull request #2226: URL: https://github.com/apache/apisix/pull/2226#issuecomment-692431848 ![image](https://user-images.githubusercontent.com/3816205/93160059-22162400-f742-11ea-98d3-300e4269365a.png) 836398818 -

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488348093 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性) +

[GitHub] [apisix] tokers commented on issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

2020-09-14 Thread GitBox
tokers commented on issue #2227: URL: https://github.com/apache/apisix/issues/2227#issuecomment-692426801 @membphis May i pick it up? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] shuaijinchao commented on pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object

2020-09-14 Thread GitBox
shuaijinchao commented on pull request #2211: URL: https://github.com/apache/apisix/pull/2211#issuecomment-692425998 Follow-up can support dynamic upstream according to request information, cool. This is an automated message

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

2020-09-14 Thread GitBox
juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-692423742 @moonming @membphis Please provide the priority for every category and plugin. This is an automated messa

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488343173 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,152 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488339941 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,152 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488336742 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,151 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +- [**Attribut

[GitHub] [apisix-dashboard] juzhiyuan closed issue #448: Proposal: improve the PluginModule

2020-09-14 Thread GitBox
juzhiyuan closed issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan closed issue #459: In the routing plug-in configuration interface, click response rewrite to display 500

2020-09-14 Thread GitBox
juzhiyuan closed issue #459: URL: https://github.com/apache/apisix-dashboard/issues/459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] gy09535 commented on issue #2151: feature: Best practice for jaeger

2020-09-14 Thread GitBox
gy09535 commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-692414315 > I think you can add a plugin for jaeger, and welcome PR for this got it This is an automated message from the

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488335359 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,151 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +- [**Attribut

[GitHub] [apisix] moonming opened a new issue #2228: bug: remove `/tmp/apisix_cores/` in makefile and bin/apisix.

2020-09-14 Thread GitBox
moonming opened a new issue #2228: URL: https://github.com/apache/apisix/issues/2228 remove https://github.com/apache/apisix/blob/master/bin/apisix#L36 and https://github.com/apache/apisix/blob/master/Makefile#L84, both of them are useless now. -

[apisix-dashboard] branch master updated (66709c4 -> 09c5be9)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 66709c4 feat: support ungroup in manager api (#460) add 09c5be9 feat: add publish status to route

[apisix-dashboard] branch master updated (09c5be9 -> 13b5f0c)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 09c5be9 feat: add publish status to route in manager api (#450) add 13b5f0c feat(route): add publ

[GitHub] [apisix] membphis commented on a change in pull request #2221: send file contents and not file name

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2221: URL: https://github.com/apache/apisix/pull/2221#discussion_r488333965 ## File path: apisix/utils/log-util.lua ## @@ -64,7 +64,11 @@ local function get_full_log(ngx, conf) else local body_file = ngx.req.

[GitHub] [apisix] membphis commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692411184 > one more thing, we need to check the `etcd` version in `bin/apisix`, confirm the `etcd` version `>= 3.4` . we can fix this in a new PR, here is the related issue: https

[GitHub] [apisix] membphis opened a new issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

2020-09-14 Thread GitBox
membphis opened a new issue #2227: URL: https://github.com/apache/apisix/issues/2227 comments: https://github.com/apache/apisix/pull/2036#issuecomment-691957197 This is an automated message from the Apache Git Service.

[GitHub] [apisix] moonming opened a new pull request #2226: doc: added channel at slack and added new qq group.

2020-09-14 Thread GitBox
moonming opened a new pull request #2226: URL: https://github.com/apache/apisix/pull/2226 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have yo

[apisix-dashboard] branch master updated (66709c4 -> 09c5be9)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 66709c4 feat: support ungroup in manager api (#460) add 09c5be9 feat: add publish status to route

[apisix-dashboard] branch master updated (09c5be9 -> 13b5f0c)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 09c5be9 feat: add publish status to route in manager api (#450) add 13b5f0c feat(route): add publ

[apisix-dashboard] branch master updated (09c5be9 -> 13b5f0c)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 09c5be9 feat: add publish status to route in manager api (#450) add 13b5f0c feat(route): add publ

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488331969 ## File path: bin/apisix ## @@ -873,35 +873,26 @@ local function init_etcd(show_output) local host_count = #(yaml_conf.etcd.host) --- check w

[apisix-dashboard] branch master updated (66709c4 -> 09c5be9)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 66709c4 feat: support ungroup in manager api (#460) add 09c5be9 feat: add publish status to route

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #473: PluginModule

2020-09-14 Thread GitBox
juzhiyuan opened a new issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473 - [ ] Support JSONSchema - [ ] Improve i18n This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #451: feat(route): add publish and offline to route

2020-09-14 Thread GitBox
juzhiyuan merged pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
juzhiyuan merged pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488328057 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692401902 Note: I found that run `etcd` v3 on docker for mac cause high CPU usage, like: https://github.com/etcd-io/etcd/issues/11460 Running on Linux is ok.

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488320970 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreement

[apisix-dashboard] branch feat-remove-netlify created (now 6bf5759)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-netlify in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 6bf5759 feat: remove netlify No new revisions were added by this update.

[apisix-dashboard] branch feat-remove-netlify created (now 6bf5759)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-netlify in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 6bf5759 feat: remove netlify No new revisions were added by this update.

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #472: feat: remove netlify

2020-09-14 Thread GitBox
juzhiyuan opened a new pull request #472: URL: https://github.com/apache/apisix-dashboard/pull/472 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Relate

[GitHub] [apisix-website] juzhiyuan commented on pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on pull request #73: URL: https://github.com/apache/apisix-website/pull/73#issuecomment-692392689 @moonming Please help to check http://www.apache.org/foundation/marks/pmcs#metadata This is an automated

[apisix-website] branch feat-trademarks created (now 46dc0ec)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-trademarks in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 46dc0ec feat: added desc No new revisions were added by this update.

[GitHub] [apisix-website] juzhiyuan opened a new pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan opened a new pull request #73: URL: https://github.com/apache/apisix-website/pull/73 - [x] Desc on the homepage; - [x] Check ASF Links at homepage's bottom.; This is an automated message from the Apache Git Servi

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488306915 ## File path: rockspec/apisix-master-0.rockspec ## @@ -52,6 +52,7 @@ dependencies = { "lua-resty-kafka = 0.07", "lua-resty-logger-socket = 2.0-0

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488305432 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key = kvs

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488305164 ## File path: README.md ## @@ -166,10 +166,9 @@ There are several ways to install the Apache Release version of APISIX: apisix start ``

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488305087 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil, nil

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488259506 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[], "ups

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488259506 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[], "ups

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488101612 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribu

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488095303 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribu

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488073128 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribu

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488064180 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488063399 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488062025 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性) +

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488057502 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[], "ups

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487997453 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contribu

  1   2   >